1. 08 Dec, 2017 14 commits
  2. 30 Nov, 2017 26 commits
    • Sakari Ailus's avatar
      media: imx274: Fix error handling, add MAINTAINERS entry · 781b045b
      Sakari Ailus authored
      Add the missing MAINTAINERS entry for imx274, fix error handling in driver
      probe and unregister the correct control handler in driver remove.
      Signed-off-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      781b045b
    • Niklas Söderlund's avatar
      media: v4l: async: use the v4l2_dev from the root notifier when matching sub-devices · 487cc857
      Niklas Söderlund authored
      When matching and registering a sub-device from a sub-notifier use the
      v4l2_device from the root parent notifier. Using the v4l2_dev stored in
      the sub-notifier itself is incorrect as it might not be set.
      
      This can be demonstrated by unbinding and rebinding the adv748x driver
      and observing that it fails to probe due to the check !v4l2_dev in
      v4l2_device_register_subdev().
      
          # echo 4-0070 > /sys/bus/i2c/drivers/adv748x/unbind
          # echo 4-0070 > /sys/bus/i2c/drivers/adv748x/bind
          adv748x 4-0070: chip found @ 0xe0 revision 2143
          adv748x 4-0070: Failed to probe TXA
          adv748x: probe of 4-0070 failed with error -22
      
      Looking at the commit which adds sub-notifiers to V4L2 it looks like
      this is the intended behavior of the original commit. With this fix the
      adv748x can be re-bound and still function properly.
      
      Fixes: 2cab00bb ("media: v4l: async: Allow binding notifiers to sub-devices")
      Signed-off-by: default avatarNiklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
      Signed-off-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      487cc857
    • Tomasz Figa's avatar
      media: v4l2-fwnode: Check subdev count after checking port · 3bf39386
      Tomasz Figa authored
      Current implementation of __v4l2_async_notifier_parse_fwnode_endpoints()
      checks first whether subdev_count >= subdev_max and only then whether
      the port being parsed matches the given port index. This triggers an
      error in otherwise valid cases of skipping ports that do not match.
      
      Fix this by moving the check below the port index check.
      
      Fixes: 9ca46531 ("media: v4l: fwnode: Support generic parsing of graph endpoints in a device")
      Signed-off-by: default avatarTomasz Figa <tfiga@chromium.org>
      Signed-off-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      3bf39386
    • Arnd Bergmann's avatar
      media: et8ek8: select V4L2_FWNODE · 2aa4d498
      Arnd Bergmann authored
      v4l2_async_register_subdev_sensor_common() is only provided when
      CONFIG_V4L2_FWNODE is enabled, otherwise we get a link failure:
      
      drivers/media/i2c/et8ek8/et8ek8_driver.o: In function `et8ek8_probe':
      et8ek8_driver.c:(.text+0x884): undefined reference to `v4l2_async_register_subdev_sensor_common'
      
      This adds a Kconfig 'select' statement like all the other users of
      this interface have.
      
      Fixes: d8932f38 ("media: et8ek8: Add support for flash and lens devices")
      Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
      Reviewed-by: default avatarSebastian Reichel <sebastian.reichel@collabora.co.uk>
      Acked-by: default avatarPavel Machek <pavel@ucw.cz>
      Signed-off-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      2aa4d498
    • Sakari Ailus's avatar
      media: ov13858: Select V4L2_FWNODE · fce8ba67
      Sakari Ailus authored
      The ov13858 driver depends on the V4L2 fwnode, thus add that to Kconfig.
      
      Fixes: 5fcf092e ("[media] ov13858: add support for OV13858 sensor")
      Signed-off-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      fce8ba67
    • Sean Young's avatar
      media: rc: partial revert of "media: rc: per-protocol repeat period" · 67f0f15a
      Sean Young authored
      Since commit d57ea877 ("media: rc: per-protocol repeat period"), most
      IR protocols have a lower keyup timeout. This causes problems on the
      ite-cir, which has default IR timeout of 200ms.
      
      Since the IR decoders read the trailing space, with a IR timeout of 200ms,
      the last keydown will have at least a delay of 200ms. This is more than
      the protocol timeout of e.g. rc-6 (which is 164ms). As a result the last
      IR will be interpreted as a new keydown event, and we get two keypresses.
      
      Revert the protocol timeout to 250ms, except for cec which needs a timeout
      of 550ms.
      
      Fixes: d57ea877 ("media: rc: per-protocol repeat period")
      
      Cc: <stable@vger.kernel.org> # 4.14
      Reported-by: default avatarMatthias Reichl <hias@horus.com>
      Signed-off-by: default avatarSean Young <sean@mess.org>
      Tested-by: default avatarMatthias Reichl <hias@horus.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      67f0f15a
    • Laurent Caumont's avatar
      media: dvb: i2c transfers over usb cannot be done from stack · 6d33377f
      Laurent Caumont authored
      Cc: stable@vger.kernel.org
      Signed-off-by: default avatarLaurent Caumont <lcaumont2@gmail.com>
      Signed-off-by: default avatarSean Young <sean@mess.org>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      6d33377f
    • Mauro Carvalho Chehab's avatar
      media: dvb-frontends: complete kernel-doc markups · be9b53c8
      Mauro Carvalho Chehab authored
      For the dvb-frontends that are now part of the documentation,
      complete the kernel-doc markups, in order for them to be
      properly used at the driver's kAPI documentation.
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      be9b53c8
    • Mauro Carvalho Chehab's avatar
      media: docs: add documentation for frontend attach info · e61edeb1
      Mauro Carvalho Chehab authored
      Add to the media book the attachment kAPI for the DVB
      frontend drivers that have already some kernel-doc markup.
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      e61edeb1
    • Mauro Carvalho Chehab's avatar
      media: dvb_frontends: fix kernel-doc macros · b95b0c98
      Mauro Carvalho Chehab authored
      Now, the Kernel checks for kernel_doc format issues.
      Weird enough, it didn't get any of those troubles. Shssst!
      
      Well, let's fix it, as a preventive way to avoid having
      hundreds of new warnings on some next Linux version.
      
      Tested by adding all files under dvb-frontends that have
      "/**" on them.
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      b95b0c98
    • Mauro Carvalho Chehab's avatar
      media: drivers: remove "/**" from non-kernel-doc comments · cba862dc
      Mauro Carvalho Chehab authored
      Several comments are wrongly tagged as kernel-doc, causing
      those warnings:
      
        drivers/media/rc/st_rc.c:98: warning: No description found for parameter 'irq'
        drivers/media/rc/st_rc.c:98: warning: No description found for parameter 'data'
        drivers/media/pci/solo6x10/solo6x10-enc.c:183: warning: No description found for parameter 'solo_dev'
        drivers/media/pci/solo6x10/solo6x10-enc.c:183: warning: No description found for parameter 'ch'
        drivers/media/pci/solo6x10/solo6x10-enc.c:183: warning: No description found for parameter 'qp'
        drivers/media/usb/pwc/pwc-dec23.c:652: warning: Cannot understand  *
         on line 652 - I thought it was a doc line
        drivers/media/usb/dvb-usb/cinergyT2-fe.c:40: warning: No description found for parameter 'op'
        drivers/media/usb/dvb-usb/friio-fe.c:301: warning: Cannot understand  * (reg, val) commad list to initialize this module.
         on line 301 - I thought it was a doc line
        drivers/media/rc/streamzap.c:201: warning: No description found for parameter 'urb'
        drivers/media/rc/streamzap.c:333: warning: No description found for parameter 'intf'
        drivers/media/rc/streamzap.c:333: warning: No description found for parameter 'id'
        drivers/media/rc/streamzap.c:464: warning: No description found for parameter 'interface'
        drivers/media/i2c/ov5647.c:432: warning: Cannot understand  * @short Subdev core operations registration
         on line 432 - I thought it was a doc line
        drivers/media/usb/dvb-usb/friio.c:35: warning: No description found for parameter 'd'
        drivers/media/usb/dvb-usb/friio.c:35: warning: No description found for parameter 'addr'
        drivers/media/usb/dvb-usb/friio.c:35: warning: No description found for parameter 'wbuf'
        drivers/media/usb/dvb-usb/friio.c:35: warning: No description found for parameter 'wlen'
        drivers/media/usb/dvb-usb/friio.c:35: warning: No description found for parameter 'rbuf'
        drivers/media/usb/dvb-usb/friio.c:35: warning: No description found for parameter 'rlen'
        drivers/media/platform/vim2m.c:350: warning: No description found for parameter 'priv'
        drivers/media/dvb-frontends/tua6100.c:34: warning: cannot understand function prototype: 'struct tua6100_priv '
        drivers/media/platform/sti/hva/hva-h264.c:140: warning: cannot understand function prototype: 'struct hva_h264_stereo_video_sei '
        drivers/media/platform/sti/hva/hva-h264.c:150: warning: Cannot understand  * @frame_width: width in pixels of the buffer containing the input frame
         on line 150 - I thought it was a doc line
        drivers/media/platform/sti/hva/hva-h264.c:356: warning: Cannot understand  * @ slice_size: slice size
         on line 356 - I thought it was a doc line
        drivers/media/platform/sti/hva/hva-h264.c:369: warning: Cannot understand  * @ bitstream_size: bitstream size
         on line 369 - I thought it was a doc line
        drivers/media/platform/sti/hva/hva-h264.c:395: warning: Cannot understand  * @seq_info:  sequence information buffer
         on line 395 - I thought it was a doc line
        drivers/media/dvb-frontends/sp887x.c:137: warning: No description found for parameter 'fe'
        drivers/media/dvb-frontends/sp887x.c:137: warning: No description found for parameter 'fw'
        drivers/media/dvb-frontends/sp887x.c:287: warning: No description found for parameter 'n'
        drivers/media/dvb-frontends/sp887x.c:287: warning: No description found for parameter 'd'
        drivers/media/dvb-frontends/sp887x.c:287: warning: No description found for parameter 'quotient_i'
        drivers/media/dvb-frontends/sp887x.c:287: warning: No description found for parameter 'quotient_f'
        drivers/media/usb/ttusb-budget/dvb-ttusb-budget.c:83: warning: cannot understand function prototype: 'struct ttusb '
        drivers/media/platform/sh_veu.c:277: warning: No description found for parameter 'priv'
        drivers/media/dvb-frontends/zl10036.c:33: warning: cannot understand function prototype: 'int zl10036_debug; '
        drivers/media/dvb-frontends/zl10036.c:179: warning: No description found for parameter 'state'
        drivers/media/dvb-frontends/zl10036.c:179: warning: No description found for parameter 'frequency'
        drivers/media/platform/rcar_fdp1.c:1139: warning: No description found for parameter 'priv'
        drivers/media/platform/ti-vpe/vpe.c:933: warning: No description found for parameter 'priv'
        drivers/media/usb/gspca/ov519.c:36: warning: No description found for parameter 'fmt'
        drivers/media/usb/dvb-usb/dib0700_devices.c:3367: warning: No description found for parameter 'adap'
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      cba862dc
    • Mauro Carvalho Chehab's avatar
      media: lm3560: add a missing kernel-doc parameter · ed050c21
      Mauro Carvalho Chehab authored
      Fix this warning:
      	drivers/media/i2c/lm3560.c:69: warning: No description found for parameter 'dev'
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      ed050c21
    • Mauro Carvalho Chehab's avatar
      media: rcar_jpu: fix two kernel-doc markups · 538cf643
      Mauro Carvalho Chehab authored
      On kernel-doc, struct declarations should be declared as "struct foo".
      
      Fix the following warnings:
      	drivers/media/platform/rcar_jpu.c:265: warning: cannot understand function prototype: 'struct jpu_q_data '
      	drivers/media/platform/rcar_jpu.c:281: warning: cannot understand function prototype: 'struct jpu_ctx '
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      538cf643
    • Mauro Carvalho Chehab's avatar
      media: vsp1: add a missing kernel-doc parameter · 2afe216d
      Mauro Carvalho Chehab authored
      Fix this warning:
      	drivers/media/platform/vsp1/vsp1_dl.c:87: warning: No description found for parameter 'has_chain'
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      2afe216d
    • Mauro Carvalho Chehab's avatar
      media: soc_camera: fix a kernel-doc markup · bd98f7a1
      Mauro Carvalho Chehab authored
      Remove this warning:
      	drivers/media/platform/soc_camera/soc_scale_crop.c:309: warning: Cannot understand  * @icd		- soc-camera device
      	 on line 309 - I thought it was a doc line
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      Acked-by: default avatarGuennadi Liakhovetski <g.liakhovetski@gmx.de>
      bd98f7a1
    • Mauro Carvalho Chehab's avatar
      media: mt2063: fix some kernel-doc warnings · 69a52ad3
      Mauro Carvalho Chehab authored
      Fix those warnings:
      	drivers/media/tuners/mt2063.c:1413: warning: No description found for parameter 'f_ref'
      	drivers/media/tuners/mt2063.c:1413: warning: Excess function parameter 'f_Ref' description in 'MT2063_fLO_FractionalTerm'
      	drivers/media/tuners/mt2063.c:1476: warning: Excess function parameter 'f_Avoid' description in 'MT2063_CalcLO2Mult'
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      69a52ad3
    • Mauro Carvalho Chehab's avatar
      media: radio-wl1273: fix a parameter name at kernel-doc macro · 5bef1c0b
      Mauro Carvalho Chehab authored
      Solve those warnings:
      	drivers/media/radio/radio-wl1273.c:1337: warning: No description found for parameter 'radio'
      	drivers/media/radio/radio-wl1273.c:1337: warning: Excess function parameter 'core' description in 'wl1273_fm_set_tx_power'
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      5bef1c0b
    • Mauro Carvalho Chehab's avatar
      media: s3c-camif: add missing description at s3c_camif_find_format() · fa787125
      Mauro Carvalho Chehab authored
      Fix this warning:
      	drivers/media/platform/s3c-camif/camif-core.c:112: warning: No description found for parameter 'vp'
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      fa787125
    • Mauro Carvalho Chehab's avatar
      media: mtk-vpu: add description for wdt fields at struct mtk_vpu · 98156359
      Mauro Carvalho Chehab authored
      Fix those warnings:
        drivers/media/platform/mtk-vpu/mtk_vpu.c:223: warning: No description found for parameter 'wdt'
        drivers/media/platform/mtk-vpu/mtk_vpu.c:223: warning: No description found for parameter 'wdt_refcnt'
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      98156359
    • Mauro Carvalho Chehab's avatar
      media: vdec: fix some kernel-doc warnings · d714a755
      Mauro Carvalho Chehab authored
      Fix those warnings:
        drivers/media/platform/mtk-vcodec/vdec/vdec_h264_if.c:69: warning: No description found for parameter 'reserved'
        drivers/media/platform/mtk-vcodec/vdec/vdec_vp8_if.c:175: warning: Excess struct member 'dev' description in 'vdec_vp8_inst'
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      d714a755
    • Mauro Carvalho Chehab's avatar
      media: tvp514x: fix kernel-doc parameters · c5bb8318
      Mauro Carvalho Chehab authored
      There are some struct fields that aren't documented, and some
      consts whose comments start with /**, but they aren't kernel-doc
      annotations. So, fix it:
      
        drivers/media/i2c/tvp514x.c:127: warning: No description found for parameter 'hdl'
        drivers/media/i2c/tvp514x.c:127: warning: No description found for parameter 'pad'
        drivers/media/i2c/tvp514x.c:127: warning: No description found for parameter 'format'
        drivers/media/i2c/tvp514x.c:127: warning: No description found for parameter 'int_seq'
        drivers/media/i2c/tvp514x.c:219: warning: cannot understand function prototype: 'const struct v4l2_fmtdesc tvp514x_fmt_list[] = '
        drivers/media/i2c/tvp514x.c:235: warning: cannot understand function prototype: 'const struct tvp514x_std_info tvp514x_std_list[] = '
        drivers/media/i2c/tvp514x.c:941: warning: No description found for parameter 'fmt'
        drivers/media/i2c/tvp514x.c:941: warning: Excess function parameter 'format' description in 'tvp514x_set_pad_format'
        drivers/media/i2c/tvp514x.c:1208: warning: cannot understand function prototype: 'const struct i2c_device_id tvp514x_id[] = '
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      c5bb8318
    • Mauro Carvalho Chehab's avatar
      media: netup_unidvb: fix a bad kernel-doc markup · b5a21f8a
      Mauro Carvalho Chehab authored
      There is a bad kernel-doc markup, producing the following warnings:
      
        drivers/media/pci/netup_unidvb/netup_unidvb_core.c:85: warning: bad line: 			Bits [0-7]:	DMA packet size, 188 bytes
        drivers/media/pci/netup_unidvb/netup_unidvb_core.c:86: warning: bad line: 			Bits [16-23]:	packets count in block, 128 packets
        drivers/media/pci/netup_unidvb/netup_unidvb_core.c:87: warning: bad line: 			Bits [24-31]:	blocks count, 8 blocks
        drivers/media/pci/netup_unidvb/netup_unidvb_core.c:89: warning: bad line: 			For example, value of 375000000 equals to 3 sec
      
      Fix that, and use a list for the bits option, in order for it
      to be better format, if we add it to a driver's documentation
      file.
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      b5a21f8a
    • Mauro Carvalho Chehab's avatar
      media: s5k6aa: describe some function parameters · 070250a1
      Mauro Carvalho Chehab authored
      as warned:
        drivers/media/i2c/s5k6aa.c:429: warning: No description found for parameter 's5k6aa'
        drivers/media/i2c/s5k6aa.c:679: warning: No description found for parameter 's5k6aa'
        drivers/media/i2c/s5k6aa.c:733: warning: No description found for parameter 's5k6aa'
        drivers/media/i2c/s5k6aa.c:733: warning: No description found for parameter 'preset'
        drivers/media/i2c/s5k6aa.c:787: warning: No description found for parameter 'sd'
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      070250a1
    • Mauro Carvalho Chehab's avatar
      media: s5k6a3: document some fields at struct s5k6a3 · 7cd18369
      Mauro Carvalho Chehab authored
      drivers/media/i2c/s5k6a3.c:68: warning: No description found for parameter 'clock'
      drivers/media/i2c/s5k6a3.c:68: warning: No description found for parameter 'clock_frequency'
      drivers/media/i2c/s5k6a3.c:68: warning: No description found for parameter 'power_count'
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      7cd18369
    • Mauro Carvalho Chehab's avatar
      media: radio-si476x: fix kernel-doc markups · d156f293
      Mauro Carvalho Chehab authored
      get rid of the following warnings:
        drivers/media/radio/radio-si476x.c:317: warning: No description found for parameter 'v4l2dev'
        drivers/media/radio/radio-si476x.c:317: warning: No description found for parameter 'ctrl_handler'
        drivers/media/radio/radio-si476x.c:317: warning: No description found for parameter 'debugfs'
        drivers/media/radio/radio-si476x.c:317: warning: No description found for parameter 'audmode'
        drivers/media/radio/radio-si476x.c:317: warning: Excess struct member 'kref' description in 'si476x_radio'
        drivers/media/radio/radio-si476x.c:317: warning: Excess struct member 'core_lock' description in 'si476x_radio'
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      d156f293
    • Mauro Carvalho Chehab's avatar
      media: ix2505v: get rid of /** comments · 4521af78
      Mauro Carvalho Chehab authored
      As warned:
      
        drivers/media/dvb-frontends/ix2505v.c:24: warning: cannot understand function prototype: 'int ix2505v_debug; '
        drivers/media/dvb-frontends/ix2505v.c:59: warning: No description found for parameter 'state'
        drivers/media/dvb-frontends/ix2505v.c:128: warning: No description found for parameter 'fe'
      
      None of the comments there are kernel-doc. So, remove them with:
      
      	perl -pi -e 's,\/\*\*,/*,g' drivers/media/dvb-frontends/ix2505v.c
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      4521af78