- 09 Jan, 2012 40 commits
-
-
Artem Bityutskiy authored
1. Teach 'mtd_write()' function to return '-EROFS' if the write method is undefined, and remove the corresponding check from 'default_mtd_writev()'. 2. Do not test 'retlen' for NULL - it cannot be NULL. 3. Few minor coding stile clean-ups. 4. Add a kerneldoc comment Additionally, minor fixes to the kerneldoc comments of the neighbor function. Signed-off-by:
Artem Bityutskiy <artem.bityutskiy@linux.intel.com> Signed-off-by:
David Woodhouse <David.Woodhouse@intel.com>
-
Artem Bityutskiy authored
Instead, use 'default_mtd_writev()' function which MTD provides. Signed-off-by:
-
Artem Bityutskiy authored
Signed-off-by:
-
Artem Bityutskiy authored
Fix the following gcc warning: drivers/mtd/devices/sst25l.c: In function ‘sst25l_probe’: drivers/mtd/devices/sst25l.c:381:11: warning: unused variable ‘i’ [-Wunused-variable] Signed-off-by:
-
Artem Bityutskiy authored
Fix this gcc warning: drivers/mtd/onenand/onenand_base.c: In function ‘onenand_block_markbad’: drivers/mtd/onenand/onenand_base.c:2636:23: warning: unused variable ‘this’ [-Wunused-variable] Signed-off-by:
-
Artem Bityutskiy authored
... since it is not needed because the generic 'dev_get_drvdata()' can be used instead. Signed-off-by:
Mike Frysinger <vapier@gentoo.org> Signed-off-by:
-
Artem Bityutskiy authored
MTD functions always assign the 'retlen' argument to 0 at the very beginning - the callers do not have to do this. I used the following semantic patch to find these places: @@ identifier retlen; expression a, b, c, d, e; constant C; type T; @@ ( - retlen = C; | T -retlen = C + retlen ; ) ... when != retlen when exists ( mtd_read(a, b, c, &retlen, d) | mtd_write(a, b, c, &retlen, d) | mtd_panic_write(a, b, c, &retlen, d) | mtd_point(a, b, c, &retlen, d, e) | mtd_read_fact_prot_reg(a, b, c, &retlen, d) | mtd_write_user_prot_reg(a, b, c, &retlen, d) | mtd_read_user_prot_reg(a, b, c, &retlen, d) | mtd_writev(a, b, c, d, &retlen) ) I ran it twice, because there were cases of double zero assigments in mtd tests. Then I went through the patch to verify that spatch did not find any false positives. Signed-off-by: -
Artem Bityutskiy authored
Make sure that the retlen is set to 0 in case of error. This harmonizes drivers - some set it to 0 in some error cases and do not write anything in other error cases. Now we can do this consistently for all drivers. Signed-off-by:
-
Artem Bityutskiy authored
The 'struct mtd_info' object is allocated with 'kzalloc()', so it contains only zeroes - no need to initialize various fields to 0 or NULL. Signed-off-by:
-
Artem Bityutskiy authored
Instead of calling 'kmalloc()' and them 'memeset(0)', use 'kzalloc()'. Signed-off-by:
-
Artem Bityutskiy authored
Move the 'get_device()' and 'put_device()' functions up within 'struct mtd_info' to make them be close to other functions. Signed-off-by:
-
Artem Bityutskiy authored
Signed-off-by:
-
Artem Bityutskiy authored
Signed-off-by:
-
Artem Bityutskiy authored
Signed-off-by:
-
Artem Bityutskiy authored
Signed-off-by:
-
Artem Bityutskiy authored
Signed-off-by:
-
Artem Bityutskiy authored
Signed-off-by:
-
Artem Bityutskiy authored
Signed-off-by:
-
Artem Bityutskiy authored
Signed-off-by:
-
Artem Bityutskiy authored
Signed-off-by:
-
Artem Bityutskiy authored
Signed-off-by:
-
Artem Bityutskiy authored
Signed-off-by:
-
Artem Bityutskiy authored
Signed-off-by:
-
Artem Bityutskiy authored
Signed-off-by:
-
Artem Bityutskiy authored
Signed-off-by:
-
Artem Bityutskiy authored
Signed-off-by:
-
Artem Bityutskiy authored
Signed-off-by:
-
Artem Bityutskiy authored
Signed-off-by:
-
Artem Bityutskiy authored
Signed-off-by:
-
Artem Bityutskiy authored
Signed-off-by:
-
Artem Bityutskiy authored
Signed-off-by:
-
Artem Bityutskiy authored
Signed-off-by:
-
Artem Bityutskiy authored
Signed-off-by:
-
Artem Bityutskiy authored
Signed-off-by:
-
Artem Bityutskiy authored
This patch is part of a patch-set which changes the MTD interface from 'mtd->func()' form to 'mtd_func()' form. We need this because we want to add common code to to all drivers in the mtd core level, which is impossible with the current interface when MTD clients call driver functions like 'read()' or 'write()' directly. At this point we just introduce a new inline wrapper function, but later some of them are expected to gain more code. E.g., the input parameters check should be moved to the wrappers rather than be duplicated at many drivers. This particular patch introduced the 'mtd_erase()' interface. The following patches add all the other interfaces one by one. Signed-off-by:
-
Artem Bityutskiy authored
We are going to re-work the MTD interface and change 'mtd->write()' to 'mtd_write()', 'mtd->read()' to 'mtd_read()' and so forth for all functions in the 'struct mtd_info' structure. However, mtdchar.c has its own 'mtd_read()', 'mtd_write()', etc functions which collide with our changes. This patch renames these functions to 'mtdchar_read()', 'mtdchar_write()', etc. Additionally, to make the 'mtdchar.c' file look consistent, rename similarly all the other functions starting with 'mtd_'. Signed-off-by:
-
Artem Bityutskiy authored
We are going to re-work the MTD interface and change 'mtd->write()' to 'mtd_write()', 'mtd->read()' to 'mtd_read()' and so forth for all functions in the 'struct mtd_info' structure. However, logfs has its own 'mtd_read()', 'mtd_write()', etc functions which collide with our changes. This patch renames these logfs functions to 'logfs_mtd_read()', 'logfs_mtd_write()', etc. Additionally, to make the 'fs/logfs/dev_mtd.c' file look consistent, rename similarly all the other functions starting with 'mtd_'. Cc: Jörn Engel <joern@logfs.org> Signed-off-by:
-
Artem Bityutskiy authored
We allocate the "mtd" structure using kzalloc which means we do not have to initialize unused MTD function pointers to NULL, since it is safe to assume in Linux that NULL contains all zeroes. Signed-off-by:
-
Artem Bityutskiy authored
This patch fixes the following build failure: In file included from include/linux/mtd/qinfo.h:4:0, from include/linux/mtd/pfow.h:7, from drivers/mtd/lpddr/lpddr_cmds.c:27: include/linux/mtd/map.h: In function 'inline_map_read': include/linux/mtd/map.h:409:3: error: implicit declaration of function 'BUILD_BUG_ON' [-Werror=implicit-function-declaration] Signed-off-by: -
Julia Lawall authored
Reimplement a call to devm_request_mem_region followed by a call to ioremap or ioremap_nocache by a call to devm_request_and_ioremap. The semantic patch that makes this transformation is as follows: (http://coccinelle.lip6.fr/) // <smpl> @nm@ expression myname; identifier i; @@ struct platform_driver i = { .driver = { .name = myname } }; @@ expression dev,res,size; expression nm.myname; @@ -if (!devm_request_mem_region(dev, res->start, size, - \(res->name\|dev_name(dev)\|myname\))) { - ... - return ...; -} ... when != res->start ( -devm_ioremap(dev,res->start,size) +devm_request_and_ioremap(dev,res) | -devm_ioremap_nocache(dev,res->start,size) +devm_request_and_ioremap(dev,res) ) ... when any when != res->start // </smpl> Signed-off-by:
Julia Lawall <julia@diku.dk> Signed-off-by:
Artem Bityutskiy <artem.bityutskiy@intel.com> Signed-off-by:
-
