- 07 Mar, 2014 40 commits
-
-
Monam Agarwal authored
This patch fixes sparse warnings "Using plain integer as NULL pointer" in sta_h2.c Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com> Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Monam Agarwal authored
Staging: iio/accel: Fix Prefer netdev_warn(netdev, ...then dev_warn(dev, ... then pr_warn(... to printk(KERN_INFO ... in sca3000_ring.c This patch fixes the following checkpatch.pl warning in sca3000_ring.c WARNING: Prefer netdev_info(netdev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ... Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Monam Agarwal authored
This patch fixes following checkpatch.pl warning WARNING: Prefer pr_warn(... to pr_warning(... Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Elena Oat authored
This patch fixes the warning of "Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are __aligned(2)" in file rtw_cmd.c. Pahole shows that the addresses are 2-byte aligned. Signed-off-by: Elena Oat <oat.elena@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Elena Oat authored
This patch fixes the warning of "suspect code indent for conditional statements" in file rtw_cmd.c. I have removed the conditional statements in two places altogether, as it didn't bring any value. Signed-off-by: Elena Oat <oat.elena@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Elena Oat authored
This patch fixes the warning of "space prohibited before semicolon" in file rtw_cmd.c. Signed-off-by: Elena Oat <oat.elena@gmail.com> Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Elena Oat authored
This patch fixes the warning of "unnecessary parentheses" in file rtw_cmd.c. Signed-off-by: Elena Oat <oat.elena@gmail.com> Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Elena Oat authored
This patch fixes the warning of "please, no space before tabs" in file rtw_cmd.c. I have also removed couple of lines of code that was commented and probably left from the previous version. Signed-off-by: Elena Oat <oat.elena@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Elena Oat authored
This patch fixes the warning of "please, no spaces at the start of a line" in file rtw_cmd.c. Signed-off-by: Elena Oat <oat.elena@gmail.com> Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Elena Oat authored
This patch fixes the warning of "braces {} are not necessary for single statement blocks" in file rtw_cmd.c. Signed-off-by: Elena Oat <oat.elena@gmail.com> Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Monam Agarwal authored
This patch fixes the following sparse warnings: drivers/staging/rtl8188eu/core/rtw_wlan_util.c:1627:25: warning: cast to restricted __le16 by changing the annotations in the struct declaration. Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com> Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Elena Oat authored
This patch fixes the warning produced by checkpatch of "printk should include KERN_ facility level". printk was replaced by netdev_info. While at it, I have also fixed the line over 80 characters warning. Signed-off-by: Elena Oat <oat.elena@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Elena Oat authored
This patch fixes the warning produced by checkpatch "Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are __aligned(2)". The address that is copied is a field of nat25_network_db_entry structure. Definition for this struct is found in rtw_br_ext.h file. Pahole shows that the addresses are 2-byte aligned. Signed-off-by: Elena Oat <oat.elena@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Elena Oat authored
This patch fixes the warning of "braces {} are not necessary for any arm of this statement" in file rtw_ioctl_set.c. The braces are removed in three places. Signed-off-by: Elena Oat <oat.elena@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Ebru Akagunduz authored
Fix checkpatch.pl issues with kfree(NULL) is safe this check is probably not required in rtw_ap.c Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com> Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Elena Oat authored
This patch fixes the warning produced by checkpatch in the file rtw_cmd.c "kfree(NULL) is safe this check is probably not required". The patch fixes it in two places for this file. Signed-off-by: Elena Oat <oat.elena@gmail.com> Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Elena Oat authored
This patch fixes the warning of "Please, no space before tab" produced by checkpatch.pl. The modified file: rtw_cmd.c. Signed-off-by: Elena Oat <oat.elena@gmail.com> Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Elena Oat authored
This patch fixes the warning of "space prohibited between function name and open parenthesis '('". The modified file: rtw_cmd.c. The patch also removes some strange spaces that were generated probably by some editor. Signed-off-by: Elena Oat <oat.elena@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
git://ftp.arm.linux.org.uk/~rmk/linux-armGreg Kroah-Hartman authored
Russell writes: This set of changes reorganises imx-drm's DT bindings by re-using the OF graph parsing code which was located in drivers/media, removing the temporary bindings. The result is that more TODO entries are now removed. While we're not quite done with this yet as there's a few straggling updates to imx-ldb to come, but leaving these out is not detrimental at this point in time - they are more an enhancement. However, this pull has the additional complication that we're sharing seven commits with Mauro's V4L git tree, which move the OF graph parsing code out of drivers/media into drivers/of. Philipp's imx-drm changes depend on these and my previously committed round of imx-drm commits. Hence, the diffstat below is from a test merge with your tree head (17b02809). Mauro merged those seven commits earlier today as a git pull, so both trees will be sharing exactly the same commit IDs. I've given these changes a spin here on both my Hummingboard and Cubox-i4 (one is iMX6Solo, the other is iMX6Quad based), which includes Xorg using the DRM device directly, and I find nothing wrong. The diffstat does look a little scarey - this is because we're having to update the ARM DT files along with this change, and obviously the dependency on the OF graph parsing code.
-
bahar sahin authored
This patch removes unnecessary braces to fix a checkpatch.pl warning. Signed-off-by: bahar sahin <baharxf@gmail.com> Reviewed-by: Sarah Sharp <sarah.a.sharp@linux.intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Himangi Saraogi authored
This patch fixes the checkpatch.pl warning : Prefer pr_warn(... to pr_warning(... Signed-off-by: Himangi Saraogi <himangi774@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Himangi Saraogi authored
This patch fixes the checkpatch warning : space prohibited after that open parenthesis '('. Signed-off-by: Himangi Saraogi <himangi774@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Ebru Akagunduz authored
Fix checkpatch.pl issues with no space before tabs in p80211mgmt.h Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Himangi Saraogi authored
This patch fixes the following sparse warnings: drivers/staging/wlan-ng/hfa384x_usb.c:3582:14: warning: cast to restricted __le16 drivers/staging/wlan-ng/hfa384x_usb.c:3584:19: warning: cast to restricted __le16 by changing the annotations in the struct declaration. Signed-off-by: Himangi Saraogi <himangi774@gmail.com> Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Tugce Sirin authored
This patch fixes following Sparse warning should it be static? in staging/wlan-ng. Signed-off-by: Tugce Sirin <ztugcesirin@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Monam Agarwal authored
This patch removes an unused struct while at the same time removing checkpatch.pl warning WARNING: Avoid use of typedef Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Monam Agarwal authored
This patch fixes the following checkpatch.pl issues in ced_ioctl.h WARNING: do not add new typedefs Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Monam Agarwal authored
This patch fixes the following checkpatch.pl issues in io.c WARNING: Bad function definition Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com> Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Monam Agarwal authored
This patch fixes following checkpatch.pl warning: WARNING:struct file_operations should normally be const Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com> Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Kristina Martšenko authored
Kernel coding style does not recommend using typedefs for structures, so remove the t3e3_resp_t typedef. Fix the following checkpatch warning: drivers/staging/sbe-2t3e3/ctrl.h:123: WARNING: do not add new typedefs Signed-off-by: Kristina Martšenko <kristina.martsenko@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Kristina Martšenko authored
Kernel coding style does not recommend using typedefs for structures, so remove the t3e3_stats_t typedef. Fix the following checkpatch warning: drivers/staging/sbe-2t3e3/ctrl.h:107: WARNING: do not add new typedefs Signed-off-by: Kristina Martšenko <kristina.martsenko@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Kristina Martšenko authored
Kernel coding style does not recommend using typedefs for structures, so remove the t3e3_param_t typedef. Fix the following checkpatch warning: drivers/staging/sbe-2t3e3/ctrl.h:87: WARNING: do not add new typedefs Signed-off-by: Kristina Martšenko <kristina.martsenko@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Kristina Martšenko authored
Kernel coding style does not recommend using typedefs for structures, so remove the t3e3_tx_desc_t typedef. Fix the following checkpatch warning: drivers/staging/sbe-2t3e3/2t3e3.h:651: WARNING: do not add new typedefs Signed-off-by: Kristina Martšenko <kristina.martsenko@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Kristina Martšenko authored
Kernel coding style does not recommend using typedefs for structures, so remove the t3e3_rx_desc_t typedef. Fix the following checkpatch warning: drivers/staging/sbe-2t3e3/2t3e3.h:616: WARNING: do not add new typedefs Signed-off-by: Kristina Martšenko <kristina.martsenko@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Elena Oat authored
This patch fixes an error in 2t3e3.h that (foo*) should be (foo *). Signed-off-by: Elena Oat <oat.elena@gmail.com> Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Himangi Saraogi authored
This patch removes the assignment in an if condition to do away with the checkpatch warning :'do not use assignment in if condition'. Signed-off-by: Himangi Saraogi <himangi774@gmail.com> Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Himangi Saraogi authored
This patch removes the assignment in if conditions to do away with the checkpatch warning :'do not use assignment in if condition'. Signed-off-by: Himangi Saraogi <himangi774@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Himangi Saraogi authored
This patch removes the assignment in if conditions to do away with the checkpatch warning :'do not use assignment in if condition'. Signed-off-by: Himangi Saraogi <himangi774@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Ebru Akagunduz authored
This patch fixes following sparse warning in dgap.c drivers/staging/media/lirc/lirc_sasem.c:392:32: warning: incorrect type in argument 1 (different address spaces) drivers/staging/media/lirc/lirc_sasem.c:392:32: expected void const [noderef] <asn:1>*<noident> drivers/staging/media/lirc/lirc_sasem.c:392:32: got char const *buf drivers/staging/media/lirc/lirc_sasem.c:123:28: warning: incorrect type in initializer (incompatible argument 2 (different address spaces)) drivers/staging/media/lirc/lirc_sasem.c:123:28: expected int ( *write )( ... ) drivers/staging/media/lirc/lirc_sasem.c:123:28: got int ( static [toplevel] *<noident> )( ... ) Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Ebru Akagunduz authored
This patch fixes the Sparse Warnings "symbol was not declared. Should it be static?" Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-