1. 26 Sep, 2020 2 commits
  2. 18 Sep, 2020 2 commits
  3. 16 Sep, 2020 1 commit
  4. 15 Sep, 2020 1 commit
  5. 14 Sep, 2020 4 commits
  6. 13 Sep, 2020 4 commits
  7. 11 Sep, 2020 1 commit
  8. 10 Sep, 2020 6 commits
  9. 09 Sep, 2020 1 commit
    • Sudeep Holla's avatar
      firmware: arm_scmi: Fix NULL pointer dereference in mailbox_chan_free · 6ed6c558
      Sudeep Holla authored
      scmi_mailbox is obtained from cinfo->transport_info and the first
      call to mailbox_chan_free frees the channel and sets cinfo->transport_info
      to NULL. Care is taken to check for non NULL smbox->chan but smbox can
      itself be NULL. Fix it by checking for it without which, kernel crashes
      with below NULL pointer dereference and eventually kernel panic.
      
         Unable to handle kernel NULL pointer dereference at
         		virtual address 0000000000000038
         Modules linked in: scmi_module(-)
         Hardware name: ARM LTD ARM Juno Development Platform/ARM Juno
         		Development Platform, BIOS EDK II Sep  2 2020
         pstate: 80000005 (Nzcv daif -PAN -UAO BTYPE=--)
         pc : mailbox_chan_free+0x2c/0x70 [scmi_module]
         lr : idr_for_each+0x6c/0xf8
         Call trace:
          mailbox_chan_free+0x2c/0x70 [scmi_module]
          idr_for_each+0x6c/0xf8
          scmi_remove+0xa8/0xf0 [scmi_module]
          platform_drv_remove+0x34/0x58
          device_release_driver_internal+0x118/0x1f0
          driver_detach+0x58/0xe8
          bus_remove_driver+0x64/0xe0
          driver_unregister+0x38/0x68
          platform_driver_unregister+0x1c/0x28
          scmi_driver_exit+0x38/0x44 [scmi_module]
         ---[ end trace 17bde19f50436de9 ]---
         Kernel panic - not syncing: Fatal exception
         SMP: stopping secondary CPUs
         Kernel Offset: 0x1d0000 from 0xffff800010000000
         PHYS_OFFSET: 0x80000000
         CPU features: 0x0240022,25806004
         Memory Limit: none
         ---[ end Kernel panic - not syncing: Fatal exception ]---
      
      Link: https://lore.kernel.org/r/20200908112611.31515-1-sudeep.holla@arm.com
      Fixes: 5c8a47a5 ("firmware: arm_scmi: Make scmi core independent of the transport type")
      Cc: Cristian Marussi <cristian.marussi@arm.com>
      Cc: Viresh Kumar <viresh.kumar@linaro.org>
      Tested-by: default avatarCristian Marussi <cristian.marussi@arm.com>
      Reviewed-by: default avatarCristian Marussi <cristian.marussi@arm.com>
      Reviewed-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
      Signed-off-by: default avatarSudeep Holla <sudeep.holla@arm.com>
      6ed6c558
  10. 08 Sep, 2020 2 commits
  11. 07 Sep, 2020 5 commits
  12. 06 Sep, 2020 1 commit
  13. 04 Sep, 2020 3 commits
  14. 02 Sep, 2020 5 commits
  15. 01 Sep, 2020 2 commits
    • Krzysztof Kozlowski's avatar
      memory: samsung: exynos5422-dmc: add missing and fix kerneldoc · 4c2af5dd
      Krzysztof Kozlowski authored
      Add missing kerneldoc to struct exynos5_dmc and correct the existing
      kerneldoc in other places to fix W=1 warnings like:
      
          drivers/memory/samsung/exynos5422-dmc.c:107: warning: Function parameter or member 'freq_hz' not described in 'dmc_opp_table'
          drivers/memory/samsung/exynos5422-dmc.c:154: warning: Function parameter or member 'dev' not described in 'exynos5_dmc'
          drivers/memory/samsung/exynos5422-dmc.c:357: warning: Excess function parameter 'param' description in 'exynos5_set_bypass_dram_timings'
          drivers/memory/samsung/exynos5422-dmc.c:630: warning: Function parameter or member 'flags' not described in 'exynos5_dmc_get_volt_freq'
          drivers/memory/samsung/exynos5422-dmc.c:962: warning: cannot understand function prototype: 'struct devfreq_dev_profile exynos5_dmc_df_profile = '
          drivers/memory/samsung/exynos5422-dmc.c:1011: warning: Function parameter or member 'reg_timing_row' not described in 'create_timings_aligned'
          drivers/memory/samsung/exynos5422-dmc.c:1011: warning: Excess function parameter 'idx' description in 'create_timings_aligned'
          drivers/memory/samsung/exynos5422-dmc.c:1345: warning: Excess function parameter 'set' description in 'exynos5_dmc_set_pause_on_switching'
      Signed-off-by: default avatarKrzysztof Kozlowski <krzk@kernel.org>
      Acked-by: default avatarLukasz Luba <lukasz.luba@arm.com>
      Link: https://lore.kernel.org/r/20200822163218.21857-3-krzk@kernel.org
      4c2af5dd
    • Krzysztof Kozlowski's avatar
      memory: samsung: exynos5422-dmc: remove unused exynos5_dmc members · 1415fa0d
      Krzysztof Kozlowski authored
      The struct exynos5_dmc members bypass_rate, mx_mspll_ccore_phy,
      mout_mx_mspll_ccore_phy and opp_bypass are not actually used.
      
      Apparently there was a plan to store the OPP for the bypass mode in
      opp_bypass member, but driver fails to do it and instead always sets
      target voltage during bypass mode.
      Signed-off-by: default avatarKrzysztof Kozlowski <krzk@kernel.org>
      Link: https://lore.kernel.org/r/20200822163218.21857-2-krzk@kernel.org
      1415fa0d