- 11 Mar, 2013 30 commits
-
-
Kurt Kanzenbach authored
This patch fixes the following checkpatch errors: -ERROR: do not initialise statics to 0 or NULL -ERROR: do not initialise globals to 0 or NULL Signed-off-by:
Kurt Kanzenbach <ly80toro@cip.cs.fau.de> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Kurt Kanzenbach authored
This patch fixes the following checkpatch warning: -ERROR: code indent should use tabs where possible -WARNING: suspect code indent for conditional statements Signed-off-by:
-
Syam Sidhardhan authored
kfree on NULL pointer is a no-op. Signed-off-by:
Syam Sidhardhan <s.syam@samsung.com> Signed-off-by:
-
Alexandru Gheorghiu authored
Fixed coding style issue. Signed-off-by:
Alexandru Gheorghiu <gheorghiuandru@gmail.com> Signed-off-by:
-
Randy Dunlap authored
Fix all sparse warning in drivers/staging/silicom/bypasslib/, e.g.: drivers/staging/silicom/bypasslib/bypass.c:471:21: warning: non-ANSI function declaration of function 'init_lib_module' drivers/staging/silicom/bypasslib/bypass.c:478:25: warning: non-ANSI function declaration of function 'cleanup_lib_module' drivers/staging/silicom/bypasslib/bypass.c:137:5: warning: symbol 'is_bypass_dev' was not declared. Should it be static? drivers/staging/silicom/bypasslib/bypass.c:182:5: warning: symbol 'is_bypass' was not declared. Should it be static? drivers/staging/silicom/bypasslib/bypass.c:192:5: warning: symbol 'get_bypass_slave' was not declared. Should it be static? drivers/staging/silicom/bypasslib/bypass.c:197:5: warning: symbol 'get_bypass_caps' was not declared. Should it be static? drivers/staging/silicom/bypasslib/bypass.c:202:5: warning: symbol 'get_wd_set_caps' was not declared. Should it be static? etc. Signed-off-by:
Randy Dunlap <rdunlap@infradead.org> Signed-off-by:
-
Peter Huewe authored
The first branch of the if statement is ended with a return thus there is no need for an else if, and thus we can move the duplicated code to the top and use it for the other two branches. Signed-off-by:
Peter Huewe <peterhuewe@gmx.de> Signed-off-by:
-
Peter Huewe authored
len is never read after assignment, thus can be removed. Signed-off-by:
-
Peter Huewe authored
sdio_boot.c and netlink_k.c both have a corresponding header file with their function prototypes but fail to include them, which leads to the following sparse warnings: sdio_boot.c:135:5: warning: symbol 'sdio_boot' was not declared. Should it be static? netlink_k.c:89:13: warning: symbol 'netlink_init' was not declared. Should it be static? netlink_k.c:109:6: warning: symbol 'netlink_exit' was not declared. Should it be static? netlink_k.c:114:5: warning: symbol 'netlink_send' was not declared. Should it be static? -> Add the include files and silence the warning Signed-off-by:
-
Joe Perches authored
Eliminate some warnings by casting to unsigned long before casting a dma_addr_t value to a pointer. btw: Does slicoss always work on x86-32? Is a pshmem guaranteed to be accessible by a 32 bit address? Signed-off-by:
Joe Perches <joe@perches.com> Signed-off-by:
-
Peter Huewe authored
Instead of assigning the pm_ops fields individually we can simply use SIMPLE_DEV_PM_OPS. Signed-off-by:
Javier Muñoz <jmunhoz@igalia.com> Signed-off-by:
-
Peter Huewe authored
Instead of performing the hash calculation for the mac address by ourself, we can simply reuse ether_crc and shift only the result according to our needs. The code was tested against the previous implementation by verifying both implementations against each other in userspace for 16200000000 different mac addresses, changing the vendor bits of the mac address first. Signed-off-by:
-
Peter Huewe authored
smatch complains about a possible buffer overflow slicoss.c:3651 slic_card_locate() error: buffer overflow 'physcard->adapter' 4 <= 4 If the for loop is not exited prematurely i++ is executed after the last iteration and thus i can be 4, which is out of bounds for physcard->adapter. -> Add check for this condition and simplify the if statement by inverting the condition. Signed-off-by:
-
Peter Huewe authored
gcc complains about an undefined operation: slicoss.c:1417:19: warning: operation on 'rspq->pageindex' may be undefined [-Wsequence-point] The intended operation was (probably) to retrieve the pageindex + 1 and let it wrap around if it reaches the num_pages. Signed-off-by:
-
Peter Huewe authored
skbtype is assigned once to NORMAL_ETHFRAME and then checked if it is NORMAL_ETHFRAME -> remove the checks. This also gets rid of the (false positive) smatch warning: slicoss.c:2829 slic_xmit_start() error: potential NULL dereference 'hcmd'. Signed-off-by:
-
Peter Huewe authored
Smatch complains that the variable adapter is dereferenced before it is checked: slicoss.c:906 slic_timer_load_check() warn: variable dereferenced before check 'adapter' (see line 904) -> move the assignment after the check. Signed-off-by:
-
Andres More authored
Removed includes and added linux/types.h instead when needed. Signed-off-by:
Andres More <more.andres@gmail.com> Signed-off-by:
-
Andres More authored
No checkpatch findings were resolved. sed -i 's/\bULONG_PTR\b/u32/g' drivers/staging/vt6656/*.[ch] sed -i 's/\bDWORD_PTR\b/u32/g' drivers/staging/vt6656/*.[ch] Signed-off-by:
-
Andres More authored
Checkpatch findings were not resolved. sed -i 's/\bDWORD\b/u32/g' drivers/staging/vt6656/*.[ch] sed -i 's/\bPDWORD\b/u32 */g' drivers/staging/vt6656/*.[ch] Signed-off-by:
-
Andres More authored
Checkpatch findings were not resolved. sed -i 's/\bWORD\b/u16/g' drivers/staging/vt6656/*.[ch] sed -i 's/\bPWORD\b/u16 */g' drivers/staging/vt6656/*.[ch] Signed-off-by:
-
Andres More authored
Checkpatch findings were not resolved, only direct replacement. sed -i 's/\bBYTE\b/u8/g' drivers/staging/vt6656/*.[ch] sed -i 's/\bPBYTE\b/u8 */g' drivers/staging/vt6656/*.[ch] Signed-off-by:
-
Kevin McKinney authored
This patch fixes a spelling error in PHSModule.c Signed-off-by:
Kevin McKinney <klmckinney1@gmail.com> Signed-off-by:
-
Kevin McKinney authored
This patch properly formats comments, and removes them as needed in PHSModule.c. Signed-off-by:
-
Kevin McKinney authored
This patch formats braces in PHSModule.c as reported by checkpatch.pl. Signed-off-by:
-
Kevin McKinney authored
This patch fixes all white space issues in PHSModule.c as reported by checkpatch.pl. Signed-off-by:
-
Chen Gang authored
set '\0' at tail for NUL terminated string, or TP_printk may cause issue. Signed-off-by:
Chen Gang <gang.chen@asianux.com> Signed-off-by:
-
Mihnea Dobrescu-Balaur authored
Signed-off-by:
Mihnea Dobrescu-Balaur <mihneadb@gmail.com> Signed-off-by:
-
Dan Carpenter authored
There is an ioctl() to write data to the firmware. After the data is written, it reads the databack from the firmware and compares against what the user wanted to write and prints an error message if it doesn't match. The problem is that verify process has a forever loop if the firmware size is not a multiple of 4. I've fixed it by replacing the bcm compare function with memcmp(). I have chopped out some debugging code in the process. Signed-off-by:
Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by:
-
Xi Wang authored
Free pBulkBuffer (pvBuffer) after pBulkBuffer->Register. Signed-off-by:
Xi Wang <xi.wang@gmail.com> Signed-off-by:
-
Peter Huewe authored
smatch complains about two dereferenced before check issues: sep_main.c:2898 sep_free_dma_tables_and_dcb() warn: variable dereferenced before check 'dma_ctx' (see line 2885) sep_main.c:2898 sep_free_dma_tables_and_dcb() warn: variable dereferenced before check '*dma_ctx' (see line 2885) -> Move the checks to the top, but keep the semantics. Signed-off-by:
-
Peter Huewe authored
Smatch complains about a potential NULL pointer dereference: sep_main.c:2312 sep_construct_dma_tables_from_lli() error: potential NULL dereference 'info_out_entry_ptr'. info_out_entry_ptr is initialized with NULL and if info_in_entry_ptr is not NULL it gets derefenced. However info_out_entry_ptr is only NULL in the first iteration of the while loop and in this case info_in_entry_ptr is also NULL (as indicated by the comment /* If info entry is null - this is the first table built */ -> this is a false positive. Nevertheless we add a check for info_out_entry_ptr to silence this warning and make it more robust in regard to code changes. Signed-off-by:
-
- 07 Mar, 2013 1 commit
-
-
Konrad Rzeszutek Wilk authored
On PPC64 we get this: In file included from drivers/staging/zcache/debug.c:2: drivers/staging/zcache/debug.h: In function 'dec_zcache_obj_count': drivers/staging/zcache/debug.h:16: error: implicit declaration of function 'BUG_ON' This simple patch adds the appropiate header file to finish the compile and reverts "staging: zcache: disable ZCACHE_DEBUG due to build error" (5db5a20a) Reported-by:
Stephen Rothwell <sfr@canb.auug.org.au> Signed-off-by:
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> Signed-off-by:
-
- 06 Mar, 2013 2 commits
-
-
Serban Constantinescu authored
Android's shared memory subsystem, Ashmem, does not support calls from a 32bit userspace in a 64 bit kernel. This patch adds support for syscalls coming from a 32bit userspace in a 64bit kernel. The patch has been successfully tested on ARMv8 AEM(64bit platform model) and Versatile Express A9(32bit platform). v2: Fix missing compat.h include. Signed-off-by:
Serban Constantinescu <serban.constantinescu@arm.com> Acked-by:
Arve Hjønnevåg <arve@android.com> Acked-by:
John Stultz <john.stultz@linaro.org> Signed-off-by:
-
Stephen Rothwell authored
In file included from drivers/staging/zcache/debug.c:2:0: drivers/staging/zcache/debug.h: In function 'dec_zcache_obj_count': drivers/staging/zcache/debug.h:16:2: error: implicit declaration of function 'BUG_ON' [-Werror=implicit-function-declaration] Signed-off-by:
-
- 05 Mar, 2013 7 commits
-
-
Konrad Rzeszutek Wilk authored
and also define this extra attribute in the Kconfig entry. Acked-by:
Dan Magenheimer <dan.magenheimer@oracle.com> Signed-off-by:
-
Konrad Rzeszutek Wilk authored
The other (same license) is at the end of the file. Acked-by:
-
Konrad Rzeszutek Wilk authored
We now have in zcache-main only the counters that are are not debugfs related. Acked-by:
-
Konrad Rzeszutek Wilk authored
It makes it neater and also allows us to piggyback on that in the zcache_dump function. Acked-by:
-
Konrad Rzeszutek Wilk authored
Note that at this point there is no CONFIG_ZCACHE_DEBUG option in the Kconfig. So in effect all of the counters are nop until that option gets re-introduced in: zcache/debug: Coalesce all debug under CONFIG_ZCACHE_DEBUG Acked-by:
-
Konrad Rzeszutek Wilk authored
as if you are debugging this driver you would be using 'debug' on the command line anyhow - and this would dump the debug data on the proper loglevel. While at it also remove the unconditional #define ZCACHE_DEBUG. Acked-by:
-
Konrad Rzeszutek Wilk authored
And now we can move the code ([inc|dec]_zcache_[*]) to their own file with a header to make them nops or feed in debugfs. Acked-by:
-
