- 28 Jan, 2019 21 commits
-
-
Pierre-Louis Bossart authored
Add helper to override dailink platform name, if passed as parameter Signed-off-by:
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Signed-off-by:
Mark Brown <broonie@kernel.org>
-
Pierre-Louis Bossart authored
Add helper to override dailink platform name, if passed as parameter Signed-off-by:
-
Pierre-Louis Bossart authored
Add helper to override dailink platform name, if passed as parameter Signed-off-by:
-
Pierre-Louis Bossart authored
Add helper to override dailink platform name, if passed as parameter Signed-off-by:
-
Pierre-Louis Bossart authored
Add helper to override dailink platform name, if passed as parameter Signed-off-by:
-
Pierre-Louis Bossart authored
Add helper to override dailink platform name, if passed as parameter Signed-off-by:
-
Pierre-Louis Bossart authored
Add helper to override dailink platform name, if passed as parameter Signed-off-by:
-
Pierre-Louis Bossart authored
Add helper to override dailink platform name, if passed as parameter Signed-off-by:
-
Pierre-Louis Bossart authored
Add helper to override dailink platform name, if passed as parameter Signed-off-by:
-
Pierre-Louis Bossart authored
Add helper to override dailink platform name, if passed as parameter Signed-off-by:
-
Pierre-Louis Bossart authored
Add helper to override dailink platform name, if passed as parameter Signed-off-by:
-
Pierre-Louis Bossart authored
Add helper to override dailink platform name, if passed as parameter Signed-off-by:
-
Pierre-Louis Bossart authored
Add helper to override dailink platform name, if passed as parameter Signed-off-by:
-
Pierre-Louis Bossart authored
Add helper to override dailink platform name, if passed as parameter Signed-off-by:
-
Pierre-Louis Bossart authored
To reuse the same machine drivers with Atom/SST, Skylake and SOF, we need to change the default platform_name (or platforms->name in the "modern" representation). So far, this override was done with an automatic override, which was broken by a set of changes for DT platforms related to deferred probe handling. This automatic override is actually not really needed, the machine driver can already receive the platform name as a platform_data parameter. This is used e.g. for HDaudio support where we have different PCI aliases used for different platforms. We can reuse the same mechanism and modify the machine drivers to override the dailinks prior to registrating the card. This will require additional work for SOF, but with this helper it'll be just two lines of additional code per machine driver which is reused, not the end of the world. This helper can be simplified when all drivers have transitioned to the "modern" representation of dailinks. Signed-off-by:
-
Yizhuo authored
In function rt5651_i2c_probe(), local variable "ret" could be uninitialized if function regmap_read() returns -EINVAL. However, this value is used in if statement. This is potentially unsafe. Signed-off-by:
Yizhuo <yzhai003@ucr.edu> Signed-off-by:
-
Pierre-Louis Bossart authored
Fix compilation issues reported by 0day-Kbuild with sparc64 w/ SOF. Signed-off-by:
-
Dimitris Papavasiliou authored
The rationale behind the current calculation is somewhat obscure [1] and can yield slightly wrong dividers in certain cases, which the machine drivers for some boards (like the HiFiBerry DAC+ Pro) seemingly try to circumvent, by updating the rate fraction so as to suit this calculation. The updated calculation should correctly yield the smallest bit clock rate that would fit the frame. [1] http://mailman.alsa-project.org/pipermail/alsa-devel/2019-January/144219.htmlSigned-off-by:
Dimitris Papavasiliou <dpapavas@gmail.com> Signed-off-by:
-
Dimitris Papavasiliou authored
Some boards, such as the HiFiBerry DAC+ Pro, use a pair of external oscillators, to generate 44.1 or 48kHz multiples and are forced to resort to hacks [1] in order to support 24-bit data without ending up with fractional dividers. This patch allows the machine driver to use 32-bit frames for 24-bit data to avoid such issues. Although the datasheet (p. 15) seems to suggest that only a handful of ratios are supported, it's not very explicit about it, so we allow the full range of values supported by the underlying register in the callback, to avoid needlessly rejecting potentially usable configurations. [1] http://mailman.alsa-project.org/pipermail/alsa-devel/2018-December/143442.htmlSigned-off-by:
-
Kuninori Morimoto authored
We can use for_each_link_codecs() without waiting for_each_rtd_codec_dai() on soc_bind_dai_link(). Let's use for_each macro. Fixes: 50acc7e49 ("ASoC: core: Fix multi-CODEC setups") Fixes: 10dff9b0 ("ASoC: soc-core: use for_each_link_codecs() for dai_link codecs") Signed-off-by:Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Tested-by:
Sylwester Nawrocki <s.nawrocki@samsung.com> Signed-off-by:
-
Kuninori Morimoto authored
This patch fixup build error for commit 6a8d4198 ("ASoC: mediatek: mt6358: add codec driver") Fixes: commit 6a8d4198 ("ASoC: mediatek: mt6358: add codec driver") Signed-off-by:
-
- 25 Jan, 2019 4 commits
-
-
Shunli Wang authored
Signed-off-by:
Shunli Wang <shunli.wang@mediatek.com> Signed-off-by:
-
Shunli Wang authored
add the mt6358 codec driver. Signed-off-by:
-
Shunli Wang authored
Signed-off-by:
-
Shunli Wang authored
add mt8183 audio platform and affiliated drivers. Signed-off-by:
-
- 24 Jan, 2019 1 commit
-
-
Colin Ian King authored
Don't populate the const arrays on the stack but instead make it static. Makes the object code smaller, for example: Before: text data bss dec hex filename 14107 8832 224 23163 5a7b bytcht_es8316.o After: text data bss dec hex filename 14015 8896 224 23135 5a5f bytcht_es8316.o (gcc version 8.2.0 x86_64) Signed-off-by:
Colin Ian King <colin.king@canonical.com> Acked-by:
-
- 22 Jan, 2019 1 commit
-
-
Mark Brown authored
Revert 10dff9b0 (ASoC: soc-core: use for_each_link_codecs() for dai_link codecs) for now as Sylwester Nawrocki reports that it causes oopses on at least Odroid boards. Reported-by:
-
- 21 Jan, 2019 7 commits
-
-
Kuninori Morimoto authored
Current simple-card is using asoc_simple_card_canonicalize_dailink(). Its naming is "dailink", but is for "platform". We already have asoc_simple_card_canonicalize_cpu() for "cpu", let's follow same naming rule. It never return error, so, void function is better idea. Signed-off-by:
-
Kuninori Morimoto authored
We can use for_each_link_codecs() without waiting for_each_rtd_codec_dai() on soc_bind_dai_link(). Let's use for_each macro Signed-off-by:
-
Kuninori Morimoto authored
We need to cleanup component when soc_probe_component() was failed, or when soc_remove_component() was called. But they are cleanuping component on each way. (And soc_probe_component() doesn't call snd_soc_dapm_free(), but it should). Same code in many places makes code un-understandable. This patch adds new soc_cleanup_component() and call it from snd_probe_component() and snd_remove_component(). Signed-off-by:
-
Kuninori Morimoto authored
Deep nested codec is not readable. Let's reduce if/else nest. Signed-off-by:
-
Kuninori Morimoto authored
We need to cleanup card resources when snd_soc_instantiate_card() was failed, or when snd_soc_unbind_card() was called. But they are cleanuping card resources on each way. Same code in many places makes code un-understandable. This patch reuses soc_cleanup_card_resources() for cleanuping code resource. Then, it makes avoiding cleanup order. It will be called from snd_soc_instantiate_card() and snd_soc_unbind_card(). Then, original soc_cleanup_card_resources() included snd_soc_flush_all_delayed_work(), but it is now separated. Signed-off-by:
-
Kuninori Morimoto authored
soc-core is calling flush_delayed_work() many times for same purpose. Same code in many places makes code un-understandable. This patch adds new snd_soc_flush_all_delayed_work() for it. Signed-off-by:
-
Kuninori Morimoto authored
Current snd_soc_dai_link is starting to use snd_soc_dai_link_component (= modern) style for Platform, but it is still assuming single Platform so far. We will need to have multi Platform support in the not far future. Currently only simple card is using it as sound card driver, and other drivers are converted to it from legacy style by snd_soc_init_platform(). To avoid future problem of multi Platform support, let's add num_platforms before it is too late. In the same time, to make it same naming mothed, "platform" should be "platforms". This patch fixup it too. Signed-off-by:
-
- 18 Jan, 2019 6 commits
-
-
Kuninori Morimoto authored
Current ALSA SoC is assuming 1 CPU 1 Platform (= DMA) style system. Because of this background, it is directly using xxx_name / xxx_of_node / xxx_dai_name on dai_link. Let's call it as legacy style here. More complex style system like multi CPU multi Platform (= DMA) will coming. To supporting it, we can use snd_soc_dai_link_component on dai_link. Let's call it as modern style here. But current ALSA SoC can't support it so far. Thus, we need to have multi CPU / multi Codec / multi Platform style in the future on ALSA SoC. Currently we already have multi Codec support. Platform is starting to use modern style on dai_link, but still style only. Multi Platform is not yet implemented. And we still don't have multi CPU support on ALSA SoC, and not have modern style either. Currently, if driver is using legacy style Codec/Platform, it will be converted to modern style on soc-core. This means, we are using glue code for legacy vs modern style so far on ALSA SoC. We can fully switch to modern style on all drivers if ALSA SoC supported modern style for CPU, and then, legacy style code will be removed from ALSA SoC. Untile then, we need to keep both legacy/modern style and its glue code. This patch adds such future plan and background on soc.h Signed-off-by:
-
Mark Brown authored
ASoC: Fixes for v5.0 Quite a big batch of fixes here. There's a couple of things going on, the main one is that we found some issues with not deferring probe when we should, causing us to skip some driver initialization. The fixes for this then in turn exposed some issues with how we were searching for components which had previously gone unnoticed due to the original issue. There's also been the normal driver specific stuff and there's been what looks like several batches of automated scanning for issues which have generated quite a large set of smaller fixes for potential crashes and missed error handling.
-
Shengjiu Wang authored
When stopping audio, ASoC will first stop DMA then CPU DAI. Sometimes there is a delay between DMA stop and CPU DAI stop, which triggers an underrun error. Now, because of the delay introduced by dev_err another underrun error will occur causing a vicious circle making impossible to stop CPU DAI. Signed-off-by:
Shengjiu Wang <shengjiu.wang@nxp.com> Signed-off-by:
Daniel Baluta <daniel.baluta@nxp.com> Signed-off-by:
-
Stefan Agner authored
Deferred probes shouldn't cause error messages in the boot log, so change the dev_err() to the more harmless dev_info(). Signed-off-by:
Stefan Agner <stefan@agner.ch> Signed-off-by:
-
Stefan Agner authored
Probe deferral is to be expected during normal operation, so avoid printing an error when it is encountered. Removing the goto would not be strictly necessary. However, if code gets added later, the cleanup in the EPROBE_DEFER case likely would get missed. Signed-off-by:
Nicolin Chen <nicoleotsuka@gmail.com> Reviewed-by:
Fabio Estevam <festevam@gmail.com> Signed-off-by:
-
Stefan Agner authored
Probe deferral is to be expected during normal operation, so avoid printing an error when it is encountered. Signed-off-by:
-
