- 13 Oct, 2015 33 commits
-
-
Shraddha Barke authored
The advantage of kcalloc is, that will prevent integer overflows which could result from the multiplication of number of elements and size and it is also a bit nicer to read. Signed-off-by:
Shraddha Barke <shraddha.6596@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Ivan Safonov authored
This patch inserts spaces preferred around that '+' found by checkpatch. Signed-off-by:
Ivan Safonov <insafonov@gmail.com> Signed-off-by:
-
Ivan Safonov authored
This patch inserts ARRAY_SIZE instead of sizeof(type array[])/sizeof(type), made arraylen variable constant and removes unnecessary default value in variable definition. Signed-off-by:
-
Shraddha Barke authored
ARRAY_SIZE is more concise to use when the size of an array is divided by the size of its type. Changes made using Coccinelle- @@ type T; T[] E; @@ - (sizeof(E)/sizeof(T)) + ARRAY_SIZE(E) Signed-off-by:
-
Ivan Safonov authored
Unused macro read_next_pair removed from rtl8188eu driver. Signed-off-by:
-
Iban Rodriguez authored
Correct errors reported by checkpatch.pl because space prohibited before ','. Also split one line into two as it was longer than 80 characters Signed-off-by:
Iban Rodriguez <iban.rodriguez@ono.com> Signed-off-by:
-
Luis de Bethencourt authored
range->avg_qual.level is of type uint8, so it shouldn't be assigned a negative number. Assigning it 0x100 - 78, which is the equivalent to (20 + -98) dBm when IW_QUAL_DBM is set. Signed-off-by:
Luis de Bethencourt <luisbg@osg.samsung.com> Signed-off-by:
-
Amitoj Kaur Chawla authored
Fix checkpatch.pl issue: "CHECK: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.txt". Replace `udelay()` with a call to `usleep_range()` with a reasonable upper limit determined by the other sleeping functions present. Signed-off-by:
Amitoj Kaur Chawla <amitoj1606@gmail.com> Signed-off-by:
-
Amitoj Kaur Chawla authored
Replace GFP_ATOMIC with GFP_KERNEL since GFP_ATOMIC is used in atomic context and only needed when functions are not allowed to sleep whereas the function is later calling msleep(). Signed-off-by:
-
Shraddha Barke authored
ARRAY_SIZE is more concise to use when the size of an array is divided by the size of its type Changes made using Coccinelle- @@ type T; T[] E; @@ - (sizeof(E)/sizeof(T)) + ARRAY_SIZE(E) Signed-off-by:
-
Luis de Bethencourt authored
range->max_qual.noise and level are of type uint8, so they shouldn't be assigned a negative number. Assigning them 0x100 - 98, and 0x100 - 78 which are the equivalent to -98 dBm and -78 dBm, respectively, when IW_QUAL_DBM is set. Signed-off-by:
-
Luis de Bethencourt authored
ieee80211_rx_stats.noise is of type uint8, so it shouldn't be assigned a negative number. Assigning it 0x100 - 98, which is the equivalent to -98 dBm when IW_QUAL_DBM is set. Signed-off-by:
-
Shraddha Barke authored
Remove commented out printk messages since they are not needed. Also remove the unnecessary braces and blank lines Signed-off-by:
Daniel Baluta <daniel.baluta@intel.com> Signed-off-by:
-
Shraddha Barke authored
Remove commented out printk messages since they are not needed Signed-off-by:
-
Shraddha Barke authored
Remove commented printk since it is not needed Signed-off-by:
-
Ksenija Stanojevic authored
Fix error "doing DMA on the stack" by using kzalloc for buffer allocation. Issue found by smatch. Signed-off-by:
Ksenija Stanojevic <ksenija.stanojevic@gmail.com> Reviewed-by:
Arnd Bergmann <arnd@arndb.de> Signed-off-by:
-
Alison Schofield authored
Out of memory messages are unnecssary in the drivers as they are reported by memory management. Addresses checkpatch.pl: WARNING: Possible unnecessary 'out of memory' message Signed-off-by:
Alison Schofield <amsfield22@gmail.com> Signed-off-by:
-
Shraddha Barke authored
The advantage of kcalloc is, that will prevent integer overflows which could result from the multiplication of number of elements and size and it is also a bit nicer to read. Signed-off-by:
-
Shraddha Barke authored
The advantage of kcalloc is, that will prevent integer overflows which could result from the multiplication of number of elements and size and it is also a bit nicer to read. Signed-off-by:
-
Ksenija Stanojevic authored
Use memdup_user when user data is immediately copied into the allocated region. Issue found using coccinelle. Signed-off-by: Ksenija Stanojevic<ksenija.stanojevic@gmail.com> Signed-off-by: -
Shraddha Barke authored
i2c_driver does not need to set an owner because core will set it Signed-off-by:
-
Masanari Iida authored
This patch fix spelling typo found in most Signed-off-by:
Masanari Iida <standby24x7@gmail.com> Signed-off-by:
-
Binbin Zhou authored
The PM_EVENT_RESUME state is needed when SM750 resume, otherwise it will be failed in the second time of continuous suspend/resume. Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com> Signed-off-by:
Binbin Zhou <zhoubb@lemote.com> Reviewed-by:
Huacai Chen <chenhc@lemote.com> Reviewed-by:
Teddy Wang <teddy.wang@siliconmotion.com> Signed-off-by:
-
Amitoj Kaur Chawla authored
Add space around operator '&'. Problem found using checkpatch.pl CHECK: spaces preferred around that '&' (ctx:VxV) Signed-off-by:
-
Amitoj Kaur Chawla authored
Add space around operator '<<'. Problem found using checkpatch.pl CHECK: spaces preferred around that '<<' (ctx:VxV) Signed-off-by:
-
Amitoj Kaur Chawla authored
Remove multiple blank lines. Problem found using checkpatch.pl CHECK: Please don't use multiple blank lines Signed-off-by:
-
Amitoj Kaur Chawla authored
Rename dispState to disp_state to avoid CamelCase. Problem found using checkpatch.pl CHECK: Avoid CamelCase: <dispState> Signed-off-by:
-
Amitoj Kaur Chawla authored
Remove multiple blank lines. Problem found using checkpatch.pl CHECK: Please don't use multiple blank lines Signed-off-by:
-
Amitoj Kaur Chawla authored
Rename miniDiff to mini_diff to avoid CamelCase. Problem found using checkpatch.pl CHECK: Avoid CamelCase: <miniDiff> Signed-off-by:
-
Amitoj Kaur Chawla authored
Remove space after opening brace '{'. Problem found using checkpatch.pl CHECK: Blank lines aren't necessary after an open brace '{' Signed-off-by: -
Amitoj Kaur Chawla authored
Remove space before closing brace '}'. Problem found using checkpatch.pl CHECK: Blank lines aren't necessary before a close brace '}' Signed-off-by:
-
Amitoj Kaur Chawla authored
Remove unnecessary space after cast. Problem found using checkpatch.pl CHECK: No space is necessary after a cast Signed-off-by:
-
Shraddha Barke authored
ARRAY_SIZE is more concise to use when the size of an array is divided by the size of its first element. Changes made using Coccinelle- @@ type T; T[] E; @@ - (sizeof(E)/sizeof(E[...])) + ARRAY_SIZE(E) Signed-off-by:
-
- 12 Oct, 2015 7 commits
-
-
Amitoj Kaur Chawla authored
The semantic patch used to find this is: @r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x)[...] | ((T *)x)->f | - (T *) e ) Signed-off-by:
-
Shraddha Barke authored
kfree on NULL pointer is a no-op. The semantic patch used to find such an instance where NULL check is present before kfree- // <smpl> @@ expression E; @@ - if (E != NULL) { kfree(E); } + kfree(E); @@ expression E; @@ - if (E != NULL) { kfree(E); E = NULL; } + kfree(E); + E = NULL; // </smpl>smpl> Signed-off-by: -
Ryan Van Quinlan authored
Fixes checkpatch.pl checks: CHECK: Comparison to NULL could be written ... Signed-off-by:
Ryan Van Quinlan <ryan.van.quinlan@gmail.com> Signed-off-by:
-
Shraddha Barke authored
Declare lustre_attr_show and lustre_attr_store as static since they are used only in this particular file. Also remove them from corresponding header files. Signed-off-by:
-
Shraddha Barke authored
Declare lu_dev_add_linkage and lu_object_find as static since they are used only in this particular file. Also remove the corresponding declarations from header file. Signed-off-by:
-
Yazen Ghannam authored
Also fixes a coding style error. Signed-off-by:
Yazen Ghannam <yghannam@gmail.com> Signed-off-by:
-
Shraddha Barke authored
Remove libiam.h since it is not used anywhere throughout the kernel. Signed-off-by:
-
