- 19 Feb, 2020 1 commit
-
-
Nathan Chancellor authored
Clang warns: ../drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link.c:980:36: warning: address of 'sink->edid_caps.panel_patch.skip_scdc_overwrite' will always evaluate to 'true' [-Wpointer-bool-conversion] if (&sink->edid_caps.panel_patch.skip_scdc_overwrite) ~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~ 1 warning generated. This is probably not what was intended so remove the address of operator, which matches how skip_scdc_overwrite is handled in the rest of the driver. While we're here, drop an extra newline after this if block. Fixes: a760fc1b ("drm/amd/display: add monitor patch to disable SCDC read/write") Link: https://github.com/ClangBuiltLinux/linux/issues/879Signed-off-by:Nathan Chancellor <natechancellor@gmail.com> Signed-off-by:
Zhan Liu <zhan.liu@amd.com> Reviewed-by:
Alex Deucher <alexander.deucher@amd.com>
-
- 13 Feb, 2020 1 commit
-
-
Evan Quan authored
Since 'smu_feature_is_enabled(smu, SMU_FEATURE_BACO_BIT)' will always return false considering the 'smu_system_features_control(smu, false)' disabled all SMU features. Signed-off-by:
Evan Quan <evan.quan@amd.com> Reviewed-by:
Kenneth Feng <kenneth.feng@amd.com> Signed-off-by:
-
- 12 Feb, 2020 19 commits
-
-
Dan Carpenter authored
The copy_to_user() function returns the number of bytes remaining to be copied, but we want to return a negative error code to the user. Fixes: 030d5b97 ("drm/amdgpu: use amdgpu_device_vram_access in amdgpu_ttm_vram_read") Reviewed-by:
Christian König <christian.koenig@amd.com> Signed-off-by:
Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by:
-
Alex Deucher authored
Otherwise we readback all ones. Fixes rlc counter readback while gfxoff is active. Reviewed-by:
Xiaojie Yuan <xiaojie.yuan@amd.com> Signed-off-by:
-
Alex Deucher authored
Otherwise we readback all ones. Fixes rlc counter readback while gfxoff is active. Reviewed-by:
-
Alex Deucher authored
It's 25 Mhz (refclk / 4). This fixes the interpretation of the rlc clock counter. Acked-by:
-
Alex Deucher authored
It's used by more than just DCN2.0. Fixes missing symbol when amdgpu is built without DCN support. Reviewed-by:
Rodrigo Siqueira <Rodrigo.Siqueira@amd.com> Signed-off-by:
-
Alex Deucher authored
to cover dcn2.x related headers. Reviewed-by:
-
Alex Deucher authored
To cover DCN 2.x. Reviewed-by:
-
Kent Russell authored
In certain situations the message could be reported dozens-to-hundreds of times, based on how often the function is called. E.g. If MCLK DPM, any calls to get/set MCLK will result in a failure message, potentially flooding dmesg. Ratelimit the warnings to avoid this flood. Signed-off-by:
Kent Russell <kent.russell@amd.com> Reviewed-by:
-
Evan Quan authored
Otherwise, the cached dpm features status may be inconsistent under some case(e.g. baco reset of Navi asic). Signed-off-by:
-
Bhawanpreet Lakha authored
there was a type in the terminate command. We should be calling psp_dtm_unload() instead of psp_hdcp_unload() Fixes: 143f2305 ("drm/amdgpu: psp DTM init") Signed-off-by:
Bhawanpreet Lakha <Bhawanpreet.Lakha@amd.com> Reviewed-by:
Feifei Xu <Feifei.Xu@amd.com> Signed-off-by:
-
Bhawanpreet Lakha authored
-msg_in is not needed for enabling encryption. -Use hdcp2_set_encryption instead of hdcp1_enable_encryption for hdcp2.2 Signed-off-by:
Nicholas Kazlauskas <nicholas.kazlauskas@amd.com> Signed-off-by:
-
Bhawanpreet Lakha authored
We were using incorrect byte order after we started using the drm_defines So fix it. Fixes: 02837a91 ("drm/amd/display: add and use defines from drm_hdcp.h") Signed-off-by:
JinZe.Xu <JinZe.Xu@amd.com> Signed-off-by:
Wenjing Liu <Wenjing.Liu@amd.com> Signed-off-by:
-
Wenjing Liu authored
[why] HDCP DTM needs to be aware of the upto date display topology information in order to validate hardware consistency. [how] update HDCP DTM on update_stream_config call. Signed-off-by:
Jun Lei <Jun.Lei@amd.com> Signed-off-by:
-
Wenjing Liu authored
[why] According to the specs when bksv or ksv list fails SRM check, HDCP TX should abort hdcp immediately. However with the current code HDCP will be reattampt upto 4 times. [how] Add the logic that stop HDCP retry if bksv or ksv list is revoked. Signed-off-by:
-
Bhawanpreet Lakha authored
[Why] PSP added a new return code for revoked receivers (SRM). We need to handle that so we don't retry hdcp This is already being handled on windows [How] Add the enums to psp interface header and handle them. Signed-off-by:
-
Alex Deucher authored
Seems to work reliably on VI+ except for a few so enable runpm barring those where baco for runtime power management is not supported. [rajneesh] Picked https://patchwork.freedesktop.org/patch/335402/ to enable runtime pm with baco for kfd. Also fixed a checkpatch warning and added extra checks for VEGA20 and ARCTURUS. Reviewed-by:
Rajneesh Bhardwaj <rajneesh.bhardwaj@amd.com> Signed-off-by:
-
Rajneesh Bhardwaj authored
So far the kfd driver implemented same routines for runtime and system wide suspend and resume (s2idle or mem). During system wide suspend the kfd aquires an atomic lock that prevents any more user processes to create queues and interact with kfd driver and amd gpu. This mechanism created problem when amdgpu device is runtime suspended with BACO enabled. Any application that relies on kfd driver fails to load because the driver reports a locked kfd device since gpu is runtime suspended. However, in an ideal case, when gpu is runtime suspended the kfd driver should be able to: - auto resume amdgpu driver whenever a client requests compute service - prevent runtime suspend for amdgpu while kfd is in use This change refactors the amdgpu and amdkfd drivers to support BACO and runtime power management. Reviewed-by:
Oak Zeng <oak.zeng@amd.com> Reviewed-by:
Felix Kuehling <felix.kuehling@amd.com> Signed-off-by:
-
Rajneesh Bhardwaj authored
During system suspend the kfd driver aquires a lock that prohibits further kfd actions unless the gpu is resumed. This adds some info which can be useful while debugging. Reviewed-by:
-
Rajneesh Bhardwaj authored
amdgpu_device_suspend might return an error code since it can be called from both runtime and system suspend flows. Add the missing return code in case of a failure. Reviewed-by:
-
- 11 Feb, 2020 19 commits
-
-
YueHaibing authored
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c: In function dcn10_post_unlock_program_front_end: drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c:2623:29: warning: variable stream_status set but not used [-Wunused-but-set-variable] commit bbf5f6c3 ("drm/amd/display: Split program front end part that occur outside lock") involved this unused variable. Signed-off-by:
YueHaibing <yuehaibing@huawei.com> Signed-off-by:
-
Alex Deucher authored
We need to handle the runpm case as well as GPU reset. Reviewed-by:
-
Alex Deucher authored
We need some special handling when using baco vs. other things. Reviewed-by:
-
Alex Deucher authored
So we know whether we in are in runtime suspend or system suspend. Reviewed-by:
-
Alex Deucher authored
Rather than the FEATURE_ID flags. Avoids a possible reading past the end of the array. Reviewed-by:
Aleksandr Mezin <mezin.alexander@gmail.com> Signed-off-by:
-
Alex Deucher authored
Update to the latest changes. Reviewed-by:
-
xinhui pan authored
As root PD has no parent, we just need move its status to idle. Suggested-by:
xinhui pan <xinhui.pan@amd.com> Reviewed-by:
-
Guchun Chen authored
Former comment looks to be one intended behavior in code, actually it's not. So correct it. Suggested-by:
Guchun Chen <guchun.chen@amd.com> Acked-by:
-
Prike Liang authored
SMU12 not support WORKLOAD_DEFAULT_BIT and WORKLOAD_PPLIB_POWER_SAVING_BIT. Signed-off-by:
Prike Liang <Prike.Liang@amd.com> Reviewed-by:
-
Evan Quan authored
To pair the latest SMU firmwares. Signed-off-by:
-
Sung Lee authored
[WHY] Programming DPPCLK to the same value currently set may cause underflow while playing video in certain conditions. [HOW] Only program DPPCLK if clock is not the same as the previous value programmed. Signed-off-by:
Sung Lee <sung.lee@amd.com> Reviewed-by:
Yongqiang Sun <yongqiang.sun@amd.com> Acked-by:
-
Nicholas Kazlauskas authored
[Why] In the case where we do have these passed in then we should be using these instead of the registers - those are only programmed when booting the adapter as primary. [How] Check if fb_base/fb_offset are non-zero. The value of 0 is invalid for fb_base but is valid for fb_offset on dGPU. Signed-off-by:
Aric Cyr <Aric.Cyr@amd.com> Reviewed-by:
-
Wyatt Wood authored
[Why] Driver needs to know PSR state. [How] Use GPINT to call to firmware and get psr state. Signed-off-by:
Wyatt Wood <wyatt.wood@amd.com> Reviewed-by:
-
Nicholas Kazlauskas authored
[Why] In DCN hardware sequencer we do actually call ATOM_INIT correctly per pipe. The workaround is not necessary for command table offloading. [How] Drop the workaround since it's not needed. Signed-off-by:
Chris Park <Chris.Park@amd.com> Acked-by:
-
Martin Leung authored
[why] customer issue: found that for their specific panel, EDID register space being overwritten during SCDC read write [how] customer accepted HDMI 2 features not working - disabled SCDC read/write as well as HDMI 2 in general based on monitor patch Signed-off-by:
Martin Leung <martin.leung@amd.com> Reviewed-by:
-
Dmytro Laktyushkin authored
Currently odm scaling calculations are only done when adding initial odm pipe. Any scaling re-calculations will mess up odm because of this. This change resolves the problem by updating scaling split logic to handle odm. Signed-off-by:
Dmytro Laktyushkin <Dmytro.Laktyushkin@amd.com> Reviewed-by:
Eric Yang <eric.yang2@amd.com> Acked-by:
Michael Strauss <Michael.Strauss@amd.com> Acked-by:
-
Anthony Koo authored
Signed-off-by:
Anthony Koo <Anthony.Koo@amd.com> Reviewed-by:
-
Nikola Cornij authored
In the struct dc_panel_patch, we have a field named manage_secondary_link which is not used by any part of the code. This commit drops the unused field. Signed-off-by:
Nikola Cornij <nikola.cornij@amd.com> Reviewed-by:
Joshua Aberback <Joshua.Aberback@amd.com> Acked-by:
-
Anthony Koo authored
[Why] Some register defines are redundant or updated [How] Update register defines Remove some redundant defines Signed-off-by:
Sun peng Li <Sunpeng.Li@amd.com> Signed-off-by:
-
