- 31 Dec, 2013 16 commits
-
-
Daniel Borkmann authored
In order to facilitate development for netlink protocol dissector, fill the unused field skb->pkt_type of the cloned skb with a hint of the address space of the new owner (receiver) socket in the notion of "to kernel" resp. "to user". At the time we invoke __netlink_deliver_tap_skb(), we already have set the new skb owner via netlink_skb_set_owner_r(), so we can use that for netlink_is_kernel() probing. In normal PF_PACKET network traffic, this field denotes if the packet is destined for us (PACKET_HOST), if it's broadcast (PACKET_BROADCAST), etc. As we only have 3 bit reserved, we can use the value (= 6) of PACKET_FASTROUTE as it's _not used_ anywhere in the whole kernel and not supported anywhere, and packets of such type were never exposed to user space, so there are no overlapping users of such kind. Thus, as wished, that seems the only way to make both PACKET_* values non-overlapping and therefore device agnostic. By using those two flags for netlink skbs on nlmon devices, they can be made available and picked up via sll_pkttype (previously unused in netlink context) in struct sockaddr_ll. We now have these two directions: - PACKET_USER (= 6) -> to user space - PACKET_KERNEL (= 7) -> to kernel space Partial `ip a` example strace for sa_family=AF_NETLINK with detected nl msg direction: syscall: direction: sendto(3, ...) = 40 /* to kernel */ recvmsg(3, ...) = 3404 /* to user */ recvmsg(3, ...) = 1120 /* to user */ recvmsg(3, ...) = 20 /* to user */ sendto(3, ...) = 40 /* to kernel */ recvmsg(3, ...) = 168 /* to user */ recvmsg(3, ...) = 144 /* to user */ recvmsg(3, ...) = 20 /* to user */ Signed-off-by:
Daniel Borkmann <dborkman@redhat.com> Signed-off-by:
Jakub Zawadzki <darkjames-ws@darkjames.pl> Signed-off-by:
David S. Miller <davem@davemloft.net>
-
Daniel Borkmann authored
We should also deliver packets to nlmon devices when we are in netlink_unicast_kernel(), and only one of the {src,dst} sockets is user sk and the other one kernel sk. That's e.g. the case in netlink diag, netlink route, etc. Still, forbid to deliver messages from kernel to kernel sks. Signed-off-by: -
David S. Miller authored
Neil Horman says: ==================== sctp: Consolidate and ratelimit deprecation warnings The SCTP protocol has several deprecation warnings in its setsockopt path that can be triggered by unprivlidged users. Since these are not ratelimited, we can spam the logs quite easily here. Since these are all deprecation warnings, and that type of warning isn't uncommon in the rest of the kernel, lets make a common pr_warn_deprecated macro to produce somewhat generalized ratelimited deprecation warnings easily ==================== Signed-off-by:
Neil Horman <nhorman@tuxdriver.com> Signed-off-by:
-
Neil Horman authored
During a recent discussion regarding some sctp socket options, it was noted that we have several points at which we issue log warnings that can be flooded at an unbounded rate by any user. Fix this by converting all the pr_warns in the sctp_setsockopt path to be pr_warn_ratelimited. Note there are several debug level messages as well. I'm leaving those alone, as, if you turn on pr_debug, you likely want lots of verbosity. Signed-off-by:
-
Neil Horman authored
sctp has several points in its setsockopt path in which it issues deprecation warnings. It seems like it might be handy to macrotize such a warning so other subsystems can use it easily Signed-off-by:
-
Yang Yingliang authored
In dsmark_drop(), the function name printed by pr_debug is "dsmark_reset", correct it to "dsmark_drop" by using __func__ . BTW, replace the other function names with __func__ . Signed-off-by:
Yang Yingliang <yangyingliang@huawei.com> Signed-off-by:
-
Yang Yingliang authored
Do not use C99 // comments and correct a spelling typo. Signed-off-by:
-
Yang Yingliang authored
Prefer pr_warn(... to pr_warning(... Signed-off-by:
-
Weilong Chen authored
Cleanup checkpatch errors.Specially,the second changed line is exactly 80 columns long. Signed-off-by:
Weilong Chen <chenweilong@huawei.com> Signed-off-by:
-
Li RongQing authored
Since addrconf_get_prefix_route inputs the address prefix to fib6_locate, which does not uses the data which is out of the prefix_len length, so do not need to use ipv6_addr_prefix to get address prefix. Signed-off-by:
Li RongQing <roy.qing.li@gmail.com> Acked-by:
Hannes Frederic Sowa <hannes@stressinduktion.org> Signed-off-by:
-
David S. Miller authored
Zhi Yong Wu says: ==================== tun: add the RFS support Since Tom Herbert's hash related patchset was modified and got merged, his pachset about adding support for RFS on tun flows also need to get adjusted accordingly. I tried to update them, and before i will start to do some perf tests, i hope to get one correct code base, so it's time to post them out now. Any constructive comments are welcome, thanks. ==================== Signed-off-by: -
Tom Herbert authored
This patch adds support so that the rps_flow_tables (RFS) can be programmed using the tun flows which are already set up to track flows for the purposes of queue selection. On the receive path (corresponding to select_queue and tun_net_xmit) the rxhash is saved in the flow_entry. The original code only does flow lookup in select_queue, so this patch adds a flow lookup in tun_net_xmit if num_queues == 1 (select_queue is not called from dev_queue_xmit->netdev_pick_tx in that case). The flow is recorded (processing CPU) in tun_flow_update (TX path), and reset when flow is deleted. Signed-off-by:
Tom Herbert <therbert@google.com> Signed-off-by:
Zhi Yong Wu <wuzhy@linux.vnet.ibm.com> Signed-off-by:
-
Tom Herbert authored
This patch adds sock_rps_record_flow_hash and sock_rps_reset_flow_hash which take a hash value as an argument and sets the sock_flow_table accordingly. This allows the table to be populated in cases where flow is being tracked outside of a sock structure. sock_rps_record_flow and sock_rps_reset_flow call this function where the hash is taken from sk_rxhash. Signed-off-by:
-
dingtianhong authored
Signed-off-by:
Ding Tianhong <dingtianhong@huawei.com> Signed-off-by:
-
dingtianhong authored
The bond 3ad and TLB/ALB has the same check path, so combine them. Signed-off-by:
-
dingtianhong authored
The bond driver could set the lp_interval when loading module. Suggested-by:
Scott Feldman <sfeldma@cumulusnetworks.com> Signed-off-by:
-
- 29 Dec, 2013 5 commits
-
-
stephen hemminger authored
Remove leftover code that is not used anywhere in current tree. Signed-off-by:
Stephen Hemminger <stephen@networkplumber.org> Signed-off-by:
-
stephen hemminger authored
bond_xmit_slave_id is only used in main. Signed-off-by:
-
stephen hemminger authored
The following are only used in one file: tcp_connect_init tcp_set_rto Signed-off-by:
-
Geert Uytterhoeven authored
This allows to drop a few casts. Signed-off-by:
Geert Uytterhoeven <geert@linux-m68k.org> Signed-off-by:
-
Geert Uytterhoeven authored
Most of them reported by checkpatch.pl Signed-off-by:
-
- 28 Dec, 2013 5 commits
-
-
Stephen Hemminger authored
Don't export ping_table or ping_v4_sendmsg. Both are only used inside ping code. Signed-off-by:
-
Stephen Hemminger authored
inetpeer_invalidate_family defined but never used Signed-off-by:
-
Stephen Hemminger authored
Don't export arp_invalidate, only used in arp.c Signed-off-by:
-
Stephen Hemminger authored
Make fib_detect_death function static only used in one file. Signed-off-by:
-
stephen hemminger authored
Only used in one file, no need to expose Signed-off-by:
-
- 27 Dec, 2013 5 commits
-
-
Hauke Mehrtens authored
This works pretty much the same way, so avoid duplicating the code. Signed-off-by:
Hauke Mehrtens <hauke@hauke-m.de> Signed-off-by:
Rafał Miłecki <zajec5@gmail.com> Acked-by:
Florian Fainelli <f.fainelli@gmail.com> Signed-off-by:
-
Rafał Miłecki authored
Signed-off-by:
-
Weilong Chen authored
Fix checkpatch error with space. Signed-off-by:
-
Weilong Chen authored
Signed-off-by:
-
Ben Hutchings authored
All other net drivers with PTP support enable it unconditionally. Make tile_net consistent with this. Signed-off-by:
Ben Hutchings <bhutchings@solarflare.com> Acked-by:
Chris Metcalf <cmetcalf@tilera.com> Signed-off-by:
-
- 26 Dec, 2013 9 commits
-
-
David S. Miller authored
drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c: In function 'bnx2x_drv_info_ether_stat': drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c:3302:46: error: dereferencing pointer to incomplete type make[6]: *** [drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.o] Error 1 Reported-by:
Eric Dumazet <eric.dumazet@gmail.com> Signed-off-by:
-
Michal Schmidt authored
The recent conversion to skb_set_hash() was incorrect. 'skb' is uninitialized at this point. Fixes: 0b680703 ('net: vmxnet3 calls skb_set_hash') Signed-off-by:
Michal Schmidt <mschmidt@redhat.com> Acked-by:
-
Yang Yingliang authored
When we set burst to 1514 with low rate in userspace, the kernel get a value of burst that less than 1514, which doesn't work. Because it may make some loss when transform burst to buffer in userspace. This makes burst lose some bytes, when the kernel transform the buffer back to burst. This patch adds two new attributes to support sending burst/mtu to kernel directly to avoid the loss. Signed-off-by:
Eric Dumazet <edumazet@google.com> Signed-off-by:
-
wangweidong authored
Signed-off-by:
Wang Weidong <wangweidong1@huawei.com> Signed-off-by:
-
wangweidong authored
fix checkpatch errors below: ERROR: that open brace { should be on the previous line ERROR: open brace '{' following function declarations go on the next line ERROR: trailing statements should be on next line Signed-off-by: -
wangweidong authored
fix checkpatch errors below: ERROR: switch and case should be at the same inden ERROR: code indent should use tabs where possible Acked-by:
-
wangweidong authored
fix checkpatch errors below: ERROR: "(foo*)" should be "(foo *)" ERROR: "foo * bar" should be "foo *bar" ERROR: "foo* bar" should be "foo *bar" Signed-off-by:
-
wangweidong authored
fix checkpatch errors while the space is required or prohibited to the "=,()++..." Acked-by:
-
Weilong Chen authored
Fix some checkpatch errors for tcp_ipv6.c Signed-off-by:
-
