1. 15 Feb, 2006 1 commit
    • Steven Whitehouse's avatar
      [GFS2] Fix for lock recursion problem for internal files · 61a30dcb
      Steven Whitehouse authored
      Two internal files which are read through the gfs2_internal_read()
      routine were already locked when the routine was called and this
      do not need locking at the redapages level.
      
      This patch introduces a struct file which is used as a sentinal
      so that readpage will only perform locking in the case that the
      struct file passed to it is _not_ equal to this sentinal.
      
      Since the comments in the generic kernel code indicate that the
      struct file will never be used for anything other than passing
      straight through to readpage(), this should be ok.
      Signed-off-by: default avatarSteven Whitehouse <swhiteho@redhat.com>
      61a30dcb
  2. 14 Feb, 2006 2 commits
    • Steven Whitehouse's avatar
      [GFS2] Fix the bugs I introduced in the last patch but one · 4dd651ad
      Steven Whitehouse authored
      Various endianess changes required in the directory code.
      Signed-off-by: default avatarSteven Whitehouse <swhiteho@redhat.com>
      4dd651ad
    • Steven Whitehouse's avatar
      [GFS2] Put back O_DIRECT support · d1665e41
      Steven Whitehouse authored
      This patch adds back O_DIRECT support with various caveats
      attached:
      
       1. Journaled data can be read via O_DIRECT since its now the
          same on disk format as normal data files.
       2. Journaled data writes with O_DIRECT will be failed sliently
          back to normal writes (should we really do this I wonder or
          should we return an error instead?)
       3. Stuffed files will be failed back to normal buffered I/O
       4. All the usual corner cases (write beyond current end of file,
          write to an unallocated block) will also revert to normal buffered I/O.
      
      The I/O path is slightly odd as reads arrive at the page cache layer
      with the lock for the file already held, but writes arrive unlocked.
      Signed-off-by: default avatarSteven Whitehouse <swhiteho@redhat.com>
      d1665e41
  3. 13 Feb, 2006 2 commits
    • Steven Whitehouse's avatar
      [GFS2] Change ondisk format (hopefully for the last time) · fc69d0d3
      Steven Whitehouse authored
      There were one or two fields in structures which didn't get changed
      last time back to their gfs1 sizes and alignments. One or two constants
      have also changed back to their original values which were missed the
      first time.
      
      Its possible that indirect pointer blocks might need to change. If
      they don't we'll have to rewrite them all on upgrade due to a change
      in the amount of padding that they use.
      Signed-off-by: default avatarSteven Whitehouse <swhiteho@redhat.com>
      fc69d0d3
    • Steven Whitehouse's avatar
      [GFS2] Fix for root inode ref count bug · 7359a19c
      Steven Whitehouse authored
      Umount is now working correctly again. The bug was due to
      not getting an extra ref count when mounting the fs. We
      should have bumped it by two (once for the internal pointer
      to the root inode from the super block and once for the
      inode hanging off the dcache entry for root).
      
      Also this patch tidys up the code dealing with looking up
      and creating inodes. We now pass Linux inodes (with gfs2_inodes
      attached) rather than the other way around and this reduces code
      duplication in various places.
      Signed-off-by: default avatarSteven Whitehouse <swhiteho@redhat.com>
      7359a19c
  4. 08 Feb, 2006 1 commit
    • Steven Whitehouse's avatar
      [GFS2] Make journaled data files identical to normal files on disk · 18ec7d5c
      Steven Whitehouse authored
      This is a very large patch, with a few still to be resolved issues
      so you might want to check out the previous head of the tree since
      this is known to be unstable. Fixes for the various bugs will be
      forthcoming shortly.
      
      This patch removes the special data format which has been used
      up till now for journaled data files. Directories still retain the
      old format so that they will remain on disk compatible with earlier
      releases. As a result you can now do the following with journaled
      data files:
      
       1) mmap them
       2) export them over NFS
       3) convert to/from normal files whenever you want to (the zero length
          restriction is gone)
      
      In addition the level at which GFS' locking is done has changed for all
      files (since they all now use the page cache) such that the locking is
      done at the page cache level rather than the level of the fs operations.
      This should mean that things like loopback mounts and other things which
      touch the page cache directly should now work.
      
      Current known issues:
      
       1. There is a lock mode inversion problem related to the resource
          group hold function which needs to be resolved.
       2. Any significant amount of I/O causes an oops with an offset of hex 320
          (NULL pointer dereference) which appears to be related to a journaled data
          buffer appearing on a list where it shouldn't be.
       3. Direct I/O writes are disabled for the time being (will reappear later)
       4. There is probably a deadlock between the page lock and GFS' locks under
          certain combinations of mmap and fs operation I/O.
       5. Issue relating to ref counting on internally used inodes causes a hang
          on umount (discovered before this patch, and not fixed by it)
       6. One part of the directory metadata is different from GFS1 and will need
          to be resolved before next release.
      Signed-off-by: default avatarSteven Whitehouse <swhiteho@redhat.com>
      18ec7d5c
  5. 31 Jan, 2006 1 commit
  6. 30 Jan, 2006 9 commits
  7. 24 Jan, 2006 2 commits
  8. 20 Jan, 2006 8 commits
  9. 19 Jan, 2006 14 commits