1. 03 Aug, 2017 33 commits
  2. 02 Aug, 2017 7 commits
    • Ido Schimmel's avatar
      mlxsw: core: Use correct EMAD transaction ID in debug message · 9820355f
      Ido Schimmel authored
      'trans->tid' is only assigned later in the function, resulting in a zero
      transaction ID. Use 'tid' instead.
      Signed-off-by: default avatarIdo Schimmel <idosch@mellanox.com>
      Signed-off-by: default avatarJiri Pirko <jiri@mellanox.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      9820355f
    • David S. Miller's avatar
      Merge branch 'netvsc-transparent-VF-support' · f6775a28
      David S. Miller authored
      Stephen Hemminger says:
      
      ====================
      netvsc: transparent VF support
      
      This patch set changes how SR-IOV Virtual Function devices are managed
      in the Hyper-V network driver. This version is rebased onto current net-next.
      
      Background
      
      In Hyper-V SR-IOV can be enabled (and disabled) by changing guest settings
      on host. When SR-IOV is enabled a matching PCI device is hot plugged and
      visible on guest. The VF device is an add-on to an existing netvsc
      device, and has the same MAC address.
      
      How is this different?
      
      The original support of VF relied on using bonding driver in active
      standby mode to handle the VF device.
      
      With the new netvsc VF logic, the Linux hyper-V network
      virtual driver will directly manage the link to SR-IOV VF device.
      When VF device is detected (hot plug) it is automatically made a
      slave device of the netvsc device. The VF device state reflects
      the state of the netvsc device; i.e. if netvsc is set down, then
      VF is set down. If netvsc is set up, then VF is brought up.
      
      Packet flow is independent of VF status; all packets are sent and
      received as if they were associated with the netvsc device. If VF is
      removed or link is down then the synthetic VMBUS path is used.
      
      What was wrong with using bonding script?
      
      A lot of work went into getting the bonding script to work on all
      distributions, but it was a major struggle. Linux network devices
      can be configured many, many ways and there is no one solution from
      userspace to make it all work. What is really hard is when
      configuration is attached to synthetic device during boot (eth0) and
      then the same addresses and firewall rules needs to also work later if
      doing bonding. The new code gets around all of this.
      
      How does VF work during initialization?
      
      Since all packets are sent and received through the logical netvsc
      device, initialization is much easier. Just configure the regular
      netvsc Ethernet device; when/if SR-IOV is enabled it just
      works. Provisioning and cloud init only need to worry about setting up
      netvsc device (eth0). If SR-IOV is enabled (even as a later step), the
      address and rules stay the same.
      
      What devices show up?
      
      Both netvsc and PCI devices are visible in the system. The netvsc
      device is active and named in usual manner (eth0). The PCI device is
      visible to Linux and gets renamed by udev to a persistent name
      (enP2p3s0). The PCI device name is now irrelevant now.
      
      The logic also sets the PCI VF device SLAVE flag on the network
      device so network tools can see the relationship if they are smart
      enough to understand how layered devices work.
      
      This is a lot like how I see Windows working.
      The VF device is visible in Device Manager, but is not configured.
      
      Is there any performance impact?
      There is no visible change in performance. The bonding
      and netvsc driver both have equivalent steps.
      
      Is it compatible with old bonding script?
      
      It turns out that if you use the old bonding script, then everything
      still works but in a sub-optimum manner. What happens is that bonding
      is unable to steal the VF from the netvsc device so it creates a one
      legged bond.  Packet flow then is:
      	bond0 <--> eth0 <- -> VF (enP2p3s0).
      In other words, if you get it wrong it still works, just
      awkward and slower.
      
      What if I add address or firewall rule onto the VF?
      
      Same problems occur with now as already occur with bonding, bridging,
      teaming on Linux if user incorrectly does configuration onto
      an underlying slave device. It will sort of work, packets will come in
      and out but the Linux kernel gets confused and things like ARP don’t
      work right.  There is no way to block manipulation of the slave
      device, and I am sure someone will find some special use case where
      they want it.
      ====================
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      f6775a28
    • stephen hemminger's avatar
      netvsc: remove bonding setup script · 12aa7469
      stephen hemminger authored
      No longer needed, now all managed by transparent VF logic.
      Signed-off-by: default avatarStephen Hemminger <sthemmin@microsoft.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      12aa7469
    • stephen hemminger's avatar
      netvsc: add documentation · a5050c61
      stephen hemminger authored
      Add some background documentation on netvsc device options
      and limitations.
      Signed-off-by: default avatarStephen Hemminger <sthemmin@microsoft.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      a5050c61
    • stephen hemminger's avatar
      netvsc: transparent VF management · 0c195567
      stephen hemminger authored
      This patch implements transparent fail over from synthetic NIC to
      SR-IOV virtual function NIC in Hyper-V environment. It is a better
      alternative to using bonding as is done now. Instead, the receive and
      transmit fail over is done internally inside the driver.
      
      Using bonding driver has lots of issues because it depends on the
      script being run early enough in the boot process and with sufficient
      information to make the association. This patch moves all that
      functionality into the kernel.
      Signed-off-by: default avatarStephen Hemminger <sthemmin@microsoft.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      0c195567
    • Amitoj Kaur Chawla's avatar
      atm: solos-pci: constify attribute_group structures · 638ce0fc
      Amitoj Kaur Chawla authored
      Functions working with attribute_groups provided by <linux/sysfs.h>
      work with const attribute_group. These attribute_group structures do not
      change at runtime so mark them as const.
      
      File size before:
       text      data     bss     dec     hex filename
       35740    28424     832   64996    fde4 drivers/atm/solos-pci.o
      
      File size after:
       text      data     bss     dec     hex filename
       35932    28232     832   64996    fde4 drivers/atm/solos-pci.o
      
      This change was made with the help of Coccinelle.
      Signed-off-by: default avatarAmitoj Kaur Chawla <amitoj1606@gmail.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      638ce0fc
    • Amitoj Kaur Chawla's avatar
      atm: adummy: constify attribute_group structure · 444826a9
      Amitoj Kaur Chawla authored
      Functions working with attribute_groups provided by <linux/sysfs.h>
      work with const attribute_group. These attribute_group structures do not
      change at runtime so mark them as const.
      
      File size before:
       text      data     bss     dec     hex filename
       2033      1448       0    3481     d99 drivers/atm/adummy.o
      
      File size after:
       text      data     bss     dec     hex filename
       2129      1352       0    3481     d99 drivers/atm/adummy.o
      
      This change was made with the help of Coccinelle.
      Signed-off-by: default avatarAmitoj Kaur Chawla <amitoj1606@gmail.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      444826a9