- 01 Nov, 2017 5 commits
-
-
Christoph Hellwig authored
No change in behavior except that the FC code cancels two work items a little later now. Signed-off-by:
Christoph Hellwig <hch@lst.de> Reviewed-by:
Sagi Grimberg <sagi@grimberg.me> Reviewed-by:
James Smart <james.smart@broadcom.com> Signed-off-by:
-
Christoph Hellwig authored
It is only used in two places, and some of the work done by it will be taken into common code soon. Signed-off-by:
-
Christoph Hellwig authored
Move the ->delete_work and the associated helpers to common code instead of duplicating them in every driver. This also adds the missing reference get/put for the loop driver. Signed-off-by:
-
Christoph Hellwig authored
No need to have two functions doing the same thing. Signed-off-by:
-
James Smart authored
There's no need to wait for the full nvme_wq, which is now shared, to flush. flush only the delete_work item. Signed-off-by:
Sagi Grimberg <sgi@grimberg.me> Signed-off-by:
-
- 27 Oct, 2017 10 commits
-
-
James Smart authored
The define is an arbitrary limit to the io size on the initiator, capping the io to 1MB-4KB. Remove the define from the transport. I/O size will solely be limited by the LLDD sg limits. Signed-off-by:
-
James Smart authored
Adds support for the duplicate_connect option. When set to true, checks whether there's an existing controller via the same host port and target port for the same host (hostnqn, hostid) to the same subsystem. Fails the connection request if an existing controller. Signed-off-by:
Johannes Thumshirn <jthumshirn@suse.de> Signed-off-by:
-
James Smart authored
Adds support for the duplicate_connect option. When set to true, checks whether there's an existing controller via the same target address (traddr), target port (trsvcid), and if specified, host address (host_traddr). Fails the connection request if there is an existing controller. Signed-off-by:
-
James Smart authored
Adds a helper function that compares the host and subsytem specified in a connect options list vs a controller. Signed-off-by:
-
James Smart authored
Add the "duplicate_connect" boolean option (presence means true). Default is false. When false, the transport should validate whether a new controller request is targeted for the same host transport addressing and target transport addressing as an existing controller. If so, the new controller request should be rejected. When true, the callee is explicitly requesting a duplicate controller connection to be made and the new request should be attempted. Signed-off-by:
-
Christoph Hellwig authored
This is a much more sensible check than just the admin queue. Signed-off-by:
Sagi Grimberg <sagi@rimbeg.me> Reviewed-by:
Hannes Reinecke <hare@suse.com> Reviewed-by:
-
Christoph Hellwig authored
Use the core chrdev code to set up the link between the character device and the nvme controller. This allows us to get rid of the global list of all controllers, and also ensures that we have both a reference to the controller and the transport module before the open method of the character device is called. Signed-off-by:
-
Christoph Hellwig authored
Instead of allocating a separate struct device for the character device handle embedd it into struct nvme_ctrl and use it for the main controller refcounting. This removes double refcounting and gets us an automatic reference for the character device operations. We keep ctrl->device as a pointer for now to avoid chaning printks all over, but in the future we could look into message printing helpers that take a controller structure similar to what other subsystems do. Note the delete_ctrl operation always already has a reference (either through sysfs due this change, or because every open file on the /dev/nvme-fabrics node has a refernece) when it is entered now, so we don't need to do the unless_zero variant there. Signed-off-by:
-
Christoph Hellwig authored
Now that we are protected against lookup vs free races for the namespace by using kref_get_unless_zero we don't need the hack of NULLing out the disk private data during removal. Signed-off-by:
-
Christoph Hellwig authored
For kref_get_unless_zero to protect against lookup vs free races we need to use it in all places where we aren't guaranteed to already hold a reference. There is no such guarantee in nvme_find_get_ns, so switch to kref_get_unless_zero in this function. Signed-off-by:
-
- 23 Oct, 2017 2 commits
-
-
Nitzan Carmi authored
Signed-off-by:
Nitzan Carmi <nitzanc@mellanox.com> Reviewed-by:
Max Gurtovoy <maxg@mellanox.com> Signed-off-by:
-
Max Gurtovoy authored
Signed-off-by:
-
- 20 Oct, 2017 5 commits
-
-
James Smart authored
The transport io timeout behavior wasn't quite correct. It ignored that the io error handler is supposed to be synchronous so it possibly allowed the blk request to be restarted while the io associated was still aborting. Timeouts on reserved commands, those used for association create, were never timing out thus they hung out forever. To correct: If an io is times out while a remoteport is not connected, just restart the io timer. The lack of connectivity will simultaneously be resetting the controller, so the reset path will abort and terminate the io. If an io is times out while it was marked for transport abort, just reset the io timer. The abort process is underway and will complete the io. Otherwise, if an io times out, abort the io. If the abort was unsuccessful (unlikely) give up and return not handled. If the abort was successful, as the abort process is underway it will terminate the io, so rather than synchronously waiting, just restart the io timer. Signed-off-by:
-
James Smart authored
The io completion handling for i/o's that are failing due to to a transport error or association termination had issues, causing io failures (DNR set so retries didn't kick in) or long stalls. Change the io completion handler for the following items: When an io has been completed due to a transport abort (based on an exchange error) or when marked as aborted as part of an association termination (FCOP_FLAGS_TERMIO), set the NVME completion status to NVME_SC_ABORTED. By default, do not set DNR on the status so that a retry can be attempted after association recreate. In cases where an io is failed (non-successful nvme status including aborted), if the controller is being deleted (blk_queue_dying) or the io was part of the ios used for association creation (ctrl state is NEW or RECONNECTING), then additionally set the DNR bit so the io will not be retried. If the failed io was part of association creation, the failure will tear down the partially completioned association and typically restart a new reconnect attempt (another create association later). Rearranged code flow to remove a largely unneeded local variable. Signed-off-by:
-
Chaitanya Kulkarni authored
This adds SGL support for NVMe PCIe driver, based on an earlier patch from Rajiv Shanmugam Madeswaran <smrajiv15 at gmail.com>. This patch refactors the original code and adds new module parameter sgl_threshold to determine whether to use SGL or PRP for IOs. The usage of SGLs is controlled by the sgl_threshold module parameter, which allows to conditionally use SGLs if average request segment size (avg_seg_size) is greater than sgl_threshold. In the original patch, the decision of using SGLs was dependent only on the IO size, with the new approach we consider not only IO size but also the number of physical segments present in the IO. We calculate avg_seg_size based on request payload bytes and number of physical segments present in the request. For e.g.:- 1. blk_rq_nr_phys_segments = 2 blk_rq_payload_bytes = 8k avg_seg_size = 4K use sgl if avg_seg_size >= sgl_threshold. 2. blk_rq_nr_phys_segments = 2 blk_rq_payload_bytes = 64k avg_seg_size = 32K use sgl if avg_seg_size >= sgl_threshold. 3. blk_rq_nr_phys_segments = 16 blk_rq_payload_bytes = 64k avg_seg_size = 4K use sgl if avg_seg_size >= sgl_threshold. Signed-off-by:
Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com> Reviewed-by:
Keith Busch <keith.busch@intel.com> Reviewed-by:
-
Christoph Hellwig authored
Switch to the ida_simple_* helpers instead of opencoding them. Signed-off-by:
-
Roy Shterman authored
In case we disable namespaces which has the nsid like subsystem max_nsid we need to search for the next largest nsid in this subsystem. If the subsystem don't has more namespaces we set it to 0, else we take nsid from the last namespace in namespaces list because the list is sorted while inserting. Reviewed-by:
Roy Shterman <roys@lightbitslabs.com> Reviewed-by:
-
- 19 Oct, 2017 4 commits
-
-
Israel Rukshin authored
This flag is useful for admin queues that aren't used for normal IO. Signed-off-by:
Israel Rukshin <israelr@mellanox.com> Reviewed-by:
-
Israel Rukshin authored
Since commit b86dd815 "block: get rid of blk-mq default scheduler choice Kconfig entries", when setting nr_hw_queues to 1 the admin tag set uses mq-deadline scheduler. This flag is useful for admin queues that aren't used for normal IO. Signed-off-by:
-
Israel Rukshin authored
Since commit b86dd815 "block: get rid of blk-mq default scheduler choice Kconfig entries", when setting nr_hw_queues to 1 the admin tag set uses mq-deadline scheduler. This flag is useful for admin queues that aren't used for normal IO. Signed-off-by:
-
Minwoo Im authored
fixed comment typos in adapter_alloc_cq() and adapter_alloc_sq(). 'the the' duplications are replaced with 'that the'. Signed-off-by:
Minwoo Im <dn3108@gmail.com> Signed-off-by:
-
- 18 Oct, 2017 11 commits
-
-
Sagi Grimberg authored
If the controller is deleting (in case the user decided to delete it), we have no point to continue reset sequence. Signed-off-by:
-
Sagi Grimberg authored
Instead of marking we are deleting, mark we are allocated and check that instead. This makes the logic symmetrical to connected mark check. Signed-off-by:
-
Sagi Grimberg authored
No chance for the local invalidate to succeed if the queue-pair is in error state. Most likely the target will do a remote invalidation of our mr so not a big loss on the test_bit. Signed-off-by:
-
Sagi Grimberg authored
Relying on the queue state while tearing down on every reconnect attempt is not a good design. We should do it once in err_work and simply try to establish the queues for each reconnect attempt. Signed-off-by:
-
Sagi Grimberg authored
Warn if req->mr is NULL as it should never happen. Reviewed-by:
-
Sagi Grimberg authored
No need for the extra line for trivial assignments. Signed-off-by:
-
Sagi Grimberg authored
Not necessarily address resolution failed. Signed-off-by:
-
Sagi Grimberg authored
Instead of flagging admin/io. Signed-off-by:
-
Sagi Grimberg authored
No callers left. Reviewed-by:
Jens Axboe <axboe@kernel.dk> Reviewed-by:
Bart Van Assche <bart.vanassche@wdc.com> Reviewed-by:
-
Sagi Grimberg authored
Move blk_mq_reinit_tagset from blk-mq to nvme core as the only user of it. Current transports that use it (rdma, fc) simply implement .reinit_request op. This patch does not change any functionality. Reviewed-by:
-
Sagi Grimberg authored
Iterator helper to apply a function on all the tags in a given tagset. export it as it will be used outside the block layer later on. Reviewed-by:
-
- 16 Oct, 2017 1 commit
-
-
Christoph Hellwig authored
We can just use our normal ioctl handler for the compat case and remove the boilerplate code for it. Signed-off-by:
-
- 05 Oct, 2017 1 commit
-
-
James Smart authored
move nvme_fc_rport_get/put and rport free to higher in the file to avoid adding prototypes to resolve references in upcoming code additions Signed-off-by:
-
- 04 Oct, 2017 1 commit
-
-
James Smart authored
Added a new fc class and a device node for udev events under it. I expect the fc class will eventually be the location where the FC SCSI and FC NVME merge in the future. Therefore names are kept somewhat generic. Signed-off-by:
-
