- 18 Jun, 2010 15 commits
-
-
Charles Clément authored
Remove custom macro for unsigned 8-bit integers. Signed-off-by:
Charles Clément <caratorn@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@suse.de>
-
Charles Clément authored
Remove custom macro for signed 8-bit integers. Signed-off-by:
-
Charles Clément authored
Signed-off-by:
-
Charles Clément authored
Calcu_LinkQual is already defined a couple lines earlier. Signed-off-by:
-
Charles Clément authored
Signed-off-by:
-
Charles Clément authored
Replace custom macro IS_ETH_ADDRESS_EQUAL by compare_ether_addr from <linux/etherdevice.h>. Signed-off-by:
-
Charles Clément authored
Replace custom macro IS_NULL_ADDRESS by is_zero_ether_addr from <linux/etherdevice.h>. Signed-off-by:
-
Charles Clément authored
Replace custom macro IS_BROADCAST_ADDRESS by is_broadcast_ether_addr from <linux/etherdevice.h>. Signed-off-by:
-
Charles Clément authored
Replace custom macro IS_MULTICAST_ADDRESS by is_multicast_ether_addr from <linux/etherdevice.h>. Remove linux/if_ether.h include as it is included in linux/etherdevice.h already. Signed-off-by:
-
Charles Clément authored
Replace custom minimum packet lenght definition MIN_PACKET_LEN by ETH_ZLEN from <linux/if_ether.h>. Signed-off-by:
-
Timofey Trofimov authored
This is a patch to the phy_calibration.c that fixes up almost all warnings and errors (except 80 characters limit and lack of tabs errors) found by the checkpatch.pl tool Signed-off-by:
Timofey Trofimov <tumoxep@gmail.com> Signed-off-by:
-
Adam Latham authored
This patch fixes line length, brace style and whitespace issues in the mac_structures.h file found by the checkpatch.pl tool Signed-off-by:
Adam Latham <adam.latham@unisontorbay.org.uk> Signed-off-by:
-
Adam Latham authored
This patch fixes the use of //C99 comments in the mac_structures.h found by the checkpatch.pl tool Signed-off-by:
Pekka Enberg <penberg@cs.helsinki.fi> Signed-off-by:
-
Tobias Klauser authored
The C99 specification states in section 6.11.5: The placement of a storage-class specifier other than at the beginning of the declaration specifiers in a declaration is an obsolescent feature. Signed-off-by:
Tobias Klauser <tklauser@distanz.ch> Cc: Haiyang Zhang <haiyangz@microsoft.com> Cc: Hank Janssen <hjanssen@microsoft.com> Signed-off-by:
-
Gustavo Silva authored
This is a patch to the pcl812.c file that fixes up the following issues: ERROR: code indent should use tabs where possible x 27 WARNING: line over 80 characters x 37 WARNING: please, no space before tabs x 13 WARNING: braces {} are not necessary for single statement blocks x 2 WARNING: printk() should include KERN_ facility level x 22 WARNING: braces {} are not necessary for any arm of this statement x 5 Signed-off-by:Gustavo Silva <silvagustavo@users.sourceforge.net> Acked-by:
Ian Abbott <abbotti@mev.co.uk> Signed-off-by:
-
- 17 Jun, 2010 25 commits
-
-
Lars Lindley authored
I fixed indentation in one place and two long lines, a space and a brace found by checkpatch.pl and fixed some long lines and whitespace around an =. Signed-off-by:
Lars Lindley <lindley@coyote.org> Signed-off-by:
Alan Cox <alan@linux.intel.com> Signed-off-by:
-
Ian Abbott authored
The dmm32at.c and comedi_bond.c comedi driver files contain an instructional comment block copied over from skel.c about how to format a driver comment block. This comment was modified in skel.c by a previous patch in this series to stop Comedi's 'dump_doc' script treating it as an actual driver comment block. There isn't any need to repeat this comment block in the other source files, so rather than modify it, this patch just removes it from those files. Signed-off-by:
-
Ian Abbott authored
The Comedi team have a script 'dump_doc' to extract text from the driver comment block (starting with line 'Driver:') in (most of) the comedi driver source files. This was recently updated to allow and strip off a " * " prefix at the start of each line (well actually, it uses the perl substitution 's/^ ?\* ?//'). The skel.c file contains an instructional comment block about how to format this driver comment block, but the updated 'dump_doc' script mistakenly treats this as a valid driver comment block. This patch adds some extra whitespace to stop the instructional comment block being treated as a valid driver comment block by Comedi's 'dump_doc' script. Signed-off-by:
-
Ian Abbott authored
Previous whitespace changes to das08.c removed some whitespace from a "driver comment block" that the Comedi team would like to keep. "Header continuation lines" in this comment block should be indented with whitespace. (This is after the " * " at the start of each line.) Signed-off-by:
-
Gustavo Silva authored
This is a patch to the quatech_daqp_cs.c file that fixes up the following issues: ERROR: code indent should use tabs where possible x 1 WARNING: line over 80 characters x 1 WARNING: braces {} are not necessary for single statement blocks x 10 WARNING: printk() should include KERN_ facility level x 6 Signed-off-by: -
Gustavo Silva authored
This is a patch to the pcmda12.c file that fixes up five printk() warning issues Signed-off-by:
-
Gustavo Silva authored
This is a patch to the pcl816.c file that fixes up the following issues: ERROR: code indent should use tabs where possible x 2 WARNING: line over 80 characters x 34 WARNING: please, no space before tabs x 1 WARNING: braces {} are not necessary for single statement blocks x 6 WARNING: printk() should include KERN_ facility level x 15 WARNING: braces {} are not necessary for any arm of this statement x 1 Signed-off-by: -
Gustavo Silva authored
This is a patch to the pcl711.c file that fixes up printk() warning issues. Signed-off-by:
-
Gustavo Silva authored
This is a patch to the me4000.c file that fixes up the following issues: ERROR: space required after that close brace '}' x 13 ERROR: spaces required around that ':' (ctx:VxV) x 3 WARNING: line over 80 characters x 96 WARNING: braces {} are not necessary for any arm of this statement x 2 Signed-off-by: -
Arun Thomas authored
Remove all remaining typedefs from comedi drivers Signed-off-by:
Arun Thomas <arun.thomas@gmail.com> Signed-off-by:
-
Arun Thomas authored
Move the PCI devinit/devexit routines to the respective C source files instead of calling COMEDI_PCI_INITCLEANUP Signed-off-by:
-
Arun Thomas authored
Move the init/exit routines to the respective C source files instead of calling COMEDI_INITCLEANUP Signed-off-by:
-
Arun Thomas authored
Add MODULE_AUTHOR, MODULE_LICENSE, and MODULE_DESCRIPTION calls to the respective C source files instead of calling COMEDI_MODULES_MACRO Signed-off-by:
-
Maurice Dawson authored
This is a patch to the ni_labpc.c file that fixes all, printk() should include KERN-facility level, warnings found by the checkpatch.pl tool Signed-off-by:
Maurice Dawson <mauricedawson2699@gmail.com> Signed-off-by:
-
Bob Beattie authored
This is a patch to the file am9513.h that fixes missing space warnings found by the checkpatch.pl tool. Signed-off-by:
Bob Beattie <bob.beattie@ntlworld.com> Signed-off-by:
-
John Sheehan authored
A patch for s626.c to fix some of the warnings reported by the checkpatch.pl tool, namely, printk() should include KERN_ facility level unnecessary whitespace before a quoted newline Signed-off-by:
John Sheehan <john.d.sheehan@gmail.com> Signed-off-by:
-
John Sheehan authored
A patch for unioxx5.c which fixes "trailing statements should be on next line" errors raised by the chechpatch.pl tool Signed-off-by:
-
Mark Rankilor authored
This patch fixes some long line lengths in gsc_hpdi.c as found by the checkpatch.pl tool Signed-off-by:
Mark Rankilor <reodge@gmail.com> Signed-off-by:
-
Mark Rankilor authored
This patch cleans up some various warnings generated from checkpatch.pl Signed-off-by:
-
Dan Carpenter authored
These checks are obviously pointless because kfree() can handle null dereferences. But really the main problem is that if the pointers were null that would cause problems on the ealier lines. The dereferences would cause an oops and the _release() functions use ->priv to determine which IRQ to free. I looked into it and quite a few of the detach functions assume link->priv is non-null. It seems like we can remove these checks. Signed-off-by:
Dan Carpenter <error27@gmail.com> Signed-off-by:
-
Ian Abbott authored
Signed-off-by:
-
Ian Abbott authored
Reduce stack usage in serial_2002_open() by allocating dig_in_config, dig_out_config, chan_in_config, and chan_out_config temporary arrays using kcalloc() and freeing them when done with. Signed-off-by:
-
Ian Abbott authored
The comedi device 'detach' method for the serial2002 driver has an off-by-one error in its loop for freeing data belonging to its subdevices. Fix it. Signed-off-by:
-
Ian Abbott authored
The comedi device 'open' method for the serial2002 driver frees any old 'maxdata_list' and 'range_table_list' arrays belonging to a subdevice and allocates them again, but was missing checks for allocation failure. If an allocation fails, free the 'maxdata_list' and 'range_table_list' arrays for all subdevices and return an error. Signed-off-by:
-
Ian Abbott authored
Some comedi drivers should return an error from their 'open' method when something goes wrong. Change the prototype of the 'open' method in 'struct comedi_device' to allow this, and change the drivers that use it. Propagate any error to the 'open' file operation. The corresponding 'close' method won't be called when the 'open' method fails, so drivers failing the 'open' need to clean up any mess they created. The dt9812 and serial2002 drivers can now return an error on 'open'. The jr3_pci driver also uses the 'open' method but doesn't fail it. Signed-off-by:
-
