- 21 Jul, 2018 17 commits
-
-
Todd Poynor authored
Add __user annotation to gasket_core top-level ioctl handling pointer arguments, for sparse checking. Reported-by:
Dmitry Torokhov <dtor@chromium.org> Signed-off-by:
Zhongze Hu <frankhu@chromium.org> Signed-off-by:
Todd Poynor <toddpoynor@google.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Todd Poynor authored
Always allow root to open device for writing. Drop special-casing of ioctl permissions for root vs. owner. Convert to bool types as appropriate. Reported-by:
-
Todd Poynor authored
Use consistent kernel-style multi-line comment syntax. Reported-by:
Guenter Roeck <groeck@chromium.org> Signed-off-by:
Simon Que <sque@chromium.org> Signed-off-by:
-
Todd Poynor authored
Remove unneeded parentheses around subexpressions. Reported-by:
-
Todd Poynor authored
gasket_mmap use PAGE_MASK, instead of performing math on PAGE_SIZE, for simplicity and clarity. Reported-by:
-
Todd Poynor authored
gasket_alloc_coherent_memory() extra parentheses in statement. Reported-by:
-
Todd Poynor authored
Use kernel-style multi-line comment syntax. Reported-by:
-
Todd Poynor authored
Else after return is unnecessary and may cause static code checkers to complain. Reported-by:
-
Todd Poynor authored
Convert from int to bool return type for gasket page table functions that return values used as booleans. Reported-by:
-
Todd Poynor authored
Collapse together two checks and return immediately, avoid conditional indentation for most of function code. Reported-by:
-
Todd Poynor authored
When offset to be mapped matches both a BAR region and a coherent mapped region return an error as intended, not the BAR index. Signed-off-by:
-
Todd Poynor authored
It is not an error for a device to not have a reset callback registered. Signed-off-by:
-
Todd Poynor authored
Remove extraneous statement in gasket_config_coherent_allocator() Reported-by:
-
Todd Poynor authored
class_create() never returns NULL, and this driver should never return PTR_ERR(NULL) anyway. Reported-by:
-
Todd Poynor authored
gasket_enable_dev code for enabling a gasket device with no physical PCI device registered shouldn't be necessary. Reported-by:
-
Todd Poynor authored
Remove unnecessary variable, pass constant param instead. Reported-by:
-
Todd Poynor authored
The gasket and apex drivers are also to be used on ARM64 architectures. Signed-off-by:
-
- 19 Jul, 2018 14 commits
-
-
Todd Poynor authored
Remove gasket_cdev_get_info(), use container_of() directly instead, drop unnecessary NULL checks. Reported-by:
-
Todd Poynor authored
If device reset callback returns an error, error out at the gasket level. Reported-by:
-
Todd Poynor authored
Don't need a 64-bit retry counter. Reported-by:
-
Todd Poynor authored
gasket_wait_with_reschedule() is a little more clear if we just return directly when the waited-for condition is hit. This also allows the following condition check to be removed and identation of the conditionally-executed code to be reduced. Reported-by:
-
Todd Poynor authored
Replace schedule_timeout() call with msleep() for simplicity. Reported-by:
-
Todd Poynor authored
Return -ETIMEDOUT, not -EINVAL, on timeout, including callers. Reported-by:
-
Todd Poynor authored
gasket_mmap_has_permissions() should return a boolean value. Signed-off-by:
-
Todd Poynor authored
If gasket_sysfs_create_mapping() hits errors allocating the attribute array, remove stale pointers to device info from the mapping object. Signed-off-by:
-
Todd Poynor authored
gasket_sysfs_create_mapping() return EBUSY if sysfs mapping already in use, as a more appropriate error code than the current return of EINVAL, which would indicate invalid parameters. Signed-off-by:
-
Todd Poynor authored
Take the global mutex on driver unregistration updates for proper ordering of updates and consistent access procedures. Signed-off-by:
-
Todd Poynor authored
If class_create() fails, remove the gasket driver from the global registration table. Signed-off-by:
-
Todd Poynor authored
Tab replaced with space. Signed-off-by:
-
Todd Poynor authored
Grammar fixup in gasket_core.h comments describing struct gasket_interrupt_desc. Signed-off-by:
-
Todd Poynor authored
Fix typo in log message. Signed-off-by:
-
- 16 Jul, 2018 9 commits
-
-
Tobias Lindskog authored
When ashmem_shrink is called from direct reclaim on a user thread, a call to do_fallocate will check for permissions against the security policy of that user thread. It can thus fail by chance if called on a thread that isn't permitted to modify the relevant ashmem areas. Because we know that we have a shmem file underneath, call the shmem implementation of fallocate directly instead of going through the user-space interface for fallocate. Signed-off-by:
Tobias Lindskog <tobias.lindskog@sonymobile.com> Signed-off-by:
Jeff Vander Stoep <jeffv@google.com> Signed-off-by:
Joel Fernandes (Google) <joel@joelfernandes.org> Signed-off-by:
-
Matthias Wolf authored
Fix checkpatch warning: avoid unnecessary line continuation to allow grepping of whole error message. Signed-off-by:
Matthias Wolf <der_wolf_@web.de> Signed-off-by:
Felix Siegel <felix.siegel@stud.uni-hannover.de> Signed-off-by:
Tim Cofala <cofala@stud.uni-hannover.de> Signed-off-by:
-
Matthias Wolf authored
Fix checkpatch line over 80 characters where it seemed appropriate Signed-off-by:
-
Nishad Kamdar authored
Shift '=' assignment operator to the end of previous line to conform to preferred kernel style line wrapping. Issue reported by checkpatch CHECK. Signed-off-by:
Nishad Kamdar <nishadkamdar@gmail.com> Reviewed-by:
Ian Abbott <abbotti@mev.co.uk> Signed-off-by:
-
Michael Straube authored
Both functions declared in rtl8188e_led.h are also declared in rtw_led.h which is included from drv_types.h. Remove rtl8188e_led.h and it's includes. Signed-off-by:
Michael Straube <straube.linux@gmail.com> Signed-off-by:
-
Michael Straube authored
Add spaces around '+' to follow kernel coding style. Signed-off-by:
-
Michael Straube authored
Rename variable to avoid CamelCase. tmpV16 -> tmpv16 Signed-off-by:
-
Michael Straube authored
Rename function parameters to avoid CamelCase. bWrite -> write PwrState -> pwrstate Signed-off-by:
-
Michael Straube authored
Rename function to avoid CamelCase. Efuse_PowerSwitch -> efuse_power_switch Signed-off-by:
-
