On 2003.03.11 14:13 Christoph Hellwig wrote:
> 
> --- 1.39/drivers/scsi/osst.c	Sun Feb  2 17:50:23 2003
> +++ edited/drivers/scsi/osst.c	Mon Mar 10 14:35:46 2003
> @@ -777,7 +777,7 @@
>  #define OSST_POLL_PER_SEC 10
>  static int osst_wait_frame(OS_Scsi_Tape * STp, Scsi_Request ** aSRpnt, int curr, int minlast, int to)
>  {
> -	long	startwait     = jiffies;
> +	unsigned long startwait = jiffies;
>  	char  * name          = tape_name(STp);
>  #if DEBUG
>  	char	notyetprinted = 1;
> @@ -1288,7 +1288,7 @@
>  	int             logical_blk_num  = ntohl(STp->buffer->aux->logical_blk_num) 
>  						- (nframes + pending - 1) * blks_per_frame;
>  	char          * name             = tape_name(STp);
> -	long		startwait        = jiffies;
> +	unsigned long	startwait        = jiffies;
>  #if DEBUG
>  	int		dbg              = debugging;
>  #endif
> @@ -1477,7 +1477,7 @@
>  	int		expected  = 0;
>  	int		attempts  = 1000 / skip;
>  	int		flag      = 1;
> -	long		startwait = jiffies;
> +	unsigned long	startwait = jiffies;
>  #if DEBUG
>  	int		dbg       = debugging;
>  #endif
> -

There are five functions that use jiffies. You fixed three of them.
If this change is done (and that's fine with me) it should be done
with this patch:

The following patch gets rid of softscsi_data struct and
array for the more manageable
static struct list_head done_q[NR_CPUS] __cacheline_aligned;

Thus, scsi_cmnd::bh_next is eliminated, since it was used only
in the scsi softirq processing code.

The comments are updated.

80 chars per line for the affected functions: scsi_done()
and scsi_softirq().

Eliminated is the double loop in scsi_softirq() -- this is
better handled in do_softirq() and gives the system a ``breather''.
(There are pros and cons for either side and if you guys
think that it was better with the double loop, I'll change it and
resubmit the patch.)

If the sdev allocation fails and q is non-null we could dereference
sdev->request_queue.  While at it reformat the function to use
goto-based cleanup - that's much easier to parse.

Compile warnings are useful...

set. A few versions of gcc-2.96 generate seriously incorrect code.

This patch creates a new include directory include/media, populates
it with a few files header files and fixups the affected drivers to
compile with the new directory layout.

The directory is intented to be used for (kernel-internal) header files
of the media drivers (which are sitting below drivers/media).  For now
the video-buf.h (mm helper), tuner.h (tv/radio tuner) and audiochip.h
(tv sound decoder drivers) header files are moved.  Some more header
files from the dvb folks will likely follow.

This patch deletes the MIN/MAX macros from audiochip.h
and fixes all users of these macros to use the kernels
min/max macros instead.

Patch from Neil Brown <neilb@cse.unsw.edu.au>

Allow auto-unplugging to work for devices that do it themselves.

Auto-unplugging - and blk_unplug_work in particular - assumes that the device
uses "generic_unplug_device" for unplugging, but some devices don't.  md
crashes.

So blk_unplug_work should use ->unplug_fn

This patch fixes spelling errors in the Documentation directory and was
extensively reviewed by the following people: Dan Kegel, David
Woodhouse, Joe Perches, Jared Daniel J.  Smith, Michael Hayes, and
Steven Cole

into home.transmeta.com:/home/torvalds/v2.5/linux

into home.transmeta.com:/home/torvalds/v2.5/linux

into kernel.bkbits.net:/home/davem/net-2.5

into nuts.ninka.net:/home/davem/src/BK/net-2.5

into home.transmeta.com:/home/torvalds/v2.5/linux

From Ben Collins

Used as manual trigger for device/driver binding, so drivers can claim 
devices that are present but failed to be bound. In case of ieee1394, this
can happen if two computers are attached to a device - the second one won't
be able to claim it until the first detaches. 

Changed device_attach() to return 1 when a driver was bound to a device. 
Makes it so bus_rescan_devices() can return the number of devices attached.
Tested this with ieee1394 over a bus reset and it worked as expected.

- Don't d_delete() files when removing a directory - they must still be 
  hashed when dput() reaps them, and it will __d_drop() them anyway.

- Don't d_invalidate() the directory on removal. 

- do simple_rmdir() after d_delete() on directory. 

- Remove extra dput(), which was causing refcount to go negative, causing 
  an oops when someone tried to create the directory again.

- Make sure we don't d_delete() or do extra dput() on file when updating, 
  either.

into shaggy.austin.ibm.com:/shaggy/bk/jfs-2.5

The old adap_lock and driver_lock could deadlock and there was a bunch
of stuff that was horribly racy.  The new locking scheme is from
lm_sensors CVS but I had to fix quite a few bugs to make this work.

This one is from lm_sensors CVS and mostly cosmetic changes.  I it up a
bit to compile properly under latest 2.5.

another bunch of IDs appeared in lm_sensors CVS lately..

This somehow got lost in the uClinux merge.

It's the _device_ filesystem, so regular files are grossly misplaced
here.  Fortauntely only one driver actually tries to use it (microcode)
and it's works fine with  a regular miscdevice as well.

Sorry, the devs_only() patch accidentally included the devfs-portion
of the DEVFS_FL_AUTO_DEVNUM patch.  This patch contains the remaining
parts.

The new slab poisoning code broke kmem_cache_size(), it now returns
a too large size as the poisoning area after the object is includes.
XFS's kmem_zone_zalloc thus overwrites exactly that area and triggers
the new checks everytime such an object is freed again.

I don't recommend using XFS on BK-current without this patch applied :)

This patches fixes the m68knommu 68360 serial driver to use the
work_struct, not the obsoleted workqueue.

This patch moves common ColdFire vector and timer procesing code from
the local per-processor config.c for the 5206 ColdFire sub-architecture.
All ColdFire CPU's have the same timer and basic vector setup, seems
crazy to repeat this code for each of 6 ColdFire CPU varients.

This patch moves common ColdFire vector and timer procesing code from
the local per-processor config.c for the 5206e ColdFire sub-architecture.
All ColdFire CPU's have the same timer and basic vector setup, seems
crazy to repeat this code for each of 6 ColdFire CPU varients.
This patch also removes the reset button support, this is now moved to
a proper device driver, where it belongs.

This patch moves common ColdFire vector and timer procesing code from
the local per-processor config.c for the 5249 ColdFire sub-architecture.
All ColdFire CPU's have the same timer and basic vector setup, seems
crazy to repeat this code for each of 6 ColdFire CPU varients.

This patch creates common timer setup and handling code for the m68knommu
ColdFire CPU sub-architecture. All 6 ColdFire CPU varients contain the
same hardware timers. Currently each sub-arch has its own timer code.
This reduces a lot of code duplication.

This patch puts the new common ColdFire timers.c and vectors.c into
the build list (in the m68knommu architecture branch).

This patches fixes the m68knommu 68328 serial driver header to use the
work_struct, not the obsoleted workqueue.

This patch moves common ColdFire vector and timer procesing code from
the local per-processor config.c for the 5407 ColdFire sub-architecture.
All ColdFire CPU's have the same timer and basic vector setup, seems
crazy to repeat this code for each of 6 ColdFire CPU varients.

This patch fixes up the PCI bios header for the m68knommu COMEM-lite
PCI hardware support. Adds missing definitions, and a couple of trivial
inline functions here.