- 06 Mar, 2017 40 commits
-
-
Varsha Rao authored
Remove blank line after open braces, to fix the following checkpatch issue: CHECK: Blank lines aren't necessary after an open brace '{' Signed-off-by:Varsha Rao <rvarsha016@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Olav Haugan authored
Fix checkpatch warning about line being over 80 characters. Signed-off-by:
Olav Haugan <ohaugan@codeaurora.org> Signed-off-by:
-
Olav Haugan authored
Fix checkpatch check notices by simplifying comparisons to NULL. Signed-off-by:
-
sayli karnik authored
Change array index from the loop bound variable to loop index. If a poll file fails to open for any intermediate device, all poll files with fds of devices from 0 upto that device must be closed in the open_poll_files() function. The current code only closes the poll file with the most recent fd allocated, and at times tries to close the same file multiple times. Detected by coccinelle: @@ expression arr,ex1,ex2; @@ for(ex1 = 0; ex1 < ex2; ex1++) { <... arr[ - ex2 + ex1 ] ...> } Signed-off-by:sayli karnik <karniksayli1995@gmail.com> Reviewed-by:
Johan Hovold <johan@kernel.org> Signed-off-by:
-
Gargi Sharma authored
All the device names were being always leaked. Also, illegal free was being called upon namelist[n] which was coincidentally NULL. The pointer to dirent structures must be individually freed before freeing the pointer array. Coccinelle Script: @@ expression arr,ex1,ex2; @@ for(ex1 = 0; ex1 < ex2; ex1++) { <... arr[ - ex2 + ex1 ] ...> } Signed-off-by:Gargi Sharma <gs051095@gmail.com> Reviewed by: Johan Hovold <johan@kernel.org> Acked-by:
Julia Lawall <julia.lawall@lip6.fr> Signed-off-by:
-
Varsha Rao authored
Moved logical OR operator to previous line to fix the following checkpatch issue: CHECK: Logical continuations should be on the previous line. Signed-off-by:
-
Varsha Rao authored
Removed unnecessary parentheses around pointers to fix the following checkpatch issues: CHECK: Unnecessary parentheses around padapter->xmitpriv CHECK: Unnecessary parentheses around padapter->recvpriv Signed-off-by:
-
Varsha Rao authored
Matched function arguments alignment with its open parenthesis. This patch fixes the following checkpatch issue: CHECK: Alignment should match open parenthesis Signed-off-by:
-
Gargi Sharma authored
Replace explicit NULL comparison with ! operator to simplify code. Found with Coccinelle script: @@ expression ptr; position p; statement s0, s1; @@ ptr@p = \(kmalloc\|devm_kzalloc\|kmalloc_array\|devm_ioremap\|usb_alloc_urb\| alloc_netdev\|dev_alloc_skb\)(...) ... when != ptr if ( ( + ! ptr - == NULL ) ) s0 else s1 Signed-off-by:
-
Gargi Sharma authored
Replace explicit NULL comparison with ! operator to simplify code. Found with Coccinelle script: @@ expression ptr; position p; statement s0, s1; @@ ptr@p = \(kmalloc\|devm_kzalloc\|kmalloc_array\|devm_ioremap\|usb_alloc_urb\| alloc_netdev\|dev_alloc_skb\)(...) ... when != ptr if ( ( + ! ptr - == NULL ) ) s0 else s1 Signed-off-by:
-
Gargi Sharma authored
Replace explicit NULL comparison with ! operator to simplify code. Found with Coccinelle script: @@ expression ptr; position p; statement s0; @@ ptr@p = \(kmalloc\|devm_kzalloc\|kmalloc_array\|devm_ioremap\|usb_alloc_urb\| alloc_netdev\|dev_alloc_skb\)(...) ... when != ptr if ( ( + ! ptr - == NULL ) ) s0 Signed-off-by:
-
Gargi Sharma authored
Parentheses are not needed on the right side of assignment. Additionally added space around '+'and '*' to remove checkpatch issue, space required around '+' and '*'. Parentheses Removed using the coccinelle script: @@ binary operator bop = {+,-,>>,<<}; expression e, e1, e2; @@ e = -( e1 bop e2 -) Signed-off-by: -
Yamanappagouda Patil authored
Fixed checkpatch.pl "missing a blank line after declarations" waring messages from rtl8188eu module. Signed-off-by:
Yamanappagouda Patil <goudapatilk@gmail.com> Signed-off-by:
-
Sebastian Haas authored
Fixes the endianness warning "restricted __le16 degrades to integer" by converting __le16 to short before using it in bitmasks or in the macro WLAN_FC_GET_STYPE. Signed-off-by:
Sebastian Haas <sehaas@deebas.com> Signed-off-by:
-
maomao xu authored
drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c:564:37: warning: incorrect type in assignment (different base types) drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c:564:37: expected unsigned short [unsigned] [usertype] len drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c:564:37: got restricted __be16 [usertype] <noident> Signed-off-by:
maomao xu <albert008.xu@gmail.com> Signed-off-by:
-
sayli karnik authored
Using typedef for a structure type is not suggested in Linux kernel coding style guidelines. So remove typedef from structure tx_pending_t. The typedef name is not used anywhere. All variables of this type are declared using "struct tx_pending_t". Also change the structure name to tx_pending since it is normally only typedefs that have names that end in _t. Signed-off-by:
-
Gargi Sharma authored
Add a blank line after function declaration to fix the checkpatch issue Please use a blank line after function/struct/union/enum declarations. Signed-off-by:
-
Gargi Sharma authored
Remove blank lines to fix the checkpatch issue, don't use multiple blank lines. Signed-off-by:
-
Gargi Sharma authored
Remove unnecessary blank lines to fix the checkpatch issue, blank lines are not required before '}'. Signed-off-by:
-
Gargi Sharma authored
Constants should be on the right side of comparisons. Issue found by checkpatch.pl script. Signed-off-by:
-
Gargi Sharma authored
Align * on each line and move final */ to a new line, to conform to the kernel coding style for block comments. Signed-off-by:
-
Gargi Sharma authored
Replace x==NULL by !x, to fix the checkpatch issue comparsion with NULL could be written as !x. Signed-off-by:
-
simran singhal authored
Replace a mix of tabs and spaces indentation by tabs only. Fixed checkpatch warning "Statements should start on a tabstop" in rtl8192u module. Signed-off-by:
simran singhal <singhalsimran0@gmail.com> Acked-by:
-
simran singhal authored
Octal permissions should be used instead of symbolic ones for easier reading. WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. This warning is detected by checkpatch.pl Signed-off-by:
-
Ivan Safonov authored
MCS_rate_2R[] does not used. Remove it. Signed-off-by:
Ivan Safonov <insafonov@gmail.com> Signed-off-by:
-
Ivan Safonov authored
rtw_hal_get_hwreg() does not used with HW_VAR_RF_TYPE parameter. Remove HW_VAR_RF_TYPE switch case in rtw_hal_get_hwreg and definition. Signed-off-by:
-
Ivan Safonov authored
rtw_hal_get_hwreg(..., HW_VAR_RF_TYPE,...) always return RF_1T1R value. Replace the function call with RF_1T1R value and refactor HT_caps_handler(). Signed-off-by:
-
Ivan Safonov authored
rtw_hal_get_hwreg(..., HW_VAR_RF_TYPE,...) always return RF_1T1R value. Replace the function call with RF_1T1R value and refactor rtw_update_ht_cap(). Signed-off-by:
-
Ivan Safonov authored
rtw_hal_get_hwreg(..., HW_VAR_RF_TYPE,...) always return RF_1T1R value. Replace the function call with RF_1T1R value and refactor issue_assocreq(). Signed-off-by:
-
Ivan Safonov authored
rtw_hal_get_hwreg(..., HW_VAR_RF_TYPE,...) always return RF_1T1R value. Replace the function call with RF_1T1R value and refactor rtw_get_cur_max_rate(). Signed-off-by:
-
Ivan Safonov authored
rtw_hal_get_hwreg(..., HW_VAR_RF_TYPE,...) always return RF_1T1R value. Replace the function call with RF_1T1R value and refactor rtw_check_beacon_data(). Signed-off-by:
-
Ivan Safonov authored
rtw_hal_get_hwreg(..., HW_VAR_RF_TYPE,...) always return RF_1T1R value. Replace the function call with RF_1T1R value and refactor add_RATid(). Signed-off-by:
-
Ivan Safonov authored
DIV_ROUND_UP macro is shorter and look better than if-else construction. DIV_ROUND_UP used in rtw_signal_stat_timer_hdl(). Signed-off-by:
-
Katie Dunne authored
Remove spaces after casts found by checkpatch.pl. In some cases, remove returns after casts and place them on a single line. Signed-off-by:
Katie Dunne <kdunne@mail.ccsf.edu> Signed-off-by:
-
Shiva Kerdel authored
Braces should be used on all arms of these statements (CHECK).. Signed-off-by:
Shiva Kerdel <shiva@exdev.nl> Signed-off-by:
-
Shiva Kerdel authored
Changed bit swifting operators to BIT macros (preferred), This change will also solve the preferred space surrounding the operator checks. Signed-off-by:
-
Kenneth Hsu authored
This fixes a coding style issue where whitespace characters were missing around some binary OR operators. Signed-off-by:
Kenneth Hsu <kennethhsu@gmail.com> Signed-off-by:
-
simran singhal authored
The macro DIV_ROUND_UP performs the computation (((n) + (d) - 1) /(d)). It clarifies the divisor calculations. This occurence was detected using the coccinelle script: @@ expression e1; expression e2; @@ ( - ((e1) + e2 - 1) / (e2) + DIV_ROUND_UP(e1,e2) | - ((e1) + (e2 - 1)) / (e2) + DIV_ROUND_UP(e1,e2) ) Signed-off-by:
-
James Simmons authored
When compiling the kernel without optimization, when using GCOV, the lprocfs_stats_alloc_one() symbol is not properly exported to other modules and causes the ptlrpc module to fail loading with an unknown symbol. There is no reason to export the function lprocfs_stats_alloc_one. The reason is due to the functions lprocfs_stats_[un]lock being inline functions in a header file. Lets untangle this mess and turn those inline functions into real functions in a source file. Signed-off-by:
James Simmons <uja.ornl@yahoo.com> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8836 Reviewed-on: https://review.whamcloud.com/23773Reviewed-by:
Andreas Dilger <andreas.dilger@intel.com> Reviewed-by:
Dmitry Eremin <dmitry.eremin@intel.com> Reviewed-by:
John L. Hammond <john.hammond@intel.com> Signed-off-by:
James Simmons <jsimmons@infradead.org> Signed-off-by:
-
Niu Yawei authored
There is race in the code of starting bl threads which leads to thread number exceeds the maximum number when race happened, it can also lead to duplicated thread name. This patch fixes the race and cleanup the code a bit. Signed-off-by:
Niu Yawei <yawei.niu@intel.com> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-7330 Reviewed-on: http://review.whamcloud.com/17026Reviewed-by:
Bobi Jam <bobijam@hotmail.com> Reviewed-by:
-
