Commits · 81dee67e215b23f0c98182eece122b906d35765a · nexedi / linux

07 Mar, 2015 38 commits

staging: sm750fb: add sm750 to staging · 81dee67e

Sudip Mukherjee authored Mar 03, 2015

sm750 of Silicon Motion is pci-e display controller device and has
features like dual display and 2D acceleration. This patch adds the
driver to staging.
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

81dee67e

staging: sm7xxfb: make vgamode static · c3d6047d

Sudip Mukherjee authored Feb 10, 2015

the variable vgamode is used only in this file and hence can be
safely made as static.
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

c3d6047d

staging: i2o: Remove use of seq_printf return value · 6a3386b1

Joe Perches authored Feb 21, 2015

The seq_printf return value, because it's frequently misused,
will eventually be converted to void.

See: commit 1f33c41c ("seq_file: Rename seq_overflow() to
     seq_has_overflowed() and make public")
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

6a3386b1

staging: rtl8188eu: Fix trivial typos in comments · 8895f04b

Yannick Guerrini authored Feb 26, 2015

Change 'disabed' and 'disabel' to 'disabled'
Change 'inviation' to 'invitation'
Change 'negoitation' to 'negotiation'
Signed-off-by: Yannick Guerrini <yguerrini@tomshardware.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

8895f04b

staging: panel: initialize lcd if lcd enabled · 733345ec

Sudip Mukherjee authored Feb 11, 2015

initialiaze lcd parameters only if lcd is enabled.
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Acked-by: Willy Tarreau <w@1wt.eu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

733345ec

staging: panel: register driver after checking device · f43de77c

Sudip Mukherjee authored Feb 10, 2015

register the driver only if lcd or keypad has been enabled and if
both are disabled then just exit.
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Acked-by: Willy Tarreau <w@1wt.eu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

f43de77c

Staging: vt6655: fix C99 comments · 9ab81fb7

Matteo Semenzato authored Feb 28, 2015

This patch fixes the following warning:
do not use C99 // comments
Signed-off-by: Matteo Semenzato <mattew8898@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

9ab81fb7

staging: vt6655: Cleanup C99 comments · bb72dd53

Alex W Slater authored Feb 26, 2015

Fix checkpatch.pl errors:

"ERROR: do not use C99 // comments"
Signed-off-by: Alex W Slater <alex.slater.dev@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

bb72dd53

Staging: vt6655 fix C99 style comments · 7e59b047

Matt authored Feb 21, 2015

Signed-off-by: Matteo Semenzato <mattew8898@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

7e59b047

staging: vt6655: fix coding style issues in channel.c · 636cd168

Ivan Stankovic authored Feb 12, 2015

Observe the line length limit to make checkpatch.pl happy.
Signed-off-by: Ivan Stankovic <pokemon@fly.srk.fer.hr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

636cd168

staging: vt6656: Fix possible leak in vnt_download_firmware() · d34add05

Christian Engelmayer authored Feb 11, 2015

When failing to allocate buffer memory, function vnt_download_firmware() goes
through the wrong exit path and fails to release the already requested
firmware. Thus use the correct cleanup. Detected by Coverity CID 1269128.
Signed-off-by: Christian Engelmayer <cengelma@gmx.at>
Reviewed-by: Martin Kepplinger <martink@posteo.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

d34add05

staging: ozwpan: Move code from success handling to error handling · 6498613d

Quentin Lambert authored Feb 10, 2015

The original version was success handling rather than error handling,
therefore this patch reduces nesting.
Signed-off-by: Quentin Lambert <lambert.quentin@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

6498613d

staging: ozwpan: Remove allocation from delaration line · e03b7297

Quentin Lambert authored Feb 10, 2015

This patch removes allocation from declaration line because
people are known to gloss over declarations.
Signed-off-by: Quentin Lambert <lambert.quentin@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

e03b7297

Staging: dgnc: Fix checking return value of register_chrdev · 5f9dca1e

Salah Triki authored Mar 05, 2015

The failure code is negative. So check <0 instead of <=0.
Return the failure code instead of -ENXIO.
Signed-off-by: Salah Triki <salah.triki@acm.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

5f9dca1e

staging: dgnc: fix braces {} are not necessary for single statement blocks · 834d8673

Salah Triki authored Mar 01, 2015

This patch fixes the following checkpatch.pl warning:
braces {} are not necessary for single statement blocks
Signed-off-by: Salah Triki <salah.triki@acm.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

834d8673

staging:lustre:libcfs: Merge linux-proc.c into module.c · 87643abf

Matthew Tyler authored Mar 06, 2015

module.c was previously the sole exporter of symbols from linux-proc.c
This patch removes the global symbols by merging the two files
Signed-off-by: Matthew Tyler <matt.tyler@flashics.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

87643abf

staging: lustre: space prohibited between function name and open parenthesis '(' · 804db5d0

Alberto Pires de Oliveira Neto authored Mar 02, 2015

This patch fixes checkpatch.pl warning.
WARNING: space prohibited between function name and open parenthesis '('
Signed-off-by: Alberto Pires de Oliveira Neto <mrpenguin2005@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

804db5d0

staging/lustre/libcfs: replace deprecated cpus_ calls with cpumask_ · c96d236f

Oleg Drokin authored Mar 02, 2015

Rusty Russel advises that cpus_* functions are deprecated to work
on cpumasks and cpumask_* functions should be called instead,
otherwise problems with CPUMASK_OFFSTACK arise.
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

c96d236f

staging/lustre/ptlrpc: Do not use deprecated cpus_* functions · 6301647b

Oleg Drokin authored Mar 02, 2015

As per Rusty Russel, cpus_* functions are deprecated.
When mixing cpumask_copy with cpus_weight, they operate on different
sized masks if CPUMASK_OFFSTACK is enabled, causing an
immediate assertion failure.
Copying of cpumasks by assignment is also not allowed now.

Additionally, in ptlrpc/service.c avoid the cpumask copies,
since we only use it to check how many siblings are there for
core #0 and nothing else.
Reported-by: Tyson Whitehead <twhitehead@gmail.com>
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

6301647b

staging: comedi: drivers/*.c: add missing braces {} to if/else branches · 6ac986d0

H Hartley Sweeten authored Mar 05, 2015

According to the CodingStyle, braces should  be used on all branches
if thet are used on any branch,
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

6ac986d0

staging: comedi: drivers/*.c: remove unnecessary blank lines · c8f4b98f

H Hartley Sweeten authored Mar 05, 2015

Blank lines are not needed before a close brace '}' or after an
open brace '{'. Also remove any multiple blank lines.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

c8f4b98f

staging: comedi: drivers/*.c: alignment should match open parenthesis · 6c7d2c8b

H Hartley Sweeten authored Mar 05, 2015

Fix the alignment issues in all the comedi drivers.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

6c7d2c8b

staging: comedi: drivers/*.c: fix common misspellings · 9949595c

H Hartley Sweeten authored Mar 05, 2015

Fix these common misspellings:
  s/dependancy/dependency
  s/occured/occurred
  s/informations/information
  s/intialize/initialize
  s/serveral/several
  s/interrups/interrupts
  s/acknowledgement/acknowledgment
  s/suppport/support
  s/writting/writing
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

9949595c

staging: comedi: s626: remove unnecessary 'cmd' pointer checks · 857ced45

H Hartley Sweeten authored Mar 04, 2015

The local variable 'cmd' is a pointer to the address of a member variable
of a struct. It will always be valid. Remove the unnecessary checks.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

857ced45

staging: comedi: kcomedilib_main: (!foo) preferred over (foo == NULL) · 4c36fdde

H Hartley Sweeten authored Mar 04, 2015

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

4c36fdde

staging: comedi: ni_mio_common: (!foo) preferred over (foo == NULL) · c6be1548

H Hartley Sweeten authored Mar 04, 2015

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

c6be1548

staging: comedi: ni_tiocmd: (!foo) preferred over (foo == NULL) · 56e97078

H Hartley Sweeten authored Mar 04, 2015

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

56e97078

staging: comedi: ni_pcimio: (!foo) preferred over (foo == NULL) · 9bacea57

H Hartley Sweeten authored Mar 04, 2015

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

9bacea57

staging: comedi: ni_pcidio: (!foo) preferred over (foo == NULL) · 4ce82def

H Hartley Sweeten authored Mar 04, 2015

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

4ce82def

staging: comedi: ni_labpc_common: (!foo) preferred over (foo == NULL) · c1bce7fd

H Hartley Sweeten authored Mar 04, 2015

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

c1bce7fd

staging: comedi: ni_atmio: (!foo) preferred over (foo == NULL) · 77ba71f6

H Hartley Sweeten authored Mar 04, 2015

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

77ba71f6

staging: comedi: ni_660x: (!foo) preferred over (foo == NULL) · 307da4b2

H Hartley Sweeten authored Mar 04, 2015

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

307da4b2

staging: comedi: mite: (!foo) preferred over (foo == NULL) · 5effdf70

H Hartley Sweeten authored Mar 04, 2015

Also, clarify the 'ring' allocation failure by returning NULL instead
of 'ring' (which would be NULL).
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

5effdf70

staging: comedi: cb_pcidas64: (!foo) preferred over (foo == NULL) · 854472c2

H Hartley Sweeten authored Mar 04, 2015

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

854472c2

staging: comedi: amplc_pci230: (!foo) preferred over (foo == NULL) · 4d719cec

H Hartley Sweeten authored Mar 04, 2015

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

4d719cec

staging: comedi: amplc_pci224: (!foo) preferred over (foo == NULL) · 0048b992

H Hartley Sweeten authored Mar 04, 2015

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

0048b992

staging: comedi: drivers: (!foo) preferred over (foo == NULL) · e2850160

H Hartley Sweeten authored Mar 04, 2015

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

e2850160

staging: comedi: comedi_fops: (!foo) preferred over (foo == NULL) · 88cc30cf

H Hartley Sweeten authored Mar 04, 2015

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

88cc30cf

06 Mar, 2015 2 commits

Staging: ste_rmi4: clean dev_err logging · 62af7214

Haneen Mohammed authored Mar 06, 2015

This patch removes  __func__ from dev_err. dev_err includes information about:
(devcice, driver, specific instance of device, etc) in the log printout.
This was done using Coccinelle, with the following semantic patch:

@A@
expression E, R;
expression  msg;
@@

dev_err(E, msg, __func__, R);

@script:python b@
e << a.msg;
y;
@@

if(e.find("%s: ") == True):
	m = e.replace("%s: ", "", 1);
	coccinelle.y = m;
elif(e.find("%s ") == True):
	m = e.replace("%s ", "", 1);
	coccinelle.y = m;
elif(e.find("%s:") == True):
	m = e.replace("%s:", "", 1);
	coccinelle.y = m;
else:
	m = e.replace("%s", "",1);
	coccinelle.y = m;

@c@
expression a.E, a.msg, a.R;
identifier  b.y;
@@

- dev_err(E, msg, __func__, R);
+ dev_err(E, y, R);
Signed-off-by: Haneen Mohammed <hamohammed.sa@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

62af7214

Staging: slicoss: clean dev_err logging · eb856202

Haneen Mohammed authored Mar 06, 2015

This patch removes  __func__ from dev_err. dev_err includes information about:
(devcice, driver, specific instance of device, etc) in the log printout.
This was done using Coccinelle, with the following semantic patch:

@A@
expression E, R;
expression  msg;
@@

dev_err(E, msg, __func__, R);

@script:python b@
e << a.msg;
y;
@@

if(e.find("%s: ") == True):
	m = e.replace("%s: ", "", 1);
	coccinelle.y = m;
elif(e.find("%s ") == True):
	m = e.replace("%s ", "", 1);
	coccinelle.y = m;
elif(e.find("%s:") == True):
	m = e.replace("%s:", "", 1);
	coccinelle.y = m;
else:
	m = e.replace("%s", "",1);
	coccinelle.y = m;

@c@
expression a.E, a.msg, a.R;
identifier  b.y;
@@

- dev_err(E, msg, __func__, R);
+ dev_err(E, y, R);
Signed-off-by: Haneen Mohammed <hamohammed.sa@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

eb856202