- 26 Feb, 2010 40 commits
-
-
Andy Walls authored
The cx18_open_id is normally dynamically allocated and stored in the filp->private_data for v4l2 file operations. The cx18-alsa routines should not dynamically allocate a cx18_open_id because they never store it anywhere and never free it. This change fixes that and plugs a memory leak. Signed-off-by:
Andy Walls <awalls@radix.net> Signed-off-by:
Mauro Carvalho Chehab <mchehab@redhat.com>
-
Andy Walls authored
File operations that manipulate the state of the encoder, or video or audio subdevices or some of the stream flags need to be serialized. Add the serilization locks to cx18-alsa in a manner consistent with the locking for the v4l2 file operations. Signed-off-by:
-
Andy Walls authored
Rename snd_cx18_mixer_lock() to snd_cx18_lock() in anticpation of using it in the cx18-alsa-pcm.c file routines. Signed-off-by:
-
Kusanagi Kouichi authored
If CX25840_VIN1_CH1 and the like is used, input is not detected as composite. Their value is 0x800000XX and CX25840_COMPONENT_ON is 0x80000200. So 739 else if ((vid_input & CX25840_COMPONENT_ON) == 0) this condition never be true. Signed-off-by:
Kusanagi Kouichi <slash@ac.auone-net.jp> Reviewed-by:
-
Jean-François Moine authored
Signed-off-by:
Jean-François Moine <moinejf@free.fr> Signed-off-by:
-
Nicolau Werneck authored
Signed-off-by:
Nicolau Werneck <nwerneck@gmail.com> Signed-off-by:
-
Jean-Francois Moine authored
Signed-off-by:
-
Márton Németh authored
Signed-off-by:
Márton Németh <nm127@freemail.hu> Signed-off-by:
-
Márton Németh authored
Signed-off-by:
-
Jean Delvare authored
The init and exit functions are needlessly complex. Remove the bloat: * Drop irrelevant/outdated comments. * Remove useless bt878_pci_driver_registered global variable. Signed-off-by:
Jean Delvare <khali@linux-fr.org> Signed-off-by:
-
Arnaud Patard authored
When using VIDIOC_QBUF with memory type set to V4L2_MEMORY_MMAP, the v4l2_buffer buffer gets unmodified on drivers like uvc (well, only bytesused field is modified). Then some apps like gstreamer are reusing the same buffer later to call munmap (eg passing the buffer "length" field as 2nd parameter of munmap). It's working fine on full 32bits but on 32bits systems with 64bit kernel, the get_v4l2_buffer32() doesn't copy length/m.offset values and then copy garbage to userspace in put_v4l2_buffer32(). This has for consequence things like that in the libv4l2 logs: libv4l2: v4l2 unknown munmap 0x2e2b0000, -2145144908 libv4l2: v4l2 unknown munmap 0x2e530000, -2145144908 The buffer are not unmap'ed and then if the application close and open again the device, it won't work and logs will show something like: libv4l2: error setting pixformat: Device or resource busy The easy solution is to read length and m.offset in get_v4l2_buffer32(). Signed-off-by:
Arnaud Patard <apatard@mandriva.com> Signed-off-by:
-
Márton Németh authored
The loop counter j is declared twice in function error_handler(). Remove the redundant declaration. This will remove the following sparse warning (see "make C=1"): * symbol 'j' shadows an earlier one Signed-off-by:
-
Márton Németh authored
The second parameter of g_input_status operation in <media/v4l2-subdev.h> is unsigned so also call it with unsigned paramter. This will remove the following sparse warning (see "make C=1"): * incorrect type in argument 2 (different signedness) expected unsigned int [usertype] *status got int *<noident> Signed-off-by: -
Roel Kluin authored
The wrong command was printed for case CX2341X_ENC_SET_DNR_FILTER_MODE, and a typo in case CX2341X_ENC_SET_PCR_ID. Signed-off-by:
Roel Kluin <roel.kluin@gmail.com> Acked-By:
Steven Toth <stoth@kernellabs.com> Signed-off-by:
-
Stefan Richter authored
Before each FCP transdaction, the entire 512 bytes of the FCP frame were cleared, then values filled in. Clear only the bytes between filled-in bytes and end of the - request frame, or - response frame if data from a larger response will be needed, or - whole frame if data from a variable length response will be taken. Signed-off-by:
Stefan Richter <stefanr@s5r6.in-berlin.de> Signed-off-by:
-
Stefan Richter authored
FCP transactions as well as CMP transactions were serialized with mutex_lock_interruptible. It is extremely unlikly though that a signal will arrive while a concurrent process holds the mutex. And even if one does, the duration of a transaction is reasonably short (1.2 seconds if all retries time out, usually much shorter). Hence simplify the code to plain mutex_lock. Signed-off-by:
-
Stefan Richter authored
This is a portability fix and reduces stack usage. The DMA mapping API cannot map on-stack addresses, as explained in Documentation/DMA-mapping.txt. Convert the two cases of on-stack packet payload buffers in firedtv (payload of write requests in avc_write and of lock requests in cmp_lock) to slab-allocated memory. We use the 512 bytes sized FCP frame buffer in struct firedtv for this purpose. Previously it held only incoming FCP responses, now it holds pending FCP requests and is then overwriten by an FCP response from the tuner subunit. Ditto for CMP lock requests and responses. Accesses to the payload buffer are serialized by fdtv->avc_mutex. As a welcome side effect, stack usage of the AV/C transaction functions is reduced by 512 bytes. Alas, avc_register_remote_control() is a special case: It previously did not wait for a response. To fit better in with the other FCP transactions, let it wait for an interim response. Signed-off-by:
-
Mauro Carvalho Chehab authored
WARNING: drivers/media/video/cx18/cx18-alsa.o(.text+0x4de): Section mismatch in reference from the function cx18_alsa_load() to the function .init.text:snd_cx18_init() The function cx18_alsa_load() references the function __init snd_cx18_init(). This is often because cx18_alsa_load lacks a __init annotation or the annotation of snd_cx18_init is wrong. WARNING: drivers/media/video/cx18/built-in.o(.text+0x1c022): Section mismatch in reference from the function cx18_alsa_load() to the function .init.text:snd_cx18_init() The function cx18_alsa_load() references the function __init snd_cx18_init(). This is often because cx18_alsa_load lacks a __init annotation or the annotation of snd_cx18_init is wrong. WARNING: drivers/media/video/built-in.o(.text+0x28cc56): Section mismatch in reference from the function cx18_alsa_load() to the function .init.text:snd_cx18_init() The function cx18_alsa_load() references the function __init snd_cx18_init(). This is often because cx18_alsa_load lacks a __init annotation or the annotation of snd_cx18_init is wrong. WARNING: drivers/media/built-in.o(.text+0x2d2432): Section mismatch in reference from the function cx18_alsa_load() to the function .init.text:snd_cx18_init() The function cx18_alsa_load() references the function __init snd_cx18_init(). This is often because cx18_alsa_load lacks a __init annotation or the annotation of snd_cx18_init is wrong. Signed-off-by: -
Mauro Carvalho Chehab authored
drivers/media/video/cx18/cx18-driver.c:252: warning: ‘request_modules’ used but never defined Signed-off-by: -
Jean-Francois Moine authored
Signed-off-by:
-
Antonio Ospite authored
Fix a regression, introduced in the driver split, which made the ov534 driver unusable. Plus, the debug message should reflect that we discard also packets beyond the expected frame size. Signed-off-by:
Antonio Ospite <ospite@studenti.unina.it> Signed-off-by:
-
Antonio Ospite authored
Signed-off-by:
-
Jean-Francois Moine authored
Signed-off-by:
-
Jean-Francois Moine authored
Signed-off-by:
-
Jean-Francois Moine authored
Signed-off-by:
-
Jean-Francois Moine authored
Signed-off-by:
-
Jean-Francois Moine authored
There is only one page to load (page 3 for pac7302 and page 4 for pac7311). Signed-off-by:
-
Hans de Goede authored
The sensors adcm2700, mc501cb and ov7620 cannot have the full height permitted by the zc3xx bridges. This change removes 8 pixels at the bottom of the images. Signed-off-by:
Hans de Goede <hdegoede@redhat.com> Signed-off-by:
-
Stephen Rothwell authored
Signed-off-by:
Stephen Rothwell <sfr@canb.auug.org.au> Acked-by:
-
Huang Weiyi authored
Remove duplicated #include('s) in drivers/media/dvb/mantis/mantis_hif.c drivers/media/dvb/mantis/mantis_pci.c Signed-off-by:Huang Weiyi <weiyi.huang@gmail.com> Signed-off-by:
-
Márton Németh authored
'extern' is not needed at function definition. This will remove the following sparse warning (see "make C=1"): * function 'dib0090_dcc_freq' with external linkage has definition Signed-off-by:
-
Márton Németh authored
The 3rd parameter v4l2_subdev_notify() is passed to the notify() callback which is a pointer, see <media/v4l2-subdev.h> and <media/v4l2-device.h>. This will remove the following sparse warning (see "make C=1"): * Using plain integer as NULL pointer Signed-off-by:
-
Márton Németh authored
Some functions are only used locally so mark them static. This will remove the following sparse warnings (see "make C=1"): * symbol 'extract_mask_pos' was not declared. Should it be static? * symbol 'stv0900_initialize' was not declared. Should it be static? * symbol 'stv0900_get_mclk_freq' was not declared. Should it be static? * symbol 'stv0900_set_mclk' was not declared. Should it be static? * symbol 'stv0900_get_err_count' was not declared. Should it be static? Signed-off-by:
-
Márton Németh authored
The functions stv0900_sw_algo() and stv0900_set_dvbs1_track_car_loop() are only used locally so mark them static. This will remove the following sparse warnings (see "make C=1"): * symbol 'stv0900_sw_algo' was not declared. Should it be static? * symbol 'stv0900_set_dvbs1_track_car_loop' was not declared. Should it be static? Signed-off-by:
-
Márton Németh authored
Remove the following sparse error (see "make C=1"): * error: incompatible types for operation (<) left side has type struct dvb_frontend * right side has type int Signed-off-by: -
Thiago Farina authored
drivers/media/dvb/dvb-core/dvb_frontend.c | 6 ++---- Signed-off-by:
Thiago Farina <tfransosi@gmail.com> Signed-off-by:
-
Márton Németh authored
Remove the following sparse warning (see "make C=1"): * warning: Using plain integer as NULL pointer Signed-off-by:
-
Ben Hutchings authored
Signed-off-by:
Ben Hutchings <ben@decadent.org.uk> Signed-off-by:
-
Muralidharan Karicheri authored
This adds platform code for ccdc driver on DM355 and DM6446. 1) new ccdc platform devices added 2) added clock aliases master and slave for CCDC clocks 3) added dm355_ccdc_setup_pinmux() pin-mux setup hook in dm355 ccdc driver platform data Reviewed-by:
Vaibhav Hiremath <hvaibhav@ti.com> Reviewed-by:
Kevin Hilman <khilman@deeprootsystems.com> Reviewed-by:
Hans Verkuil <hverkuil@xs4all.nl> Signed-off-by:
Muralidharan Karicheri <m-karicheri2@ti.com> Signed-off-by:
-
Muralidharan Karicheri authored
1) clocks are configured using generic clock names 2) converting the driver to a platform driver 3) cleanup - consolidate all static variables inside a structure, ccdc_cfg The ccdc driver now uses generic names for clocks - master and slave. On individual platforms these clocks will inherit from the platform specific clock. This will allow re-use of the driver for the same IP across different SoCs. Reviewed-by:
-
