An error occurred fetching the project authors.
- 20 Jan, 2015 3 commits
-
-
Takashi Iwai authored
This is a fairly big rewrite regarding the card resource management in line6 drivers: - The card creation is moved into line6_probe(). This adds the global destructor to private_free, so that each driver doesn't have to call it any longer. - The USB disconnect callback handles the card release, thus each driver needs to concentrate on only its own resources. No need to snd_card_*() call in the destructor. - Fix the potential stall in disconnection by removing snd_card_free(). It's replaced with snd_card_free_when_closed() for asynchronous release. - The only remaining operation for the card in each driver is the call of snd_card_register(). All the rest are dealt in the common module by itself. - These ended up with removal of audio.[ch] as a result of a reduction of one layer. Each driver just needs to call line6_probe(). Tested-by:
Chris Rorvick <chris@rorvick.com> Signed-off-by:
Takashi Iwai <tiwai@suse.de>
-
Takashi Iwai authored
The line6 drivers don't support the full resume although they set SNDRV_PCM_INFO_RESUME. These flags have to be dropped to inform properly to the user-space. Also, drop the CONFIG_PM in trigger callbacks, too, which are rather superfluous. Tested-by:
-
Takashi Iwai authored
Split to each individual driver for POD, PODHD, TonePort and Variax with a core LINE6 helper module. The new modules follow the standard ALSA naming rule with snd prefix: snd-usb-pod, snd-usb-podhd, snd-usb-toneport and snd-usb-variax, together with the corresponding CONFIG_SND_USB_* Kconfig items. Tested-by:
-
- 12 Jan, 2015 8 commits
-
-
Takashi Iwai authored
Promote line6 driver from staging to sound/usb/line6 directory, and maintain through sound subsystem tree. This commit just moves the code and adapts Makefile / Kconfig. The further renames and misc cleanups will follow. Signed-off-by: -
Chris Rorvick authored
Remove declarations from the header and move the definitions up in the source so they need not be forward declared. Signed-off-by:
Stefan Hajnoczi <stefanha@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by:
-
Chris Rorvick authored
Which *_disconnect() to call on disconnect is known at initialization. Add a function pointer to the `usb_line6' struct and use to call into the appropriate logic instead of evaluating the conditional logic. Signed-off-by:
-
Chris Rorvick authored
Which *_process_message() function (if any) to call when data is received is known at initialization. Add a function pointer to the `usb_line6' struct and use to call into the appropriate logic instead of evaluating the conditional logic for each message. Signed-off-by:
-
Chris Rorvick authored
Casting the `struct usb_line6' pointer at the call point makes the code difficult to read. This is substantially cleaned up by moving the cast into the callees. Signed-off-by:
-
Chris Rorvick authored
Casting the `struct usb_line6' pointer at the call point makes the code difficult to read. This is substantially cleaned up by moving the cast into the callees. Signed-off-by:
-
Chris Rorvick authored
Including "BIT" in the macro name is pointless. Replace with "CAP" to provide some context for what its value represents. Signed-off-by:
-
Chris Rorvick authored
This function was no longer used as of commit 28079044 (staging: line6: drop MIDI parameter sysfs attrs). Signed-off-by:
-
- 15 May, 2014 1 commit
-
-
Jerry Snitselaar authored
Fix coding style warnings reported by checkpath. Signed-off-by:
Jerry Snitselaar <dev@snitselaar.org> Signed-off-by:
-
- 24 Aug, 2013 1 commit
-
-
Greg Kroah-Hartman authored
Move to use the DEVICE_ATTR_RW/RO macros, making it easier to audit the sysfs file permissions, and get rid of the "empty" callback for read-only files, saving lines of code. Cc: Stefan Hajnoczi <stefanha@gmail.com> Cc: Laurent Navet <laurent.navet@gmail.com> Cc: Johannes Thumshirn <morbidrsa@googlemail.com> Signed-off-by:
-
- 11 Mar, 2013 1 commit
-
-
Laurent Navet authored
- WARNING: braces {} are not necessary for single statement blocks Signed-off-by:Laurent Navet <laurent.navet@gmail.com> Reviewed-by:
-
- 20 Jan, 2013 1 commit
-
-
Stefan Hajnoczi authored
Previous versions of the line6 driver snooped MIDI traffic in order to make device state accessible via sysfs attributes. This involved a lot of logic in line6_pod_process_message() that has since been removed. Drop unused conditionals in line6_pod_process_message() and reduce the levels of indentation. Only two MIDI messages are still tracked: the POD version message on startup and monitor level changes originating from the device. Signed-off-by:
-
- 12 Jan, 2013 2 commits
-
-
Stefan Hajnoczi authored
Fix the following checkpatch.pl warnings: WARNING: Avoid CamelCase: <POD_monitor_level> #4512: FILE: staging/line6/pod.c:41: + POD_monitor_level = 0x04, WARNING: Avoid CamelCase: <POD_system_invalid> #4513: FILE: staging/line6/pod.c:42: + POD_system_invalid = 0x10000 Signed-off-by:
-
Stefan Hajnoczi authored
Fix the following checkpatch.pl warnings: WARNING: line over 80 characters #4508: FILE: staging/line6/pod.c:37: + /* POD_SYSEX_DUMPMEM2 = 0x76 */ /* dumps entire internal memory of PODxt Pro */ WARNING: line over 80 characters #4630: FILE: staging/line6/pod.c:159: + if (memcmp(buf + 1, line6_midi_id, sizeof(line6_midi_id)) == 0) { Signed-off-by:
-
- 27 Nov, 2012 23 commits
-
-
Stefan Hajnoczi authored
The pod startup procedure dumps model data. This is no longer useful since the sysfs attrs which expose this information to userspace have been removed. The dump request wasn't been processed anymore. Signed-off-by:
-
Stefan Hajnoczi authored
Signed-off-by:
-
Stefan Hajnoczi authored
The driver no longer keeps state of MIDI-accessible device parameters. Drop the buffers but be careful to keep the device startup procedure working even though we no longer store the contents of the dump request. The startup procedure will be simplified in a later patch. Signed-off-by:
-
Stefan Hajnoczi authored
Both pod.c and variax.c expose the device's MIDI parameters as sysfs attrs. Knowledge of MIDI constants should be in userspace, not in the driver. Drop the sysfs attrs and let userspace interpret parameters it cares about instead. Signed-off-by:
-
Stefan Hajnoczi authored
Since the driver no longer needs to keep state of device parameters it is no longer necessary to refresh state when messages that affect other parameters are sent. Drop the code to trigger a dump when amp/effects are changed. Signed-off-by:
-
Stefan Hajnoczi authored
The pod_set_system_param_int() helper function is only used to set the monitor level. Previously it was also used to control the tuner and has special checks. These checks can now be dropped, along with the tuner constants. Signed-off-by:
-
Stefan Hajnoczi authored
The raw sysfs attr transmits MIDI messages with less filtering. This was a useful debugging tool while the staging driver still had a lot of state and filtering. It is not useful anymore since the filtering is being dropped. Signed-off-by:
-
Stefan Hajnoczi authored
It is no longer necessary to trigger on MIDI transmit messages that will change the state of the device since: 1. We've dropped the midi_postprocess sysfs attr in a previous commit so it is not possible to activate this feature anymore. 2. The other sysfs attrs that could inspect the state after a dump request have been dropped. Therefore we can safely remove this dead code. Signed-off-by:
-
Stefan Hajnoczi authored
Signed-off-by:
-
Stefan Hajnoczi authored
Signed-off-by:
-
Stefan Hajnoczi authored
Dropping this final tuner sysfs attr also leaves the POD_GET_SYSTEM_PARAM() macro, pod_get_system_param_string(), and pod_get_system_param_int() unused. Remove them immediately to avoid compiler warnings. POD_monitor_level is now the only SYSEX value that needs to be watched by the driver since the ALSA volume control should reflect the current monitor volume level used by the device. Therefore, drop the switch statement entirely and just check for POD_monitor_level, ignoring unknown system parameter changes. Signed-off-by:
-
Stefan Hajnoczi authored
Signed-off-by:
-
Stefan Hajnoczi authored
Signed-off-by:
-
Stefan Hajnoczi authored
Signed-off-by:
-
Stefan Hajnoczi authored
Signed-off-by:
-
Stefan Hajnoczi authored
Signed-off-by:
-
Stefan Hajnoczi authored
Signed-off-by:
-
Stefan Hajnoczi authored
Signed-off-by:
-
Stefan Hajnoczi authored
Signed-off-by:
-
Stefan Hajnoczi authored
Signed-off-by:
-
Stefan Hajnoczi authored
Signed-off-by:
-
Stefan Hajnoczi authored
Signed-off-by:
-
Stefan Hajnoczi authored
Signed-off-by:
-
