1. 10 Jul, 2019 2 commits
    • Bernard Metzler's avatar
      RDMA/siw: Remove unnecessary kthread create/destroy printouts · 85de5d53
      Bernard Metzler authored
      There is already a warning if we cannot start any thread, and stopping
      those threads is not worth spamming the console.
      
      This also corrects a warning from gcc:
      
       drivers/infiniband/sw/siw/siw_main.c: In function 'siw_create_tx_threads':
       drivers/infiniband/sw/siw/siw_main.c:91:11: warning:
        variable 'rv' set but not used [-Wunused-but-set-variable]
      Reported-by: default avatarHulk Robot <hulkci@huawei.com>
      Signed-off-by: default avatarYueHaibing <yuehaibing@huawei.com>
      Signed-off-by: default avatarBernard Metzler <bmt@zurich.ibm.com>
      Signed-off-by: default avatarJason Gunthorpe <jgg@mellanox.com>
      85de5d53
    • Nathan Chancellor's avatar
      IB/rdmavt: Fix variable shadowing issue in rvt_create_cq · 4d2b8517
      Nathan Chancellor authored
      clang warns:
      
      drivers/infiniband/sw/rdmavt/cq.c:260:7: warning: variable 'err' is used
      uninitialized whenever 'if' condition is true
      [-Wsometimes-uninitialized]
                      if (err)
                          ^~~
      drivers/infiniband/sw/rdmavt/cq.c:310:9: note: uninitialized use occurs
      here
              return err;
                     ^~~
      drivers/infiniband/sw/rdmavt/cq.c:260:3: note: remove the 'if' if its
      condition is always false
                      if (err)
                      ^~~~~~~~
      drivers/infiniband/sw/rdmavt/cq.c:253:7: warning: variable 'err' is used
      uninitialized whenever 'if' condition is true
      [-Wsometimes-uninitialized]
                      if (!cq->ip) {
                          ^~~~~~~
      drivers/infiniband/sw/rdmavt/cq.c:310:9: note: uninitialized use occurs
      here
              return err;
                     ^~~
      drivers/infiniband/sw/rdmavt/cq.c:253:3: note: remove the 'if' if its
      condition is always false
                      if (!cq->ip) {
                      ^~~~~~~~~~~~~~
      drivers/infiniband/sw/rdmavt/cq.c:211:9: note: initialize the variable
      'err' to silence this warning
              int err;
                     ^
                      = 0
      2 warnings generated.
      
      The function scoped err variable is uninitialized when the flow jumps into
      the if statement. The if scoped err variable shadows the function scoped
      err variable, preventing the err assignments within the if statement to be
      reflected at the function level, which will cause uninitialized use when
      the goto statements are taken.
      
      Just remove the if scoped err declaration so that there is only one copy
      of the err variable for this function.
      
      Fixes: 239b0e52 ("IB/hfi1: Move rvt_cq_wc struct into uapi directory")
      Link: https://github.com/ClangBuiltLinux/linux/issues/594Reviewed-by: default avatarNick Desaulniers <ndesaulniers@google.com>
      Signed-off-by: default avatarNathan Chancellor <natechancellor@gmail.com>
      Acked-by: default avatarMike Marciniszyn <mike.marciniszyn@intel.com>
      Signed-off-by: default avatarJason Gunthorpe <jgg@mellanox.com>
      4d2b8517
  2. 09 Jul, 2019 2 commits
  3. 08 Jul, 2019 13 commits
  4. 07 Jul, 2019 6 commits
  5. 05 Jul, 2019 17 commits