- 01 May, 2017 27 commits
-
-
Håkon Bugge authored
Change and simplify the code to match the variable name. This commit improves readability but makes no functional change to the code. Signed-off-by:
Håkon Bugge <haakon.bugge@oracle.com> Suggested-by:
Wengang Wang <wen.gang.wang@oracle.com> Reviewed-by:
Wengang Wang <wen.gang.wang@oracle.com> Reviewed-by:
Knut Omang <knut.omang@oracle.com> Acked-by:
Leon Romanovsky <leonro@mellanox.com> Signed-off-by:
Doug Ledford <dledford@redhat.com>
-
Sagi Grimberg authored
In case we got an initial sg_offset, we need to account for it in the mr length. Cc: stable@vger.kernel.org Fixes: ff2ba993 ("IB/core: Add passing an offset into the SG to ib_map_mr_sg") Signed-off-by:
Sagi Grimberg <sagi@grimberg.me> Tested-by:
Israel Rukshin <israelr@mellanox.com> Signed-off-by:
Doug Ledford <dledford@redhat.com>
-
Johannes Thumshirn authored
When reading a RDMA WRITE FIRST packet we copy the DMA length from the RDMA header into the qp->resp.resid variable for later use. Later in check_rkey() we clamp it to the MTU if the packet is an RDMA WRITE packet and has a residual length bigger than the MTU. Later in write_data_in() we subtract the payload of the packet from the residual length. If the packet happens to have a payload of exactly the MTU size we end up with a residual length of 0 despite the packet not being the last in the conversation. When the next packet in the conversation arrives, we don't have any residual length left and thus set the QP into an error state. This broke NVMe over Fabrics functionality over rdma_rxe.ko The patch was verified using the following test. # echo eth0 > /sys/module/rdma_rxe/parameters/add # nvme connect -t rdma -a 192.168.155.101 -s 1023 -n nvmf-test # mkfs.xfs -fK /dev/nvme0n1 meta-data=/dev/nvme0n1 isize=256 agcount=4, agsize=65536 blks = sectsz=4096 attr=2, projid32bit=1 = crc=0 finobt=0, sparse=0 data = bsize=4096 blocks=262144, imaxpct=25 = sunit=0 swidth=0 blks naming =version 2 bsize=4096 ascii-ci=0 ftype=1 log =internal log bsize=4096 blocks=2560, version=2 = sectsz=4096 sunit=1 blks, lazy-count=1 realtime =none extsz=4096 blocks=0, rtextents=0 # mount /dev/nvme0n1 /tmp/ [ 148.923263] XFS (nvme0n1): Mounting V4 Filesystem [ 148.961196] XFS (nvme0n1): Ending clean mount # dd if=/dev/urandom of=test.bin bs=1M count=128 128+0 records in 128+0 records out 134217728 bytes (134 MB, 128 MiB) copied, 0.437991 s, 306 MB/s # sha256sum test.bin cde42941f045efa8c4f0f157ab6f29741753cdd8d1cff93a6b03649d83c4129a test.bin # cp test.bin /tmp/ sha256sum /tmp/test.bin cde42941f045efa8c4f0f157ab6f29741753cdd8d1cff93a6b03649d83c4129a /tmp/test.bin Signed-off-by:
Johannes Thumshirn <jthumshirn@suse.de> Cc: Hannes Reinecke <hare@suse.de> Cc: Sagi Grimberg <sagi@grimberg.me> Cc: Max Gurtovoy <maxg@mellanox.com> Acked-by:
Moni Shoua <monis@mellanox.com> Signed-off-by:
Doug Ledford <dledford@redhat.com>
-
Dasaratharaman Chandramouli authored
When the bit 26 of capmask2 field in OPA classport info query is set, SA will query for OPA path records instead of querying for IB path records. Note that OPA path records can only be queried by kernel ULPs. Userspace clients continue to query IB path records. Reviewed-by:
Don Hiatt <don.hiatt@intel.com> Reviewed-by:
Ira Weiny <ira.weiny@intel.com> Signed-off-by:
Dasaratharaman Chandramouli <dasaratharaman.chandramouli@intel.com> Signed-off-by:
Doug Ledford <dledford@redhat.com>
-
Dasaratharaman Chandramouli authored
Add opa_sa_path_rec to sa_path_rec data structure. The 'type' field in sa_path_rec identifies the type of the path record. Reviewed-by:
Don Hiatt <don.hiatt@intel.com> Reviewed-by:
Ira Weiny <ira.weiny@intel.com> Signed-off-by:
Dasaratharaman Chandramouli <dasaratharaman.chandramouli@intel.com> Signed-off-by:
Doug Ledford <dledford@redhat.com>
-
Dasaratharaman Chandramouli authored
sa_path_rec now contains a union of sa_path_rec_ib and sa_path_rec_roce based on the type of the path record. Note that fields applicable to path record type ROCE v1 and ROCE v2 fall under sa_path_rec_roce. Accessor functions are added to these fields so the caller doesn't have to know the type. Reviewed-by:
Don Hiatt <don.hiatt@intel.com> Reviewed-by:
Ira Weiny <ira.weiny@intel.com> Signed-off-by:
Dasaratharaman Chandramouli <dasaratharaman.chandramouli@intel.com> Signed-off-by:
Doug Ledford <dledford@redhat.com>
-
Dasaratharaman Chandramouli authored
struct sa_path_rec has a gid_type field. This patch introduces a more generic path record specific type 'rec_type' which is either IB, ROCE v1 or ROCE v2. The patch also provides conversion functions to get a gid type from a path record type and vice versa Reviewed-by:
Don Hiatt <don.hiatt@intel.com> Reviewed-by:
Ira Weiny <ira.weiny@intel.com> Signed-off-by:
Dasaratharaman Chandramouli <dasaratharaman.chandramouli@intel.com> Signed-off-by:
Doug Ledford <dledford@redhat.com>
-
Dasaratharaman Chandramouli authored
Rename ib_sa_path_rec to a more generic sa_path_rec. This is part of extending ib_sa to also support OPA path records in addition to the IB defined path records. Reviewed-by:
Don Hiatt <don.hiatt@intel.com> Reviewed-by:
Ira Weiny <ira.weiny@intel.com> Signed-off-by:
Dasaratharaman Chandramouli <dasaratharaman.chandramouli@intel.com> Signed-off-by:
Doug Ledford <dledford@redhat.com>
-
Dasaratharaman Chandramouli authored
This patch adds braces around parameters to sizeof as called out by checkpatch Reviewed-by:
Don Hiatt <don.hiatt@intel.com> Reviewed-by:
Ira Weiny <ira.weiny@intel.com> Signed-off-by:
Dasaratharaman Chandramouli <dasaratharaman.chandramouli@intel.com> Signed-off-by:
Doug Ledford <dledford@redhat.com>
-
Dasaratharaman Chandramouli authored
OPA ah_attr types allows core components to specify attributes that may be specific to opa devices. For instance, opa type ah_attr provides 32 bit lids enabling larger OPA fabric sizes. Reviewed-by:
Ira Weiny <ira.weiny@intel.com> Reviewed-by:
Don Hiatt <don.hiatt@intel.com> Reviewed-by:
Sean Hefty <sean.hefty@intel.com> Signed-off-by:
Dasaratharaman Chandramouli <dasaratharaman.chandramouli@intel.com> Signed-off-by:
Doug Ledford <dledford@redhat.com>
-
Dasaratharaman Chandramouli authored
rdma_ah_attr can now be either ib or roce allowing core components to use one type or the other and also to define attributes unique to a specific type. struct ib_ah is also initialized with the type when its first created. This ensures that calls such as modify_ah dont modify the type of the address handle attribute. Reviewed-by:
Ira Weiny <ira.weiny@intel.com> Reviewed-by:
Don Hiatt <don.hiatt@intel.com> Reviewed-by:
Sean Hefty <sean.hefty@intel.com> Reviewed-by:
Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com> Signed-off-by:
Dasaratharaman Chandramouli <dasaratharaman.chandramouli@intel.com> Signed-off-by:
Doug Ledford <dledford@redhat.com>
-
Dasaratharaman Chandramouli authored
Modify core and driver components to use accessor functions introduced to access individual fields of rdma_ah_attr Reviewed-by:
Ira Weiny <ira.weiny@intel.com> Reviewed-by:
Don Hiatt <don.hiatt@intel.com> Reviewed-by:
Sean Hefty <sean.hefty@intel.com> Reviewed-by:
Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com> Signed-off-by:
Dasaratharaman Chandramouli <dasaratharaman.chandramouli@intel.com> Signed-off-by:
Doug Ledford <dledford@redhat.com>
-
Dasaratharaman Chandramouli authored
These accessor functions are supposed to be used to get and set individual fields of struct rdma_ah_attr Reviewed-by:
Ira Weiny <ira.weiny@intel.com> Reviewed-by:
Don Hiatt <don.hiatt@intel.com> Reviewed-by:
Sean Hefty <sean.hefty@intel.com> Signed-off-by:
Dasaratharaman Chandramouli <dasaratharaman.chandramouli@intel.com> Signed-off-by:
Doug Ledford <dledford@redhat.com>
-
Dasaratharaman Chandramouli authored
Functions pvrdma_ah_attr_to_ib and ib_ah_attr_to_pvrdma have been renamed so they are in sync wit the rename of the ib_ah_attr structure Reviewed-by:
Ira Weiny <ira.weiny@intel.com> Reviewed-by:
Don Hiatt <don.hiatt@intel.com> Reviewed-by:
Sean Hefty <sean.hefty@intel.com> Signed-off-by:
Dasaratharaman Chandramouli <dasaratharaman.chandramouli@intel.com> Signed-off-by:
Doug Ledford <dledford@redhat.com>
-
Dasaratharaman Chandramouli authored
local function to_ib_ah_attr is renamed so it in sync with the rename of the ib_ah_attr structure Reviewed-by:
Ira Weiny <ira.weiny@intel.com> Reviewed-by:
Don Hiatt <don.hiatt@intel.com> Reviewed-by:
Sean Hefty <sean.hefty@intel.com> Signed-off-by:
Dasaratharaman Chandramouli <dasaratharaman.chandramouli@intel.com> Signed-off-by:
Doug Ledford <dledford@redhat.com>
-
Dasaratharaman Chandramouli authored
local function to_ib_ah_attr is renamed so it in sync with the rename of the ib_ah_attr structure Reviewed-by:
Ira Weiny <ira.weiny@intel.com> Reviewed-by:
Don Hiatt <don.hiatt@intel.com> Reviewed-by:
Sean Hefty <sean.hefty@intel.com> Signed-off-by:
Dasaratharaman Chandramouli <dasaratharaman.chandramouli@intel.com> Signed-off-by:
Doug Ledford <dledford@redhat.com>
-
Dasaratharaman Chandramouli authored
local function to_ib_ah_attr is renamed so it in sync with the rename of the ib_ah_attr structure Reviewed-by:
Ira Weiny <ira.weiny@intel.com> Reviewed-by:
Don Hiatt <don.hiatt@intel.com> Reviewed-by:
Sean Hefty <sean.hefty@intel.com> Signed-off-by:
Dasaratharaman Chandramouli <dasaratharaman.chandramouli@intel.com> Signed-off-by:
Doug Ledford <dledford@redhat.com>
-
Dasaratharaman Chandramouli authored
Rename ib_destroy_ah to rdma_destroy_ah so its in sync with the rename of the ib address handle attribute Reviewed-by:
Ira Weiny <ira.weiny@intel.com> Reviewed-by:
Don Hiatt <don.hiatt@intel.com> Reviewed-by:
Sean Hefty <sean.hefty@intel.com> Reviewed-by:
Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com> Signed-off-by:
Dasaratharaman Chandramouli <dasaratharaman.chandramouli@intel.com> Signed-off-by:
Doug Ledford <dledford@redhat.com>
-
Dasaratharaman Chandramouli authored
Rename ib_query_ah to rdma_query_ah so its in sync with the rename of the ib address handle attribute Reviewed-by:
Ira Weiny <ira.weiny@intel.com> Reviewed-by:
Don Hiatt <don.hiatt@intel.com> Reviewed-by:
Sean Hefty <sean.hefty@intel.com> Signed-off-by:
Dasaratharaman Chandramouli <dasaratharaman.chandramouli@intel.com> Signed-off-by:
Doug Ledford <dledford@redhat.com>
-
Dasaratharaman Chandramouli authored
Rename ib_modify_ah to rdma_modify_ah so its in sync with the rename of the ib address handle attribute Reviewed-by:
Ira Weiny <ira.weiny@intel.com> Reviewed-by:
Don Hiatt <don.hiatt@intel.com> Reviewed-by:
Sean Hefty <sean.hefty@intel.com> Signed-off-by:
Dasaratharaman Chandramouli <dasaratharaman.chandramouli@intel.com> Signed-off-by:
Doug Ledford <dledford@redhat.com>
-
Dasaratharaman Chandramouli authored
Rename ib_create_ah to rdma_create_ah so its in sync with the rename of the ib address handle attribute Reviewed-by:
Ira Weiny <ira.weiny@intel.com> Reviewed-by:
Don Hiatt <don.hiatt@intel.com> Reviewed-by:
Sean Hefty <sean.hefty@intel.com> Reviewed-by:
Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com> Signed-off-by:
Dasaratharaman Chandramouli <dasaratharaman.chandramouli@intel.com> Signed-off-by:
Doug Ledford <dledford@redhat.com>
-
Dasaratharaman Chandramouli authored
This patch simply renames struct ib_ah_attr to rdma_ah_attr as these fields specify attributes that are not necessarily specific to IB. Reviewed-by:
Ira Weiny <ira.weiny@intel.com> Reviewed-by:
Don Hiatt <don.hiatt@intel.com> Reviewed-by:
Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com> Reviewed-by:
Sean Hefty <sean.hefty@intel.com> Signed-off-by:
Dasaratharaman Chandramouli <dasaratharaman.chandramouli@intel.com> Signed-off-by:
Doug Ledford <dledford@redhat.com>
-
Dasaratharaman Chandramouli authored
Zero out ib_ah_attr before calling query_ah. Set ah_flags appropriately. Reviewed-by:
Ira Weiny <ira.weiny@intel.com> Reviewed-by:
Don Hiatt <don.hiatt@intel.com> Reviewed-by:
Sean Hefty <sean.hefty@intel.com> Signed-off-by:
Dasaratharaman Chandramouli <dasaratharaman.chandramouli@intel.com> Signed-off-by:
Doug Ledford <dledford@redhat.com>
-
Dasaratharaman Chandramouli authored
Read/write grh fields of the ah_attr only if the ah_flags field has the IB_AH_GRH bit enabled Reviewed-by:
Ira Weiny <ira.weiny@intel.com> Reviewed-by:
Don Hiatt <don.hiatt@intel.com> Reviewed-by:
Sean Hefty <sean.hefty@intel.com> Signed-off-by:
Dasaratharaman Chandramouli <dasaratharaman.chandramouli@intel.com> Signed-off-by:
Doug Ledford <dledford@redhat.com>
-
Dasaratharaman Chandramouli authored
This patch adds braces around parameters to sizeof as called out by checkpatch Reviewed-by:
Don Hiatt <don.hiatt@intel.com> Reviewed-by:
Ira Weiny <ira.weiny@intel.com> Reviewed-by:
Sean Hefty <sean.hefty@intel.com> Signed-off-by:
Dasaratharaman Chandramouli <dasaratharaman.chandramouli@intel.com> Signed-off-by:
Doug Ledford <dledford@redhat.com>
-
Dasaratharaman Chandramouli authored
This patch fixes a checkpatch issue related to not having to use an 'else' if the 'if' path returns from the function. Reviewed-by:
Ira Weiny <ira.weiny@intel.com> Reviewed-by:
Don Hiatt <don.hiatt@intel.com> Reviewed-by:
Sean Hefty <sean.hefty@intel.com> Signed-off-by:
Dasaratharaman Chandramouli <dasaratharaman.chandramouli@intel.com> Signed-off-by:
Doug Ledford <dledford@redhat.com>
-
Dasaratharaman Chandramouli authored
Address a checkpatch issue on missing identifier names on function definitions. Reviewed-by:
Ira Weiny <ira.weiny@intel.com> Reviewed-by:
Don Hiatt <don.hiatt@intel.com> Reviewed-by:
Sean Hefty <sean.hefty@intel.com> Signed-off-by:
Dasaratharaman Chandramouli <dasaratharaman.chandramouli@intel.com> Signed-off-by:
Doug Ledford <dledford@redhat.com>
-
- 28 Apr, 2017 13 commits
-
-
Dasaratharaman Chandramouli authored
For OPA devices, SA will query the OPA classport info instead of the IB defined classport info. opa classport info exposes additional information and capabilities that are specific to OPA devices. Reviewed-by:
Ira Weiny <ira.weiny@intel.com> Reviewed-by:
Don Hiatt <don.hiatt@intel.com> Reviewed-by:
Dennis Dalessandro <dennis.dalessandro@intel.com> Signed-off-by:
Dasaratharaman Chandramouli <dasaratharaman.chandramouli@intel.com> Signed-off-by:
Doug Ledford <dledford@redhat.com>
-
Dasaratharaman Chandramouli authored
Both opa_vnic and the hfi driver use the same opa_classport_info definition. We will also have ib_sa capable of querying opa class port info and would need this definition. Move it to ib_mad.h for everyone to use. Signed-off-by:
Dasaratharaman Chandramouli <dasaratharaman.chandramouli@intel.com> Signed-off-by:
Doug Ledford <dledford@redhat.com>
-
Dasaratharaman Chandramouli authored
rdma_cap_opa_ah(..) enables core components to check if the corresponding port supports OPA extended addressing. Reviewed-by:
Ira Weiny <ira.weiny@intel.com> Reviewed-by:
Don Hiatt <don.hiatt@intel.com> Signed-off-by:
Dasaratharaman Chandramouli <dasaratharaman.chandramouli@intel.com> Signed-off-by:
Doug Ledford <dledford@redhat.com>
-
Dasaratharaman Chandramouli authored
SA will query and cache class port info as part of its initialization. SA will also invalidate and refresh the cache based on specific events. Callers such as IPoIB and CM can query the SA to get the classportinfo information. Apart from making the caller code much simpler, this change puts the onus on the SA to query and maintain classportinfo much like how it maitains the address handle to the SM. Reviewed-by:
Ira Weiny <ira.weiny@intel.com> Reviewed-by:
Don Hiatt <don.hiatt@intel.com> Signed-off-by:
Dasaratharaman Chandramouli <dasaratharaman.chandramouli@intel.com> Signed-off-by:
Doug Ledford <dledford@redhat.com>
-
Dasaratharaman Chandramouli authored
Moving these will facilitate changes to these in the next patchs. This is strictly a move and there are no changes to the functions in any way. Reviewed-by:
Don Hiatt <don.hiatt@intel.com> Reviewed-by:
Ira Weiny <ira.weiny@intel.com> Signed-off-by:
Dasaratharaman Chandramouli <dasaratharaman.chandramouli@intel.com> Signed-off-by:
Doug Ledford <dledford@redhat.com>
-
Dasaratharaman Chandramouli authored
This fixes a checkpatch issue. The fix is needed so that some of these functions can be moved around in the forthcoming patches Reviewed-by:
Don Hiatt <don.hiatt@intel.com> Reviewed-by:
Ira Weiny <ira.weiny@intel.com> Signed-off-by:
Dasaratharaman Chandramouli <dasaratharaman.chandramouli@intel.com> Signed-off-by:
Doug Ledford <dledford@redhat.com>
-
Dasaratharaman Chandramouli authored
This fixes a checkpatch issue. The fix is needed so that some of these functions can be moved around in the forthcoming patches Reviewed-by:
Don Hiatt <don.hiatt@intel.com> Reviewed-by:
Ira Weiny <ira.weiny@intel.com> Signed-off-by:
Dasaratharaman Chandramouli <dasaratharaman.chandramouli@intel.com> Signed-off-by:
Doug Ledford <dledford@redhat.com>
-
Dasaratharaman Chandramouli authored
This fixes a checkpatch issue. The fix is needed so that some of these functions can be moved around in the forthcoming patches Reviewed-by:
Don Hiatt <don.hiatt@intel.com> Reviewed-by:
Ira Weiny <ira.weiny@intel.com> Signed-off-by:
Dasaratharaman Chandramouli <dasaratharaman.chandramouli@intel.com> Signed-off-by:
Doug Ledford <dledford@redhat.com>
-
Dennis Dalessandro authored
The process_ecn intends to return a bool value. However it is doing so incorrectly by ANDing the fecn mask. The fecn bit is bit 31. Bool is not a native data type and is up to the compiler to implement how it sees fit. It is conceivable that this upper bit gets washed out. Fix by converting to a bool properly. Cc: stable@vger.kernel.org Fixes: Commit fd2b562edca6 ("IB/hfi1: Pull FECN/BECN processing to a common place") Reviewed-by:
Mike Marciniszyn <mike.marciniszyn@intel.com> Signed-off-by:
Dennis Dalessandro <dennis.dalessandro@intel.com> Signed-off-by:
Doug Ledford <dledford@redhat.com>
-
Ira Weiny authored
The device/port status is not intended to be changed from user space. Prevent a user from mapping them as write or execute. Reviewed-by:
Dennis Dalessandro <dennis.dalessandro@intel.com> Signed-off-by:
Ira Weiny <ira.weiny@intel.com> Signed-off-by:
Dennis Dalessandro <dennis.dalessandro@intel.com> Signed-off-by:
Doug Ledford <dledford@redhat.com>
-
Dennis Dalessandro authored
Add missing braces around else blocks in a few places to make checkpatch happy. Fixes: 77241056 ("IB/hfi1: add driver files") Signed-off-by:
Dennis Dalessandro <dennis.dalessandro@intel.com> Signed-off-by:
Doug Ledford <dledford@redhat.com>
-
Dennis Dalessandro authored
According to checkpatch %Lx is not standard C so remove it and use the suggested %llx. Fixes: 77241056 ("IB/hfi1: add driver files") Signed-off-by:
Dennis Dalessandro <dennis.dalessandro@intel.com> Signed-off-by:
Doug Ledford <dledford@redhat.com>
-
Dennis Dalessandro authored
Checkpatch flagged a misspelled word. Fix it. Fixes: 8764522e ("staging/rdma/hfi1: Unexpected link up pkey values are not an error") Signed-off-by:
Dennis Dalessandro <dennis.dalessandro@intel.com> Signed-off-by:
Doug Ledford <dledford@redhat.com>
-