- 18 Dec, 2019 32 commits
-
-
Jérôme Pouiller authored
Argument to wfx_set_pm() is always wvif->powersave_mode. So, we can simplify it. Signed-off-by:
Jérôme Pouiller <jerome.pouiller@silabs.com> Link: https://lore.kernel.org/r/20191217161318.31402-33-Jerome.Pouiller@silabs.comSigned-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Jérôme Pouiller authored
wfx_set_pm() is now only used by sta.c. It can be declared static. Signed-off-by:
-
Jérôme Pouiller authored
When user try to launch scan while connected, it is necessary to notify the AP that we cannot receive data (using power save mode). Firmware already handles this automatically so the code in the driver is redundant and can be dropped. By edge effect, hack of scan status in wfx_set_pm() is now useless. Signed-off-by:
-
Jérôme Pouiller authored
In the old days, wfx_do_join() could be called from different contexts. Now that wfx_do_join() is called only from one place, it is cleaner to keep lock and unlock of data inside the function. Signed-off-by:
-
Jérôme Pouiller authored
Current name "mixed_or_greenfield_type" does not allow to know if "true" means "mixed" of "greenfield". It is possible to use a better name and drop "enum hif_tx_mode". Signed-off-by:
-
Jérôme Pouiller authored
HIF_PREAMBLE_SHORT_LONG12 is never used. So it is possible to change "preamble_type" into a boolean and drop "enum hif_preamble". Signed-off-by:
-
Jérôme Pouiller authored
In fact "mode" is a boolean that indicates if IBSS mode is used. This patch fixes the name and uses a more adapted memory representation. Signed-off-by:
-
Jérôme Pouiller authored
The original name did not make any sense. Signed-off-by:
-
Jérôme Pouiller authored
The script that has imported API header has made a mistake "num_i_es". Signed-off-by:
-
Jérôme Pouiller authored
The script that has imported API headers has made a mistake in "num_of_ssi_ds". Signed-off-by:
-
Jérôme Pouiller authored
There are no real reason to modify the data received from device. So, let's mark the arguments constant. Signed-off-by:
-
Jérôme Pouiller authored
There is no reason for a trace to change any bit of the argument. So, let's make sure that is the case by declaring the arguments constant. Signed-off-by:
-
Jérôme Pouiller authored
We prefer series of simple boolean conditions than computing bitmasks. Signed-off-by:
-
Jérôme Pouiller authored
Attribute "aborted" and argument "aborted" are both booleans. Signed-off-by:
-
Jérôme Pouiller authored
hif_tx.c does not use any struct skb. Signed-off-by:
-
Jérôme Pouiller authored
This new naming allows to save a comment. Signed-off-by:
-
Jérôme Pouiller authored
In wfx driver, when a function is used as a struct member, its name is the name of the member prefixed with "wfx_". This patch apply this rule to wfx_spi_remove(). Also remove the useless comment above the function. Signed-off-by:
-
Jérôme Pouiller authored
Obviously, current code can be replaced by IS_ERR_OR_NULL(). Signed-off-by:
-
Jérôme Pouiller authored
When driver receives an unexpected answer from the device, it shows "unsupported HIF ID". That message does not represent the real error. Signed-off-by:
-
Jérôme Pouiller authored
Currently, number of available tx retry policies is checked two times. Only one is sufficient. Signed-off-by:
-
Jérôme Pouiller authored
During chip probing, if error does not come from secure boot (for exemple when firmware has been found), others errors probably appears. It is not necessary to say to user that the error does not come from secure boot. So, drop the message saying "no error reported by secure boot". BTW, we take the opportunity to simplify print_boot_status(). Signed-off-by:
-
Jérôme Pouiller authored
The chip has now proven that it can run at 50MHz on any boards without any problem. Signed-off-by:
-
Jérôme Pouiller authored
The driver checks that the number of retries made by the device is coherent with the rate policy. However, this check make sense only if the device has returned RETRY_EXCEEDED. Signed-off-by:
-
Jérôme Pouiller authored
struct hif_mib_protected_mgmt_policy is an array of u8. There is no reason to swap its bytes. Signed-off-by:
-
Jérôme Pouiller authored
Current code has a special case to handle association with WEP. Before to rework the tx data handling, let's try to detect any possible misuse of this code. Signed-off-by:
-
Jérôme Pouiller authored
When not using HT mode, minstrel always includes 1Mbps as fallback rate. But, when using HT mode, this fallback is not included. Yet, it seems that it could save some frames. So, this patch add it unconditionally. Signed-off-by:
-
Jérôme Pouiller authored
A tx_retry_policy (the equivalent of a list of ieee80211_tx_rate in hardware API) is not able to include a rate multiple time. So currently, the driver merges the identical rates from the policy provided by minstrel (and it try to do the best choice it can in the associated flags) before to sent it to firmware. Until now, when rates are merged, field "count" is set to max(count1, count2). But, it means that the sum of retries for all rates could be far less than initial number of retries. So, this patch changes the value of field "count" to count1 + count2. Thus, sum of all retries for all rates stay the same. Signed-off-by:
-
Jérôme Pouiller authored
The sum of all retries for a Tx frame cannot be superior to 32. There are 4 rates at most. So this patch limits number of retries per rate to 8. Signed-off-by:
-
Jérôme Pouiller authored
The field 'uploaded' is used as a boolean, so call it a boolean. Signed-off-by:
-
Jérôme Pouiller authored
Some weird behaviors were observed when connection is really good and packets are small. It appears that sometime, number of packets in queues can exceed 255 and generate an overflow in field usage_count. Signed-off-by:
-
Jérôme Pouiller authored
In some rare cases, driver may not have any available tx_retry_policies. In this case, the driver asks to mac80211 to stop sending data. However, it seems that a race is possible and a few frames can be sent to the driver. In this case, driver can't wait for free tx_retry_policies since wfx_tx() must be atomic. So, this patch fix this case by sending these frames with the special policy number 15. The firmware normally use policy 15 to send internal frames (PS-poll, beacons, etc...). So, it is not a so bad fallback. Signed-off-by:
-
Jérôme Pouiller authored
Device and driver maintain a cache of rate policies (aka. tx_retry_policy in hardware API). When hif_reset() is sent to hardware, device resets its cache of rate policies. In order to keep driver in sync, it is necessary to do the same on driver. Note, when driver tries to use a rate policy that has not been defined on device, data is sent at 1Mbps. So, this patch should fix abnormal throughput observed sometime after a reset of the interface. Signed-off-by:
-
- 17 Dec, 2019 8 commits
-
-
Michael Straube authored
Add missing spaces around operators to improve readability and clear checkpatch issues. Signed-off-by:
Michael Straube <straube.linux@gmail.com> Link: https://lore.kernel.org/r/20191214100955.16670-2-straube.linux@gmail.comSigned-off-by:
-
Michael Straube authored
Cleanup comparsions to NULL reported by checkpatch. if (x == NULL) -> if (!x) if (x != NULL) -> if (x) Signed-off-by:
-
Christian Gromm authored
This patch replaces the double quotes in all include paths with angle brackets. Signed-off-by:
Christian Gromm <christian.gromm@microchip.com> Link: https://lore.kernel.org/r/1576238662-16512-7-git-send-email-christian.gromm@microchip.comSigned-off-by:
-
Christian Gromm authored
This patch reduces the size of the arrays inside the mdev_link struct to a reasonable value. Reported-by:
Joe Perches <joe@perches.com> Signed-off-by:
-
Christian Gromm authored
This patch uses strlcpy to copy data provided by userspace in order to not overflow the allocated space. Signed-off-by:
-
Christian Gromm authored
The data structures of the most.h header file will be exposed to the kernel once the file is moved out of the staging area. This is why the name is prefixed with the string 'most'. Reported-by:
-
Christian Gromm authored
The stuctures defined in the most.h header file will be exposed to the kernel once the file is moved out of the staging area. That's why the name is changed into something more descriptive. Reported-by:
-
Christian Gromm authored
This patch renames the core header file core.h to most.h. The intention behind this is to have a meaningful name once this file is moved to the /include/linux directory. Signed-off-by:
-
