- 12 Mar, 2006 1 commit
-
-
Dave Jones authored
We're leaking an skb in a failure path in this function. Coverity #632 Signed-off-by:
Dave Jones <davej@redhat.com> Signed-off-by:
David S. Miller <davem@davemloft.net>
-
- 11 Mar, 2006 28 commits
-
-
Linus Torvalds authored
Gaah. Delayed. But all the better for it!
-
Andrew Morton authored
- Don't call eisa_driver_unregister() if eisa_driver_register() failed. - Properly propagate error values. Signed-off-by:
Andrew Morton <akpm@osdl.org> Signed-off-by:
Jeff Garzik <jeff@garzik.org>
-
Sam Ravnborg authored
In latest -mm de620 gave following warning: WARNING: drivers/net/de620.o - Section mismatch: reference to \ .init.text:de620_probe from .text between 'init_module' (at offset \ 0x1682) and 'cleanup_module' init_module() call de620_probe() which is declared __init. Fix is to declare init_module() __init too. Signed-off-by:
Sam Ravnborg <sam@ravnborg.org> Signed-off-by:
-
Jesper Juhl authored
Improve reference to PCI NE2K support in ISA NE2K documentation. Original 2.4 patch From: Ged Haywood <ged@jubileegroup.co.uk> Signed-off-by:
Jesper Juhl <jesper.juhl@gmail.com> Signed-off-by:
-
Jon Mason authored
This patch fixes an error in the dl2k driver's DMA mapping/unmapping. The adapter uses the upper 16bits of the DMA address for the buffer size. However, this is not masked off when referencing the DMA address, and can lead to errors by trying to free a DMA address out of range. Thanks, Jon Signed-off-by:
Jon Mason <jdmason@us.ibm.com> Signed-off-by:
-
David S. Miller authored
For some reason, E1000's ->hard_start_xmit() routine returns -EFAULT instead of one of the NETDEV_TX_* error codes. In fact, it frees up the SKB before returning this. This makes the queueing layer think the packet should be requeued and subsequently we corrupt a freed object. Signed-off-by:
-
-
Antonino A. Daplas authored
radeonfb_parse_monitor_layout() will produce an array overrun if passed with a substring of length higher than 4 (ie, "XXXXX,YYYYYY"). Coverity Bug 494 Signed-off-by:
Antonino Daplas <adaplas@pol.net> Signed-off-by:
Linus Torvalds <torvalds@osdl.org>
-
Antonino A. Daplas authored
Fix static array overrun Coverity Bug 556 Signed-off-by:
-
Antonino A. Daplas authored
The pseudo_palette has room only for 16 entries, but tdfxfb_setcolreg may attempt to write more. Coverity Bug 557 Signed-off-by:
-
Antonino A. Daplas authored
The pseudo_palette has room only for 16 entries, but intelfb_setcolreg will attempt to write more. Coverity Bug 558 Signed-off-by:
-
Antonino A. Daplas authored
par->edid is kfree'd before using in fb_edid_to_monspecs() Signed-off-by:
-
Antonino A. Daplas authored
The struct info and device resource may not be released in the driver's error path. Fix. Coverity Bug 671 Signed-off-by:
-
Antonino A. Daplas authored
struct info may not be released in the driver's error path. Coverity Bug 672 Signed-off-by:
-
Antonino A. Daplas authored
info->par is dereferenced before info is checked for NULL. Fix. Coverity Bug 833 Signed-off-by:
-
Antonino A. Daplas authored
Initialize Variable 'count' in DisableVGA to zero. Coverity Bug 874 Signed-off-by:
-
Antonino A. Daplas authored
Remove insignificant and uninitialized variable "count" from arcfb_lcd_update_page. Coverity Bug 894 Signed-off-by:
-
Antonino A. Daplas authored
Remove insignificant and unitialized variable "waitcycles" from neo2200_sync. Coverity Bug 895 Signed-off-by:
-
Chris Wright authored
LSM mail list has moved. Signed-off-by:
Chris Wright <chrisw@sous-sol.org> Signed-off-by:
-
Chris Wright authored
Update email address. Signed-off-by:
-
Christoph Hellwig authored
The patch '[PATCH] RCU signal handling' [1] added an export for __put_task_struct_cb, a put_task_struct helper newly introduced in that patch. But the put_task_struct couldn't be used modular previously as __put_task_struct wasn't exported. There are not callers of it in modular code, and it shouldn't be exported because we don't want drivers to hold references to task_structs. This patch removes the export and folds __put_task_struct into __put_task_struct_cb as there's no other caller. [1] http://www2.kernel.org/git/gitweb.cgi?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=e56d090310d7625ecb43a1eeebd479f04affb48bSigned-off-by:
Christoph Hellwig <hch@lst.de> Acked-by:
Paul E. McKenney <paulmck@us.ibm.com> Signed-off-by:
-
Pat Gefre authored
Get rid of the local 'flip' variable and no need to 'trim' the buffer. Signed-off-by:
Patrick Gefre <pfg@sgi.com> Signed-off-by:
-
Stephen Smalley authored
Fix SELinux to not reset the tracer SID when the child is already being traced, since selinux_ptrace is also called by proc for access checking outside of the context of a ptrace attach. Signed-off-by:
Stephen Smalley <sds@tycho.nsa.gov> Acked-by:
James Morris <jmorris@namei.org> Acked-by:
-
Arjan van de Ven authored
Disable (via ugly #if 0's) the 3 sysfs files that I think by now we all agree are very much wrong. These files shouldn't become part of the ABI by the 2.6.16 release, so I rather have this minimal patch merged to disable them for now, the real fix can then come during the 2.6.17 devel window. Signed-off-by:
Arjan van de Ven <arjan@linux.intel.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@suse.de> Signed-off-by:
-
Badari Pulavarty authored
One can do "chattr +j" on a file to change its journalling mode. Fix writeback mode with "nobh" handling for it. Even though, we mount ext3 filesystem in writeback mode with "nobh" option, some one can do "chattr +j" on a single file to force it to do journalled mode. In order to do journaling, ext3_block_truncate_page() need to fallback to default case of creating buffers and adding them to transaction etc. Signed-off-by:
Badari Pulavarty <pbadari@us.ibm.com> Signed-off-by:
-
Kirill Korotaev authored
This patch fixes illegal __GFP_FS allocation inside ext3 transaction in ext3_symlink(). Such allocation may re-enter ext3 code from try_to_free_pages. But JBD/ext3 code keeps a pointer to current journal handle in task_struct and, hence, is not reentrable. This bug led to "Assertion failure in journal_dirty_metadata()" messages. http://bugzilla.openvz.org/show_bug.cgi?id=115Signed-off-by:
Andrey Savochkin <saw@saw.sw.com.sg> Signed-off-by:
Kirill Korotaev <dev@openvz.org> Signed-off-by:
-
Dmitry Torokhov authored
Automatic resynchronization in psmouse driver causes problems on some hardware so disable it by default for now. People with KVM switches that require resync can still enable it via module parameter or sysfs attribute. Signed-off-by:
Dmitry Torokhov <dtor@mail.ru> Signed-off-by:
-
git://git.kernel.org/pub/scm/linux/kernel/git/aegl/linux-2.6Linus Torvalds authored
* 'release' of git://git.kernel.org/pub/scm/linux/kernel/git/aegl/linux-2.6: [IA64] Fix race in the accessed/dirty bit handlers
-
- 10 Mar, 2006 11 commits
-
-
Jan Beulich authored
Rebuilding a previously built tree while using make's -j option from time to time results in the version.h check running at the same time as the updating of .kernelrelease, resulting in UTS_RELEASE remaining an empty string (and as a side effect causing the entire kernel to be rebuilt). Signed-Off-By:
Jan Beulich <jbeulich@novell.com> Signed-off-by:
-
Hugh Dickins authored
Fix pcmcia_device_probe NULL pointer dereference at startup. Signed-off-by:
Hugh Dickins <hugh@veritas.com> Signed-off-by:
-
Christoph Lameter authored
The cache reaper currently tries to free all alien caches and all remote per cpu pages in each pass of cache_reap. For a machines with large number of nodes (such as Altix) this may lead to sporadic delays of around ~10ms. Interrupts are disabled while reclaiming creating unacceptable delays. This patch changes that behavior by adding a per cpu reap_node variable. Instead of attempting to free all caches, we free only one alien cache and the per cpu pages from one remote node. That reduces the time spend in cache_reap. However, doing so will lengthen the time it takes to completely drain all remote per cpu pagesets and all alien caches. The time needed will grow with the number of nodes in the system. All caches are drained when they overflow their respective capacity. So the drawback here is only that a bit of memory may be wasted for awhile longer. Details: 1. Rename drain_remote_pages to drain_node_pages to allow the specification of the node to drain of pcp pages. 2. Add additional functions init_reap_node, next_reap_node for NUMA that manage a per cpu reap_node counter. 3. Add a reap_alien function that reaps only from the current reap_node. For us this seems to be a critical issue. Holdoffs of an average of ~7ms cause some HPC benchmarks to slow down significantly. F.e. NAS parallel slows down dramatically. NAS parallel has a 12-16 seconds runtime w/o rotor compared to 5.8 secs with the rotor patches. It gets down to 5.05 secs with the additional interrupt holdoff reductions. Signed-off-by:
Christoph Lameter <clameter@sgi.com> Signed-off-by:
-
Roman Zippel authored
We require that all archs implement atomic_cmpxchg(), for the generic version of atomic_add_unless(). Signed-off-by:
Roman Zippel <zippel@linux-m68k.org> Cc: Geert Uytterhoeven <geert@linux-m68k.org> Cc: Adrian Bunk <bunk@stusta.de> Signed-off-by:
-
Horst Hummel authored
This fixes a typo introduced with 90f0094d. Signed-off-by:
Horst Hummel <horst.hummel@de.ibm.com> Signed-off-by:
Heiko Carstens <heiko.carstens@de.ibm.com> Signed-off-by:
-
Yasunori Goto authored
When pages are onlined, not only zone->present_pages but also pgdat->node_present_pages should be refreshed. This parameter is used to show information at /sys/device/system/node/nodeX/meminfo via si_meminfo_node(). So, it shows strange value for MemUsed which is calculated (node_present_pages - all zones free pages). Signed-off-by:
Yasunori Goto <y-goto@jp.fujitsu.com> Cc: Dave Hansen <haveblue@us.ibm.com> Signed-off-by:
-
Tim Small authored
EDAC is still causing a few problems and the code is relatively green. Mark it as experimental until thing settle down. Also, provide some documentation pointers in Kconfig help. Signed-off-by:
Tim Small <tim@buttersideup.com> Signed-off-by:
-
Christian Ehrhardt authored
Currently the code tries up to spin_retry times to grab a lock using the cs instruction. The cs instruction has exclusive access to a memory region and therefore invalidates the appropiate cache line of all other cpus. If there is contention on a lock this leads to cache line trashing. This can be avoided if we first check wether a cs instruction is likely to succeed before the instruction gets actually executed. Signed-off-by:
Christian Ehrhardt <ehrhardt@de.ibm.com> Signed-off-by:
Martin Schwidefsky <schwidefsky@de.ibm.com> Signed-off-by:
-
Max Asbock authored
The kobject_put() can free the memory at *cmd, but cmd->lock points to a persistent lock that is not freed with cmd. Signed-off-by:
Max Asbock <masbock@us.ibm.com> Cc: Vernon Mauery <vernux@us.ibm.com> Cc: Srihari Vijayaraghavan <sriharivijayaraghavan@yahoo.com.au> Signed-off-by:
-
Christoph Lameter authored
If the process has already set PF_MALLOC and is already using current->reclaim_state then do not try to reclaim memory from the zone. This is set by kswapd and/or synchrononous global reclaim which will not take it lightly if we zap the reclaim_state. Signed-off-by:
Christoph Lameter <clameter@sig.com> Signed-off-by:
-
NeilBrown authored
- wrong test for 'is this a BARRIER bio' - not freeing on all possible paths. - using r1_bio after freeing it. Signed-off-by:
Neil Brown <neilb@suse.de> Signed-off-by:
-
