- 19 Mar, 2012 40 commits
-
-
Guenter Roeck authored
Fixed: ERROR: do not use assignment in if condition ERROR: space prohibited after that open parenthesis '(' ERROR: space prohibited before that close parenthesis ')' ERROR: space required after that ',' (ctx:VxV) ERROR: spaces required around that '<' (ctx:VxV) ERROR: spaces required around that '==' (ctx:VxV) ERROR: trailing statements should be on next line ERROR: trailing whitespace ERROR: Macros with multiple statements should be enclosed in a do - while loop WARNING: line over 80 characters WARNING: please, no space before tabs WARNING: please, no spaces at the start of a line WARNING: simple_strtol is obsolete, use kstrtol instead WARNING: simple_strtoul is obsolete, use kstrtoul instead Modify multi-line comments to follow Documentation/CodingStyle. Cc: Aurelien Jarno <aurelien@aurel32.net> Signed-off-by:Guenter Roeck <linux@roeck-us.net>
-
Guenter Roeck authored
Fixed: ERROR: do not use assignment in if condition ERROR: spaces required around that ':' (ctx:VxV) ERROR: spaces required around that '?' (ctx:VxV) WARNING: line over 80 characters WARNING: simple_strtoul is obsolete, use kstrtoul instead Modify multi-line comments to follow Documentation/CodingStyle. Cc: Aurelien Jarno <aurelien@aurel32.net> Signed-off-by: -
Guenter Roeck authored
Fixed: ERROR: code indent should use tabs where possible ERROR: do not use assignment in if condition ERROR: else should follow close brace '}' ERROR: space prohibited after that open parenthesis '(' ERROR: space required after that ',' (ctx:VxV) ERROR: spaces required around that '<=' (ctx:VxV) ERROR: spaces required around that '<' (ctx:VxV) ERROR: spaces required around that '==' (ctx:VxV) ERROR: spaces required around that '=' (ctx:VxV) ERROR: spaces required around that ':' (ctx:VxW) ERROR: trailing statements should be on next line WARNING: braces {} are not necessary for any arm of this statement WARNING: do not add new typedefs WARNING: please, no space before tabs WARNING: simple_strtol is obsolete, use kstrtol instead WARNING: simple_strtoul is obsolete, use kstrtoul instead Modify multi-line comments to follow Documentation/CodingStyle. Not fixed (unknown impact): WARNING: msleep < 20ms can sleep for up to 20ms Cc: Mark M. Hoffman <mhoffman@lightlink.com> Signed-off-by: -
Guenter Roeck authored
Fixed: ERROR: code indent should use tabs where possible ERROR: do not use assignment in if condition ERROR: spaces required around that '<' (ctx:VxV) ERROR: spaces required around that '=' (ctx:VxV) ERROR: spaces required around that '*=' (ctx:VxV) ERROR: trailing whitespace WARNING: line over 80 characters WARNING: please, no space before tabs WARNING: please, no spaces at the start of a line WARNING: simple_strtol is obsolete, use kstrtol instead Modify multi-line comments to follow Documentation/CodingStyle. Cc: Jean Delvare <khali@linux-fr.org> Signed-off-by: -
Guenter Roeck authored
Fix checkpatch issue: ERROR: do not use assignment in if condition Replace repeated calls to device_create_file() with calls to sysfs_create_group. Cc: Jean Delvare <khali@linux-fr.org> Signed-off-by:
Jean Delvare <khali@linux-fr.org>
-
Guenter Roeck authored
Fixed: ERROR: do not use assignment in if condition ERROR: space required after that close brace '}' ERROR: space required after that ',' (ctx:VxV) ERROR: spaces required around that '<' (ctx:VxV) ERROR: trailing statements should be on next line WARNING: line over 80 characters WARNING: simple_strtol is obsolete, use kstrtol instead WARNING: simple_strtoul is obsolete, use kstrtoul instead Modify multi-line comments to follow Documentation/CodingStyle. Not fixed everywhere (code complexity): ERROR: do not use assignment in if condition As a side effect of the changes made, attribute set functions now return an error if an attempt is made to write non-numeric values. Previously, such writes were interpreted as writing 0. Cc: Jean Delvare <khali@linux-fr.org> Signed-off-by:
-
Guenter Roeck authored
Fixed: ERROR: that open brace { should be on the previous line ERROR: trailing statements should be on next line WARNING: line over 80 characters WARNING: simple_strtol is obsolete, use kstrtol instead WARNING: simple_strtoul is obsolete, use kstrtoul instead Modify multi-line comments to follow Documentation/CodingStyle. Cc: Hans de Goede <hdegoede@redhat.com> Signed-off-by: -
Guenter Roeck authored
Fixed: ERROR: code indent should use tabs where possible ERROR: do not use assignment in if condition ERROR: else should follow close brace '}' ERROR: "foo * bar" should be "foo *bar" WARNING: braces {} are not necessary for single statement blocks WARNING: line over 80 characters WARNING: please, no space before tabs WARNING: please, no spaces at the start of a line WARNING: simple_strtoul is obsolete, use kstrtoul instead Modify multi-line comments to follow Documentation/CodingStyle. Cc: Sebastian Witt <se.witt@gmx.net> Signed-off-by: -
Guenter Roeck authored
Fixed: ERROR: that open brace { should be on the previous line WARNING: please, no space before tabs Cc: Darrick J. Wong <djwong@us.ibm.com> Signed-off-by: -
Guenter Roeck authored
Cc: Ira W. Snyder <iws@ovro.caltech.edu> Signed-off-by:
Ira W. Snyder <iws@ovro.caltech.edu>
-
Guenter Roeck authored
Cc: Ira W. Snyder <iws@ovro.caltech.edu> Signed-off-by:
-
Guenter Roeck authored
Constify fixed string array and make checkpatch happy. Cc: Mark Brown <broonie@opensource.wolfsonmicro.com> Signed-off-by:
Mark Brown <broonie@opensource.wolfsonmicro.com>
-
Guenter Roeck authored
Cc: Henrik Rydberg <rydberg@euromail.se> Signed-off-by:
Henrik Rydberg <rydberg@euromail.se>
-
Guenter Roeck authored
Cc: Luca Tettamanti <kronos.it@gmail.com> Signed-off-by:
Luca Tettamanti <kronos.it@gmail.com>
-
Guenter Roeck authored
Make checkpatch happy by constifying fixed string arrays. Cc: Jean Delvare <khali@linux-fr.org> Signed-off-by:
-
Guenter Roeck authored
Cc: Stefan Roese <sr@denx.de> Signed-off-by:
Stefan Roese <sr@denx.de>
-
Guenter Roeck authored
Signed-off-by: -
Guenter Roeck authored
Fix: ERROR: Macros with complex values should be enclosed in parenthesis Cc: Fenghua Yu <fenghua.yu@intel.com> Acked-By:
Durgadoss R <durgadoss.r@intel.com> Signed-off-by:
-
Guenter Roeck authored
Cc: Jim Cromie <jim.cromie@gmail.com> Acked-by:
Jim Cromie <jim.cromie@gmail.com> Signed-off-by:
-
Guenter Roeck authored
Acked-by:
-
Guenter Roeck authored
Fix: ERROR: Macros with complex values should be enclosed in parenthesis Also updated multi-line comments to follow Documentation/CodingStyle. Signed-off-by: -
Guenter Roeck authored
Cc: George Joseph <george.joseph@fairview5.com> Acked-by:
George Joseph <george.joseph@fairview5.com> Signed-off-by:
-
Guenter Roeck authored
Fix multi-line comments, and clean up some of the affected comments. Cc: Jean Delvare <khali@linux-fr.org> Acked-by:
-
Guenter Roeck authored
Acked-by:
-
Guenter Roeck authored
Acked-by:
-
Guenter Roeck authored
Fixed: ERROR: code indent should use tabs where possible ERROR: do not use assignment in if condition ERROR: trailing whitespace WARNING: labels should not be indented WARNING: please, no spaces at the start of a line WARNING: simple_strtol is obsolete, use kstrtol instead Also modified multi-line comments to follow Documentation/CodingStyle. Signed-off-by:
-
Axel Lin authored
This patch converts the drivers in drivers/hwmon/* to use the module_spi_driver() macro which makes the code smaller and a bit simpler. Signed-off-by:
Axel Lin <axel.lin@gmail.com> Cc: Sonic Zhang <sonic.zhang@analog.com> Cc: Marc Pignat <marc.pignat@hevs.ch> Cc: Paul Thomas <pthomas8589@gmail.com> Cc: Eric Miao <eric.y.miao@gmail.com> Acked-by:
Sonic Zhang <sonic.zhang@analog.com> Signed-off-by:
Guenter Roeck <guenter.roeck@ericsson.com>
-
Axel Lin authored
This patch converts the drivers in drivers/hwmon/* to use the module_i2c_driver() macro which makes the code smaller and a bit simpler. Signed-off-by:
-
Guenter Roeck authored
Cc: Roger Lucas <vt8231@hiddenengine.co.uk> Acked-by:
Roger Lucas <vt8231@hiddenengine.co.uk> Signed-off-by:
-
Guenter Roeck authored
Cc: Jean Delvare <khali@linux-fr.org> Acked-by:
-
Guenter Roeck authored
Fixed: ERROR: code indent should use tabs where possible ERROR: do not use assignment in if condition ERROR: "foo* bar" should be "foo *bar" ERROR: need consistent spacing around '|' (ctx:VxW) WARNING: simple_strtol is obsolete, use kstrtol instead WARNING: simple_strtoul is obsolete, use kstrtoul instead WARNING: static const char * array should probably be static const char * const Also modified multi-line comments to follow Documents/Codingstyle. Cc: Jean Delvare <khali@linux-fr.org> Signed-off-by:
-
Guenter Roeck authored
Cc: Hans J. Koch <hjk@hansjkoch.de> Acked-by:
Hans J. Koch <hjk@hansjkoch.de> Signed-off-by:
-
Guenter Roeck authored
Fixed: ERROR: code indent should use tabs where possible ERROR: do not use assignment in if condition ERROR: "foo* bar" should be "foo *bar" ERROR: space prohibited after that open parenthesis '(' ERROR: space required after that ',' (ctx:VxV) ERROR: spaces required around that '==' (ctx:VxV) WARNING: line over 80 characters WARNING: simple_strtol is obsolete, use kstrtol instead WARNING: simple_strtoul is obsolete, use kstrtoul instead WARNING: space prohibited between function name and open parenthesis '(' Not fixed (false positive): ERROR: Macros with multiple statements should be enclosed in a do - while loop ERROR: Macros with complex values should be enclosed in parenthesis Not all fixed (code complexity): ERROR: do not use assignment in if condition Acked-by: -
Guenter Roeck authored
Fixed: ERROR: do not use assignment in if condition ERROR: space required after that ',' (ctx:VxV) ERROR: spaces required around that '<' (ctx:VxV) ERROR: spaces required around that '=' (ctx:VxV) ERROR: trailing whitespace WARNING: simple_strtol is obsolete, use kstrtol instead WARNING: simple_strtoul is obsolete, use kstrtoul instead Not fixed: ERROR: Macros with multiple statements should be enclosed in a do - while loop Acked-by:
-
Guenter Roeck authored
Fixed: ERROR: do not use assignment in if condition ERROR: "foo* bar" should be "foo *bar" WARNING: line over 80 characters Not fixed: WARNING: msleep < 20ms can sleep for up to 20ms Cc: Hans de Goede <hdegoede@redhat.com> Reviewed-by:
Robert Coulson <robert.coulson@ericsson.com> Signed-off-by:
-
Guenter Roeck authored
Fixed: ERROR: code indent should use tabs where possible ERROR: do not use assignment in if condition ERROR: trailing statements should be on next line WARNING: braces {} are not necessary for any arm of this statement WARNING: line over 80 characters WARNING: please, no space before tabs WARNING: simple_strtol is obsolete, use kstrtol instead WARNING: simple_strtoul is obsolete, use kstrtoul instead Not fixed (false positive): ERROR: Macros with multiple statements should be enclosed in a do - while loop Cc: Roger Lucas <vt8231@hiddenengine.co.uk> Acked-by: -
Guenter Roeck authored
Fixed: ERROR: do not use assignment in if condition ERROR: open brace '{' following struct go on the same line ERROR: spaces required around that '||' (ctx:VxV) ERROR: switch and case should be at the same indent WARNING: simple_strtoul is obsolete, use kstrtoul instead Cc: Hans J. Koch <hjk@hansjkoch.de> Acked-by: -
Guenter Roeck authored
strict_strtol is deprecated and results in a checkpatch warning. Replace it with kstrtol. Acked-by:
-
Frans Meulenbroeks authored
resolved: ERROR: trailing whitespace WARNING: please, no spaces at the start of a line WARNING: simple_strtol is obsolete, use kstrtol instead ERROR: do not use assignment in if condition Signed-off-by:
Frans Meulenbroeks <fransmeulenbroeks@gmail.com> Signed-off-by:
-
Frans Meulenbroeks authored
resolved: WARNING: line over 80 characters ERROR: do not use assignment in if condition Signed-off-by:
-
