1. 23 Jan, 2013 2 commits
    • Mauro Carvalho Chehab's avatar
      [media] dvb: Add DVBv5 statistics properties · 9569793a
      Mauro Carvalho Chehab authored
      The DVBv3 statistics parameters are limited on several ways:
              - It doesn't provide any way to indicate the used measure,
      	  so userspace need to guess how to calculate/use it;
              - Only a limited set of stats are supported;
              - Can't be called in a way to require them to be filled
                all at once (atomic reads from the hardware), with may
                cause troubles on interpreting them on userspace;
              - On some OFDM delivery systems, the carriers can be
                independently modulated, having different properties.
                Currently, there's no way to report per-layer stats.
      To address the above issues, adding a new DVBv5-based stats API.
      While here, correct inner code nomenclature on a few places.
      Reviewed-by: default avatarAntti Palosaari <crope@iki.fi>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      9569793a
    • Mauro Carvalho Chehab's avatar
      [media] mb86a20s: don't use state before initializing it · f167e302
      Mauro Carvalho Chehab authored
      As reported by Feng's kbuild test:
      	From: kbuild test robot <fengguang.wu@intel.com>
      	Subject: drivers/media/dvb-frontends/mb86a20s.c:706 mb86a20s_attach() error: potential null dereference 'state'.  (kzalloc returns null)
      	Date: Wed, 23 Jan 2013 19:30:43 +0800
      
      	commit: f66d81b5 [media] mb86a20s: convert it to use dev_info/dev_err/dev_dbg
      
      	drivers/media/dvb-frontends/mb86a20s.c:706 mb86a20s_attach() error: potential null dereference 'state'.  (kzalloc returns null)
      	drivers/media/dvb-frontends/mb86a20s.c:706 mb86a20s_attach() error: we previously assumed 'state' could be null (see line 705)
      
      As, at mb86a20s_attach(), we have an i2c pointer, use it for all printk
      messages there, instead of state->i2c.
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      f167e302
  2. 22 Jan, 2013 7 commits
  3. 11 Jan, 2013 2 commits
    • Stephen Rothwell's avatar
      [media] media: remove __dev* annotations · 3151d14a
      Stephen Rothwell authored
      Hi Mauro,
      After merging the v4l-dvb tree, today's linux-next build (x86_64
      allmodconfig) failed like this:
      drivers/media/platform/sh_veu.c:1146:22: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'sh_veu_probe'
      drivers/media/platform/sh_veu.c:1228:22: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'sh_veu_remove'
      drivers/media/platform/sh_veu.c:1244:2: error: implicit declaration of function '__devexit_p' [-Werror=implicit-function-declaration]
      drivers/media/platform/sh_veu.c:1244:25: error: 'sh_veu_remove' undeclared here (not in a function)
      drivers/media/platform/sh_veu.c: In function 'sh_veu_init':
      drivers/media/platform/sh_veu.c:1253:45: error: 'sh_veu_probe' undeclared (first use in this function)
      drivers/media/platform/sh_veu.c:1253:45: note: each undeclared identifier is reported only once for each function it appears in
      drivers/media/platform/sh_veu.c: At top level:
      drivers/media/platform/sh_veu.c:1095:20: warning: 'sh_veu_bh' defined but not used [-Wunused-function]
      drivers/media/platform/sh_veu.c:1109:20: warning: 'sh_veu_isr' defined but not used [-Wunused-function]
      drivers/media/platform/sh_veu.c: In function 'sh_veu_init':
      drivers/media/platform/sh_veu.c:1254:1: warning: control reaches end of non-void function [-Wreturn-type]
      Caused by commit 05efa71b ("[media] media: add a VEU MEM2MEM format
      conversion and scaling driver") interacting with commit 54b956b9
      ("Remove __dev* markings from init.h") from the driver-core.current tree.
      I have applied the following merge fix patch which could be applied
      directly to the v4l-dvb tree (please):
      CONFIG_HOTPLUG is always true now and the __dev* macros have meen removed.
      
      Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
      Signed-off-by: default avatarStephen Rothwell <sfr@canb.auug.org.au>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      3151d14a
    • Mauro Carvalho Chehab's avatar
      [media] extract_xc3028.pl: fix permissions · 978ae224
      Mauro Carvalho Chehab authored
      This is an executable file. Change permissions to reflect it.
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      978ae224
  4. 06 Jan, 2013 29 commits