1. 18 Mar, 2020 3 commits
    • Wambui Karuga's avatar
      drm/i915/fbc: convert to drm_device based logging macros. · 97ed48b5
      Wambui Karuga authored
      This replaces the uses of the printk based drm logging macros with the
      struct drm_device based logging macros in i915/display/intel_fbc.c.
      This transformation was done using the following coccinelle semantic
      patch that matches based on the existence of a drm_i915_private device
      pointer:
      @@
      identifier fn, T;
      @@
      
      fn(...,struct drm_i915_private *T,...) {
      <+...
      (
      -DRM_INFO(
      +drm_info(&T->drm,
      ...)
      |
      -DRM_ERROR(
      +drm_err(&T->drm,
      ...)
      |
      -DRM_WARN(
      +drm_warn(&T->drm,
      ...)
      |
      -DRM_DEBUG(
      +drm_dbg(&T->drm,
      ...)
      |
      -DRM_DEBUG_DRIVER(
      +drm_dbg(&T->drm,
      ...)
      |
      -DRM_DEBUG_KMS(
      +drm_dbg_kms(&T->drm,
      ...)
      |
      -DRM_DEBUG_ATOMIC(
      +drm_dbg_atomic(&T->drm,
      ...)
      )
      ...+>
      }
      
      @@
      identifier fn, T;
      @@
      
      fn(...) {
      ...
      struct drm_i915_private *T = ...;
      <+...
      (
      -DRM_INFO(
      +drm_info(&T->drm,
      ...)
      |
      -DRM_ERROR(
      +drm_err(&T->drm,
      ...)
      |
      -DRM_WARN(
      +drm_warn(&T->drm,
      ...)
      |
      -DRM_DEBUG(
      +drm_dbg(&T->drm,
      ...)
      |
      -DRM_DEBUG_KMS(
      +drm_dbg_kms(&T->drm,
      ...)
      |
      -DRM_DEBUG_DRIVER(
      +drm_dbg(&T->drm,
      ...)
      |
      -DRM_DEBUG_ATOMIC(
      +drm_dbg_atomic(&T->drm,
      ...)
      )
      ...+>
      }
      
      New checkpatch warnings were addressed manually.
      
      v2 by Jani:
      - also convert pr_info_once to drm based logging
      Signed-off-by: default avatarWambui Karuga <wambui.karugax@gmail.com>
      Signed-off-by: default avatarJani Nikula <jani.nikula@intel.com>
      Reviewed-by: default avatarWambui Karuga <wambui.karugax@gmail.com>
      Link: https://patchwork.freedesktop.org/patch/msgid/32a92f1d4e4d01131605b17bec831517e39c5902.1583766715.git.jani.nikula@intel.com
      97ed48b5
    • Swati Sharma's avatar
      drm/i915/color: Extract icl_read_luts() · b4ab7aa8
      Swati Sharma authored
      For icl+, have hw read out to create hw blob of gamma
      lut values. icl+ platforms supports multi segmented gamma
      mode by default, add hw lut creation for this mode.
      
      This will be used to validate gamma programming using dsb
      (display state buffer) which is a tgl specific feature.
      
      v2: -readout code for multisegmented gamma has to come
           up with some intermediate entries that aren't preserved
           in hardware (Jani N)
          -linear interpolation (Ville)
          -moved common code to check gamma_enable to specific funcs,
           since icl doesn't support that
      v3: -use u16 instead of __u16 [Jani N]
          -used single lut [Jani N]
          -improved and more readable for loops [Jani N]
          -read values directly to actual locations and then fill gaps [Jani N]
          -moved cleaning to patch 1 [Jani N]
          -renamed icl_read_lut_multi_seg() to icl_read_lut_multi_segment to
           make it similar to icl_load_luts()
          -renamed icl_compute_interpolated_gamma_blob() to
           icl_compute_interpolated_gamma_lut_values() more sensible, I guess
      v4: -removed interpolated func for creating gamma lut values
          -removed readouts of fine and coarse segments, failure to read PAL_PREC_DATA
           correctly
      v5: -added gamma_enable check inside read_luts()
      v6: -renamed intel_color_lut_entry_equal() to intel_color_lut_entries_equal() [Ville]
          -changed if-else to switch [Ville]
          -removed intel_color_lut_entry_multi_equal() [Ville]
      v7: -checkpatch warnings
      v8: -rebased
      v9: -rebased, aligned with Ville's style of gamma cleanup
      Signed-off-by: default avatarSwati Sharma <swati2.sharma@intel.com>
      Reviewed-by: default avatarMika Kahola <mika.kahola@intel.com>
      Signed-off-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
      Link: https://patchwork.freedesktop.org/patch/msgid/20200317135736.14305-1-swati2.sharma@intel.com
      b4ab7aa8
    • Anshuman Gupta's avatar
      drm/i915: Enable non-contiguous pipe fusing · 0a7ada19
      Anshuman Gupta authored
      As we have already enabled supported infrastructure for
      non-contiguous pipe fusing in driver, we don't require non-contiguous
      pipe_mask check anymore.
      It is an unlike condition, it make sense to remove this condition.
      
      changes since RFC:
      - using intel_pipe_mask_is_valid() function to check integrity of
        pipe_mask. [Ville]
      v2:
      - simplify condition in intel_pipe_mask_is_valid(). [Ville]
      v3:
      - removed non-contiguous pipe fusing check. [Lucas]
      
      Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
      Cc: Lucas De Marchi <lucas.demarchi@intel.com>
      Reviewed-by: default avatarLucas De Marchi <lucas.demarchi@intel.com>
      Signed-off-by: default avatarAnshuman Gupta <anshuman.gupta@intel.com>
      Signed-off-by: default avatarUma Shankar <uma.shankar@intel.com>
      Link: https://patchwork.freedesktop.org/patch/msgid/20200318094448.26239-1-anshuman.gupta@intel.com
      0a7ada19
  2. 17 Mar, 2020 8 commits
  3. 16 Mar, 2020 4 commits
  4. 15 Mar, 2020 1 commit
  5. 14 Mar, 2020 1 commit
  6. 13 Mar, 2020 8 commits
  7. 12 Mar, 2020 5 commits
  8. 11 Mar, 2020 10 commits