- 16 Mar, 2017 31 commits
-
-
Tobin C. Harding authored
Driver code uses custom return values (often positive) to signal error condition instead of using standard kernel error codes. Replace custom return values with standard kernel error codes. Signed-off-by:
Tobin C. Harding <me@tobin.cc> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Tobin C. Harding authored
Bug introduced in commit 7676b724 by Tobin C. Harding. Remove equals sign from comparison, fixing off by one error. Fixes: 7676b724 ("staging: ks7010: move comparison to right hand side") Reported-by:
Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by:
-
Dan Carpenter authored
It's a post-op loop so we timeout with "max_wait" set to -1, not 0. Fixes: a49d2536 ("staging/atomisp: Add support for the Intel IPU v2") Signed-off-by:
-
Gargi Sharma authored
This patch removes multiple assignments by factorizing them. This was done with Coccinelle for the if branch. For the else part the change was done manually since Coccinelle only detects constants. Braces were also added to the else part to remove the checkpatch warning, "braces should be on all arms of if-else statements". @@ identifier i1,i2; constant c; @@ - i1=i2=c; + i1=c; + i2=c; Signed-off-by:
Gargi Sharma <gs051095@gmail.com> Signed-off-by:
-
Andrii Vladyka authored
Fix 'multiple blank lines' coding style problem reported by checkpatch.pl. Signed-off-by:
Andrii Vladyka <tulup@mail.ru> Signed-off-by:
-
Dan Carpenter authored
We converted these conditions from == NULL and != NULL but messed up and inverted some. Fixes: e31447f9 ("staging: rtl8188eu: Replace x==NULL by !x") Signed-off-by:
-
Gargi Sharma authored
Using typedef for a structure type and upper case struct names is not suggested in Linux kernel coding style guidelines. Hence, occurences of typedefs have been removed and struct names converted to lowercase in the file. Grep was also used to ensure that all occurence of the typedefs have been removed. The module compiles without any warnings or errors. Script 1: @r1@ type T; @@ typedef struct { ... } T; @script:python c1@ T2; T << r1.T; @@ if T[-2:] =="_T": coccinelle.T2 = T[:-2].lower(); print T else: coccinelle.T2=T.lower(); @r2@ type r1.T; identifier c1.T2; @@ -typedef struct + T2 { ... } -T ; @r3@ type r1.T; identifier c1.T2; @@ - T + struct T2 Script 2: @@ typedef VCHIQ_ELEMENT_T; @@ ( - VCHIQ_ELEMENT_T + struct vchiq_element ) Signed-off-by: -
Gargi Sharma authored
The function prototype is for a function that is not even in the kernel, and hence has been removed. The type VCHIQ_SHARED_MEM_INFO_T is not used anywhere in the kernel as well. Signed-off-by:
-
Jean-Baptiste Abbadie authored
These four functions are not used and report errors with sparse. Signed-off-by:
Jean-Baptiste Abbadie <jb@abbadie.fr> Acked-by:
Stefan Wahren <stefan.wahren@i2se.com> Signed-off-by:
-
Jérémy Lefaure authored
These duplicate includes have been found with scripts/checkincludes.pl but they have been removed manually to avoid removing false positives. Signed-off-by:
Jérémy Lefaure <jeremy.lefaure@lse.epita.fr> Signed-off-by:
-
Jérémy Lefaure authored
When CONFIG_ION is disabled, HMM_BO_LAST is 3. In this case, "i" should not be added in hmm_bo_type_strings. Signed-off-by:
-
Daeseok Youn authored
Fix checkpatch.pl issues in atomisp_cmd.c : "CHECK: Alignment should match open parenthesis" Signed-off-by:
Daeseok Youn <daeseok.youn@gmail.com> Signed-off-by:
-
Daeseok Youn authored
There is no reason to have "#ifdef ISP2401" condition on top of atomisp_cmd.c file Signed-off-by:
-
Daeseok Youn authored
Fix warnings from the smatch tool atomisp_cmd.c:5698 atomisp_set_fmt_to_snr() warn: inconsistent indenting atomisp_cmd.c:5714 atomisp_set_fmt_to_snr() warn: inconsistent indenting Signed-off-by:
-
Daeseok Youn authored
Fix warnings from the smatch tool atomisp_cmd.c:2649 atomisp_set_array_res() warn: unsigned 'config->width' is never less than zero. atomisp_cmd.c:2650 atomisp_set_array_res() warn: unsigned 'config->height' is never less than zero. Signed-off-by:
-
Tahia Khan authored
Repaces pointer comparison to 0 with NULL in ia_css_queue_get_size to improve code readability. Identified with coccinelle script 'badzero.cocci'. Signed-off-by:
Tahia Khan <tahia.khan@gmail.com> Signed-off-by:
-
Tahia Khan authored
Repaces pointer comparison to 0 with NULL in ia_css_queue_dequeue to improve code readability. Identified with coccinelle script 'badzero.cocci'. Signed-off-by:
-
Tahia Khan authored
Repaces pointer comparison to 0 with NULL in ia_css_queue_enqueue to improve code readability. Identified with coccinelle script 'badzero.cocci'. Signed-off-by:
-
Tobias Regnery authored
The ov5693 driver unconditionally uses the entity member of struct v4l2_subdev. However this member is conditionally compiled in if CONFIG_MEDIA_CONTROLLER is set. This results in the following build error if CONFIG_MEDIA_CONTROLLER is not set: drivers/staging/media/atomisp/i2c/ov5693/ov5693.c: In function 'ov5693_remove': drivers/staging/media/atomisp/i2c/ov5693/ov5693.c:1961:31: error: 'struct v4l2_subdev' has no member named 'entity' media_entity_cleanup(&dev->sd.entity); drivers/staging/media/atomisp/i2c/ov5693/ov5693.c:2023:9: error: 'struct v4l2_subdev' has no member named 'entity' dev->sd.entity.function = MEDIA_ENT_F_CAM_SENSOR; ^ drivers/staging/media/atomisp/i2c/ov5693/ov5693.c:2045:39: error: 'struct v4l2_subdev' has no member named 'entity' ret = media_entity_pads_init(&dev->sd.entity, 1, &dev->pad); Add the corresponding Kconfig dependency to solve this error. Signed-off-by:Tobias Regnery <tobias.regnery@gmail.com> Signed-off-by:
-
Dan Carpenter authored
We shouldn't pass devm allocated pointers to kfree() or it leads to a double free. Fixes: a49d2536 ("staging/atomisp: Add support for the Intel IPU v2") Signed-off-by:
-
Dan Carpenter authored
Static checkers complain that we should check if "i" is in bounds before we check if "var8[i]" is a NUL char. This bug is harmless but also easy to fix. Signed-off-by:
-
Dan Carpenter authored
These print an uninitialized value for "opt". Let's just remove the printk. Signed-off-by:
-
Dan Carpenter authored
We should be doing i-- on all error paths but we don't if the loop finishes successfully. I've re-arranged this so that we don't read beyond the end of acc_flag_to_pipe[] array. Fixes: a49d2536 ("staging/atomisp: Add support for the Intel IPU v2") Signed-off-by:
-
Julia Lawall authored
Remove unneeded semicolon. Generated by: scripts/coccinelle/misc/semicolon.cocci Signed-off-by:
Julia Lawall <julia.lawall@lip6.fr> Signed-off-by:
Fengguang Wu <fengguang.wu@intel.com> Signed-off-by:
-
Arushi Singhal authored
Commenting out Code is a Bad Idea. Comments are their to explain the code and how the code achieves its goal and as codes in the comments does not explain what the code is doing so there is no use of commenting them. So in this patch codes in the comments are removed. Signed-off-by:
Arushi Singhal <arushisinghal19971997@gmail.com> Signed-off-by:
-
Arushi Singhal authored
Indentation should always use tabs and never spaces. Signed-off-by:
-
Arushi Singhal authored
Patch fixes the warnings reported by checkpatch.pl for please use a blank line after function/struct/union/enum declarations. Add a blank line after enum and struct declarations. Signed-off-by:
-
Samuel Thibault authored
commit 33590c18 ("speakup: Support spelling unicode characters") mistakenly passed unicode characters to IS_CHAR(), which only supports latin1. Let's assume non-latin1 is lower case, like is done in spell_word(). Signed-off-by:
Samuel Thibault <samuel.thibault@ens-lyon.org> Reviewed-by:
Chris Brannon <chris@the-brannons.com> Signed-off-by:
-
Okash Khawaja authored
This moves call to spk_stop_serial_interrupt() function out of synth_release() and into release() method of specific spk_synth instances. This is because the spk_stop_serial_interrupt() call is specific to current serial i/o implementation. Moving it into each synth's release() method gives the decision of calling spk_stop_serial_interrupt() to that synth. Signed-off-by:
Okash Khawaja <okash.khawaja@gmail.com> Reviewed-by:
-
Okash Khawaja authored
This patch adds spk_io_ops struct which contain those methods whose job is to communicate with synth device. Currently, all comms with external synth device use raw serial i/o. The idea is to group all methods which do the actual communication with external device into this new struct. Then migrating a serial-based synth over to an alternative to raw serial i/o will mean swapping serial spk_io_ops instance with the io_ops instance of the new method, making the migration simpler. At the moment, this struct only contains one method, synth_out but more will be added in future when migrating synths which require input functionality. Also at the moment, synth_out method has one implementation which uses serial i/o. Plan is to add an alternative. Signed-off-by:
-
Okash Khawaja authored
These two functions are always called from a context where spk_synth instance is available. They also use the spk_synth instance but instead of taking it as an argument, they rely on a global spk_synth instance inside synth.c which points to the same synth as the one being passed in as argument. Signed-off-by:
-
- 14 Mar, 2017 9 commits
-
-
Daeseok Youn authored
The dgnc_tty_send_break() has a switch-case condition for msec. It is no use except case -1. Signed-off-by:
-
Daeseok Youn authored
The bd variables in functions are already assigned from ch->ch_bd but it is not used in those functions except checking NULL. The ch->ch_bd could be replaced with bd variable. Signed-off-by:
-
Roy Pledge authored
add Roy Pledge as maintainer of DPIO Signed-off-by:
Roy Pledge <Roy.Pledge@nxp.com> Signed-off-by:
Stuart Yoder <stuart.yoder@nxp.com> Signed-off-by:
-
Roy Pledge authored
The DPIO driver registers with the fsl-mc bus to handle bus-related events for DPIO objects. Key responsibility is mapping I/O regions, setting up interrupt handlers, and calling the DPIO service initialization during probe. Signed-off-by:
Haiying Wang <haiying.wang@nxp.com> Signed-off-by:
-
Roy Pledge authored
The DPIO service interface handles initialization of DPIO objects and exports APIs to be used by other DPAA2 object drivers to perform queuing and buffer management related operations. The service allows registration of callbacks when frames or notifications are received. Signed-off-by:
-
Roy Pledge authored
Add QBman APIs for frame queue and buffer pool operations. Signed-off-by:
-
Roy Pledge authored
Create header for global dpaa2 definitions. Add definitions for dequeue results. Signed-off-by:
-
Roy Pledge authored
Add global definitions for DPAA2 frame descriptors and scatter gather entries. Signed-off-by:
-
Ioana Radulescu authored
Add the command build/parse APIs for operating on DPIO objects through the DPAA2 Management Complex. Signed-off-by:
Ioana Radulescu <ruxandra.radulescu@nxp.com> Signed-off-by:
-
