- 09 Jul, 2014 24 commits
-
-
Pawel Lebioda authored
Fix the following warning reported by checkpatch.pl: WARNING: else is not generally useful after a break or return 235: FILE: drivers/staging/nvec/nvec.c:235 Signed-off-by:
Pawel Lebioda <pawel.lebioda89@gmail.com> Acked-by:
Marc Dietrich <marvin24@gmx.de> Reviewed-by:
Thierry Reding <treding@nvidia.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Pawel Lebioda authored
This patch fixes coding style warnings reported by checkpatch.pl: "Missing a blank line after declarations". Signed-off-by:
-
Daeseok Youn authored
The brd is allocated by kzalloc() in dgnc_found_board() so do not need to set 0 to member variable. Signed-off-by:
Daeseok Youn <daeseok.youn@gmail.com> Signed-off-by:
-
Daeseok Youn authored
dgnc_tty_ioctl() cannot reach the end of function. Signed-off-by:
-
Daeseok Youn authored
The "un->un_open_count" is unsigned variable, so it cannot be less than zero. Signed-off-by:
-
Daeseok Youn authored
Signed-off-by:
-
Daeseok Youn authored
The brd is already checked by earlier function in dgap_init_one(). Signed-off-by:
-
Daeseok Youn authored
Signed-off-by:
-
Daeseok Youn authored
dgap_dl_wait and kme_wait are not used in dgap. Signed-off-by:
-
Daeseok Youn authored
The dgap_init_pci() calls only pci_register_driver(). It doesn't need to make a function for that. Signed-off-by:
-
Daeseok Youn authored
clean up checkpatch.pl warning: WARNING: Missing a blank line after declarations Signed-off-by:
-
Daeseok Youn authored
clean up checkpatch warning: WARNING: void function return statements are not generally useful Signed-off-by:
-
Daeseok Youn authored
clean up checkpatch.pl error: ERROR: "foo* bar" should be "foo *bar" Signed-off-by:
-
Matt Kurz authored
Fix checkpatch.pl warnings due to missing blank line after declarations Signed-off-by:
Matt Kurz <matt@ninezulu.com> Signed-off-by:
-
Tobias Klauser authored
Instead of using an own copy of struct net_device_stats in struct wlandevice, use stats from struct net_device. Also remove the thus unnecessary .ndo_get_stats function, as it would now just return netdev->stats, which is the default in dev_get_stats(). Furthermore, convert prefix increment of stats counters to the more common postfix increment idiom. Signed-off-by:
Tobias Klauser <tklauser@distanz.ch> Signed-off-by:
-
Tobias Klauser authored
The memory for struct net_device private data is allocated using kzalloc/vzalloc in alloc_netdev_mqs, thus there is no need to zero it again in the driver. Signed-off-by:
-
Tobias Klauser authored
Instead of using an own copy of struct net_device_stats in struct nic, use stats from struct net_device. Also remove the thus unnecessary .ndo_get_stats function, as it would now just return netdev->stats, which is the default in dev_get_stats(). Signed-off-by:
-
Ben Chan authored
The descriptions are provided by GCT Semiconductor, Inc. Signed-off-by:
Ben Chan <benchan@chromium.org> Signed-off-by:
-
Michalis Pappas authored
Remove code surrounded by otherwise unused #define LOOPBACK_TEST Signed-off-by:
Michalis Pappas <mpappas@fastmail.fm> Signed-off-by:
-
Ben Chan authored
This patch cleans up the endianness conversions in the gdm72xx driver: - Directly use the generic byte-reordering macros for endianness conversion instead of some custom-defined macros. - Convert values on the constant side instead of the variable side when appropriate. - Add endianness annotations. Signed-off-by:
-
Ben Chan authored
Signed-off-by:
-
Sachin Kamat authored
‘strict_strtol’ is deprecated. Use kstrtol instead. Fixes the following build error: drivers/staging/emxx_udc/emxx_udc.c:3288:3: error: implicit declaration of function ‘strict_strtol’ Signed-off-by:
Sachin Kamat <sachin.kamat@samsung.com> Signed-off-by:
-
Andrey Utkin authored
The issue is discovered by static checker. The proposed change (0x000c0 -> 0x000c) is likely correct because: 1. 16-bit `map` holds value coming from struct ieee80211_vht_mcs_info.tx_mcs_map, which is described so: "TX MCS map 2 bits for each stream, total 8 streams". The changed code refers to case of 2 TX streams, and 0x000c mask filters two bits related to the second stream. Some codelines below 0x0003 mask is used to test first stream. 2. Mask 0x000c is used 3 more times in that place. 3. Specifying 5 digits of hex value is uncommon, especially while working with `u16` variable. So likely the trailing zero is a typo. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=78041Reported-by:
David Binderman <dcb314@hotmail.com> Signed-off-by:
Andrey Utkin <andrey.krieger.utkin@gmail.com> Signed-off-by:
-
Emil Goode authored
We need to make sure the struct rtllib_device pointer ieee is not NULL after the goto rx_dropped label since it is dereferenced there. Signed-off-by:
Emil Goode <emilgoode@gmail.com> Signed-off-by:
-
- 08 Jul, 2014 16 commits
-
-
Anil Belur authored
- this replaces jiffies comparision with safer function using time_after_eq() Signed-off-by:
Anil Belur <askb23@gmail.com> Signed-off-by:
-
Rasmus Villemoes authored
struct rtl_stats is rather huge (152 bytes), and since rtl92ee_rx_command_packet() does not modify it, it might as well be passed by const reference. Reported by Coverity: CID 1222131 Signed-off-by:
Rasmus Villemoes <linux@rasmusvillemoes.dk> Signed-off-by:
-
Rasmus Villemoes authored
struct rtl_stats is rather huge (152 bytes), and since rtl8812ae_rx_command_packet_handler() does not modify it, it might as well be passed by const reference. Reported by Coverity: CID 1167285 Signed-off-by:
-
Fabian Frederick authored
use macro definition Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Josh Triplett <josh@joshtriplett.org> Cc: devel@driverdev.osuosl.org Signed-off-by:
Fabian Frederick <fabf@skynet.be> Signed-off-by:
-
Fabian Frederick authored
lprocfs_stats_seq_sops is only used in static int lprocfs_stats_seq_open with seq_open as const struct seq_operations * Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Peng Tao <bergwolf@gmail.com> Cc: devel@driverdev.osuosl.org Signed-off-by:
-
Aaro Koskinen authored
wHubCharacteristics gets wrong value on big-endian CPUs. Signed-off-by:
Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by:
-
Aaro Koskinen authored
Return transferred bytes only when transfer was successful. Signed-off-by:
-
Aaro Koskinen authored
On data toggle error, we don't know if and how many bytes were successfully transferred by DMA. We should just fail the transaction instead of trying a retry. Signed-off-by:
-
Aaro Koskinen authored
The driver did not use link_urb_to_ep() / unlink_urb_from_ep(). This caused odd behaviour in some error recovery situations, all requests would start to fail after the first failure. Signed-off-by:
-
Aaro Koskinen authored
Cancel requests synchronously instead of using the dequeue tasklet. Signed-off-by:
-
Geert Uytterhoeven authored
The handling of ip2= in drivers/char/ip2/ip2base.c was moved to drivers/char/ip2/ip2main.c in commit 47babd4c ("Char: merge ip2main and ip2base"). The ip2 driver was demoted to staging in commit 4a6514e6 ("tty: move obsolete and broken tty drivers to drivers/staging/tty/"), and finally deleted in commit 51c9d654 ("Staging: delete tty drivers"). Signed-off-by:
Geert Uytterhoeven <geert@linux-m68k.org> Signed-off-by:
-
Bernd Porr authored
The AD converter on the usbsigma turns vref (2.5V/2) into the binary value 0x780000. However the full scale range goes up to 0x800000 so that vref/2 needs to be upscaled by 0x800000/0x780000 which is 1.06bar. In the driver it's been 1.06 without the infinite 6666. I've put the fraction in the code so that the compiler can calculate the most precise scaling value by itself. Signed-off-by:
Bernd Porr <mail@berndporr.me.uk> Reviewed-by:
Ian Abbott <abbotti@mev.co.uk> Signed-off-by:
-
Ian Abbott authored
Comedi subdevices can be locked for mostly exclusive access by a particular file object by means of the COMEDI_LOCK ioctl. Some operations disregard the lock. For example, the read() and write() file operations are allowed for the file object that set up an asynchronous command on the subdevice (making it "busy") regardless of whether it is locked. The COMEDI_BUFINFO, COMEDI_CANCEL and COMEDI_POLL ioctls are also associated with the file object that made the subdevice "busy" with a command. They currently obey the exclusive access lock on the subdevice as well, but it makes more sense for them to ignore it like the read() and write() file operations. Remove the exclusive subdevice access checks for these ioctls. Signed-off-by:
-
Chase Southwood authored
Remove the checks for interrupts from unknown sources. This situation should never occur and the checks were doing nothing to help the situation. Also, the portion of the function for handling counter interrupts is reapeated four times (once for each counter), but is completely identical save for the register is is accessing, so we can handle all four counters with a for loop. Finally, the interrupt handler is incorrectly setting and then checking devpriv->timer_select_mode before processing some of the triggered interrupts, so just remove all occurrences of this. Signed-off-by:
Chase Southwood <chase.southwood@gmail.com> Cc: H Hartley Sweeten <hsweeten@visionengravers.com> Reviewed-by:
Ian Abbott <abbotti@mev.co.uk.> Signed-off-by:
-
Chase Southwood authored
apci1564_cos_insn_config() is currently using apci1564_reset() to disable digital input interrupts when the configuration operation is COMEDI_DIGITAL_TRIG_DISABLE. However, this is incorrect as the device reset function also resets the registers for the digital outputs, timer, watchdog, and counters as well. Replace the reset function call with a direct disabling of just the digital input interrupts. Signed-off-by:
-
Chase Southwood authored
Commit aed3f9d4 (staging: comedi: addi_apci_1564: absorb apci1564_reset()) moved the only use of addi_watchdog.h from hwdrv_apci1564.c to addi_apci_1564.c, but left the include statement itself in the former file. Move this include to the file which actually uses it. Signed-off-by:
-
