1. 14 Jun, 2011 2 commits
    • Namhyung Kim's avatar
      md/raid5: fix FUA request handling in ops_run_io() · b062962e
      Namhyung Kim authored
      Commit e9c7469b ("md: implment REQ_FLUSH/FUA support")
      introduced R5_WantFUA flag and set rw to WRITE_FUA in that case.
      However remaining code still checks whether rw is exactly same
      as WRITE or not, so FUAed-write ends up with being treated as
      READ. Fix it.
      
      This bug has been present since 2.6.37 and the fix is suitable for any
      -stable kernel since then.  It is not clear why this has not caused
      more problems.
      
      Cc: Tejun Heo <tj@kernel.org>
      Cc: stable@kernel.org
      Signed-off-by: default avatarNamhyung Kim <namhyung@gmail.com>
      Signed-off-by: default avatarNeilBrown <neilb@suse.de>
      b062962e
    • Namhyung Kim's avatar
      md/raid5: fix raid5_set_bi_hw_segments · 9b2dc8b6
      Namhyung Kim authored
      The @bio->bi_phys_segments consists of active stripes count in the
      lower 16 bits and processed stripes count in the upper 16 bits. So
      logical-OR operator should be bitwise one.
      
      This bug has been present since 2.6.27 and the fix is suitable for any
      -stable kernel since then.  Fortunately the bad code is only used on
      error paths and is relatively unlikely to be hit.
      
      Cc: stable@kernel.org
      Signed-off-by: default avatarNamhyung Kim <namhyung@gmail.com>
      Signed-off-by: default avatarNeilBrown <neilb@suse.de>
      9b2dc8b6
  2. 09 Jun, 2011 8 commits
    • NeilBrown's avatar
      md:Documentation/md.txt - fix typo · f699bf23
      NeilBrown authored
      Reported-by: default avatarCoolCold <coolthecold@gmail.com>
      Signed-off-by: default avatarNeilBrown <neilb@suse.de>
      f699bf23
    • Namhyung Kim's avatar
      md/bitmap: remove unused fields from struct bitmap · 97b3d4aa
      Namhyung Kim authored
      Get rid of ->syncchunk and ->counter_bits since they're never used.
      
      Also discard COUNTER_BYTE_RATIO which is unused.
      Signed-off-by: default avatarNamhyung Kim <namhyung@gmail.com>
      Signed-off-by: default avatarNeilBrown <neilb@suse.de>
      97b3d4aa
    • Namhyung Kim's avatar
      md/bitmap: use proper accessor macro · 27d5ea04
      Namhyung Kim authored
      Use COUNTER()/NEEDED() macro instead of open-coding them.
      Signed-off-by: default avatarNamhyung Kim <namhyung@gmail.com>
      Signed-off-by: default avatarNeilBrown <neilb@suse.de>
      27d5ea04
    • Namhyung Kim's avatar
      md: check ->hot_remove_disk when removing disk · 01393f3d
      Namhyung Kim authored
      Check pers->hot_remove_disk instead of pers->hot_add_disk in slot_store()
      during disk removal. The linear personality only has ->hot_add_disk and
      no ->hot_remove_disk, so that removing disk in the array resulted to
      following kernel bug:
      
      $ sudo mdadm --create /dev/md0 --level=linear --raid-devices=4 /dev/loop[0-3]
      $ echo none | sudo tee /sys/block/md0/md/dev-loop2/slot
       BUG: unable to handle kernel NULL pointer dereference at           (null)
       IP: [<          (null)>]           (null)
       PGD c9f5d067 PUD 8575a067 PMD 0
       Oops: 0010 [#1] SMP
       CPU 2
       Modules linked in: linear loop bridge stp llc kvm_intel kvm asus_atk0110 sr_mod cdrom sg
      
       Pid: 10450, comm: tee Not tainted 3.0.0-rc1-leonard+ #173 System manufacturer System Product Name/P5G41TD-M PRO
       RIP: 0010:[<0000000000000000>]  [<          (null)>]           (null)
       RSP: 0018:ffff880085757df0  EFLAGS: 00010282
       RAX: ffffffffa00168e0 RBX: ffff8800d1431800 RCX: 000000000000006e
       RDX: 0000000000000001 RSI: 0000000000000002 RDI: ffff88008543c000
       RBP: ffff880085757e48 R08: 0000000000000002 R09: 000000000000000a
       R10: 0000000000000000 R11: ffff88008543c2e0 R12: 00000000ffffffff
       R13: ffff8800b4641000 R14: 0000000000000005 R15: 0000000000000000
       FS:  00007fe8c9e05700(0000) GS:ffff88011fa00000(0000) knlGS:0000000000000000
       CS:  0010 DS: 0000 ES: 0000 CR0: 000000008005003b
       CR2: 0000000000000000 CR3: 00000000b4502000 CR4: 00000000000406e0
       DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
       DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
       Process tee (pid: 10450, threadinfo ffff880085756000, task ffff8800c9f08000)
       Stack:
        ffffffff8138496a ffff8800b4641000 ffff88008543c268 0000000000000000
        ffff8800b4641000 ffff88008543c000 ffff8800d1431868 ffffffff81a78a90
        ffff8800b4641000 ffff88008543c000 ffff8800d1431800 ffff880085757e98
       Call Trace:
        [<ffffffff8138496a>] ? slot_store+0xaa/0x265
        [<ffffffff81384bae>] rdev_attr_store+0x89/0xa8
        [<ffffffff8115a96a>] sysfs_write_file+0x108/0x144
        [<ffffffff81106b87>] vfs_write+0xb1/0x10d
        [<ffffffff8106e6c0>] ? trace_hardirqs_on_caller+0x111/0x135
        [<ffffffff81106cac>] sys_write+0x4d/0x77
        [<ffffffff814fe702>] system_call_fastpath+0x16/0x1b
       Code:  Bad RIP value.
       RIP  [<          (null)>]           (null)
        RSP <ffff880085757df0>
       CR2: 0000000000000000
       ---[ end trace ba5fc64319a826fb ]---
      Signed-off-by: default avatarNamhyung Kim <namhyung@gmail.com>
      Cc: stable@kernel.org
      Signed-off-by: default avatarNeilBrown <neilb@suse.de>
      01393f3d
    • 马建朋's avatar
    • Jonathan Brassow's avatar
      MD: use is_power_of_2 macro · d744540c
      Jonathan Brassow authored
      Make use of is_power_of_2 macro.
      Signed-off-by: default avatarJonathan Brassow <jbrassow@redhat.com>
      Signed-off-by: default avatarNeilBrown <neilb@suse.de>
      d744540c
    • Jonathan Brassow's avatar
      MD: raid5 do not set fullsync · d6b212f4
      Jonathan Brassow authored
      Add check to determine if a device needs full resync or if partial resync will do
      
      RAID 5 was assuming that if a device was not In_sync, it must undergo a full
      resync.  We add a check to see if 'saved_raid_disk' is the same as 'raid_disk'.
      If it is, we can safely skip the full resync and rely on the bitmap for
      partial recovery instead.  This is the legitimate purpose of 'saved_raid_disk',
      from md.h:
      int saved_raid_disk;            /* role that device used to have in the
                                       * array and could again if we did a partial
                                       * resync from the bitmap
                                       */
      Signed-off-by: default avatarJonathan Brassow <jbrassow@redhat.com>
      Signed-off-by: default avatarNeilBrown <neilb@suse.de>
      d6b212f4
    • Jonathan Brassow's avatar
      MD: support initial bitmap creation in-kernel · 9c81075f
      Jonathan Brassow authored
      Add bitmap support to the device-mapper specific metadata area.
      
      This patch allows the creation of the bitmap metadata area upon
      initial array creation via device-mapper.
      Signed-off-by: default avatarJonathan Brassow <jbrassow@redhat.com>
      Signed-off-by: default avatarNeilBrown <neilb@suse.de>
      9c81075f
  3. 08 Jun, 2011 6 commits
  4. 06 Jun, 2011 5 commits
  5. 04 Jun, 2011 17 commits
  6. 03 Jun, 2011 2 commits