- 06 Feb, 2014 1 commit
-
-
Emmanuel Grumbach authored
The current WARNING isn't very helpful. Reported-by:
David Binderman <dcb314@hotmail.com> Signed-off-by:
Emmanuel Grumbach <emmanuel.grumbach@intel.com>
-
- 03 Feb, 2014 39 commits
-
-
Emmanuel Grumbach authored
The main complexity of the power code is that it needs to take into account the firmware limitations. These limitations state that we need to have a global picture of the vifs present in the system to be able to decide if we can enable power management on a specific vif. Even device power save (as opposed to vif power management) must be disabled in certain circumstances (monitor vif). Refactor the current code to make this clearer by defining a function that explicitely computes these constraints. Signed-off-by: -
Emmanuel Grumbach authored
Its logic can be implemented with iwl_mvm_power_mac_update_mode. Signed-off-by: -
Emmanuel Grumbach authored
If the driver detects old firmware, we disable support for power management. This greatly simplifies the code. Reviewed-by:
Alexander Bondar <alexander.bondar@intel.com> Signed-off-by:
-
Emmanuel Grumbach authored
Instead of re-building the power command upon debugfs read, store the latest command sent to the firmware. This reduces the code complexity by reducing the number of entries in the power code. Reviewed-by:
Johannes Berg <johannes.berg@intel.com> Reviewed-by:
-
Emmanuel Grumbach authored
The firmware doesn't allow per-vif beacon filtering: we can use beacon filtering for one vif only. So remember which vif has beacon filtering enabled in the iterator, and send the command outside the iterator. Reviewed-by:
-
Emmanuel Grumbach authored
Reviewed-by:
-
Emmanuel Grumbach authored
Reduce indentation where it is possible. Make a function static - it wasn't used outside its file anyway. Remove the unneeded pm_prevent state. Reviewed-by:
-
Emmanuel Grumbach authored
Signed-off-by: -
Johannes Berg authored
Remove the enum abuse (using an enum to store a set of values), the unneeded ret variable and unnecessary if nesting. Signed-off-by:
-
Emmanuel Grumbach authored
The Sync to SCO is a feature that allows to synchronize between the WiFi traffic and the expectable BT traffic when SCO profile is active. We need to set the validity bit in the command in the init flow, and set / clear the enablement bit if we want to enabled / disable the feature. While at it, clean up the flags that are not used in the API. This feature needs to be enabled / disabled easily, so export its enablement to constants.h. Reviewed-by:
Eyal Zolotov <eyal.zolotov@intel.com> Reviewed-by:
-
Emmanuel Grumbach authored
Signed-off-by: -
Johannes Berg authored
Some older versions of wpa_supplicant don't necessarily stop scheduled scan before starting a regular scan, and there's nothing in the API that requires it either. As a consequence our driver's behaviour of not allowing scan while scheduled scan was in progress broke userspace. However, it is valid to unilaterally stop scheduled scan at any point in time, so when a regular scan request comes just abort the scheduled scan and run the regular scan. Signed-off-by:
-
Liad Kaufman authored
Fix a potential buffer overrun when creating the fw name in drv->firmware_name by setting a maximal length to the char array copied to it. The maximal length is also updated to 32 rather than 25 to keep both 32bit and 64bit alignment without requiring padding to the struct it is in. Signed-off-by:
Liad Kaufman <liad.kaufman@intel.com> Signed-off-by:
-
Eran Harary authored
Newer devices have two embedded CPUs, and the firwmare for both of them is include in the .ucode file requested upon enumeration. An empty section with address=0xFFFFCCCC separates between the sections intended for cpu1 and the sections intended for cpu2. Update the driver to parse the .ucode file with this format and act accordingly. Signed-off-by:
Eran Harary <eran.harary@intel.com> Reviewed-by:
-
Johannes Berg authored
In iwl_mvm_calc_rssi() some values are calculated but then never used, remove the calculations. Signed-off-by:
-
Eliad Peller authored
Support taking an mvm ref (and preventing D0i3) by writing '1' into the d0i3_refs debugfs file. The reference can be unref by writing 0 to the same file. Signed-off-by:
Eliad Peller <eliadx.peller@intel.com> Signed-off-by:
-
Eliad Peller authored
Schedule work to query the wakeup reasons, and disconnect in some cases (e.g. beacon loss). Signed-off-by:
-
Eliad Peller authored
We need to ask the fw to wake up on incoming packets (that pass the filters). Signed-off-by:
-
Eliad Peller authored
Add d0i3_refs debugfs file that prints the currently taken mvm D0i3 refs. Signed-off-by:
-
Eliad Peller authored
We don't want to go into D0i3, when P2P_CLI, AP (including GO) or IBSS interfaces are running, so take appropriate references. Signed-off-by:
-
Eliad Peller authored
Take a reference when ROC command is started, and unref it on completion. Signed-off-by:
-
Arik Nemtsov authored
Take a reference when starting to scan and release it on completion. Note that if the scan is cancelled/aborted, a completion will still be sent up. Signed-off-by:
Arik Nemtsov <arikx.nemtsov@intel.com> Signed-off-by:
-
Eliad Peller authored
Hold a bitmap of taken references, according to the reference reason (e.g. down, scan). This will allow us validate our state and add some debugfs entries later on. Unref the transport when the FW is fully initialized, allowing it to go into a low power mode. Disallow the transition to low-power while recovery is in progress. Signed-off-by:
-
Eliad Peller authored
Upon D0i3 entry/exit, iterate over the active interfaces and configure them appropriately. Signed-off-by:
-
Eliad Peller authored
Configure skip-over-dtim and beacon filtering on D0i3 enter/exit. Since the D0i3 entry/exit commands require different command flags (e.g. CMD_HIGH_PRIORITY), add a new parameter to the functions being called, and make the current users pass CMD_SYNC. Signed-off-by:
-
Arik Nemtsov authored
When the bus is in D0i3, we can't send regular commands to the firmware. This means that we need to add a state to remember what is our d0i3 state and make sure that only d0i3 exit commands can be sent. Add flags to CMD_ flags and transport status for this purpose. Commands with CMD_HIGH_PRIO set are queued at the head of the command queue, behind other high priority commands. Commands with CMD_SEND_IN_IDLE set can be sent while the transport is idle (without taking rpm reference). Commands with CMD_MAKE_TRANS_IDLE set indicate that command completion should mark the transport as idle (and release the bus). Commands with CMD_WAKE_UP_TRANS set instruct the transport to exit from idle when this command is completed. The transport is marked as idle (STATUS_TRANS_IDLE) when the FW enters D0i3 state. This bit is cleared when it enters D0 state again. Process only commands with CMD_SEND_IN_IDLE flag while the transport is idle. Other enqueued commands will be processed only later, right after exiting D0i3. Signed-off-by:
Arik Nemtsov <arik@wizery.com> Signed-off-by:
-
Eliad Peller authored
Add new enter_d0i3 and exit_d0i3 ops that will be called by the transport on D0i3 enter/exit. Each one of these ops will include the host commands mentionned in the previous patch. Signed-off-by:
Eliad Peller <eliad@wizery.com> Signed-off-by:
-
Eliad Peller authored
D0i3 is bus power saving feature. It involves the firmware - the driver needs to send a list of commands to the firmware before entering this state. Wake up from d0i3 also requires a few commands to the firmware. The trigger to enter D0i3 is an idle timeout that will be implemented later and will most probably rely on RUNTIME_PM infrastructure. In order to prevent entrance to D0i3 in critical flows, we implement here a reference infrastructure. When a ref is taken, we can't enter D0i3. PCIe does't support D0i3. Signed-off-by:
-
Ido Yariv authored
Signed-off-by:
Ido Yariv <idox.yariv@intel.com> Reviewed-by:
-
Ido Yariv authored
The tx backoff settings used by the thermal throttling mechanism can also be used for enforcing a limit on the power consumption of the module. Handle the platform PCIe power limitation by translating the limit (measured in mw) to its respective tx backoff value. The translation is module specific. The resulting tx backoff value is sent to the ucode, and also serves as the minimal backoff value that can be set by the thermal throttling mechanism. Signed-off-by:
-
Ido Yariv authored
Some platforms may have power limitations on PCIe cards connected to specific root ports. This information is encoded as part of the ACPI tables, for instance: <snip> Name (SPLX, Package (0x02) { Zero, Package (0x03) { 0x07, 0x00000500, 0x80000000 } }) Method (SPLC, 0, Serialized) { Return (SPLX) } </snip> The structure returned contains the domain type, the default power limitation and the default time window (reserved for future use). Upon PCI probing, call the relevant ACPI method, parse the returned structure, and save the power limitation. Signed-off-by: -
Ilan Peer authored
Divide the maximal quota between all the data interfaces even in the case of a single low latency binding without any other non low latency interfaces, so that afterwards the quota allocation (which considers the number of data interfaces) will be correct. Signed-off-by:
Ilan Peer <ilan.peer@intel.com> Reviewed-by:
-
Ilan Peer authored
Currently the quota remainder was added to the first binding, although it is possible that this was not a data binding (only the P2P_DEVICE interface is part of the binding). Fix this by adding the remainder to the first binding that was actually allocated quota. Signed-off-by:
-
Emmanuel Grumbach authored
Add the vif type when we print the mac params. Signed-off-by: -
Johannes Berg authored
This makes the code a little bit longer as zero-extension has to be done (mov vs. movzwl), but that's miniscule and the space saving is significant, about 600 bytes in DVM and 700 bytes in MVM, so the cache effect should be worth the few bytes more code. While at it, remove two spurious blank lines in variable declaration blocks. Signed-off-by:
Eyal Shapira <eyal@wizery.com> Signed-off-by:
-
Emmanuel Grumbach authored
This will be useful during tests done on the physical layer. Reviewed-by:
-
Eliad Peller authored
Allow reading and setting bcast filtering configuration through debugfs. By default, mvm->bcast_filters is used for setting the bcast filtering configuration (these filters will be configured for each associated station). For testing purposes, allow overriding this configuration, and setting the bcast filtering configuration manually. The following debugfs keys can be used: * bcast_filtering/override - use debugfs values instead of default configuration * bcast_filtering/filters - set filters (+ attributes) * bcast_filtering/macs - per-mac bcast filtering configuration (policy + attached filters) Signed-off-by:
-
Eliad Peller authored
Add our ip as a new attribute to the bcast filtering configuration (i.e. check the dest ip field of the arp request). Add bcast filter to pass incoming dhcp offer broadcast frames as well (for sta vifs). In order to support such dynamic configuration, use the reserved1 field as a bitmap for driver internal flags (which will indicate we want to configure the ip in this attribute), and reconfigure the bcast filtering on BSS_CHANGED_ARP_FILTER indication. Signed-off-by:
-
Eliad Peller authored
Configure arp request broadcast filter if this option is enabled, in order to allow only arp request broadcasts to pass-in. (A following patch will make this filter even narrower by limiting the arp request to our own ip) Signed-off-by:
-
