1. 18 Oct, 2005 2 commits
    • Ralf Baechle's avatar
      [PATCH] rcu in bpqether driver. · bc0a7438
      Ralf Baechle authored
      From Suzanne Wood <suzannew@cs.pdx.edu>:
      
      Clarify RCU implementation in bpqether.c.
      
      Because bpq_new_device() calls list_add_rcu() and bpq_free_device() calls
      list_del_rcu(), substitute list_for_each_entry_rcu() for
      list_for_each_entry() in bpq_get_ax25_dev() and in bpq_seq_start().
      
      Add rcu dereference protection in bpq_seq_next().
      
      The rcu_read_lock()/unlock() in bpq_device_event() are removed because
      netdev event handlers are called with RTNL locking in place.
      
      FYI: bpq_free_device() calls list_del_rcu() which, per list.h, requires
      synchronize_rcu() which can block or call_rcu() or call_rcu_bh() which
      cannot block.  Herbert Xu notes that synchronization is done here by
      unregister_netdevice().  This calls synchronize_net() which in turn uses
      synchronize_rcu().
      Signed-off-by: default avatarRalf Baechle DL5RB <ralf@linux-mips.org>
      Signed-off-by: default avatarJeff Garzik <jgarzik@pobox.com>
      bc0a7438
    • ravinandan.arakali@neterion.com's avatar
      [PATCH] S2io: Offline diagnostics fixes · ad4ebed0
      ravinandan.arakali@neterion.com authored
      This patch fixes the following bugs with offline diagnostics
      code(run with "ethtool -t").
      
      1. After running offline diagnostics, adapter would report
      corrupted packets on receive. This was because of adapter not
      being brought out of "RLDRAM test mode".
      2. Current EEPROM test works only for Xframe I. Since Xframe II
      uses different interface(SPI), support for this interface has
      been added. Also, since SPI supports write access to all areas
      of EEPROM, negative testing is done only for Xframe I.
      3. Return values from subfunctions of offline diagnostics have
      been corrected.
      4. In register test, expected value from rx_queue_cfg register
      is made to depend on adapter type.
      5. After the test, need to restore values at EEPROM offsets
      0x4F0 and 0x7F0. These locations were modified as part of test.
      6. Use macro SPECIAL_REG_WRITE for write access to mc_rldram_test_ctrl
      register. Also, couple of unnecessary writes to mc_rldram_test_ctrl
      have been removed.
      Signed-off-by: default avatarRavinandan Arakali <ravinandan.arakali@neterion.com>
      Signed-off-by: default avatarJeff Garzik <jgarzik@pobox.com>
      ad4ebed0
  2. 14 Oct, 2005 1 commit
  3. 13 Oct, 2005 11 commits
  4. 12 Oct, 2005 19 commits
  5. 11 Oct, 2005 7 commits