- 11 Jan, 2012 40 commits
-
-
Andy Whitcroft authored
Fix up type and cast spacing checks such that all occurences on a line are examined and reported. For example the line below has a valid cast and a bad type, but currently we check the cast first which is good and stop: u16* bar = (u16 *)baz; We will also only report one of the errors in this example: u16* bar = (u16*)bad; Move to iterating across all casts and all types, reporting any failure. [akpm@linux-foundation.org: coding-style fixes] Signed-off-by:Andy Whitcroft <apw@canonical.com> Cc: Joe Perches <joe@perches.com> Signed-off-by:
Andrew Morton <akpm@linux-foundation.org> Signed-off-by:
Linus Torvalds <torvalds@linux-foundation.org>
-
Andy Whitcroft authored
typeof may have various more complex forms as its arguement, not just an identifier. For now allow us to leak to the first close perenthesis ')'. Signed-off-by:
-
Andy Whitcroft authored
Ensure the cast type is unique in the context parser, we do not want them to detect as a comma ','. Signed-off-by:
-
Andy Whitcroft authored
Signed-off-by:
-
Andy Whitcroft authored
We are incorrectly matching square brackets '[' and ']' leading to false positives on more complex functions as below: return (dt3155_fbuffer[m]->ready_head - dt3155_fbuffer[m]->ready_len + dt3155_fbuffer[m]->nbuffers)% (dt3155_fbuffer[m]->nbuffers); Signed-off-by: -
Andy Whitcroft authored
It is common to stub out a function as below, this is triggering a complex macro format incorrectly. Sort this out: #define cma_early_regions_reserve(reserve) do { } while (0) Signed-off-by: -
Andy Whitcroft authored
The following fragment defeats the DEVICE_ATTR style handing, check for and ignore the close brace '}' in this context: int foo() { } DEVICE_ATTR(link_power_management_policy, S_IRUGO | S_IWUSR, ata_scsi_lpm_show, ata_scsi_lpm_put); EXPORT_SYMBOL_GPL(dev_attr_link_power_management_policy); Signed-off-by: -
Andy Whitcroft authored
The intent of this check is to catch the options which the user will see and ensure they are properly described. It is also common for internal only options to have a brief description. Allow this form. Reported-by:
Steven Rostedt <rostedt@goodmis.org> Tested-by:
-
Andy Whitcroft authored
In the middle of a long definition or similar, there is no possibility of finding a smaller sub-statement. Optimise this case by skipping statement aquirey where there are no starts of statement (open brace '{' or semi-colon ';'). We are likely to scan slightly more than needed still but this is safest. Signed-off-by: -
Andy Whitcroft authored
Inserting a # into the modifiers list will incorrectly add the null string to the modifiers list, leading to an infinite loop. As neither of these is a valid modifier form simply ignore them. Signed-off-by:
Joe Perches <joe@perches.com> Signed-off-by:
-
Joe Perches authored
Improve the checking of arguments to memset and min/max tests. Move the checking of min/max to statement blocks instead of single line. Change $Constant to allow any case type 0x initiator and trailing ul specifier. Add $FuncArg type as any function argument with or without a cast. Print the whole statement when showing memset or min/max messages. Improve the memset with 0 as 3rd argument error message. There are still weaknesses in the $FuncArg and $Constant code as arbitrary parentheses and negative signs are not generically supported. [akpm@linux-foundation.org: fix per Andy] Signed-off-by:
-
Andy Whitcroft authored
Move the memset checks over to work against the statement. Also add checks for 0 and 1 used as lengths. Generally these indicate badly ordered parameters. Signed-off-by:
-
Andy Whitcroft authored
When looking for a statement we currently run on through preprocessor commands. This means that a header file with just definitions is parsed over and over again combining all of the lines from the current line to the end of file leading to severe performance issues. Fix up context accumulation to track preprocessor commands and stop when reaching the end of them. At the same time vastly simplify the #define handling. Signed-off-by:
-
Joe Perches authored
Add a warn for not using __printf. Signed-off-by:
-
Joe Perches authored
email header lines can look like signature tags. It's valid to have multiple email recipients on a single line but not valid to have multiple signatures on a single line. Validate signatures only when not in the email headers. Clear the $in_commit_log flag when the patch filename appears. Add '-' to the valid chars in a message header for headers like "Message-Id:" and "In-Reply-To:". Signed-off-by:
Julia Lawall <julia.lawall@lip6.fr> Signed-off-by:
-
Steve Hodgson authored
The btree_for_each API is implemented with macros that internally call btree_get_prev(), so if btree_get_prev() isn't exported then modules fail to link if they try to use one of the btree_for_each macros. Since the rest of the btree API is exported, we should keep things orthogonal and make this work too. Signed-off-by:
Roland Dreier <roland@purestorage.com> Signed-off-by:
Steve Hodgson <steve@purestorage.com> Acked-by:
Joern Engel <joern@logfs.org> Signed-off-by:
-
Mark Brown authored
Saves a small amount of code and systematically eliminates leaks. Signed-off-by:
Mark Brown <broonie@opensource.wolfsonmicro.com> Cc: Richard Purdie <rpurdie@rpsys.net> Signed-off-by:
-
Mark Brown authored
Saves a small amount of code and systematically eliminates leaks. Signed-off-by:
-
Axel Lin authored
The LED id begins from 0. Thus the maximum number of leds should be MC13783_LED_MAX + 1. Signed-off-by:
Axel Lin <axel.lin@gmail.com> Acked-by:
Philippe Retornaz <philippe.retornaz@epfl.ch> Cc: Richard Purdie <rpurdie@rpsys.net> Signed-off-by:
-
NeilBrown authored
TI's TCA6507 is the LED driver in the GTA04 Openmoko motherboard. The driver provides full support for brightness levels and hardware blinking. This driver can drive each of 7 outputs as an LED or a GPIO output, and provides hardware-assist blinking. [akpm@linux-foundation.org: fix __mod_i2c_device_table alias] [akpm@linux-foundation.org: coding-style fixes] Signed-off-by:
NeilBrown <neilb@suse.de> Cc: Richard Purdie <rpurdie@rpsys.net> Cc: Randy Dunlap <rdunlap@xenotime.net> Cc: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by:
-
Axel Lin authored
Use gpio_request_one() instead of multiple gpiolib calls. This also simplifies error handling a bit. Signed-off-by:
-
Axel Lin authored
Use gpio_request_one() instead of multiple gpiolib calls. Signed-off-by:
-
Axel Lin authored
Signed-off-by:
-
Axel Lin authored
Factor out some boilerplate code for spi driver registration into module_spi_driver. Signed-off-by:
Guennadi Liakhovetski <g.liakhovetski@gmx.de> Signed-off-by:
-
Axel Lin authored
Factor out some boilerplate code for i2c driver registration into module_i2c_driver. Signed-off-by:
-
Axel Lin authored
Factor out some boilerplate code for platform driver registration into module_platform_driver. Signed-off-by:
-
Mark Brown authored
Should be no functional changes, mainly a reorganisation to support future work. [akpm@linux-foundation.org: fix CONFIG_PM=n build] Signed-off-by:
-
Mark Brown authored
Saves some error handling code and eliminates a class of leaks. Signed-off-by:
-
Jingoo Han authored
The usage of simple_strtoul() or strict_strtoul() is not preferred. Thus, kstrtoul should be used. This patch also fixes checkpatch error as follows: ERROR: space required after that ',' (ctx:VxV) Signed-off-by:
Jingoo Han <jg1.han@samsung.com> Cc: Richard Purdie <rpurdie@rpsys.net> Signed-off-by:
-
Jingoo Han authored
module.h is included twice. Signed-off-by:
H Hartley Sweeten <hsweeten@visionengravers.com> Cc: Ryan Mallon <rmallon@gmail.com> Cc: Richard Purdie <rpurdie@rpsys.net> Signed-off-by:
-
Donghwa Lee authored
This patch supports regulator power control in the driver. Current ld9040 driver was controlled power on/off sequence by callback function in the board file. But, by doing this, there's no need to register lcd power on/off callback function in the board file. Signed-off-by:
Donghwa Lee <dh09.lee@samsung.com> Signed-off-by:
Kyungmin Park <kyungmin.park@samsung.com> Signed-off-by:
Inki Dae <inki.dae@samsung.com> Cc: Richard Purdie <rpurdie@rpsys.net> Cc: Florian Tobias Schandinat <FlorianSchandinat@gmx.de> Signed-off-by:
-
Axel Lin authored
Convert the drivers in drivers/video/backlight/* to use the module_platform_driver() macro which makes the code smaller and a bit simpler. Signed-off-by:
Haojian Zhuang <haojian.zhuang@gmail.com> Acked-by: H Hartley Sweeten <hsweeten@visionengravers.com> [ep93xx_bl.c] Cc: Mike Rapoport <mike@compulab.co.il> Cc: Richard Purdie <rpurdie@rpsys.net> Acked-by:
Michael Hennerich <michael.hennerich@analog.com> Acked-by:
-
Paul Bolle authored
Support for the Avionic Design Xanthos backlight device got added in commit 3b96ea9e ("backlight: Add support for the Avionic Design Xanthos backlight device."). That support depends on ARCH_PXA_ADX. The code that should have provided that Kconfig symbol never got submitted. It has never been possible to even build this driver. Remove it. Signed-off-by:
Paul Bolle <pebolle@tiscali.nl> Acked-by:
Thierry Reding <thierry.reding@avionic-design.de> Cc: Richard Purdie <rpurdie@rpsys.net> Cc: Wim Van Sebroeck <wim@iguana.be> Signed-off-by:
-
Kyungmin Park authored
As devfreq is merged at mainline. Also update the maintainer entry. Signed-off-by:
Rafael J. Wysocki <rjw@sisk.pl> Signed-off-by:
-
Joe Perches authored
commit ca632f55 ("spi: reorganize drivers") renamed the files, update the F: patterns. Signed-off-by:
Grant Likely <grant.likely@secretlab.ca> Signed-off-by:
-
Joe Perches authored
commit 0c6967b5 ("serial:blackfin: rename Blackfin serial driver to bfin_uart.c") renamed the file, update the pattern. Signed-off-by:
Sonic Zhang <sonic.zhang@analog.com> Signed-off-by:
-
Joe Perches authored
commit 4860c738 ("staging: Move media drivers to staging/media") moved the files, update the F: patterns. Signed-off-by:
-
Joe Perches authored
commit 61cf45d0 ("encrypted-keys: create encrypted-keys directory") moved the files, update the patterns. Signed-off-by:
-
Joe Perches authored
commit 1fe003fd ("greth: Move the Aeroflex Gaisler driver") moved the files, update the patterns. Signed-off-by:
-
Joe Perches authored
commit a88394cf ("ewrk3/tulip: Move the DEC - Tulip drivers") moved the files, update the patterns. Signed-off-by:
Grant Grundler <grundler@parisc-linux.org> Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com> Cc: Tobias Ringstrom <tori@unhappy.mine.nu> Cc: Grant Grundler <grundler@parisc-linux.org> Cc: David Davies <davies@maniac.ultranet.com> Cc: David Miller <davem@davemloft.net> Signed-off-by:
-
