1. 23 May, 2019 6 commits
    • Trent Piepho's avatar
      net: phy: dp83867: Rework delay rgmii delay handling · c11669a2
      Trent Piepho authored
      The code was assuming the reset default of the delay control register
      was to have delay disabled.  This is what the datasheet shows as the
      register's initial value.  However, that's not actually true: the
      default is controlled by the PHY's pin strapping.
      
      If the interface mode is selected as RX or TX delay only, insure the
      other direction's delay is disabled.
      
      If the interface mode is just "rgmii", with neither TX or RX internal
      delay, one might expect that the driver should disable both delays.  But
      this is not what the driver does.  It leaves the setting at the PHY's
      strapping's default.  And that default, for no pins with strapping
      resistors, is to have delay enabled and 2.00 ns.
      
      Rather than change this behavior, I've kept it the same and documented
      it.  No delay will most likely not work and will break ethernet on any
      board using "rgmii" mode.  If the board is strapped to have a delay and
      is configured to use "rgmii" mode a warning is generated that "rgmii-id"
      should have been used.
      
      Also validate the delay values and fail if they are not in range.
      
      Cc: Andrew Lunn <andrew@lunn.ch>
      Cc: Florian Fainelli <f.fainelli@gmail.com>
      Cc: Heiner Kallweit <hkallweit1@gmail.com>
      Signed-off-by: default avatarTrent Piepho <tpiepho@impinj.com>
      Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      c11669a2
    • Trent Piepho's avatar
      net: phy: dp83867: Add ability to disable output clock · 13c83cf8
      Trent Piepho authored
      Generally, the output clock pin is only used for testing and only serves
      as a source of RF noise after this.  It could be used to daisy-chain
      PHYs, but this is uncommon.  Since the PHY can disable the output, make
      doing so an option.  I do this by adding another enumeration to the
      allowed values of ti,clk-output-sel.
      
      The code was not using the value DP83867_CLK_O_SEL_REF_CLK as one might
      expect: to select the REF_CLK as the output.  Rather it meant "keep
      clock output setting as is", which, depending on PHY strapping, might
      not be outputting REF_CLK.
      
      Change this so DP83867_CLK_O_SEL_REF_CLK means enable REF_CLK output.
      Omitting the property will leave the setting as is (which was the
      previous behavior in this case).
      
      Out of range values were silently converted into
      DP83867_CLK_O_SEL_REF_CLK.  Change this so they generate an error.
      
      Cc: Andrew Lunn <andrew@lunn.ch>
      Cc: Florian Fainelli <f.fainelli@gmail.com>
      Cc: Heiner Kallweit <hkallweit1@gmail.com>
      Signed-off-by: default avatarTrent Piepho <tpiepho@impinj.com>
      Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      13c83cf8
    • Trent Piepho's avatar
      dt-bindings: phy: dp83867: Add documentation for disabling clock output · 980066e6
      Trent Piepho authored
      The clock output is generally only used for testing and development and
      not used to daisy-chain PHYs.  It's just a source of RF noise afterward.
      
      Add a mux value for "off".  I've added it as another enumeration to the
      output property.  In the actual PHY, the mux and the output enable are
      independently controllable.  However, it doesn't seem useful to be able
      to describe the mux setting when the output is disabled.
      
      Document that PHY's default setting will be left as is if the property
      is omitted.
      
      Cc: Rob Herring <robh+dt@kernel.org>
      Cc: Mark Rutland <mark.rutland@arm.com>
      Signed-off-by: default avatarTrent Piepho <tpiepho@impinj.com>
      Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      980066e6
    • Trent Piepho's avatar
      dt-bindings: phy: dp83867: Describe how driver behaves w.r.t rgmii delay · 9c3f3410
      Trent Piepho authored
      Add a note to make it more clear how the driver behaves when "rgmii" vs
      "rgmii-id", "rgmii-idrx", or "rgmii-idtx" interface modes are selected.
      
      Cc: Rob Herring <robh+dt@kernel.org>
      Cc: Mark Rutland <mark.rutland@arm.com>
      Signed-off-by: default avatarTrent Piepho <tpiepho@impinj.com>
      Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      9c3f3410
    • Vishal Kulkarni's avatar
      cxgb4: Enable hash filter with offload · 74dd5aa1
      Vishal Kulkarni authored
      Hash (exact-match) filters used for offloading flows share the
      same active region resources on the chip with upper layer drivers,
      like iw_cxgb4, chcr, etc. Currently, only either Hash filters
      or ULDs can use the active region resources, but not both. Hence,
      use the new firmware configuration parameters (when available)
      to allow both the Hash filters and ULDs to share the
      active region simultaneously.
      Signed-off-by: default avatarVishal Kulkarni <vishal@chelsio.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      74dd5aa1
    • Baruch Siach's avatar
      net: fec: remove redundant ipg clock disable · 2bb0f3b4
      Baruch Siach authored
      Don't disable the ipg clock in the regulator error path. The clock is
      disable unconditionally two lines below the failed_regulator label.
      Signed-off-by: default avatarBaruch Siach <baruch@tkos.co.il>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      2bb0f3b4
  2. 22 May, 2019 6 commits
    • Felipe Gasper's avatar
      net: Add UNIX_DIAG_UID to Netlink UNIX socket diagnostics. · cae9910e
      Felipe Gasper authored
      This adds the ability for Netlink to report a socket's UID along with the
      other UNIX diagnostic information that is already available. This will
      allow diagnostic tools greater insight into which users control which
      socket.
      
      To test this, do the following as a non-root user:
      
          unshare -U -r bash
          nc -l -U user.socket.$$ &
      
      .. and verify from within that same session that Netlink UNIX socket
      diagnostics report the socket's UID as 0. Also verify that Netlink UNIX
      socket diagnostics report the socket's UID as the user's UID from an
      unprivileged process in a different session. Verify the same from
      a root process.
      Signed-off-by: default avatarFelipe Gasper <felipe@felipegasper.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      cae9910e
    • Linus Torvalds's avatar
      Merge tag 'arm64-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux · 54dee406
      Linus Torvalds authored
      Pull arm64 fixes from Will Deacon:
      
       - Fix SPE probe failure when backing auxbuf with high-order pages
      
       - Fix handling of DMA allocations from outside of the vmalloc area
      
       - Fix generation of build-id ELF section for vDSO object
      
       - Disable huge I/O mappings if kernel page table dumping is enabled
      
       - A few other minor fixes (comments, kconfig etc)
      
      * tag 'arm64-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux:
        arm64: vdso: Explicitly add build-id option
        arm64/mm: Inhibit huge-vmap with ptdump
        arm64: Print physical address of page table base in show_pte()
        arm64: don't trash config with compat symbol if COMPAT is disabled
        arm64: assembler: Update comment above cond_yield_neon() macro
        drivers/perf: arm_spe: Don't error on high-order pages for aux buf
        arm64/iommu: handle non-remapped addresses in ->mmap and ->get_sgtable
      54dee406
    • Linus Torvalds's avatar
      Merge tag 'gfs2-5.1.fixes2' of git://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2 · 651bae98
      Linus Torvalds authored
      Pull gfs2 fix from Andreas Gruenbacher:
       "Fix a gfs2 sign extension bug introduced in v4.3"
      
      * tag 'gfs2-5.1.fixes2' of git://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2:
        gfs2: Fix sign extension bug in gfs2_update_stats
      651bae98
    • Linus Torvalds's avatar
      Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net · f75b6f30
      Linus Torvalds authored
      Pull networking fixes from David Miller:
      
       1) Clear up some recent tipc regressions because of registration
          ordering. Fix from Junwei Hu.
      
       2) tipc's TLV_SET() can read past the end of the supplied buffer during
          the copy. From Chris Packham.
      
       3) ptp example program doesn't match the kernel, from Richard Cochran.
      
       4) Outgoing message type fix in qrtr, from Bjorn Andersson.
      
       5) Flow control regression in stmmac, from Tan Tee Min.
      
       6) Fix inband autonegotiation in phylink, from Russell King.
      
       7) Fix sk_bound_dev_if handling in rawv6_bind(), from Mike Manning.
      
       8) Fix usbnet crash after disconnect, from Kloetzke Jan.
      
      * git://git.kernel.org/pub/scm/linux/kernel/git/davem/net: (21 commits)
        usbnet: fix kernel crash after disconnect
        selftests: fib_rule_tests: use pre-defined DEV_ADDR
        net-next: net: Fix typos in ip-sysctl.txt
        ipv6: Consider sk_bound_dev_if when binding a raw socket to an address
        net: phylink: ensure inband AN works correctly
        usbnet: ipheth: fix racing condition
        net: stmmac: dma channel control register need to be init first
        net: stmmac: fix ethtool flow control not able to get/set
        net: qrtr: Fix message type of outgoing packets
        networking: : fix typos in code comments
        ptp: Fix example program to match kernel.
        fddi: fix typos in code comments
        selftests: fib_rule_tests: enable forwarding before ipv4 from/iif test
        selftests: fib_rule_tests: fix local IPv4 address typo
        tipc: Avoid copying bytes beyond the supplied data
        2/2] net: xilinx_emaclite: use readx_poll_timeout() in mdio wait function
        1/2] net: axienet: use readx_poll_timeout() in mdio wait function
        vlan: Mark expected switch fall-through
        macvlan: Mark expected switch fall-through
        net/mlx4_en: ethtool, Remove unsupported SFP EEPROM high pages query
        ...
      f75b6f30
    • Linus Torvalds's avatar
      Merge tag 'for-5.2/dm-fix-1' of... · 86f9e56d
      Linus Torvalds authored
      Merge tag 'for-5.2/dm-fix-1' of git://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm
      
      Pull device mapper fix from Mike Snitzer:
       "Fix a particularly glaring oversight in a DM core commit from 5.1 that
        doesn't properly trim special IOs (e.g. discards) relative to
        corresponding target's max_io_len_target_boundary()"
      
      * tag 'for-5.2/dm-fix-1' of git://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm:
        dm: make sure to obey max_io_len_target_boundary
      86f9e56d
    • Andreas Gruenbacher's avatar
      gfs2: Fix sign extension bug in gfs2_update_stats · 5a5ec83d
      Andreas Gruenbacher authored
      Commit 4d207133 changed the types of the statistic values in struct
      gfs2_lkstats from s64 to u64.  Because of that, what should be a signed
      value in gfs2_update_stats turned into an unsigned value.  When shifted
      right, we end up with a large positive value instead of a small negative
      value, which results in an incorrect variance estimate.
      
      Fixes: 4d207133 ("gfs2: Make statistics unsigned, suitable for use with do_div()")
      Signed-off-by: default avatarAndreas Gruenbacher <agruenba@redhat.com>
      Cc: stable@vger.kernel.org # v4.4+
      5a5ec83d
  3. 21 May, 2019 28 commits