1. 11 Jun, 2016 3 commits
    • Ben Dooks's avatar
      net: diag: add missing declarations · c3ec5e5c
      Ben Dooks authored
      The functions inet_diag_msg_common_fill and inet_diag_msg_attrs_fill
      seem to have been missed from the include/linux/inet_diag.h header
      file. Add them to fix the following warnings:
      
      net/ipv4/inet_diag.c:69:6: warning: symbol 'inet_diag_msg_common_fill' was not declared. Should it be static?
      net/ipv4/inet_diag.c:108:5: warning: symbol 'inet_diag_msg_attrs_fill' was not declared. Should it be static?
      Signed-off-by: default avatarBen Dooks <ben.dooks@codethink.co.uk>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      c3ec5e5c
    • Ido Schimmel's avatar
      bridge: Fix incorrect re-injection of STP packets · 56fae404
      Ido Schimmel authored
      Commit 8626c56c ("bridge: fix potential use-after-free when hook
      returns QUEUE or STOLEN verdict") fixed incorrect usage of NF_HOOK's
      return value by consuming packets in okfn via br_pass_frame_up().
      
      However, this function re-injects packets to the Rx path with skb->dev
      set to the bridge device, which breaks kernel's STP, as all STP packets
      appear to originate from the bridge device itself.
      
      Instead, if STP is enabled and bridge isn't a 802.1ad bridge, then learn
      packet's SMAC and inject it back to the Rx path for further processing
      by the packet handlers.
      
      The patch also makes netfilter's behavior consistent with regards to
      packets destined to the Bridge Group Address, as no hook registered at
      LOCAL_IN will ever be called, regardless if STP is enabled or not.
      
      Cc: Florian Westphal <fw@strlen.de>
      Cc: Shmulik Ladkani <shmulik.ladkani@gmail.com>
      Cc: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>
      Fixes: 8626c56c ("bridge: fix potential use-after-free when hook returns QUEUE or STOLEN verdict")
      Signed-off-by: default avatarJiri Pirko <jiri@mellanox.com>
      Signed-off-by: default avatarIdo Schimmel <idosch@mellanox.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      56fae404
    • Manfred Schlaegl's avatar
      net: phy: smsc: reintroduced unconditional soft reset · fc0f7e33
      Manfred Schlaegl authored
      We detected some problems using the smsc lan8720a in combination with
      i.MX28 and tracked this down to commit 21009686 ("net: phy: smsc: move
      smsc_phy_config_init reset part in a soft_reset function")
      With 21009686 the generic soft reset is replaced by a specific function
      which handles power down state correctly. But additionally the soft reset
      itself got conditional and is therefore also only performed if the phy is
      in power down state.
      
      This patch keeps the conditional wake up from power down, but
      re-introduces the unconditional soft reset using the generic soft reset
      function.
      It was tested on linux-4.1.25 and linux-4.7.0-rc2.
      Signed-off-by: default avatarManfred Schlaegl <manfred.schlaegl@ginzinger.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      fc0f7e33
  2. 10 Jun, 2016 25 commits
  3. 09 Jun, 2016 12 commits