- 04 Jun, 2017 4 commits
-
-
Gilad Ben-Yossef authored
The Linked List Item descriptors were being programmed via a set of macros which suffer a few problems: - Use of macros rather than inline leaves out parameter type checking and risks multiple macro parameter evaluation side effects. - Implemented via hand rolled versions of bitfield operations. This patch refactors LLI programming into a set of of inline functions using generic kernel bitfield access infrastructure, thus resolving the above issues and opening the way later on to drop the hand rolled bitfield macros once additional users are dropped in later patches in the series. Signed-off-by:
Gilad Ben-Yossef <gilad@benyossef.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Gilad Ben-Yossef authored
Remove no longer needed code used to simulate 48 bit dma addresses on 32 bit platforms for development purposes. Signed-off-by:
-
Gilad Ben-Yossef authored
The programming of the HW command FIFO in ccree was done via a set of macros which suffer a few problems: - Use of macros rather than inline leaves out parameter type checking and risks multiple macro parameter evaluation side effects. - Implemented via hand rolled versions of bitfield operations. This patch refactors the HW command queue access into a set of inline functions using generic kernel bitfield access infrastructure, thus resolving the above issues and opening the way later on to drop the hand rolled bitfield macros once additional users are dropped in later patches in the series. Signed-off-by:
-
Gilad Ben-Yossef authored
CC_CTX_SIZE was being defined using a hand rolled bit shift operation. Replace with use of BIT macro. Signed-off-by:
-
- 03 Jun, 2017 32 commits
-
-
Derek Robson authored
Fixed block comment alignment, Style fix only Found using checkpatch Signed-off-by:
Derek Robson <robsonde@gmail.com> Signed-off-by:
-
Derek Robson authored
Fixed block comment alignment, Style fix only Found using checkpatch Signed-off-by:
-
Derek Robson authored
Fixed block comment alignment, Style fix only Found using checkpatch Signed-off-by:
-
Derek Robson authored
Fixed block comment alignment, Style fix only Found using checkpatch Signed-off-by:
-
Derek Robson authored
Fixed block comment alignment, Style fix only Found using checkpatch Signed-off-by:
-
Derek Robson authored
Fixed block comment alignment, Style fix only Found using checkpatch Signed-off-by:
-
Derek Robson authored
Fixed block comment alignment, Style fix only Found using checkpatch Signed-off-by:
-
Derek Robson authored
Fixed block comment alignment, Style fix only Found using checkpatch Signed-off-by:
-
Derek Robson authored
Fixed block comment alignment, Style fix only Found using checkpatch Signed-off-by:
-
Derek Robson authored
Fixed block comment alignment, Style fix only Found using checkpatch Signed-off-by:
-
Derek Robson authored
Fixed block comment alignment, Style fix only Found using checkpatch Signed-off-by:
-
Derek Robson authored
Fixed block comment alignment, Style fix only Found using checkpatch Signed-off-by:
-
Derek Robson authored
Fixed block comment alignment, Style fix only Found using checkpatch Signed-off-by:
-
Derek Robson authored
Fixed block comment alignment, Style fix only Found using checkpatch Signed-off-by:
-
Derek Robson authored
Fixed block comment alignment, Style fix only Found using checkpatch Signed-off-by:
-
Jia-Ju Bai authored
The driver may sleep under a spin lock, and the function call path is: rtsx_exclusive_enter_ss (acquire the lock by spin_lock) rtsx_enter_ss rtsx_power_off_card sd_cleanup_work sd_stop_seq_mode sd_switch_clock sd_ddr_tuning sd_ddr_pre_tuning_tx sd_change_phase wait_timeout schedule_timeout --> may sleep To fix it, "wait_timeout" is replaced with mdelay in sd_change_phase. Signed-off-by:Jia-Ju Bai <baijiaju1990@163.com> Signed-off-by:
-
Jia-Ju Bai authored
The driver may sleep under a spin lock, and the function call path is: rtsx_exclusive_enter_ss (acquire the lock by spin_lock) rtsx_enter_ss rtsx_power_off_card sd_power_off_card3v3 wait_timeout schedule_timeout --> may sleep To fix it, "wait_timeout" is replaced with mdelay in sd_power_off_card3v3. Signed-off-by: -
Gilad Ben-Yossef authored
Add parentheses around macro argument to guard against precedence issues. Signed-off-by:
-
Gilad Ben-Yossef authored
A few of the comments in cc_crypto_ctx.h where not formatted correctly. Format according to coding style guidelines. Signed-off-by:
-
Gilad Ben-Yossef authored
Clip longer than 80 chars lines in header files worked on in the patch set. Signed-off-by:
-
Gilad Ben-Yossef authored
Remove spurious blanks lines from cc_crypto_ctx.h file Signed-off-by:
-
Mart Lubbers authored
This patch fixes the following checkpatch.pl warning in gdm_usb.c: WARNING: suspect code indent for conditional statements (8, 12) Signed-off-by:
Mart Lubbers <mart@martlubbers.net> Signed-off-by:
-
Gleb Fotengauer-Malinovskiy authored
This problem was found by strace ioctl list generator. Fixes: 15c6098c ("staging: android: ion: Remove ion_handle and ion_client") Signed-off-by:
Gleb Fotengauer-Malinovskiy <glebfm@altlinux.org> Acked-by:
Laura Abbott <labbott@redhat.com> Signed-off-by:
-
Okash Khawaja authored
In spk_ttyio_release we read tty's index but never do anything with it. The patch removes this dead code. Signed-off-by:
Okash Khawaja <okash.khawaja@gmail.com> Reviewed-by:
Samuel Thibault <samuel.thibault@ens-lyon.org> Signed-off-by:
-
Okash Khawaja authored
We should check the flush_buffer method of a tty for null before invoking it. Some drivers such as usbserial don't implement flush_buffer. This will be required for upcoming patches where we expand spk_ttyio to support more than just ttyS*. Signed-off-by:
-
Nikola Jelic authored
lib-move.c file has a lot of expressions in the form of: v = le[32|64]_to_cpu(v); This caused a lot of sparse warnings. Replaced with: le[32|64]_to_cpus(&v); Signed-off-by:
Nikola Jelic <nikola.jelic83@gmail.com> Signed-off-by:
-
Nikola Jelic authored
Temporary variable is used only as __be32, for both assignments and reads, but the type is inconsistent (__u32). Signed-off-by:
-
Nikola Jelic authored
sockaddr_in.sin_addr.s_addr is __be32 integral type, so the (__force u32) cast after the htonl call is unnecessary, and also detected by sparse: drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c:2309:33: warning: incorrect type in assignment (different base types) drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c:2381:30: warning: incorrect type in assignment (different base types) Signed-off-by:
-
Valentin Vidic authored
Introduces a local var to collect flags and convert them to le32. Fixes the following sparse warnings: drivers/staging/lustre/lustre/lmv/lmv_obd.c:2305:23: warning: invalid assignment: |= drivers/staging/lustre/lustre/lmv/lmv_obd.c:2305:23: left side has type restricted __le32 drivers/staging/lustre/lustre/lmv/lmv_obd.c:2305:23: right side has type int drivers/staging/lustre/lustre/lmv/lmv_obd.c:2383:39: warning: invalid assignment: |= drivers/staging/lustre/lustre/lmv/lmv_obd.c:2383:39: left side has type restricted __le32 drivers/staging/lustre/lustre/lmv/lmv_obd.c:2383:39: right side has type int Signed-off-by:
Valentin Vidic <Valentin.Vidic@CARNet.hr> Signed-off-by:
-
Mathias Rav authored
Reported by checkpatch.pl: "WARNING: Prefer seq_puts to seq_printf". Signed-off-by:
Mathias Rav <mathiasrav@gmail.com> Signed-off-by:
-
Mathias Rav authored
Clean up the helper functions used to implement "dump_granted_max" in debugfs. Replace the lprocfs_rd_uint() and lprocfs_wr_uint() generic callbacks with a simpler, more direct implementation of ldlm_rw_uint_fops. There's a slight change in lustre debugfs write semantics: Using kstrtox causes EINVAL when the written number is followed by other (garbage) characters, whereas previously the garbage would be ignored and such a write would succeed. Signed-off-by:
-
Konrad Malkowski authored
This patch fixes the checkpoint.pl warning: WARNING: Prefer printk_ratelimited or pr_<level>_ratelimited to printk_ratelimit Signed-off-by:
Konrad Malkowski <konrad.malkowski@gmail.com> Signed-off-by:
-
- 29 May, 2017 4 commits
-
-
Stefan Wahren authored
This replaces all remaining BUG_ON with WARN_ON. So in case of a VCHIQ bug the system is still usable. Signed-off-by:
Stefan Wahren <stefan.wahren@i2se.com> Signed-off-by:
-
Stefan Wahren authored
Properly handle the error case in case of an invalid tx_pos. Signed-off-by:
-
Stefan Wahren authored
Bail out properly if the process index doesn't match the remote insert. We also drop the BUG in case the process index is at local insert, so we can trigger the WARN_ON again some steps later. Signed-off-by:
-
Stefan Wahren authored
If the ref counter of service has an unexpected value then we better bail out. Signed-off-by:
-
