1. 12 Dec, 2014 1 commit
  2. 02 Dec, 2014 2 commits
    • Benjamin Tissoires's avatar
      HID: wacom: fix freeze on open when autosuspend is on · dff67416
      Benjamin Tissoires authored
      Since the conversion from USB to HID (in v3.17), some people reported a
      freeze on boot with the wacom driver. Hans managed to get a stacktrace:
      
      [  240.272331] Call Trace:
      [  240.272338]  [<ffffffff813de7b9>] ? usb_hcd_submit_urb+0xa9/0xb10
      [  240.272347]  [<ffffffff81555579>] schedule+0x29/0x70
      [  240.272355]  [<ffffffff815559e6>] schedule_preempt_disabled+0x16/0x20
      [  240.272363]  [<ffffffff81557365>] __mutex_lock_slowpath+0xe5/0x230
      [  240.272372]  [<ffffffff815574c7>] mutex_lock+0x17/0x30
      [  240.272380]  [<ffffffffa063c1d2>] wacom_resume+0x22/0x50 [wacom]
      [  240.272396]  [<ffffffffa01aea8a>] hid_resume_common+0xba/0x110 [usbhid]
      [  240.272404]  [<ffffffff813e5890>] ? usb_runtime_suspend+0x80/0x80
      [  240.272417]  [<ffffffffa01aeb1d>] hid_resume+0x3d/0x70 [usbhid]
      [  240.272425]  [<ffffffff813e44a6>] usb_resume_interface.isra.6+0xb6/0x120
      [  240.272432]  [<ffffffff813e4774>] usb_resume_both+0x74/0x140
      [  240.272439]  [<ffffffff813e58aa>] usb_runtime_resume+0x1a/0x20
      [  240.272446]  [<ffffffff813b1912>] __rpm_callback+0x32/0x70
      [  240.272453]  [<ffffffff813b1976>] rpm_callback+0x26/0xa0
      [  240.272460]  [<ffffffff813b2d71>] rpm_resume+0x4b1/0x690
      [  240.272468]  [<ffffffff812ab992>] ? radix_tree_lookup_slot+0x22/0x50
      [  240.272475]  [<ffffffff813b2c1a>] rpm_resume+0x35a/0x690
      [  240.272482]  [<ffffffff8116e9c9>] ? zone_statistics+0x89/0xa0
      [  240.272489]  [<ffffffff813b2f90>] __pm_runtime_resume+0x40/0x60
      [  240.272497]  [<ffffffff813e4272>] usb_autopm_get_interface+0x22/0x60
      [  240.272509]  [<ffffffffa01ae8d9>] usbhid_open+0x59/0xe0 [usbhid]
      [  240.272517]  [<ffffffffa063ac85>] wacom_open+0x35/0x50 [wacom]
      [  240.272525]  [<ffffffff813f37b9>] input_open_device+0x79/0xa0
      [  240.272534]  [<ffffffffa048d1c1>] evdev_open+0x1b1/0x200 [evdev]
      [  240.272543]  [<ffffffff811c899e>] chrdev_open+0xae/0x1f0
      [  240.272549]  [<ffffffff811c88f0>] ? cdev_put+0x30/0x30
      [  240.272556]  [<ffffffff811c17e2>] do_dentry_open+0x1d2/0x320
      [  240.272562]  [<ffffffff811c1cd1>] finish_open+0x31/0x50
      [  240.272571]  [<ffffffff811d2202>] do_last.isra.36+0x652/0xe50
      [  240.272579]  [<ffffffff811d2ac7>] path_openat+0xc7/0x6f0
      [  240.272586]  [<ffffffff811cf012>] ? final_putname+0x22/0x50
      [  240.272594]  [<ffffffff811d42d2>] ? user_path_at_empty+0x72/0xd0
      [  240.272602]  [<ffffffff811d43fd>] do_filp_open+0x4d/0xc0
      [...]
      
      So here, wacom_open is called, and then wacom_resume is called by the
      PM system. However, wacom_open already took the lock when wacom_resume
      tries to get it. Freeze.
      
      A little bit of history shows that this already happened in the past
      - commit f6cd3783 ("Input: wacom - fix runtime PM related deadlock"),
      and the solution was to call first the PM function before taking the lock.
      
      The lock was introduced in commit commit e7224094 ("Input: wacom -
      implement suspend and autosuspend") when the autosuspend feature has
      been added. Given that usbhid already takes care of this very same
      locking between suspend/resume, I think we can simply kill the lock
      in open/close.
      
      The lock is now used also with LEDs, so we can not remove it completely.
      Reported-by: default avatarHans Spath <inbox-546@hans-spath.de>
      Tested-by: default avatarHans Spath <inbox-546@hans-spath.de>
      CC: stable@vger.kernel.org # v3.17+
      Signed-off-by: default avatarBenjamin Tissoires <benjamin.tissoires@redhat.com>
      Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
      dff67416
    • Benjamin Tissoires's avatar
      HID: wacom: re-add accidentally dropped Lenovo PID · 00d6f227
      Benjamin Tissoires authored
      Dropped in the following commit:
      
      commit a3e6f654 ("Input: wacom - keep wacom_ids ordered")
      Reported-by: default avatarHans Spath <inbox-546@hans-spath.de>
      CC: stable@vger.kernel.org    # v3.17+
      Signed-off-by: default avatarBenjamin Tissoires <benjamin.tissoires@redhat.com>
      Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
      00d6f227
  3. 03 Nov, 2014 2 commits
  4. 29 Oct, 2014 1 commit
  5. 20 Oct, 2014 1 commit
  6. 10 Oct, 2014 2 commits
  7. 08 Oct, 2014 10 commits
    • Linus Torvalds's avatar
      Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid · 39520eea
      Linus Torvalds authored
      Pull HID updates from Jiri Kosina:
      
       - quirk for devices that need to be pulled in much more aggresive way
         than mandated, by Johan Hovold
      
       - robustification of sanity checking of incoming reports in RMI driver,
         by Benjamin Tissoires
      
       - fixes, updates, and new HW support to SONY driver, by Frank Praznik
      
       - port of uHID to the new transport layer layout, by David Herrmann
      
       - robustification of Clear-Halt/reset in USB HID, by Alan Stern
      
       - native support for hopefully any future HID compliant wacom tablet.
         Those found on the various laptops (ISDv4/5) already are HID
         compliant and they should work in the future without any modification
         of the kernel.  Written by Benjamin Tissoires.
      
       - a lot more simple fixes and device ID additions all over the place
      
      * 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid: (45 commits)
        HID: uHID: fix excepted report type
        HID: usbhid: add another mouse that needs QUIRK_ALWAYS_POLL
        HID: wacom: implement the finger part of the HID generic handling
        HID: wacom: implement generic HID handling for pen generic devices
        HID: wacom: move allocation of inputs earlier
        HID: wacom: split out input allocation and registration
        HID: wacom: rename failN with some meaningful information
        HID: sony: Update the DualShock 4 touchpad resolution
        HID: wacom: fix timeout on probe for some wacoms
        HID: sony: Set touchpad bits in the input_configured callback
        HID: sony: Update file header and correct comments
        HID: sony: Corrections for the DualShock 4 HID descriptor
        HID: rmi: check sanity of the incoming report
        HID: wacom: make the WL connection friendly for the desktop
        HID: wacom - enable LED support for Wireless Intuos5/Pro
        HID: wacom - remove report_id from wacom_get_report interface
        HID: wacom - Clean up of sysfs
        HID: wacom - Add default permission defines for sysfs attributes
        HID: usbhid: fix PIXART optical mouse
        HID: Add Holtek USB ID 04d9:a0c2 ETEKCITY Scroll
        ...
      39520eea
    • Linus Torvalds's avatar
      Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial · 28596c97
      Linus Torvalds authored
      Pull "trivial tree" updates from Jiri Kosina:
       "Usual pile from trivial tree everyone is so eagerly waiting for"
      
      * 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial: (39 commits)
        Remove MN10300_PROC_MN2WS0038
        mei: fix comments
        treewide: Fix typos in Kconfig
        kprobes: update jprobe_example.c for do_fork() change
        Documentation: change "&" to "and" in Documentation/applying-patches.txt
        Documentation: remove obsolete pcmcia-cs from Changes
        Documentation: update links in Changes
        Documentation: Docbook: Fix generated DocBook/kernel-api.xml
        score: Remove GENERIC_HAS_IOMAP
        gpio: fix 'CONFIG_GPIO_IRQCHIP' comments
        tty: doc: Fix grammar in serial/tty
        dma-debug: modify check_for_stack output
        treewide: fix errors in printk
        genirq: fix reference in devm_request_threaded_irq comment
        treewide: fix synchronize_rcu() in comments
        checkstack.pl: port to AArch64
        doc: queue-sysfs: minor fixes
        init/do_mounts: better syntax description
        MIPS: fix comment spelling
        powerpc/simpleboot: fix comment
        ...
      28596c97
    • Linus Torvalds's avatar
      Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/doc · b6420ebd
      Linus Torvalds authored
      Pull documentation updates from Jiri Kosina:
       "Updates to kernel documentation.
      
        I took this over (hopefully temporarily) from Randy who was not
        willing to maintain it any longer.  This pile mostly is a relay of
        queue that Randy already had in his tree"
      
      * 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/doc:
        Documentation: fix broken v4l-utils URL
        Documentation: update include path for mpssd
        Documentation: correct parameter error for dma_mapping_error
        MAINTAINERS: update location of linux-doc tree
        Documentation: remove networking/.gitignore
        tools: add more endian.h macros
        Make Documenation depend on headers_install
        Docs: this_cpu_ops: remove redundant add forms
        Documentation: disable vdso_test to avoid breakage with old glibc
        Documentation: update vDSO makefile to build portable examples
        Documentation: update .gitignore files
        Documentation: support glibc versions without htole macros
        v4l2-pci-skeleton: Only build if PCI is available
        Documentation: fix misc. warnings
        Documentation: make functions static to avoid prototype warnings
        Documentation: add makefiles for more targets
        Documentation: use subdir-y to avoid unnecessary built-in.o files
      b6420ebd
    • Linus Torvalds's avatar
      Merge tag 'spi-v3.18' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi · d2901069
      Linus Torvalds authored
      Pull spi updates from Mark Brown:
       "A quiet release for SPI, mainly driver updates and not too many of
        them:
      
         - Support for dummy transfers (for delays on startup) in drivers
           using transfer_one().
         - Lots of enhancements to the Designware driver to support new Intel
           SoCs.
         - Support for newer Renesas chips.
         - DMA support for the i.MX driver.
         - One new driver for Broadcom BCM53xx chips"
      
      * tag 'spi-v3.18' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi: (64 commits)
        spi: spi-mxs: fix a tiny typo in a comment
        spi: dw-mid: follow new DMAengine workflow
        spi: dw-mid: convert to use DMAengine wrappers
        spi: dw-mid: change magic numbers to the constants
        spi: orion: support armada extended baud rates
        spi: fsl: Sort include headers alphabetically
        spi: bcm53xx: Add missing module information
        spi: bcm53xx: Fix module dependency
        spi/rockchip: fix bug that cause the failure to read data in DMA mode
        spi: fsl-dspi: Remove probe info message
        spi: pl022: Add support for chip select extension
        spi: Fix possible ZERO_SIZE_PTR pointer dereferencing error.
        spi: dw: fix style of code in few places
        spi: dw: introduce support of loopback mode
        spi: dw-mid: terminate ongoing transfers at exit
        spi: dw-mid: respect 8 bit mode
        spi: clps711x: Migrate to the new clk subsystem
        spi: pl022: Add missing error check for devm_kzalloc
        spi: spi-imx: add DMA support
        spi: davinci: add support for adding delay between word's transmissions
        ...
      d2901069
    • Linus Torvalds's avatar
      Merge tag 'regulator-v3.18' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator · 81e29b7d
      Linus Torvalds authored
      Pull regulator updates from Mark Brown:
       "This time around most of the changes are a lot of new drivers along
        with the standard set of fixes and cleanups (thanks again largely to
        Axel Lin).  We do have one nice new feature in the core which factors
        out the disappointingly tricky code around DT parsing, only a couple
        of drivers have been converted so far:
      
         - Factor out the code for parsing the standard bindings for a set of
           regulators out of DT, making the probe part of a lot of drivers
           simplier.
         - New drivers for Dialog DA9213, HiSilicon HI6420, Intersil
           ISL9305/H, Ricoh RN5T618, Rockchip RK808, Skyworks SKY81452,
           Silergy SYR82x, and Qualcomm RPM"
      
      * tag 'regulator-v3.18' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator: (71 commits)
        regulator: da9211: Fix a bug in update of mask bit
        regulator: pwm-regulator: add devicetree bindings for pwm regulator
        regulator: pwm-regulator: get voltage and duty table from dts
        regulator: qcom_rpm: Fix FORCE_MODE_IS_2_BITS macro
        regulator: qcom_rpm: Don't explicitly initialise the first field of config
        regulator: ltc3589: fix broken voltage transitions
        regulator: qcom-rpm: Regulator driver for the Qualcomm RPM
        regulator: axp20x: Use parent device as regulator configuration device
        regulator: fan53555: Fix null pointer dereference
        regulator: fan53555: Fixup report wrong vendor message
        regulator: fan53555: fix wrong cast in probe
        regulator: fan53555: add support for Silergy SYR82x regulators
        regulator: fan53555: add devicetree support
        regulator: add devicetree bindings for Fairchild FAN53555 regulators
        regulator: rk808: Add function for ramp delay for buck1/buck2
        regulator: fan53555: use set_ramp_delay to set the ramp up slew rate
        regulator: fan53555: enable vin supply
        regulator: rk808: Fix missing of_node_put
        regulator: rk808: Remove unused variables
        regulator: of: Add stub OF match function for !OF case
        ...
      81e29b7d
    • Linus Torvalds's avatar
      Merge tag 'regmap-v3.18' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regmap · c831dd73
      Linus Torvalds authored
      Pull regmap updates from Mark Brown:
       "The main update this time around is the addition of a standard DT
        binding for specifying the endianness of devices.  This allows drivers
        to support any endianness of device register map without any code,
        useful for configurable IP blocks.
      
        There's also a few bug fixes that I didn't get round to sending, none
        of them terribly severe or new, and a reduction in size for struct
        regmap"
      
      * tag 'regmap-v3.18' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regmap:
        regmap: Fix debugfs-file 'registers' mode
        regmap: fix possible ZERO_SIZE_PTR pointer dereferencing error.
        regmap: debugfs: fix possbile NULL pointer dereference
        regmap: fix NULL pointer dereference in _regmap_write/read
        regmap: fix NULL pointer dereference in regmap_get_val_endian
        regmap: cache: Do not fail silently from regcache_sync calls
        regmap: change struct regmap's internal locks as union
        regmap: Split regmap_get_endian() in two functions
        regmap: of_regmap_get_endian() cleanup
        regmap: Fix DT endianess parsing logic
        regmap: Add explicit dependencies to catch "select" misuse
        regmap: Restore L: linux-kernel@vger.kernel.org entry
        regmap: Add the DT binding documentation for endianness
        regmap: add DT endianness binding support.
      c831dd73
    • Linus Torvalds's avatar
      Merge tag 'pinctrl-v3.18-1' of git://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl · 2b425a3f
      Linus Torvalds authored
      Pull pin control changes from Linus Walleij:
       "This is the bulk of pin control changes for the v3.18 development
        series:
      
         - New drivers for the Freescale i.MX21, Qualcomm APQ8084 pin
           controllers.
      
         - Incremental new features on the Rockchip, atlas 6, OMAP, AM437x,
           APQ8064, prima2, AT91, Tegra, i.MX, Berlin and Nomadik.
      
         - Push Freescale drivers down into their own subdirectory.
      
         - Assorted sprays of syntax and semantic fixes"
      
      * tag 'pinctrl-v3.18-1' of git://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl: (48 commits)
        pinctrl: specify bindings for pins and groups
        pinctrl: nomadik: improve GPIO debug prints
        pinctrl: abx500: refactor DT parser to take two paths
        pinctrl: abx500: use helpers for map allocation/free
        pinctrl: alter device tree bindings for functions
        pinctrl: nomadik: refactor DT parser to take two paths
        pinctrl: nomadik: use utils map free function
        pinctrl: nomadik: use util function to reserve maps
        pinctrl: qcom: use restart_notifier mechanism for ps_hold
        pinctrl: sh-pfc: sh73a0: Remove unnecessary SoC data allocation
        pinctrl: berlin: fix the dt_free_map function
        pinctrl: at91: disable PD or PU before enabling PU or PD
        pinctrl: st: remove gpiochip in failure cases
        pinctrl: at91: Fix error handling while doing gpiochio_irqchip_add
        pinctrl: at91: Fix failure path in at91_gpio_probe path
        pinctrl: lantiq: Release gpiochip resources in fail case
        pinctrl: imx: detect uninitialized pins
        pinctrl: tegra: Add MIPI pad control
        pinctrl: at91: Switch to using managed clk_get
        pinctrl: adi2: Remove duplicate gpiochip_remove_pin_ranges
        ...
      2b425a3f
    • Linus Torvalds's avatar
      Merge tag 'edac_for_3.18' of git://git.kernel.org/pub/scm/linux/kernel/git/bp/bp · c91662cb
      Linus Torvalds authored
      Pull EDAC fixes from Borislav Petkov:
       "Misc small fixes/improvements accumulated from the summer months,
        nothing earth-shattering.
      
        The mpc85xx_edac fix is tagged for stable but since it got confirmed
        only days before the final 3.17 release, I didn't rush a last minute
        pull request to you.  I hope that's ok as it will trickle down to
        stable anyway and we'll make sure it lands in 3.17-stable too"
      
      * tag 'edac_for_3.18' of git://git.kernel.org/pub/scm/linux/kernel/git/bp/bp:
        mpc85xx_edac: Make L2 interrupt shared too
        amd64_edac: Modify usage of amd64_read_dct_pci_cfg()
        ppc4xx_edac: Fix build error caused by wrong member access
        EDAC: Fix mem_types strings type
      c91662cb
    • Linus Torvalds's avatar
      Merge tag 'dmaengine-3.17' of git://git.kernel.org/pub/scm/linux/kernel/git/djbw/dmaengine · d0cd8481
      Linus Torvalds authored
      Pull dmaengine updates from Dan Williams:
       "Even though this has fixes marked for -stable, given the size and the
        needed conflict resolutions this is 3.18-rc1/merge-window material.
      
        These patches have been languishing in my tree for a long while.  The
        fact that I do not have the time to do proper/prompt maintenance of
        this tree is a primary factor in the decision to step down as
        dmaengine maintainer.  That and the fact that the bulk of drivers/dma/
        activity is going through Vinod these days.
      
        The net_dma removal has not been in -next.  It has developed simple
        conflicts against mainline and net-next (for-3.18).
      
        Continuing thanks to Vinod for staying on top of drivers/dma/.
      
        Summary:
      
         1/ Step down as dmaengine maintainer see commit 08223d80
            "dmaengine maintainer update"
      
         2/ Removal of net_dma, as it has been marked 'broken' since 3.13
            (commit 77873803 "net_dma: mark broken"), without reports of
            performance regression.
      
         3/ Miscellaneous fixes"
      
      * tag 'dmaengine-3.17' of git://git.kernel.org/pub/scm/linux/kernel/git/djbw/dmaengine:
        net: make tcp_cleanup_rbuf private
        net_dma: revert 'copied_early'
        net_dma: simple removal
        dmaengine maintainer update
        dmatest: prevent memory leakage on error path in thread
        ioat: Use time_before_jiffies()
        dmaengine: fix xor sources continuation
        dma: mv_xor: Rename __mv_xor_slot_cleanup() to mv_xor_slot_cleanup()
        dma: mv_xor: Remove all callers of mv_xor_slot_cleanup()
        dma: mv_xor: Remove unneeded mv_xor_clean_completed_slots() call
        ioat: Use pci_enable_msix_exact() instead of pci_enable_msix()
        drivers: dma: Include appropriate header file in dca.c
        drivers: dma: Mark functions as static in dma_v3.c
        dma: mv_xor: Add DMA API error checks
        ioat/dca: Use dev_is_pci() to check whether it is pci device
      d0cd8481
    • Linus Torvalds's avatar
      Merge tag 'modules-next-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/rusty/linux · bdf428fe
      Linus Torvalds authored
      Pull module update from Rusty Russell:
       "Nothing major: support for compressing modules, and auto-tainting
        params.
      
        PS. My virtio-next tree is empty: DaveM took the patches I had.  There
            might be a virtio-rng starvation fix, but so far it's a bit voodoo
            so I will get to that in the next two days or it will wait"
      
      * tag 'modules-next-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/rusty/linux:
        moduleparam: Resolve missing-field-initializer warning
        kbuild: handle module compression while running 'make modules_install'.
        modinst: wrap long lines in order to enhance cmd_modules_install
        modsign: lookup lines ending in .ko in .mod files
        modpost: simplify file name generation of *.mod.c files
        modpost: reduce visibility of symbols and constify r/o arrays
        param: check for tainting before calling set op.
        drm/i915: taint the kernel if unsafe module parameters are set
        module: add module_param_unsafe and module_param_named_unsafe
        module: make it possible to have unsafe, tainting module params
        module: rename KERNEL_PARAM_FL_NOARG to avoid confusion
      bdf428fe
  8. 07 Oct, 2014 6 commits
    • Linus Torvalds's avatar
      Merge branch 'ipmi' (patches from Corey Minyard) · a40a7201
      Linus Torvalds authored
      Merge ipmi patches from Corey Minyard:
       "These have been in linux-next for a while, ready for 3.18"
      
      * emailed patches from Corey Minyard <minyard@acm.org>:
        ipmi: Clear drvdata when interface is removed
        ipmi: work around gcc-4.9 build warning
        ipmi/of: Don't use unavailable interfaces
        ipmi: Clean up the error handling for channel config errors
      a40a7201
    • Takao Indoh's avatar
      ipmi: Clear drvdata when interface is removed · 567eded9
      Takao Indoh authored
      This patch fixes a bug on hotmod removing.
      
      After ipmi interface is removed using hotmod, kernel panic occurs when
      rmmod impi_si.  For example, try this:
      
       # echo "remove,"`cat /proc/ipmi/0/params` > \
       /sys/module/ipmi_si/parameters/hotmod
       # rmmod ipmi_si
      
      Then, rmmod fails with the following messages.
      
        ------------[ cut here ]------------
        WARNING: CPU: 12 PID: 10819 at /mnt/repos/linux/lib/list_debug.c:53 __list_del_entry+0x63/0xd0()
        CPU: 12 PID: 10819 Comm: rmmod Not tainted 3.17.0-rc1 #19
        Hardware name: FUJITSU-SV PRIMERGY BX920 S2/D3030, BIOS 080015 Rev.3D81.3030 02/10/2012
        Call Trace:
          dump_stack+0x45/0x56
          warn_slowpath_common+0x7d/0xa0
          warn_slowpath_fmt+0x4c/0x50
          __list_del_entry+0x63/0xd0
          list_del+0xd/0x30
          cleanup_one_si+0x2a/0x230 [ipmi_si]
          ipmi_pnp_remove+0x15/0x20 [ipmi_si]
          pnp_device_remove+0x24/0x40
          __device_release_driver+0x7f/0xf0
          driver_detach+0xb0/0xc0
          bus_remove_driver+0x55/0xd0
          driver_unregister+0x2c/0x50
          pnp_unregister_driver+0x12/0x20
          cleanup_ipmi_si+0xbc/0xf0 [ipmi_si]
          SyS_delete_module+0x132/0x1c0
          system_call_fastpath+0x16/0x1b
        ---[ end trace 70b4377268f85c23 ]---
      
      list_del in cleanup_one_si() fails because the smi_info is already
      removed when hotmod removing.
      
      When ipmi interface is removed by hotmod, smi_info is removed by
      cleanup_one_si(), but is is still set in drvdata.  Therefore when rmmod
      ipmi_si, ipmi_pnp_remove tries to remove it again and fails.
      
      By this patch, a pointer to smi_info in drvdata is cleared when hotmod
      removing so that it will be not accessed when rmmod.
      
      changelog:
      v2:
      - Clear drvdata in cleanup_one_si
      - Change subject
      
      v1:
      https://lkml.org/lkml/2014/9/8/741Signed-off-by: default avatarTakao Indoh <indou.takao@jp.fujitsu.com>
      Signed-off-by: default avatarCorey Minyard <cminyard@mvista.com>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      567eded9
    • Arnd Bergmann's avatar
      ipmi: work around gcc-4.9 build warning · cc4cbe90
      Arnd Bergmann authored
      Building ipmi on arm with gcc-4.9 results in this warning for an
      allmodconfig build:
      
        drivers/char/ipmi/ipmi_si_intf.c: In function 'ipmi_thread':
        include/linux/time.h:28:5: warning: 'busy_until.tv_sec' may be used uninitialized in this function [-Wmaybe-uninitialized]
          if (lhs->tv_sec > rhs->tv_sec)
             ^
        drivers/char/ipmi/ipmi_si_intf.c:1007:18: note: 'busy_until.tv_sec' was declared here
          struct timespec busy_until;
                          ^
      
      The warning is bogus and this case can not occur.  Apparently this is a
      false positive resulting from gcc getting a little smarter about
      tracking assignments but not smart enough.
      
      Marking the ipmi_thread_busy_wait function as inline gives the gcc
      optimization logic enough information to figure out for itself that the
      case cannot happen, which gets rid of the warning without adding any
      fake initialization.
      Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
      Signed-off-by: default avatarCorey Minyard <cminyard@mvista.com>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      cc4cbe90
    • Benjamin Herrenschmidt's avatar
      ipmi/of: Don't use unavailable interfaces · 08dc4169
      Benjamin Herrenschmidt authored
      If an IPMI controller is used by the firmware and as such marked with
      a reserved status, we shouldn't use it.
      Signed-off-by: default avatarBenjamin Herrenschmidt <benh@kernel.crashing.org>
      Signed-off-by: default avatarCorey Minyard <cminyard@mvista.com>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      08dc4169
    • Corey Minyard's avatar
      ipmi: Clean up the error handling for channel config errors · 1f668423
      Corey Minyard authored
      The code to send the channel config errors was missing an error report
      in one place and needed some more information in another, and had an
      extraneous bit of code.  Clean all that up.
      Signed-off-by: default avatarCorey Minyard <cminyard@mvista.com>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      1f668423
    • Linus Torvalds's avatar
      Merge tag 'tiny/for-3.18' of git://git.kernel.org/pub/scm/linux/kernel/git/josh/linux · 74da3863
      Linus Torvalds authored
      Pull "tinification" patches from Josh Triplett.
      
      Work on making smaller kernels.
      
      * tag 'tiny/for-3.18' of git://git.kernel.org/pub/scm/linux/kernel/git/josh/linux:
        bloat-o-meter: Ignore syscall aliases SyS_ and compat_SyS_
        mm: Support compiling out madvise and fadvise
        x86: Support compiling out human-friendly processor feature names
        x86: Drop support for /proc files when !CONFIG_PROC_FS
        x86, boot: Don't compile early_serial_console.c when !CONFIG_EARLY_PRINTK
        x86, boot: Don't compile aslr.c when !CONFIG_RANDOMIZE_BASE
        x86, boot: Use the usual -y -n mechanism for objects in vmlinux
        x86: Add "make tinyconfig" to configure the tiniest possible kernel
        x86, platform, kconfig: move kvmconfig functionality to a helper
      74da3863
  9. 06 Oct, 2014 1 commit
  10. 05 Oct, 2014 2 commits
  11. 04 Oct, 2014 1 commit
  12. 03 Oct, 2014 11 commits