Skip to content

L
linux
Switch branch/tag
  1. 05 May, 2008 6 commits
    • Jeremy Kerr's avatar
      [POWERPC] spufs: don't acquire state_mutex interruptible while performing callback · d29694f0
      Jeremy Kerr authored 
      There's currently no way to tell if spu_process_callback has
returned with the state mutex held, as -EINTR may be returned
by either the syscall or the spu_acquire fail case.

Instead, just do a non-interruptible mutex_lock here.
Signed-off-by: default avatarJeremy Kerr <jk@ozlabs.org>
      d29694f0
    • Jeremy Kerr's avatar
      [POWERPC] spufs: update master runcntl with context lock held · c0bace5c
      Jeremy Kerr authored 
      Currently, we update the SPU master run control bit (ie,
spu_enable_spu) in spufs_run_spu before we grab the context mutex. This
can result in races with other processes accessing this context's
resources.

This change moves the spu_enable_spu to after we have acquired the
context lock.
Signed-off-by: default avatarJeremy Kerr <jk@ozlabs.org>
      c0bace5c
    • Jeremy Kerr's avatar
      [POWERPC] spufs: fix post-stopped update of MFC_CNTL register · 55d7cd74
      Jeremy Kerr authored 
      We currently have two issues with the MFC save code:

 * save_mfc_decr doesn't handle a transition of 1 -> 0 of the Ds bit
 * The Q bit may be stale in the CSA

This change fixes the first issue by clearing the relevant bits from
the MFC_CNTL value in the CSA before or-ing in the updated status.
Also, we add the Q bit to the updated status.
Signed-off-by: default avatarJeremy Kerr <jk@ozlabs.org>
      55d7cd74
    • Jeremy Kerr's avatar
      [POWERPC] spufs: fix save of mfc_cntl register · 1ca4264e
      Jeremy Kerr authored 
      Currently, we can introduce invalid entries into the MFC queues:

1) context starts a DMA

2) context gets scheduled out during a DMA
  - kernel saves MFC queue to CSA
  - kernel saves 0x0 in csa->mfc_control_RW

3) context gets scheduled in
  - csa->mfc_control[Q] ('queues empty') isn't set, so DMA queues are
    restored from the CSA

4) context's DMA is completed

5) context gets scheduled out again, no DMA occuring this time
  - kernel sees that MFC_CNTL[Q] ('queues empty') is set, so doesn't
    touch saved queue data in CSA
  - kernel saves 0x0 in csa->mfc_control_RW

6) context gets scheduled in
  - csa->mfc_control[Q] ('queues empty') isn't set (we saved is as 0!),
    so DMA queues are restored from the CSA

In this last restore, we've restored the queue status from step 2,
which are now invalid.

This change makes save_mfc_cntl() closer to the save/restore sequence,
as specified in the CBE handbook.

With changes from Luke Browning.
Signed-off-by: default avatarJeremy Kerr <jk@ozlabs.org>
      1ca4264e
    • Jeremy Kerr's avatar
      [POWERPC] spufs: don't touch suspend bits when purging DMA queue · 943906ba
      Jeremy Kerr authored 
      When we issue a MFC purge request, we may inadvertantly clear the
suspended status.

This change adds the MFC_CNTL_SUSPEND_MASK when we issue a purge
request, so that the suspend bit is masked out.
Signed-off-by: default avatarJeremy Kerr <jk@ozlabs.org>
      943906ba
    • Jeremy Kerr's avatar
      [POWERPC] cell: Fix lost interrupts due to fasteoi handler · 5711fe90
      Jeremy Kerr authored 
      We may currently lose interrupts during SPE context switch, as we alter
the INT_Route register. Because the IIC uses a per-thread priority
status, changing the interrupt routing to a different thread means that
the IRQ is no longer masked by the priority status, so we end up with
two fasteoi IRQ handlers executing for the one irq_desc. The fasteoi
handler doesn't handle multiple IRQs, so drops the second one.

Fix this by using our own flow handler. This is based on
handle_edge_irq, but issues an eoi after IRQs are handled, and doesn't
do any mask/unmasking.
Signed-off-by: default avatarJeremy Kerr <jk@ozlabs.org>
      5711fe90
  3. 02 May, 2008 11 commits
  5. 01 May, 2008 2 commits
  7. 30 Apr, 2008 10 commits
  9. 29 Apr, 2008 11 commits
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7