- 05 Aug, 2010 4 commits
-
-
Ville Syrjälä authored
Once the DSI PLL is separated from the DSI display a full DSI reset will not be performed every time the display is enabled so the interface and VCs must be disabled when disabling the display. If the VCs are not disabled some register accesses will abort. Signed-off-by:
Ville Syrjälä <ville.syrjala@nokia.com> Signed-off-by:
Tomi Valkeinen <tomi.valkeinen@nokia.com>
-
Tomi Valkeinen authored
The TRM tells us to wait for the DSI PLL derived clocks to become active before selecting them for use. I didn't actually have any issues which this would fix but according to the TRM it seems to be the right thing to do. Signed-off-by:
-
Ville Syrjälä authored
Print an error message if dsi_calc_clock_rates() fails just like it's done when dispc_calc_clock_rates() fails. Signed-off-by:
-
Ville Syrjälä authored
Do not leave the free running pixel clock enabled if the DSI PLL reset times out. Signed-off-by:
-
- 03 Aug, 2010 36 commits
-
-
Jani Nikula authored
Prepare for supporting panels other than Taal in this driver. Signed-off-by:
Jani Nikula <ext-jani.1.nikula@nokia.com> Signed-off-by:
-
Tomi Valkeinen authored
Add support for configuring regulators in the panel specific configuration data. Signed-off-by:
-
Jani Nikula authored
The driver will support other panels in addition to Taal, print also the name. Signed-off-by:
-
Jani Nikula authored
Add a structure for panel specific configration to be able to support more than one panel in the future. Signed-off-by:
-
Jani Nikula authored
Make ESD check usage configurable in DSI panel data, as opposed to a define. Signed-off-by:
-
Tomi Valkeinen authored
Get board specific information from the Nokia DSI panel data structure instead of the DSS. Signed-off-by:
-
Jani Nikula authored
Introduce a configuration struct for platform/board specific information of Nokia DSI command mode panels, to be used in addition to struct omap_dss_device (passed via the 'void *data' member). Signed-off-by:
-
Jani Nikula authored
Add gpio irq based external TE support with timeout. Signed-off-by:
-
Jani Nikula authored
Switch from numbered to named labels to make it easier to add new labels for error handling. Signed-off-by:
-
Jani Nikula authored
Move ESD work queuing and cancelling out of taal_power_on/off() to avoid problems related to taal_esd_work() calling the power on/off functions. Signed-off-by:
-
Jani Nikula authored
Change state only if power on was succesful. Signed-off-by:
-
Jani Nikula authored
Move dsi_bus_lock/unlock() out of taal_power_on/off() to avoid deadlock in taal_esd_work(). Signed-off-by:
-
Jani Nikula authored
Bail out from taal_enable_te() and taal_run_test() if panel is not enabled. Signed-off-by:
-
Jani Nikula authored
Check return values and bail out on errors. Signed-off-by:
-
Jani Nikula authored
ESD work is never queued in probe, no need to cancel it on probe error. Signed-off-by:
-
Jani Nikula authored
Separate gpio_request() and request_irq() error handling. Signed-off-by:
-
Jani Nikula authored
After the addition of proper hardware reset, taal_hw_reset(), there's no need for an additional platform enable/disable. Remove them. Signed-off-by:
-
Jani Nikula authored
Avoid potential race conditions in sysfs access to taal data. Signed-off-by:
-
Jani Nikula authored
Issue a proper reset pulse on the reset line instead of just doing power on/off. Signed-off-by:
-
Tomi Valkeinen authored
taal_bl_update_status was missing locks to protect taal_data. This caused a kernel crash randomly, as the code attempted to set the brightness while the OMAP's DSI block was actually disabled. Signed-off-by: -
Tomi Valkeinen authored
Using nanoseconds as arguments to functions that set the DSI timeouts was perhaps not so good idea. The timeouts are based on different DSI clocks, so the possible range for the timeouts vary greatly depending on the clocks. Also, the multipliers used with the timeouts cause big gaps in the timeout range, meaning that the nanosecond based functions could cause the timeout to be quite far from the intended value. This patch changes the functions to take the plain tick values with the multiplier enable/disable bits, and sets the TA/LP_RX/HS_TX timeouts to maximum. While the timeouts could be much lower, the fact is that when TA/LP_RX/HS_TX timeout happens, we are in an error situation and not in a hurry anyway. STOP_STATE_COUNTER is a different matter, but it is only used at initialization time, and won't normally affect the performance. Signed-off-by: -
Tomi Valkeinen authored
Check if the peripheral answered something, and if so, dump the data and return an error. Signed-off-by: -
Tomi Valkeinen authored
Change dsi_vc_dcs_read_2() data parameter to two u8 parameters to make the byte-order clear. Signed-off-by: -
Tomi Valkeinen authored
Using the shared workqueue led to to a deadlock in the case where the display was unblanked via keyboard. What happens is something like this: - User presses a key context 1: - drivers/char/keyboard.c calls schedule_console_callback() - fb_unblank takes the console semaphore - dsi bus lock is taken, and frame transfer is started (dsi bus lock is left on) - Unblank code tries to set the panel backlight, which tries to take dsi bus lock, but is blocked while the frame transfer is going on context 2, shared workqueue, console_callback in drivers/char/vt.c: - Tries to take console semaphore - Blocks, as console semaphore is being held by context 1 - No other shared workqueue work can be run context 3, HW irq, caused by FRAMEDONE interrupt: - Interrupt handler schedules framedone-work in shared workqueue - Framedone-work is never ran, as the shared workqueue is blocked. This means that the unblank thread stays blocked, which means that context 2 stays blocked. While I think the real problem is in keyboard/virtual terminal code, using a private workqueue in the DSI driver is perhaps safer and more robust than using the shared one. The DSI works should not be delayed more than a millisecond or so, and even if the private workqueue gives us no hard promise of doing so, it's still safer bet than the shared workqueue. Signed-off-by: -
Tomi Valkeinen authored
dsi_vc_flush_receive_data() is meant to dump data when something has gone wrong, and thus we should use DSSERR, not DSSDBG. Signed-off-by: -
Ville Syrjälä authored
Trigger WARN_ON() messages from various places in the code in case the memory region is not currently locked. Signed-off-by:
-
Ville Syrjälä authored
When more than one memory region needs to be lockd at the same time use the memory region id to fix the order in which the locks are taken. Also one needs to use the _nested() versions of the locking primitives. The memory region id can serve as the lock class there as well. Signed-off-by:
-
Ville Syrjälä authored
R/W semaphore is a good fit for the memory region locking pattern. So use it. Signed-off-by:
-
Ville Syrjälä authored
Add locking to the memory regions to make sure the memory region size won't be changed while some other piece of code is performing some checks or setup based on that information. Signed-off-by:
-
Ville Syrjälä authored
Separate the memory region from the framebuffer device a little bit. It's now possible to select the memory region used by the framebuffer device using the new mem_idx parameter of omapfb_plane_info. If the mem_idx is specified it will be interpreted as an index into the memory regions array, if it's not specified the framebuffer's index is used instead. So by default each framebuffer keeps using it's own memory region which preserves backwards compatibility. This allows cloning the same memory region to several overlays and yet each overlay can be controlled independently since they can be associated with separate framebuffer devices. Signed-off-by:
-
Ville Syrjälä authored
In omapfb_enable_overlay() if the overlay state is already what we want skip the set_overlay_info(). Signed-off-by:
-
Ville Syrjälä authored
If video memory hasn't been allocate have check_fb_var() still check most of the settings, just skip the ones involving the size of the memory region. Also skip the memory address calculations in omapfb_setup_overlay() if there's no memory. Signed-off-by:
-
Ville Syrjälä authored
Split the overlay address calculations into their own function. Signed-off-by:
-
Tomi Valkeinen authored
When there are multiple scaled overlays simply checking whether the update area intersects any of them in order is not enough. If eg. VID1 starts out completely outside the update area but VID2 causes the update area to increase in such a way that VID1 now falls partially within the increased update area VID1 should be rechecked and the update area possibly increased even further to fully encompass VID1. So simply keep looping over the overlays until such time that none of the overlays caused the update area to change. Signed-off-by:
-
Ville Syrjälä authored
When DSS transitions from off mode to on VENC may generate a spurious SYNC_LOST_DIGIT error. Just ack it when restoring the context. Also restore IRQENABLE last to avoid triggering interrupts before the context is fully restored. Signed-off-by:
-
Ville Syrjälä authored
When the display is not active make the wait_for_go() functions return immediately. Signed-off-by:
-
