- 30 Aug, 2014 40 commits
-
-
H Hartley Sweeten authored
Use the new comedi_subdevice 'readback' member and the core provided (*insn_read) for the readback of the analog output subdevice channels. For aesthetics, tidy up pcl812_ao_insn_write(). Signed-off-by:
H Hartley Sweeten <hsweeten@visionengravers.com> Reviewed-by:
Ian Abbott <abbotti@mev.co.uk> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
H Hartley Sweeten authored
Use the new comedi_subdevice 'readback' member and the core provided (*insn_read) for the readback of the analog output subdevice channels. Signed-off-by:
-
H Hartley Sweeten authored
Use the new comedi_subdevice 'readback' member and the core provided (*insn_read) for the readback of the analog output subdevice channels. Signed-off-by:
-
H Hartley Sweeten authored
Use the new comedi_subdevice 'readback' member and the core provided (*insn_read) for the readback of the analog output subdevice channels. For aesthetics, rename the (*insn_write) function and tidy it up a bit. Signed-off-by:
-
H Hartley Sweeten authored
Use the new comedi_subdevice 'readback' member and the core provided (*insn_read) for the readback of the analog output subdevice channels. Signed-off-by:
-
H Hartley Sweeten authored
Use the new comedi_subdevice 'readback' member and the core provided (*insn_read) for the readback of the analog output subdevice channels. For aesthetics, rename the (*insn_write) function and tidy it up a bit. Signed-off-by:
-
H Hartley Sweeten authored
Use the new comedi_subdevice 'readback' member and the core provided (*insn_read) for the readback of the analog output subdevice channels. Signed-off-by:
-
H Hartley Sweeten authored
Use the new comedi_subdevice 'readback' member and the core provided (*insn_read) for the readback of the analog output subdevice channels. Signed-off-by:
-
H Hartley Sweeten authored
Use the new comedi_subdevice 'readback' member and the core provided (*insn_read) for the readback of the analog output subdevice channels. Signed-off-by:
-
H Hartley Sweeten authored
Use the new comedi_subdevice 'readback' member and the core provided (*insn_read) for the readback of the analog output subdevice channels. Remove the unused private data and its allocation. For aesthetics, rename the (*insn_write) and (*insn_read) functions. Signed-off-by:
-
H Hartley Sweeten authored
Use the new comedi_subdevice 'readback' member and the core provided (*insn_read) for the readback of the analog output subdevice channels. Remove the unused private data and its allocation. Signed-off-by:
-
H Hartley Sweeten authored
Use the new comedi_subdevice 'readback' member and the core provided (*insn_read) for the readback of the analog output subdevice channels. Remove the unused private data and its allocation. Signed-off-by:
-
H Hartley Sweeten authored
Use the new comedi_subdevice 'readback' member and the core provided (*insn_read) for the readback of the analog output subdevice channels. Remove the unused private data and its allocation. Signed-off-by:
-
H Hartley Sweeten authored
Use the new comedi_subdevice 'readback' member and the core provided (*insn_read) for the readback of the analog output subdevice channels. Remove the unused private data and its allocation. For aesthetics, rename the (*insn_write) function and tidy it up. Signed-off-by:
-
H Hartley Sweeten authored
Use the new comedi_subdevice 'readback' member and the core provided (*insn_read) for the readback of the analog output subdevice channels. The loop used to write the values could timeout. Move the saving of the readback value so that the last value written is always saved. Remove the unused private data and its allocation. Signed-off-by:
-
H Hartley Sweeten authored
Use the new comedi_subdevice 'readback' member and the core provided (*insn_read) for the readback of the analog output subdevice channels. For aesthetics, rename the (*insn_write) function and tidy it up a bit. Add a comment about the 'readback' member. Signed-off-by:
-
H Hartley Sweeten authored
The analog output hardware in most comedi drivers does not provide a way to readback to last values written to the channels. In order to provide an (*insn_read) for the analog output subdevice, the comedi drivers save the last values for each channel in the private data. Add a new member, 'readback', to the comedi_subdevice definition to provide a common way to save these values. Introduce a comedi core function, comedi_alloc_subdev_readback(), to allocate the memory needed to save the values. This memory will be automatically kfree'd when the driver is detached. Introduce a comedi core function, comedi_readback_insn_read(), that the comedi drivers can use for the (*insn_read) of a subdevice to return the saved values for each channel. This will allow removing the boilerplate in the comedi drivers to return the saved values. In some drivers it will also allow removing the private data completely. Signed-off-by:
-
H Hartley Sweeten authored
Reported by: coverity Signed-off-by:
-
H Hartley Sweeten authored
Reported by: coverity Signed-off-by:
-
H Hartley Sweeten authored
Reported by: coverity Signed-off-by:
-
H Hartley Sweeten authored
Reported by: coverity Signed-off-by:
-
H Hartley Sweeten authored
Reported by: coverity Signed-off-by:
-
H Hartley Sweeten authored
Reported by: coverity Signed-off-by:
-
H Hartley Sweeten authored
Reported by: coverity Signed-off-by:
-
H Hartley Sweeten authored
The 'aref' (CR_AREF) values are all AREF_* defines. The SDF_* defines are subdevice flags. Fix the test in this function. Reported by: coverity Signed-off-by:
-
H Hartley Sweeten authored
The 'aref' (CR_AREF) values are all AREF_* defines. The SDF_* defines are subdevice flags. Fix the test in this function. Reported by: coverity Signed-off-by:
-
H Hartley Sweeten authored
Reported by: coverity Signed-off-by:
-
H Hartley Sweeten authored
Reported by: coverity Signed-off-by:
-
H Hartley Sweeten authored
Reported by: coverity Signed-off-by:
-
H Hartley Sweeten authored
The previous mask by 0xf ensures that calib_source will not be > 0xf. Remove the dead code. Reported by: coverity Signed-off-by:
-
H Hartley Sweeten authored
The local variable 'd' is used to read a 32-bit register. One branch of the code shifts the register value 16 bits to the right to get the high 16-bits. Change the type of the local variable so that this shift works correctly. Reported by: coverity Signed-off-by:
-
H Hartley Sweeten authored
Reported by: coverity Signed-off-by:
-
H Hartley Sweeten authored
Reported by: coverity Signed-off-by:
-
H Hartley Sweeten authored
These should both be checking the -errno. Reported by: coverity Signed-off-by:
-
H Hartley Sweeten authored
This code wants to allocate two arrays of struct urb pointers not two arrays of struct urb objects. The size argument for both kcalloc calls should be sizeof(urb) not sizeof(*urb). Reported by: coverity Signed-off-by:
-
H Hartley Sweeten authored
These should both be checking the -errno. Reported by: coverity Signed-off-by:
-
Ian Abbott authored
The "ni_labpc" module is a Comedi driver for the National Instruments Lab-PC series of ISA data acquistion boards, and also provides common code for the "ni_labpc_pci" and "ni_labpci_cs" modules (for PCI boards and PCMCIA cards). Split out the common code into a new module "ni_labpc_common", leaving the driver for the ISA boards in the existing "ni_labpc" module. This removes the C preprocessor conditional directives from the resulting ".c" files (although they remain in the included header file "ni_labpc_isadma.h"). Unneccessary `#include` directives have been removed from the resulting ".c" files. Signed-off-by:
-
Ian Abbott authored
For consistency, break lines before operators, not after. Signed-off-by:
-
Ian Abbott authored
Fix checkpatch issues "CHECK: Logical continuations should be on the previous line". Signed-off-by:
-
Ian Abbott authored
Fix checkpatch issues "CHECK: Alignment should match open parenthesis". Signed-off-by:
-
