- 28 Jan, 2008 40 commits
-
-
Dan Williams authored
Make it a struct cmd_header, since that's what it is, and clean up the places that it's used. Signed-off-by:
Dan Williams <dcbw@redhat.com> Signed-off-by:
David Woodhouse <dwmw2@infradead.org> Signed-off-by:
John W. Linville <linville@tuxdriver.com>
-
David Woodhouse authored
Signed-off-by:
-
David Woodhouse authored
This prevents us from trying to remove it when it didn't exist, in the error case. Signed-off-by:
-
David Woodhouse authored
Amazing what interesting things the compiler will tell you if you let it know what types you expect to be passing around. Signed-off-by:
-
Dan Williams authored
Signed-off-by:
-
Dan Williams authored
A simple callback which copies the response back into the command buffer that was used to send the command to the card. Will allow for direct command processing outside the mega-switches in cmd.c and cmdresp.c. Signed-off-by:
-
Dan Williams authored
Move direct command handling through __lbs_cmd() over to using the header as the first member of the command structure, and only define the __lbs_cmd() callback in one place rather than 3. Convert boot2 version command to new usage. Signed-off-by:
-
David Woodhouse authored
Signed-off-by:
-
David Woodhouse authored
No need to busy-wait, even if we did have a 100ms delay in the loop. This makes it easier to support the new 'firmware ready' event which is in the new firmware, too. Signed-off-by:
-
David Woodhouse authored
Increase the delay between issuing the RESET command and the usb reset, and be prepared to discard more than one 'normal' packet from it before it resets. Signed-off-by:
-
David Woodhouse authored
Signed-off-by:
-
Dan Williams authored
Total overkill to have an array when there's only one command in it. Signed-off-by:
-
David Woodhouse authored
The firmware is always initialised before we register the netdevices. It's not possible for pre_open_check() to fail. One day we might try loading firmware in ->open(), but still it won't be just a _check_, like this. Signed-off-by:
-
Dan Williams authored
Define a macro that relieves the caller from having to use sizeof on the command structure when calling lbs_cmd(), and move the prototype of __lbs_cmd() to a new cmd.h file. Signed-off-by:
-
David Woodhouse authored
Make it take struct lbs_private as argument; that's all it wants anyway, and all callers were starting off from that. Don't wake the netif queues, because those should be handled elsewhere. And sort out the locking, with a big nasty warning for those who don't have the driver_lock locked when they call it. Oh, and fix if_cs.c to lock the driver_lock before calling it. Signed-off-by:
-
David Woodhouse authored
This will be useful for letting callbacks do stuff like copying the response into a buffer provided by the caller of lbs_cmd() Signed-off-by:
-
Holger Schurig authored
Previously, the display of subscribed events could be wrong. Signed-off-by:
Holger Schurig <hs4233@mail.mn-solutions.de> Signed-off-by:
-
David Woodhouse authored
No need for these any more. We've collapsed all the unneeded nests of functions which needed to keep track of which device the skb belonged to. Signed-off-by:
-
David Woodhouse authored
It replaces two lines of code. And even for those it has to make inferences about things (i.e. which device) which the caller would have just known. Signed-off-by:
-
David Woodhouse authored
Signed-off-by:
-
David Woodhouse authored
The function is only ever called if we're in rtap mode. So the bit in it which is conditional on rtap mode seems a little superfluous. Signed-off-by:
-
David Woodhouse authored
The locking issues with TX, especially TX from multiple netdevs, get _so_ much easier if you do it like this. Signed-off-by:
-
David Woodhouse authored
This was making my brain hurt. Signed-off-by:
-
David Woodhouse authored
I was so busy cleaning up the failure modes that I accidentally forgot to make sure we still free them in the success case. Oops. Signed-off-by:
-
David Woodhouse authored
Fix one of the barriers to simultaneous radiotap and normal operation -- stop misinterpreting the TX packets on the normal devices. We're also going to have to clone the incoming skbs and feed them into both devices, and there seem to be firmware problems with staying associated too. But this is a reasonable start... Signed-off-by:
-
David Woodhouse authored
This lets us bring it up, because eth_validate_addr() succeeds instead of returning -EINVAL. And finally monitor mode seems to (mostly) work. Signed-off-by:
-
David Woodhouse authored
There seems to be no point in doing it as an ieee80211 device instead of a normal netdev, and when we override its ->priv and then call free_ieee80211() it has a distressing tendency to crash horribly. Signed-off-by:
-
David Woodhouse authored
These wrappers only do two things. Firstly, they set the frame type, which isn't necessary since lbs_hard_start_xmit() gets to see which device it belongs to anyway. Secondly, they return -EOPNOTSUPP if the device is in monitor mode. Which is a strange thing to do and will provide nasty warnings from qdisc_restart(). And lbs_hard_start_xmit() seems to have code to cope with monitor mode anyway. Signed-off-by:
-
David Woodhouse authored
Having merged the nest of functions into one, now we can clean it up and fix the error handling, and the duplication -- and at least make a start on the locking. Signed-off-by:
-
David Woodhouse authored
Signed-off-by:
-
David Woodhouse authored
... where it can shortly be merged with lbs_process_tx()... Signed-off-by:
-
David Woodhouse authored
Make a start on reducing the number of pointless nested functions, starting with the StudlyCaps. No semantic changes (yet) -- we can sort out the now-obvious discrepancy in the failure paths in a separate commit. Signed-off-by:
-
David Woodhouse authored
It was buggy as hell anyway, since it was just spewing packets at the device when it wasn't necessarily ready for them (in the USB case, while the URB was still busy). We could probably do with a better way of flushing packets to the device _immediately_, before we stick it back into sleep mode. But we can no longer just dequeue packets directly, it seems. Signed-off-by:
-
David Woodhouse authored
It doesn't need to wait until no commands are pending anyway -- it only needs to wait until the scan is finished. We can hopefully find it something else to wait on too -- it's the only user of the cmd_pending waitqueue. Signed-off-by:
-
David Woodhouse authored
Signed-off-by:
-
David Woodhouse authored
Also attempt some locking in lbs_host_to_card_done() Signed-off-by:
-
David Woodhouse authored
There seems to be no reason for a separate structure; move it all into struct lbs_private. Signed-off-by:
-
David Woodhouse authored
We don't need this. We can use adapter->currenttxskb instead. Signed-off-by:
-
David Woodhouse authored
At least it doesn't oops when you attempt to read or write it now. Only when you enable it and then later turn it off. And when it's enabled I don't see how it actually works. But one fewer oops is good, for now... Signed-off-by:
-
David Woodhouse authored
No semantic changes. Signed-off-by:
-
