- 20 Jul, 2008 40 commits
-
-
Michael Krufky authored
Signed-off-by:
Michael Krufky <mkrufky@linuxtv.org> Signed-off-by:
Mauro Carvalho Chehab <mchehab@infradead.org>
-
Michael Krufky authored
Signed-off-by:
-
Michael Krufky authored
fix the following checkpatch.pl warning: WARNING: unnecessary cast may hide bugs, see http://c-faq.com/malloc/mallocnocast.html 596: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:540: + msg = (struct SmsMsgHdr_ST *) kmalloc(PAGE_SIZE, GFP_KERNEL | GFP_DMA); Signed-off-by:
-
Michael Krufky authored
Signed-off-by:
-
Michael Krufky authored
Signed-off-by:
-
Michael Krufky authored
Signed-off-by:
-
Michael Krufky authored
Signed-off-by:
-
Michael Krufky authored
Signed-off-by:
-
Michael Krufky authored
Signed-off-by:
-
Michael Krufky authored
Signed-off-by:
-
Michael Krufky authored
Signed-off-by:
-
Michael Krufky authored
Signed-off-by:
-
Michael Krufky authored
Signed-off-by:
-
Michael Krufky authored
ERROR: "(foo*)" should be "(foo *)" Signed-off-by:
-
Michael Krufky authored
ERROR: "foo* bar" should be "foo *bar" ERROR: "foo * bar" should be "foo *bar" Signed-off-by:
-
Michael Krufky authored
Signed-off-by:
-
Michael Krufky authored
Signed-off-by:
-
Michael Krufky authored
Signed-off-by:
-
Steven Toth authored
Signed-off-by:
Steven Toth <stoth@hauppauge.com> Signed-off-by:
-
Steven Toth authored
Signed-off-by:
-
Steven Toth authored
Signed-off-by:
-
Steven Toth authored
Signed-off-by:
-
Steven Toth authored
Signed-off-by:
-
Steven Toth authored
Signed-off-by:
-
Steven Toth authored
Signed-off-by:
-
Steven Toth authored
Signed-off-by:
-
Steven Toth authored
Signed-off-by:
-
Steven Toth authored
Signed-off-by:
-
Steven Toth authored
Signed-off-by:
-
Michael Krufky authored
Signed-off-by:
-
Michael Krufky authored
Signed-off-by:
-
Michael Krufky authored
initial driver drop, provided by Siano Mobile Silicon, Inc. Signed-off-by:
-
Laurent Pinchart authored
The uvcvideo driver's uvc_v4l2_open() method is called from videodev's video_open() function, which means it is called with the videodev_lock mutex held. uvc_v4l2_open() then takes uvc_driver.open_mutex to check dev->state and avoid racing against a device disconnect, which means that open_mutex must nest inside videodev_lock. However uvc_disconnect() takes the open_mutex around setting dev->state and also around putting its device reference. However, if uvc_disconnect() ends up dropping the last reference, it will call uvc_delete(), which calls into the videodev code to unregister its device, and this will end up taking videodev_lock. This opens a (unlikely in practice) window for an AB-BA deadlock and also causes a lockdep warning because of the lock misordering. Fortunately there is no apparent reason to hold open_mutex when doing kref_put() in uvc_disconnect(): if uvc_v4l2_open() runs before the state is set to UVC_DEV_DISCONNECTED, then it will take another reference to the device and kref_put() won't call uvc_delete; if uvc_v4l2_open() runs after the state is set, it will run before uvc_delete(), see the state, and return immediately -- uvc_delete() does uvc_unregister_video() (and hence video_unregister_device(), which is synchronized with videodev_lock) as its first thing, so there is no risk of use-after-free in uvc_v4l2_open(). Bug diagnosed based on a lockdep warning reported by Romano Giannetti <romano@dea.icai.upcomillas.es>. Signed-off-by:
Roland Dreier <roland@digitalvampire.org> Signed-off-by:
Laurent Pinchart <laurent.pinchart@skynet.be> Signed-off-by:
-
Andrew Morton authored
drivers/media/video/uvc/uvc_v4l2.c: In function `uvc_v4l2_mmap': drivers/media/video/uvc/uvc_v4l2.c:1035: warning: 'buffer' might be used uninitialized in this function Signed-off-by:
Andrew Morton <akpm@linux-foundation.org> Signed-off-by:
-
Laurent Pinchart authored
Signed-off-by:
-
Mauro Carvalho Chehab authored
/home/v4l/master/v4l/gspca.c: In function 'gspca_frame_add': /home/v4l/master/v4l/gspca.c:222: warning: format '%d' expects type 'int', but argument 2 has type 'long int' /home/v4l/master/v4l/gspca.c: In function 'dev_read': /home/v4l/master/v4l/gspca.c:1568: warning: format '%d' expects type 'int', but argument 2 has type 'size_t' /home/v4l/master/v4l/gspca.c:1618: warning: format '%d' expects type 'int', but argument 3 has type 'size_t' Acked-by:
Jean-Francois Moine <moinejf@free.fr> Signed-off-by:
-
Christophe Jaillet authored
1) Remove a useless initialisation of 'i' 2) Avoid clearing the memory allocated twice (once in 'kcalloc', once in 'sg_init_table') 3) Remove a test that can never trigger. The function returns NULL in such a case, so we know that at this point 'pages[0]' != NULL Signed-off-by:
Christophe Jaillet <jaillet.christophe@wanadoo.fr> Signed-off-by:
-
Akinobu Mita authored
Signed-off-by:
Akinobu Mita <akinobu.mita@gmail.com> Signed-off-by:
-
David Howells authored
Fix casts of pointers to integers of different sizes in the ivtv framebuffer driver. These were introduced in patch 38eb6ba5b8487d15b020fe391d324edd2b659b03. Signed-off-by:
David Howells <dhowells@redhat.com> Signed-off-by:
Hans Verkuil <hverkuil@xs4all.nl> Signed-off-by:
-
Jean Delvare authored
The tvaudio driver is using "official" I2C device IDs for internal purpose. There must be some historical reason behind this but anyway, it shouldn't do that. As the stored values are never used, the easiest way to fix the problem is simply to remove them altogether. Signed-off-by:
Jean Delvare <khali@linux-fr.org> Signed-off-by:
-
