1. 05 Jan, 2014 4 commits
    • Sergei Shtylyov's avatar
      phy: kill useless local variables · e62a768f
      Sergei Shtylyov authored
      A number of functions (especially in phy.c) has local variables that were hardly
      needed in the first place -- remove them.
      Signed-off-by: default avatarSergei Shtylyov <sergei.shtylyov@cogentembedded.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      e62a768f
    • Sergei Shtylyov's avatar
      <linux/phy.h>: coding style fixes · 4017b4d3
      Sergei Shtylyov authored
      Running 'checkpatch.pl' gives some errors and warnings:
      
      - no spaces around =;
      
      - * separated by space from the function name;
      
      - { in function definition not on a separate line;
      
      - line over 80 characters.
      
      While fixing these, also fix the following style issues:
      
      - file name in the heading comment;
      
      - alignment not matching open paren.
      Signed-off-by: default avatarSergei Shtylyov <sergei.shtylyov@cogentembedded.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      4017b4d3
    • Sergei Shtylyov's avatar
      mdio_bus: coding style fixes · 02d320c3
      Sergei Shtylyov authored
      The recent patch from Florian Fainelli fixed all 'checkpatch.pl' errors but left
      some warnings like:
      
      - including <asm/io.h> instead of <linux/io.h>;
      
      - including <asm/uaccess.h> instead of <linux/uaccess.h>;
      
      - block comments using empty /* line;
      
      - 'struct dev_pm_ops' variable not being *const*.
      
      While fixing these, also fix the following style issues (some of which were
      found running 'checkpatch.pl --strict'):
      
      - alignment not matching open paren;
      
      - file name in the heading comment.
      Signed-off-by: default avatarSergei Shtylyov <sergei.shtylyov@cogentembedded.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      02d320c3
    • Sergei Shtylyov's avatar
      phy: coding style fixes · 2f53e904
      Sergei Shtylyov authored
      The recent patch from Florian Fainelli fixed all 'checkpatch.pl' errors but left
      the numerous warnings:
      
      - including <asm/io.h> instead of <linux/io.h>;
      
      - including <asm/uaccess.h> instead of <linux/uaccess.h>;
      
      - *extern* declaration in .c file;
      
      - block comments using empty /* line;
      
      - block comments not starting with * on the middle lines;
      
      - block comments not having trailing */ on a separate line;
      
      - EXPORT_SYMBOL() not immediately following its function;
      
      - unnecessary {} for signle statement block;
      
      - spaces before tabs.
      
      While fixing these, also fix the following style issues (some of which were
      found running 'checkpatch.pl --strict'):
      
      - alignment not matching open paren;
      
      - missing {} on one of the *if* arms where another has them;
      
      - use of sizeof(struct structure) instead of sizeof(*variable);
      
      - multiple assignments on one line;
      
      - empty line before };
      
      - file names in the heading comments;
      
      - missing spaces around operators;
      
      - no {} around multi-line *if* operator's arm;
      
      - unneeded () around subexpressions;
      
      - incomplete kernel-doc comment style;
      
      - comment line exceeding 80 characters;
      
      - missing empty line after declarations.
      Signed-off-by: default avatarSergei Shtylyov <sergei.shtylyov@cogentembedded.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      2f53e904
  2. 04 Jan, 2014 22 commits
  3. 03 Jan, 2014 1 commit
    • Cong Wang's avatar
      net: revert "sched classifier: make cgroup table local" · c1ddf295
      Cong Wang authored
      This reverts commit de6fb288.
      Otherwise we got:
      
      net/sched/cls_cgroup.c:106:29: error: static declaration of ‘net_cls_subsys’ follows non-static declaration
       static struct cgroup_subsys net_cls_subsys = {
                                   ^
      In file included from include/linux/cgroup.h:654:0,
                       from net/sched/cls_cgroup.c:18:
      include/linux/cgroup_subsys.h:35:29: note: previous declaration of ‘net_cls_subsys’ was here
       SUBSYS(net_cls)
                                   ^
      make[2]: *** [net/sched/cls_cgroup.o] Error 1
      
      Cc: Stephen Hemminger <stephen@networkplumber.org>
      Cc: David S. Miller <davem@davemloft.net>
      Signed-off-by: default avatarCong Wang <xiyou.wangcong@gmail.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      c1ddf295
  4. 02 Jan, 2014 13 commits