1. 05 Aug, 2010 1 commit
    • Henrik Kretzschmar's avatar
      fbdev: section cleanup in viafb driver · eca9c47b
      Henrik Kretzschmar authored
      This patch moves two functions from .devexit to .text,
      which are called on the probe error path.
      Also a function which is called by probe is moved
      from .text to .devinit.
      
      WARNING: vmlinux.o(.devinit.text+0x2ca5): Section mismatch in reference
      from the function via_pci_probe() to the function
      devexit.text:via_teardown_subdevs()
      The function __devinit via_pci_probe() references
      a function __devexit via_teardown_subdevs().
      This is often seen when error handling in the init function
      uses functionality in the exit path.
      The fix is often to remove the __devexit annotation of
      via_teardown_subdevs() so it may be used outside an exit section.
      
      WARNING: vmlinux.o(.devinit.text+0x2cb1): Section mismatch in reference
      from the function via_pci_probe() to the function
      devexit.text:via_pci_teardown_mmio()
      The function __devinit via_pci_probe() references
      a function __devexit via_pci_teardown_mmio().
      This is often seen when error handling in the init function
      uses functionality in the exit path.
      The fix is often to remove the __devexit annotation of
      via_pci_teardown_mmio() so it may be used outside an exit section.
      Signed-off-by: default avatarHenrik Kretzschmar <henne@nachtwindheim.de>
      Signed-off-by: default avatarFlorian Tobias Schandinat <FlorianSchandinat@gmx.de>
      eca9c47b
  2. 23 Jul, 2010 11 commits
    • Florian Tobias Schandinat's avatar
      viafb: fix accel_flags check_var bug · af29a5b1
      Florian Tobias Schandinat authored
      viafb: fix accel_flags check_var bug
      
      In check_var we should check and modify the var given and not the
      one which is currently active. So this code was obviously wrong.
      Probably this was doing no harm because all acceleration functions
      also check whether acceleration is possible. (otherwise I would
      expect this to lead to a null pointer dereference)
      Signed-off-by: default avatarFlorian Tobias Schandinat <FlorianSchandinat@gmx.de>
      Cc: Joseph Chan <JosephChan@via.com.tw>
      af29a5b1
    • Florian Tobias Schandinat's avatar
      viafb: probe cleanups · cd589955
      Florian Tobias Schandinat authored
      viafb: probe cleanups
      
      Removal of strange special cases that must not exist as well as a
      useless check.
      Signed-off-by: default avatarFlorian Tobias Schandinat <FlorianSchandinat@gmx.de>
      Cc: Joseph Chan <JosephChan@via.com.tw>
      cd589955
    • Florian Tobias Schandinat's avatar
      viafb: remove ioctls which break the framebuffer interface · 45f85f4a
      Florian Tobias Schandinat authored
      viafb: remove ioctls which break the framebuffer interface
      
      The ioctls VIAFB_SET_DEVICE, VIAFB_SET_DEVICE_INFO and
      VIAFB_SET_SECOND_MODE are removed because they prevent a clean
      framebuffer driver because they modify the hardware and/or the
      internal structures.
      There are no known applications using these ioctls so no breakage is
      expected. Additionaly the main functionality was duplicating the
      framebuffer interface so there really should not exist any user.
      Signed-off-by: default avatarFlorian Tobias Schandinat <FlorianSchandinat@gmx.de>
      Cc: Joseph Chan <JosephChan@via.com.tw>
      45f85f4a
    • Florian Tobias Schandinat's avatar
      viafb: update fix before calculating depth · 65123c68
      Florian Tobias Schandinat authored
      viafb: update fix before calculating depth
      
      As the depth calculation depends on information in fix it is saner to
      do the update first.
      No runtime change expected as the value visual in fix used never
      changes to MONO.
      Signed-off-by: default avatarFlorian Tobias Schandinat <FlorianSchandinat@gmx.de>
      Cc: Joseph Chan <JosephChan@via.com.tw>
      65123c68
    • Florian Tobias Schandinat's avatar
      viafb: PLL value cleanup · 1f844350
      Florian Tobias Schandinat authored
      viafb: PLL value cleanup
      
      This is a big change of how PLL values are handled on the road to
      dynamic PLL value generation. The table was converted automatically in
      the relevant parameters for frequency generation. Sadly there were some
      bits set whose meaning is unknown. Those differences are documented
      but ignored as the unichrome code implies that they are not important
      (a big thanks to Luc for his amazing work).
      The PLL values for 31490000 and 133308000 are deleted as they were more
      than 5% off and not used anyway. The values for CX700@60466000 and
      VX855@153920000 are corrected as they were wrong and easily correctable
      as enough correct values was available because CX700 and VX855 support
      the same values only with a little difference in hardware format.
      All remaining values are not more than 2% off.
      Additionally the surrounding code is changed as needed especially the
      byte order of the values written to hardware to allow nicer conversion
      functions.
      This is mostly a change preparing for dynamic PLL generation and the two
      corrected values aside no runtime change is expected.
      Signed-off-by: default avatarFlorian Tobias Schandinat <FlorianSchandinat@gmx.de>
      Cc: Joseph Chan <JosephChan@via.com.tw>
      1f844350
    • Florian Tobias Schandinat's avatar
      viafb: simplify lcd size "detection" · cc3fd679
      Florian Tobias Schandinat authored
      viafb: simplify lcd size "detection"
      
      Remove all occurences of get_lcd_size_method as only the values
      GET_LCD_SIZE_BY_VGA_BIOS and GET_LCD_SIZE_BY_USER_SETTING were used
      which had the identical code so there is no need to make things look
      more complicated than they actually are.
      Just a bit of of cleanup, really no regressions expected.
      Signed-off-by: default avatarFlorian Tobias Schandinat <FlorianSchandinat@gmx.de>
      Cc: Joseph Chan <JosephChan@via.com.tw>
      cc3fd679
    • Florian Tobias Schandinat's avatar
      viafb: fix PCI table · ad0676cf
      Florian Tobias Schandinat authored
      viafb: fix PCI table
      
      This patch fixes an oddity in the device table where the P4M890 ID was
      assigned with the enumeration value of CN700 which itself was missing.
      This is a regression introduced by
      	"viafb: make viafb a first-class citizen using pci_driver"
      
      While at it reorder the table to reflect the order of the  enumeration
      values.
      Signed-off-by: default avatarFlorian Tobias Schandinat <FlorianSchandinat@gmx.de>
      Cc: Joseph Chan <JosephChan@via.com.tw>
      Cc: Jonathan Corbet <corbet@lwn.net>
      Cc: Harald Welte <laforge@gnumonks.org>
      ad0676cf
    • Florian Tobias Schandinat's avatar
      viafb: add lcd scaling support for some IGPs · f1ad752a
      Florian Tobias Schandinat authored
      viafb: add lcd scaling support for some IGPs
      
      These IGPs should also support lcd scaling but likely this switch was
      missed when adding support for them. Fix it, allowing lcd scaling on
      CN750, VX800 and VX855. At least this improves the situation for
      VX855. (there seems to be another scaling unrelated bug somewhere)
      Signed-off-by: default avatarFlorian Tobias Schandinat <FlorianSchandinat@gmx.de>
      Cc: Joseph Chan <JosephChan@via.com.tw>
      f1ad752a
    • Florian Tobias Schandinat's avatar
      viafb: improve lcd code readability · 119b953a
      Florian Tobias Schandinat authored
      viafb: improve lcd code readability
      
      This changes the code to better reflect that we can (currently) only
      perform upscaling.
      Signed-off-by: default avatarFlorian Tobias Schandinat <FlorianSchandinat@gmx.de>
      Cc: Joseph Chan <JosephChan@via.com.tw>
      119b953a
    • Florian Tobias Schandinat's avatar
      viafb: remove duplicated scaling code · 4a73d70e
      Florian Tobias Schandinat authored
      viafb: remove duplicated scaling code
      
      The code for P4M900 does the same as for all newer IGPs so there is no
      reason to duplicate it. Just reducing the code to maintain.
      Signed-off-by: default avatarFlorian Tobias Schandinat <FlorianSchandinat@gmx.de>
      Cc: Joseph Chan <JosephChan@via.com.tw>
      4a73d70e
    • Florian Tobias Schandinat's avatar
      MAINTAINERS: update viafb entry · c7babebd
      Florian Tobias Schandinat authored
      MAINTAINERS: update viafb entry
      
      List the files that got recently moved to include/linux.
      Add myself as a maintainer and remove Scott as his email address is
      no longer valid and he has shown no interest in maintaining viafb.
      Signed-off-by: default avatarFlorian Tobias Schandinat <FlorianSchandinat@gmx.de>
      Cc: Joseph Chan <JosephChan@via.com.tw>
      Cc: Jonathan Corbet <corbet@lwn.net>
      Cc: Harald Welte <laforge@gnumonks.org>
      c7babebd
  3. 22 Jul, 2010 18 commits
  4. 21 Jul, 2010 10 commits