Commits · ed71f5e21db9479c78318dc13126946b3aacfa17 · nexedi / linux

12 Jul, 2014 25 commits

staging: vt6656: rxtx remove unneeded comments · ed71f5e2

Malcolm Priestley authored Jul 11, 2014

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

ed71f5e2

staging: vt6656: rxtx remove static declarations · 1a9c1005

Malcolm Priestley authored Jul 11, 2014

all functions are in visibility order.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

1a9c1005

staging: vt6656: rename s_vGetFreeContext to vnt_get_free_context · a032b16c

Malcolm Priestley authored Jul 11, 2014

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

a032b16c

staging: vt6656: clean up and rename wFB_Opt1 to vnt_fb_opt1 · 2331ba42

Malcolm Priestley authored Jul 11, 2014

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2331ba42

staging: vt6656: clean up and rename wFB_Opt0 to vnt_fb_opt0 · e3f31874

Malcolm Priestley authored Jul 11, 2014

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

e3f31874

staging: vt6656: rename and cleanup wTimeStampOff · 1a4d4509

Malcolm Priestley authored Jul 11, 2014

Rename to vnt_time_stampoff
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

1a4d4509

staging: vt6656: rename s_uGetTxRsvTime to vnt_get_rsvtime · 3815a27b

Malcolm Priestley authored Jul 11, 2014

Drop tx from name
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

3815a27b

staging: vt6656: rename s_uGetRTSCTSRsvTime to vnt_get_rtscts_rsvtime_le · aadf7d13

Malcolm Priestley authored Jul 11, 2014

Function always returns little endian.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

aadf7d13

staging: vt6656: rename s_uGetDataDuration to vnt_get_duration_le · 435ae3be

Malcolm Priestley authored Jul 11, 2014

Drop data and the function always returns little endian
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

435ae3be

staging: vt6656: s_uGetDataDuration remove camel case · a4c2a8a4

Malcolm Priestley authored Jul 11, 2014

camel case changes
pDevice -> priv
byPktType -> pkt_type
bNeedAck -> need_ack
uAckTime -> ack_time
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

a4c2a8a4

staging: vt6656: rxtx rename s_uGetRTSCTSDuration to vnt_get_rtscts_duration_le · f2aabee6

Malcolm Priestley authored Jul 11, 2014

Function always returns little endian value.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

f2aabee6

staging: vt6656: s_uGetRTSCTSDuration remove camel case · 7beae9a2

Malcolm Priestley authored Jul 11, 2014

camel case changes
pDevice -> priv
byDurType -> dur_type
cbFrameLength -> frame_length
byPktType -> pkt_type
wRate -> rate
bNeedAck -> need_ack
uCTSTime -> cts_time
uDurTime -> dur_time
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

7beae9a2

staging: gdm724x: fix leak at failure path in init_usb() · 22505b25

Alexey Khoroshilov authored Jul 10, 2014

If an allocation in init_usb() failed, it returns without
deallocation of already allocated resources.

The patch fix it and replaces GFP_ATOMIC by GFP_KERNEL in
alloc_tx_sdu_struct() and alloc_rx_struct() as long as
they are called from probe only.

Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

22505b25

staging: ced1401: usb1401.c: join quoted strings · 4f4756fc

Luca Ellero authored Jul 11, 2014

Fix checkpatch warnings "quoted string split across lines" in file usb1401.c
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

4f4756fc

staging: ced1401: usb1401.c: split long lines · c1dee266

Luca Ellero authored Jul 11, 2014

Fix checkpatch warnings "line over 80 characters" in file usb1401.c
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

c1dee266

staging: ced1401: usb1401.c rename camel case variable · 898065ef

Luca Ellero authored Jul 11, 2014

Rename camel case variable dwCount in function ced_writechar_callback
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

898065ef

staging: ced1401: usb1401.c: fix code indent · 97a7b0e0

Luca Ellero authored Jul 11, 2014

Fix checkpatch warning "suspect code indent for conditional statements" in file
usb1401.c
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

97a7b0e0

staging: ced1401: usb1401.c: add blank line after declarations · d9918484

Luca Ellero authored Jul 11, 2014

Fix checkpatch warnings "Missing a blank line after declarations" in file
usb1401.c
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

d9918484

staging: ced1401: ced_ioc.c : split long lines · 5d335f07

Luca Ellero authored Jul 11, 2014

Fix checkpatch warnings "line over 80 characters" in file ced_ioc.c
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

5d335f07

staging: ced1401: ced_ioc.c: remove else branch in ced_wait_event · 6cfa0152

Luca Ellero authored Jul 11, 2014

Fix checkpatch warning "else is not generally useful after a break or return" in
file ced_ioc.c, function ced_wait_event()
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

6cfa0152

staging: ced1401: ced_ioc.c: remove else branch in ced_set_event · c626bd5b

Luca Ellero authored Jul 11, 2014

Fix checkpatch warning "else is not generally useful after a break or return" in
file ced_ioc.c, function ced_set_event()
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

c626bd5b

staging: ced1401: ced_ioc.c: remove space before tabs · 9609ce31

Luca Ellero authored Jul 11, 2014

Fix checkpatch warning "please, no space before tabs" in file
ced_ioc.c
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

9609ce31

staging: ced1401: ced_ioc.c: add blank line after declarations · 0d9095b3

Luca Ellero authored Jul 11, 2014

Fix checkpatch warnings "Missing a blank line after declarations" in file
ced_ioc.c
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

0d9095b3

staging: ced1401: usb1401.h: fix "foo * bar" · a0825943

Luca Ellero authored Jul 11, 2014

Fix checkpatch error "foo * bar" should be "foo *bar" in file usb1401.h
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

a0825943

staging: ced1401: usb1401.c: change spaces to tabs · 96c53cc7

Luca Ellero authored Jul 11, 2014

Fix checkpatch errors "code indent should use tabs where possible" in file
usb1401.c
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

96c53cc7

10 Jul, 2014 15 commits

staging: vt6656: rename s_vFillCTSHead to vnt_fill_cts_head · 4f31668f

Malcolm Priestley authored Jul 10, 2014

Removing static declaration.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

4f31668f

staging: vt6656: s_vFillCTSHead remove camel case · ee16de8c

Malcolm Priestley authored Jul 10, 2014

Camel case changes
byPktType -> pkt_type
cbFrameLength -> frame_len
bNeedAck -> need_ack
pDevice -> priv
uCTSFrameLen -> cts_frame_len
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

ee16de8c

staging: vt6656: rename s_vGenerateTxParameter to vnt_generate_tx_parameter · 9ec7f2d8

Malcolm Priestley authored Jul 10, 2014

Removing static declaration
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

9ec7f2d8

staging: vt6656: s_vGenerateTxParameter remove camel case · 165ac77a

Malcolm Priestley authored Jul 10, 2014

Camel case changes
byPktType -> pkt_type
wCurrentRate -> current_rate
cbFrameSize -> frame_size
bNeedACK -> need_ack
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

165ac77a

staging: vt6656: s_vGenerateTxParameter remove else from if statements · da9ef9f4

Malcolm Priestley authored Jul 10, 2014

The function returns out at if statements so drop else.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

da9ef9f4

staging: vt6656: merge data positions for packet types a and b into vnt_rxtx_ab · 681acf68

Malcolm Priestley authored Jul 10, 2014

add rts positions from s_vFillRTSHead

add need_mic and remaining union vnt_tx_data_head head positions from
s_vGenerateTxParameter for packet type PK_TYPE_11A and PK_TYPE_11B..

As there are no other possibilities for packet types in  s_vGenerateTxParameter
the if becomes else.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

681acf68

staging: vt6656: move s_vFillCTSHead to vnt_rxtx_cts · b00cb684

Malcolm Priestley authored Jul 10, 2014

add need_mic and union vnt_tx_data_head head positions from s_vGenerateTxParameter.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

b00cb684

staging: vt6656: merge PK_TYPE_11GB and PK_TYPE_11GA into vnt_rxtx_rts · 4f06c0dc

Malcolm Priestley authored Jul 10, 2014

add to vnt_rxtx_rts calls from s_vFillRTSHead.

4f06c0dc

staging: vt6656: s_vGenerateTxParameter parse out vnt_rrv_time_ab · 3b03fea2

Malcolm Priestley authored Jul 10, 2014

create new function vnt_rxtx_ab which will eventually carry onward
functions
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

3b03fea2

staging: vt6656: s_vGenerateTxParameter rxtx.c s_vGenerateTxParameter... · f1be5759

Malcolm Priestley authored Jul 10, 2014

staging: vt6656: s_vGenerateTxParameter rxtx.c s_vGenerateTxParameter pBuf->rrv_time always the calling pkt_type

Use byPktType instead of macro.

The pkt_type has already been filtered in this function so its always set
to the correct one.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

f1be5759

staging: vt6656: s_vGenerateTxParameter Parse out struct vnt_rrv_time_cts · bf9c0118

Malcolm Priestley authored Jul 10, 2014

Create new function vnt_rxtx_cts that will eventually carry onward
function.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

bf9c0118

staging: vt6656: s_vGenerateTxParameter Parse out struct vnt_rrv_time_rts · 24cdd90f

Malcolm Priestley authored Jul 10, 2014

Creat new function vnt_rxtx_rts that will eventually carry onward
functions.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

24cdd90f

staging: vt6656: move current_rate setting out of s_vGenerateTxParameter · cb8ee9de

Malcolm Priestley authored Jul 10, 2014

Removing unneeded pointers
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

cb8ee9de

staging: vt6656: rxtx remove fb_option from functions. · 26e7362c

Malcolm Priestley authored Jul 10, 2014

This is now dead code.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

26e7362c

staging: vt6656: rxtx: move tx_context->fb_option into function structure. · ce7b0db8

Malcolm Priestley authored Jul 10, 2014

Replace fb_option in function calls with tx_context->fb_option.

Namely functions s_vFillCTSHead and s_vFillRTSHead
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

ce7b0db8