1. 30 May, 2015 40 commits
    • Hans Verkuil's avatar
      [media] cx24120: fix sparse warning · edff2bac
      Hans Verkuil authored
      drivers/media/dvb-frontends/cx24120.c:837:6: warning: symbol 'cx24120_calculate_ber_window' was not declared. Should it be static?
      Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
      edff2bac
    • Hans Verkuil's avatar
      [media] cobalt: fix sparse warnings · 4da70768
      Hans Verkuil authored
      drivers/media/pci/cobalt/cobalt-v4l2.c:189:9: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-v4l2.c:191:9: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-v4l2.c:192:9: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-v4l2.c:193:9: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-v4l2.c:194:9: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-v4l2.c:195:9: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-v4l2.c:196:9: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-v4l2.c:197:9: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-v4l2.c:198:9: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-v4l2.c:199:9: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-v4l2.c:201:9: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-v4l2.c:202:9: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-v4l2.c:203:9: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-v4l2.c:234:17: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-v4l2.c:240:17: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-v4l2.c:246:17: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-v4l2.c:266:17: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-v4l2.c:267:17: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-v4l2.c:271:28: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-v4l2.c:275:17: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-v4l2.c:276:17: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-v4l2.c:312:9: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-v4l2.c:313:9: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-v4l2.c:314:9: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-v4l2.c:315:9: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-v4l2.c:317:9: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-v4l2.c:320:9: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-v4l2.c:321:9: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-v4l2.c:321:36: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-v4l2.c:324:9: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-v4l2.c:327:9: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-v4l2.c:328:9: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-v4l2.c:328:41: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-v4l2.c:329:9: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-v4l2.c:331:9: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-v4l2.c:332:9: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-v4l2.c:334:9: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-v4l2.c:335:9: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-v4l2.c:336:9: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-v4l2.c:362:17: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-v4l2.c:367:17: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-v4l2.c:368:17: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-v4l2.c:420:9: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-v4l2.c:421:9: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-v4l2.c:422:9: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-v4l2.c:423:9: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-v4l2.c:516:9: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-v4l2.c:516:9: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-v4l2.c:518:9: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-v4l2.c:518:9: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-v4l2.c:518:9: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-v4l2.c:525:9: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-v4l2.c:525:9: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-v4l2.c:531:9: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-v4l2.c:531:9: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-v4l2.c:531:9: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-v4l2.c:531:9: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-v4l2.c:531:9: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-v4l2.c:531:9: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-v4l2.c:531:9: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-v4l2.c:546:9: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-v4l2.c:546:9: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-v4l2.c:548:9: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-v4l2.c:549:9: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-v4l2.c:550:9: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-v4l2.c:551:9: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-v4l2.c:552:9: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-v4l2.c:553:9: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-v4l2.c:554:9: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-v4l2.c:555:9: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-v4l2.c:556:9: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-v4l2.c:556:9: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-v4l2.c:556:9: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-v4l2.c:563:9: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-v4l2.c:564:9: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-v4l2.c:564:9: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-v4l2.c:569:9: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-v4l2.c:595:16: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-v4l2.c:602:9: warning: dereference of noderef expression
      Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
      4da70768
    • Hans Verkuil's avatar
      [media] cobalt: fix sparse warnings · 0664fb61
      Hans Verkuil authored
      drivers/media/pci/cobalt/cobalt-i2c.c:130:17: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-i2c.c:147:17: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-i2c.c:151:26: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-i2c.c:156:34: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-i2c.c:206:17: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-i2c.c:210:26: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-i2c.c:215:34: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-i2c.c:225:27: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-i2c.c:335:17: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-i2c.c:336:17: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-i2c.c:337:17: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-i2c.c:348:34: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-i2c.c:352:17: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-i2c.c:353:17: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-i2c.c:356:17: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-i2c.c:357:17: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-i2c.c:359:17: warning: dereference of noderef expression
      Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
      0664fb61
    • Hans Verkuil's avatar
      [media] cobalt: fix sparse warnings · c0ce6220
      Hans Verkuil authored
      drivers/media/pci/cobalt/cobalt-irq.c:62:33: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-irq.c:64:17: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-irq.c:65:23: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-irq.c:72:21: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-irq.c:73:25: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-irq.c:74:25: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-irq.c:82:33: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-irq.c:83:33: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-irq.c:91:25: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-irq.c:94:23: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-irq.c:103:25: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-irq.c:107:17: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-irq.c:109:17: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-irq.c:116:13: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-irq.c:119:17: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-irq.c:120:17: warning: dereference of noderef expression
      drivers/media/pci/cobalt/cobalt-irq.c:122:17: warning: dereference of noderef expression
      Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
      c0ce6220
    • Hans Verkuil's avatar
      [media] cobalt: fix sparse warnings · dd2567c0
      Hans Verkuil authored
      drivers/media/pci/cobalt/cobalt-flash.c:101:5: warning: symbol 'cobalt_flash_probe' was not declared. Should it be static?
      drivers/media/pci/cobalt/cobalt-flash.c:126:6: warning: symbol 'cobalt_flash_remove' was not declared. Should it be static?
      drivers/media/pci/cobalt/cobalt-cpld.c:101:6: warning: symbol 'cobalt_cpld_status' was not declared. Should it be static?
      drivers/media/pci/cobalt/cobalt-cpld.c:240:6: warning: symbol 'cobalt_cpld_set_freq' was not declared. Should it be static?
      Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
      dd2567c0
    • Hans Verkuil's avatar
      [media] cobalt: fix sparse warnings · 4a561c4b
      Hans Verkuil authored
      drivers/media/pci/cobalt/cobalt-flash.c:39:36: warning: incorrect type in initializer (different address spaces)
      drivers/media/pci/cobalt/cobalt-flash.c:54:36: warning: incorrect type in initializer (different address spaces)
      drivers/media/pci/cobalt/cobalt-flash.c:63:36: warning: incorrect type in initializer (different address spaces)
      drivers/media/pci/cobalt/cobalt-flash.c:82:36: warning: incorrect type in initializer (different address spaces)
      drivers/media/pci/cobalt/cobalt-flash.c:107:19: warning: incorrect type in assignment (different address spaces)
      Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
      4a561c4b
    • Hans Verkuil's avatar
      [media] e4000: fix compiler warning · 1ba90492
      Hans Verkuil authored
      drivers/media/tuners/e4000.c:287:3: warning: this decimal constant is unsigned only in ISO C90
         .rangehigh  =  2208000000L,
         ^
      Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
      Cc: Antti Palosaari <crope@iki.fi>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
      1ba90492
    • Hans Verkuil's avatar
      [media] cobalt: fix compiler warnings on 32 bit OSes · 40c942a1
      Hans Verkuil authored
      Fixes these warnings:
      
      drivers/media/pci/cobalt/cobalt-omnitek.c: In function 'omni_sg_dma_start':
      drivers/media/pci/cobalt/cobalt-omnitek.c:112:28: warning: right shift count >= width of type [-Wshift-count-overflow]
        iowrite32((u32)(desc->bus >> 32), DESCRIPTOR(s->dma_channel) + 4);
                                  ^
      drivers/media/pci/cobalt/cobalt-omnitek.c: In function 'descriptor_list_create':
      drivers/media/pci/cobalt/cobalt-omnitek.c:222:28: warning: right shift count >= width of type [-Wshift-count-overflow]
           d->next_h = (u32)(next >> 32);
                                  ^
      drivers/media/pci/cobalt/cobalt-omnitek.c:268:32: warning: right shift count >= width of type [-Wshift-count-overflow]
          d->next_h = (u32)(desc->bus >> 32);
                                      ^
      drivers/media/pci/cobalt/cobalt-omnitek.c:275:27: warning: right shift count >= width of type [-Wshift-count-overflow]
          d->next_h = (u32)(next >> 32);
                                 ^
      drivers/media/pci/cobalt/cobalt-omnitek.c: In function 'descriptor_list_chain':
      drivers/media/pci/cobalt/cobalt-omnitek.c:293:31: warning: right shift count >= width of type [-Wshift-count-overflow]
         d->next_h = (u32)(next->bus >> 32);
                                     ^
      drivers/media/pci/cobalt/cobalt-omnitek.c: In function 'descriptor_list_loopback':
      drivers/media/pci/cobalt/cobalt-omnitek.c:332:30: warning: right shift count >= width of type [-Wshift-count-overflow]
        d->next_h = (u32)(desc->bus >> 32);
                                    ^
      Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
      40c942a1
    • Hans Verkuil's avatar
      [media] cobalt: fix 64-bit division link error · 99cabb18
      Hans Verkuil authored
      [linuxtv-media:master 1023/1029] ERROR: "__aeabi_uldivmod" [drivers/media/pci/cobalt/cobalt.ko] undefined!
      Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
      Reported-by: default avatarkbuild test robot <fengguang.wu@intel.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
      99cabb18
    • Hans Verkuil's avatar
      [media] cobalt: fix irqs used for the adv7511 transmitter · 86bad00a
      Hans Verkuil authored
      The interrupt bit assignments use for the adv7511 were off by one.
      This means that the current scheme (bit << (4 * stream_index)) can
      no longer be used.
      
      Fix this by precalculating and storing the correct masks in the
      cobalt_stream struct.
      
      This wasn't noticed before because the adv7511 interrupts are very
      rare. But for CEC support these interrupts are essential, so this made
      me realize that it wasn't working correctly.
      Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
      86bad00a
    • Mauro Carvalho Chehab's avatar
      [media] DocBook: Update DocBook version and fix a few legacy things · 1e35c77d
      Mauro Carvalho Chehab authored
      The DVB part of the media API documentation has several
      legacy things on it:
      	- Examples that don't work;
      	- APIs unused and deprecated;
      	- places mentioning the wrong API version.
      
      Fix them and bump the documentation version, in order to
      reflect the cleanup efforts to make it more consistent with
      the current status of the API.
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
      1e35c77d
    • Mauro Carvalho Chehab's avatar
      [media] DocBook: Fix arguments on some ioctl documentation · 87db4553
      Mauro Carvalho Chehab authored
      Due to a cut-and-paste error, the argument is missing or wrong
      on 3 ioctl documentation. Fix them.
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
      87db4553
    • Mauro Carvalho Chehab's avatar
      [media] DocBook: cleaup the notes about DTV properties · ac99edd2
      Mauro Carvalho Chehab authored
      The notes there are somewhat confusing and assumes that the
      reader would have read the DVBv3 way. This is not true anymore,
      as the DVBv3 is now on a separate section that is marked as
      deprecated.
      
      So, cleanup the notes.
      
      While here, add a note about using libdvbv5, instead of using
      the DVBv5 API directly.
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
      ac99edd2
    • Mauro Carvalho Chehab's avatar
      [media] DocBook: Add an example for using FE_SET_PROPERTY · e3dae862
      Mauro Carvalho Chehab authored
      In order to make it clearer about how to use the DVBv5 calls,
      add an example of its usage. That should make it clearer about
      what's actually required for the DVBv5 calls to work.
      
      While here, also mentions the libdvbv5 library.
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
      e3dae862
    • Mauro Carvalho Chehab's avatar
      [media] DocBook: improve documentation of the properties structs · 38fbb986
      Mauro Carvalho Chehab authored
      Rename the tytle of the struct documentation to reflect
      the name of the structures, and use links to do cross-ref.
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
      38fbb986
    • Mauro Carvalho Chehab's avatar
      [media] DocBook: improve documentation for hierarchy · 9df4fc5b
      Mauro Carvalho Chehab authored
      Format it as a table and links it with the legacy API xml.
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
      9df4fc5b
    • Mauro Carvalho Chehab's avatar
      [media] DocBook: improve documentation for guard interval · 903142e5
      Mauro Carvalho Chehab authored
      Format it as a table and add more details, in special for
      DTMB guard intervals.
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
      903142e5
    • Mauro Carvalho Chehab's avatar
      [media] DocBook: improve documentation for FEC fields · 2d457b8a
      Mauro Carvalho Chehab authored
      Format it as a table and add more details. Also, remove the
      duplicated occurrences.
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
      2d457b8a
    • Mauro Carvalho Chehab's avatar
      [media] DocBook: move fe_bandwidth to the frontend legacy section · b174fb71
      Mauro Carvalho Chehab authored
      fe_bandwidth/fe_bandwidth_t is used only on DVBv3 API. So, move
      it to the frontend legacy xml, and convert it into a table.
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
      b174fb71
    • Mauro Carvalho Chehab's avatar
      [media] DocBook: improve documentation for OFDM transmission mode · 0577a2f6
      Mauro Carvalho Chehab authored
      Format it as a table and add more details, in special, for
      the DTMB modes.
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
      0577a2f6
    • Mauro Carvalho Chehab's avatar
      [media] DocBook: improve documentation for DVB spectral inversion · 58e11cc3
      Mauro Carvalho Chehab authored
      Format it as a table and provide more details.
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
      58e11cc3
    • Mauro Carvalho Chehab's avatar
      [media] DocBook: cross-reference enum fe_modulation where needed · 01f18d96
      Mauro Carvalho Chehab authored
      At frontend legacy API description, there are three places
      where fe_modulation_t is defined. Cross-reference it to point
      to the right place at the documentation.
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
      01f18d96
    • Mauro Carvalho Chehab's avatar
      [media] DocBook/Makefile: improve typedef parser · edcf3cdf
      Mauro Carvalho Chehab authored
      The typedef parser is wrong and doesn't get some of the
      types defined at the DVB API. Improve it, as we want to add
      cross-references to those types.
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
      edcf3cdf
    • Mauro Carvalho Chehab's avatar
      [media] DocBook: some fixes at FE_GET_INFO · 704db805
      Mauro Carvalho Chehab authored
      There are a few issues at FE_GET_INFO documentation:
      - name is a string, not a pointer to a string;
      - the return text should be after the paragraph.
      
      While here, better to bold that two fields of the structure used
      by FE_GET_INFO are actually deprecated.
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
      704db805
    • Mauro Carvalho Chehab's avatar
      [media] DocBook: Better document enum fe_modulation · 997eb903
      Mauro Carvalho Chehab authored
      Instead of using programlisting, use a table, as this provides
      a better view of the structure.
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
      997eb903
    • Mauro Carvalho Chehab's avatar
      [media] DocBook: add a proper description for dvb_frontend_info.fe_type · 2c2bc8ff
      Mauro Carvalho Chehab authored
      The fe_type is deprecated at the DVB API. However, it may still
      be used by legacy DVBv3 applications. While this works with old
      devices, modern devices may support more than one delivery
      system.
      
      Add an explanation about that and a point to what should be
      used, instead, in order for legacy apps to support newer hardware.
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
      2c2bc8ff
    • Mauro Carvalho Chehab's avatar
      [media] DocBook: Provide a high-level description for DVB frontend · be1ad6e7
      Mauro Carvalho Chehab authored
      Instead of just showing ioctls, let's add an introdutory text
      briefly explaining the DVB frontend API.
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
      be1ad6e7
    • Mauro Carvalho Chehab's avatar
      [media] DocBook: fix FE_READ_STATUS argument description · d27518ca
      Mauro Carvalho Chehab authored
      What's written there about the arguments for this ioctl
      is bogus: it doesn't return an enum (or a typedef)
      for enum fe_status. Instead, it returns a bitmask with the
      values defined by enum fe_status.
      
      Also, the size of the integer returned is not 16 bits, but,
      instead, sizeof(fe_status_t), e. g. sizeof(enum), with is
      arch-dependent.
      
      This should of course be fixed, but this should be done on
      a separate patch.
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
      d27518ca
    • Mauro Carvalho Chehab's avatar
      [media] DocBook: better organize the function descriptions for frontend · b60da5b2
      Mauro Carvalho Chehab authored
      Move the function ioctl definitions to the end of the chapter,
      at their importance. That makes the document better organized,
      as the DVB frontend system call index will look like:
      
      	open()
      	close()
      	ioctl FE_GET_INFO — Query DVB frontend capabilities and returns information about the front-end. This call only requires read-only access to the device
      	ioctl FE_READ_STATUS — Returns status information about the front-end. This call only requires read-only access to the device
      	ioctl FE_SET_PROPERTY, FE_GET_PROPERTY — FE_SET_PROPERTY sets one or more frontend properties. FE_GET_PROPERTY returns one or more frontend properties.
      	ioctl FE_DISEQC_RESET_OVERLOAD — Restores the power to the antenna subsystem, if it was powered off due to power overload.
      	ioctl FE_DISEQC_SEND_MASTER_CMD — Sends a DiSEqC command
      	ioctl FE_DISEQC_RECV_SLAVE_REPLY — Receives reply from a DiSEqC 2.0 command
      	ioctl FE_DISEQC_SEND_BURST — Sends a 22KHz tone burst for 2x1 mini DiSEqC satellite selection.
      	ioctl FE_SET_TONE — Sets/resets the generation of the continuous 22kHz tone.
      	ioctl FE_SET_VOLTAGE — Allow setting the DC level sent to the antenna subsystem.
      	ioctl FE_ENABLE_HIGH_LNB_VOLTAGE — Select output DC level between normal LNBf voltages or higher LNBf voltages.
      	ioctl FE_SET_FRONTEND_TUNE_MODE — Allow setting tuner mode flags to the frontend.
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
      b60da5b2
    • Mauro Carvalho Chehab's avatar
      [media] DocBook: better document FE_DISEQC_RESET_OVERLOAD · 26b2574f
      Mauro Carvalho Chehab authored
      Use the new format for the ioctl documentation and put the
      struct dvb_diseqc_slave_reply together with the ioctl.
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
      26b2574f
    • Mauro Carvalho Chehab's avatar
      [media] DocBook: better document FE_DISEQC_SEND_MASTER_CMD · db2a4ee8
      Mauro Carvalho Chehab authored
      Use the new format for the ioctl documentation and put the
      struct dvb_diseqc_slave_reply together with the ioctl.
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
      db2a4ee8
    • Mauro Carvalho Chehab's avatar
      [media] DocBook: better document FE_DISEQC_RECV_SLAVE_REPLY · 32b64436
      Mauro Carvalho Chehab authored
      Use the new format for the ioctl documentation and put the
      struct dvb_diseqc_slave_reply together with the ioctl.
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
      32b64436
    • Mauro Carvalho Chehab's avatar
      [media] DocBook: better document FE_DISEQC_SEND_BURST ioctl · 81959d99
      Mauro Carvalho Chehab authored
      Use the proper format for FE_DISEQC_SEND_BURST documentation
      and  improve the documentation.
      
      Keep the enum fe_sec_mini_cmd description together with
      the ioctl, as both are used together.
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
      81959d99
    • Mauro Carvalho Chehab's avatar
      [media] DocBook: better document FE_SET_TONE ioctl · 6dc59e7a
      Mauro Carvalho Chehab authored
      Use the proper format for FE_SET_TONE documentation and
      improve the documentation.
      
      Keep the enum fe_sec_tone_mode description together with
      the ioctl, as both are used together.
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
      6dc59e7a
    • Mauro Carvalho Chehab's avatar
      [media] DocBook: better document FE_SET_VOLTAGE ioctl · d6b6d346
      Mauro Carvalho Chehab authored
      Use the proper format for FE_SET_VOLTAGE documentation and fix
      the documentation. The description for the enum is not 100%,
      and it is missing the voltage off value.
      
      Also, it is better to keep the enum description together with
      the ioctl, as both are used together.
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
      d6b6d346
    • Mauro Carvalho Chehab's avatar
      [media] DocBook: reformat FE_ENABLE_HIGH_LNB_VOLTAGE ioctl · 50f88f3d
      Mauro Carvalho Chehab authored
      Use the proper format for FE_ENABLE_HIGH_LNB_VOLTAGE documentation.
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
      50f88f3d
    • Mauro Carvalho Chehab's avatar
      [media] DocBook: reformat FE_SET_FRONTEND_TUNE_MODE ioctl · 3d7f9c9b
      Mauro Carvalho Chehab authored
      Use the proper format for FE_SET_FRONTEND_TUNE_MODE documentation.
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
      3d7f9c9b
    • Mauro Carvalho Chehab's avatar
      [media] DocBook: move FE_GET_PROPERTY to its own xml file · 0f16290e
      Mauro Carvalho Chehab authored
      That helps the xref logic at the Makefile to point to the
      right place. Also, it becomes more organized and easier to
      maintain if each ioctl have its own xml file.
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
      0f16290e
    • Mauro Carvalho Chehab's avatar
      [media] DocBook: Rename ioctl xml files · 09c3b4a0
      Mauro Carvalho Chehab authored
      for the xml files describing ioctls, use the same nomenclature
      as on V4L2: the ioctl name, in lower case, using - instead of _.
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
      09c3b4a0
    • Mauro Carvalho Chehab's avatar
      [media] DocBook: Fix false positive undefined ioctl references · 55d4423a
      Mauro Carvalho Chehab authored
      The new code that detects undocumented ioctls hits some false
      positives:
      
      This one is not documented, nor it should, as this is
      there just to reserve namespace:
      
      	Warning: can't find reference for VIDIOC_RESERVED ioctl
      
      But those are already documented together with other ioctls:
      
      	Warning: can't find reference for VIDIOC_UNSUBSCRIBE_EVENT ioctl
      	Warning: can't find reference for FE_GET_PROPERTY ioctl
      	Warning: can't find reference for VIDIOC_SUBDEV_G_EDID ioctl
      	Warning: can't find reference for VIDIOC_SUBDEV_S_EDID ioctl
      	Warning: can't find reference for VIDIOC_SUBDEV_S_DV_TIMINGS ioctl
      	Warning: can't find reference for VIDIOC_SUBDEV_G_DV_TIMINGS ioctl
      	Warning: can't find reference for VIDIOC_SUBDEV_QUERY_DV_TIMINGS ioctl
      
      So, we need to just be sure to point to the right documentation.
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
      Acked-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
      55d4423a