- 01 Mar, 2019 26 commits
-
-
Mauro Carvalho Chehab authored
Add an horizontal linear scaler using Breseham algorithm in order to speep up its calculus. Signed-off-by:Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
-
Mauro Carvalho Chehab authored
Handling any Y,Cr,Cb formats require some extra logic, as it handles a group of two pixels. That's easy while we don't do horizontal scaling. However, doing horizontal scaling with such formats would require a lot more code, in order to avoid distortions, as, if it scales to two non-consecutive points, the logic would need to read 4 points in order to properly convert to RGB. As this is just a test driver, and we want fast algorithms, let's just get rid of this format as an output one. Signed-off-by: -
Mauro Carvalho Chehab authored
When resolutions are different, the expected behavior is to scale the image. Implement a vertical scaler as the first step. Signed-off-by: -
Mauro Carvalho Chehab authored
The vim2m driver doesn't enforce that the capture and output buffers would have the same size. Do the right thing if the buffers are different, zeroing the buffer before writing, ensuring that lines will be aligned and it won't write past the buffer area. This is a temporary fix. A proper fix is to either implement a simple scaler at vim2m, or to better define the behaviour of M2M transform drivers at V4L2 API with regards to its capability of scaling the image or not. In any case, such changes would deserve a separate patch anyway, as it would imply on some behavoral change. Also, as we have an actual bug of writing data at wrong places, let's fix this here, and add a mental note that we need to properly address it. Signed-off-by: -
Mauro Carvalho Chehab authored
The only real restriction at vim2m is that width should be multiple of two, as the copy routine always copy two pixels each time. However, Bayer formats are defined as having a 2x2 matrix. So, odd vertical numbers would cause color distortions at the last line. So, it makes sense to use step 2 for vertical alignment on Bayer. With this patch, the reported formats for video capture will be: [0]: 'RGBP' (16-bit RGB 5-6-5) Size: Stepwise 32x32 - 640x480 with step 2/1 [1]: 'RGBR' (16-bit RGB 5-6-5 BE) Size: Stepwise 32x32 - 640x480 with step 2/1 [2]: 'RGB3' (24-bit RGB 8-8-8) Size: Stepwise 32x32 - 640x480 with step 2/1 [3]: 'BGR3' (24-bit BGR 8-8-8) Size: Stepwise 32x32 - 640x480 with step 2/1 [4]: 'YUYV' (YUYV 4:2:2) Size: Stepwise 32x32 - 640x480 with step 2/1 [5]: 'BA81' (8-bit Bayer BGBG/GRGR) Size: Stepwise 32x32 - 640x480 with step 2/2 [6]: 'GBRG' (8-bit Bayer GBGB/RGRG) Size: Stepwise 32x32 - 640x480 with step 2/2 [7]: 'GRBG' (8-bit Bayer GRGR/BGBG) Size: Stepwise 32x32 - 640x480 with step 2/2 [8]: 'RGGB' (8-bit Bayer RGRG/GBGB) Size: Stepwise 32x32 - 640x480 with step 2/2 Signed-off-by: -
Mauro Carvalho Chehab authored
As we do alignments for width, expose it via V4L2 API. Signed-off-by: -
Mauro Carvalho Chehab authored
The copy logic assumes that the data width is multiple of two, as this is needed in order to support YUYV. There's no reason to force it to be 8-pixel aligned, as 2-pixel alignment is enough. Signed-off-by: -
Mauro Carvalho Chehab authored
1) Use two levels for debug: - level 1: setup stuff - level 2: add queue/dequeue messages 2) Better display the debug output, translating buffer type, fourcc and making some messages clearer. Signed-off-by: -
Mauro Carvalho Chehab authored
The vim2m device is interesting to simulate a webcam. As most sensors are arranged using bayer formats, the best is to support to output data using those formats. So, add support for them. All 4 8-bit bayer formats tested with: $ qvidcap -p & $ v4l2-ctl --stream-mmap --stream-out-mmap --stream-to-host localhost --stream-lossless --stream-out-hor-speed 1 -v pixelformat=RGGB It was tested also with GStreamer with: $ gst-validate-1.0 filesrc location=some_video.mp4 ! qtdemux ! avdec_h264 ! videoconvert ! videoscale ! v4l2convert disable-passthrough=1 extra-controls="s,horizontal_flip=0,vertical_flip=0" ! bayer2rgb ! videoconvert ! xvimagesink For all possible HFLIP/VFLIP values. Signed-off-by: -
Mauro Carvalho Chehab authored
Those typos were left over from codespell check, on my first pass or belong to code added after the time I ran it. Signed-off-by: -
Mauro Carvalho Chehab authored
Use codespell to fix lots of typos over frontends. Manually verified to avoid false-positives. Signed-off-by:
Philipp Zabel <p.zabel@pengutronix.de> Signed-off-by:
-
Mauro Carvalho Chehab authored
Use codespell to fix lots of typos over frontends. Manually verified to avoid false-positives. Signed-off-by: -
Mauro Carvalho Chehab authored
Use codespell to fix lots of typos over frontends. Manually verified to avoid false-positives. Signed-off-by:
Lad, Prabhakar <prabhakar.csengg@gmail.com> Signed-off-by:
-
Mauro Carvalho Chehab authored
Use codespell to fix lots of typos over frontends. Manually verified to avoid false-positives. Signed-off-by: -
Mauro Carvalho Chehab authored
Use codespell to fix lots of typos over frontends. Manually verified to avoid false-positives. Signed-off-by: -
Mauro Carvalho Chehab authored
Use codespell to fix lots of typos over frontends. Manually verified to avoid false-positives. Signed-off-by: -
Mauro Carvalho Chehab authored
Use codespell to fix lots of typos over frontends. Manually verified to avoid false-positives. Signed-off-by: -
Mauro Carvalho Chehab authored
Use codespell to fix lots of typos over frontends. Manually verified to avoid false-positives. Signed-off-by:
Sean Young <sean@mess.org> Signed-off-by:
-
Mauro Carvalho Chehab authored
Use codespell to fix lots of typos over frontends. Manually verified to avoid false-positives. Reviewed-by:
Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> Acked-by:
Andrzej Pietrasiewicz <andrzejtp2010@gmail.com> Reviewed-by:
Benoit Parrot <bparrot@ti.com> Reviewed-by:
Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> Reviewed-by:
Houlong Wei <houlong.wei@mediatek.com> Reviewed-by:
Yong Deng <yong.deng@magewell.com> Signed-off-by:
-
Mauro Carvalho Chehab authored
Use codespell to fix lots of typos over frontends. Manually verified to avoid false-positives. Signed-off-by: -
Mauro Carvalho Chehab authored
Use codespell to fix lots of typos over frontends. Manually verified to avoid false-positives. Signed-off-by:
Sakari Ailus <sakari.ailus@linux.intel.com> Signed-off-by:
-
Mauro Carvalho Chehab authored
Use codespell to fix lots of typos over frontends. Manually verified to avoid false-positives. Signed-off-by: -
Mauro Carvalho Chehab authored
Use codespell to fix lots of typos over frontends. Manually verified to avoid false-positives. Signed-off-by: -
Mauro Carvalho Chehab authored
Use codespell to fix lots of typos over frontends. Manually verified to avoid false-positives. Signed-off-by: -
Rui Miguel Silva authored
Remove code that is not called anywhere, just remove the internal ops. Signed-off-by:
Rui Miguel Silva <rui.silva@linaro.org> Signed-off-by:
Hans Verkuil <hverkuil-cisco@xs4all.nl> Signed-off-by:
-
Sean Young authored
When an rc device is created, we do not know what key codes it will support, since a new keymap might be loaded at some later point. So, we set all keybit in the input device. The uevent for the input device includes all the key codes, of which there are now 768. This overflows the size of the uevent (UEVENT_BUFFER_SIZE) and no event is generated. Revert for now until we figure out a different solution. This reverts commit fec225a0. Cc: <stable@vger.kernel.org> # 4.20+ Reported-by:
Christian Holpert <christian@holpert.de> Signed-off-by:
-
- 19 Feb, 2019 5 commits
-
-
Mauro Carvalho Chehab authored
Some kernel-doc markups are wrong. fix them. Signed-off-by: -
Mauro Carvalho Chehab authored
There are lots of warnings produced by this driver. It is not as much as atomisp, but it is still a lot. So, use the same solution to hide most of them. Those need to be fixed before promoting it out of staging, so add it at the TODO list. Signed-off-by: -
Mauro Carvalho Chehab authored
drivers/staging/media/imx/imx7-media-csi.c: In function 'imx7_csi_enum_mbus_code': drivers/staging/media/imx/imx7-media-csi.c:926:33: warning: variable 'in_cc' set but not used [-Wunused-but-set-variable] const struct imx_media_pixfmt *in_cc; ^~~~~ Signed-off-by: -
Mauro Carvalho Chehab authored
if imx7_csi_try_fmt() fails, outcc variable won't be initialized and csi->cc[IMX7_CSI_PAD_SRC] would be pointing to a random location. Signed-off-by: -
Hans Verkuil authored
Commit 5964cbd8 ("imx: Set capture compose rectangle in capture_device_set_format") broke the compilation of commit 05f63404 ("staging/imx7: add imx7 CSI subdev driver"). These patches came in through different pull requests and nobody noticed that the first changed functions that the second relied upon. Update imx7-media-csi.c accordingly. Signed-off-by:
-
- 18 Feb, 2019 9 commits
-
-
Rui Miguel Silva authored
Add maintainer entry for the imx7 media csi, mipi csis driver, dt-bindings and documentation. Signed-off-by:
-
Rui Miguel Silva authored
Add non vendor bayer formats to the allowed format array. Signed-off-by:
-
Rui Miguel Silva authored
Add some i.MX7 related entries to TODO file. Signed-off-by:
-
Mauro Carvalho Chehab authored
Sphinx didn't like the code-blocks on this file: Documentation/media/v4l-drivers/imx7.rst:19: WARNING: Inline substitution_reference start-string without end-string. Documentation/media/v4l-drivers/imx7.rst:20: WARNING: Block quote ends without a blank line; unexpected unindent. Documentation/media/v4l-drivers/imx7.rst:27: WARNING: Inline substitution_reference start-string without end-string. Documentation/media/v4l-drivers/imx7.rst:79: WARNING: Error in "code-block" directive: maximum 1 argument(s) allowed, 26 supplied. .. code-block:: none # Setup links <snip/> media-ctl -V "'csi':0 [fmt:SBGGR10_1X10/800x600 field:none]" Documentation/media/v4l-drivers/imx7.rst:96: WARNING: Error in "code-block" directive: maximum 1 argument(s) allowed, 9 supplied. .. code-block:: none <snip/>. -> "imx7-mipi-csis.0":0 [ENABLED] Fix them, in order to match the expected syntax for code blocks. Signed-off-by: -
Rui Miguel Silva authored
Add rst document to describe the i.MX7 media driver and also a working example from the Warp7 board usage with a OV2680 sensor. Signed-off-by:
-
Rui Miguel Silva authored
Adds MIPI CSI-2 subdev for i.MX7 to connect with sensors with a MIPI CSI-2 interface. Signed-off-by:
-
Rui Miguel Silva authored
This add the media entity subdevice and control driver for the i.MX7 CMOS Sensor Interface. Signed-off-by:
-
Rui Miguel Silva authored
Add bindings documentation for i.MX7 media drivers. The imx7 MIPI CSI2 and imx7 CMOS Sensor Interface. Signed-off-by:
Rob Herring <robh@kernel.org> Acked-by:
-
Rui Miguel Silva authored
Some imx system do not have IPU, so prepare the imx media drivers to support this kind of devices. Rename the group ids to include an _IPU_ prefix, add a new group id to support systems with only a CSI without IPU, and also rename the create internal links to make it clear that only systems with IPU have internal subdevices. Signed-off-by:
-
