- 27 Mar, 2019 6 commits
-
-
Jasminko Dedic authored
This patch fixes the following sparse warnings by adding missing __user annotations. It also cleans up two related unnecessary casts by reuseing casts already made a few lines up. Remaining sparse warnings are of a different type. vchiq_arm.c:1606:14: warning: incorrect type in assignment (different address spaces) vchiq_arm.c:1606:14: expected struct vchiq_queue_message *args vchiq_arm.c:1606:14: got void [noderef] <asn:1> * vchiq_arm.c:1612:13: warning: incorrect type in argument 1 (different address spaces) vchiq_arm.c:1612:13: expected void const volatile [noderef] <asn:1> * vchiq_arm.c:1612:13: got unsigned int * vchiq_arm.c:1613:13: warning: incorrect type in argument 1 (different address spaces) vchiq_arm.c:1613:13: expected void const volatile [noderef] <asn:1> * vchiq_arm.c:1613:13: got unsigned int * vchiq_arm.c:1614:13: warning: incorrect type in argument 1 (different address spaces) vchiq_arm.c:1614:13: expected void const volatile [noderef] <asn:1> * vchiq_arm.c:1614:13: got struct vchiq_element const [noderef] <asn:1> ** vchiq_arm.c:1638:21: warning: incorrect type in argument 1 (different address spaces) vchiq_arm.c:1638:21: expected void const volatile [noderef] <asn:1> * vchiq_arm.c:1638:21: got struct vchiq_element const [noderef] <asn:1> ** Signed-off-by:
Jasminko Dedic <betelge@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Branden Bonaby authored
Remove the comparison to true in the if statement. CHECK: Using comparison to true is error prone. Signed-off-by:
Branden Bonaby <brandonbonaby94@gmail.com> Signed-off-by:
-
Branden Bonaby authored
Remove unnecessary parentheses in rtl8712_xmit.c. Reported by checkpatch. Signed-off-by:
-
Sanjana Sanikommu authored
Challenge suggested by coccinelle. Linux kernel coding style guidelines suggest not using typedefs for structure. The following Coccinelle semantic patch detects the cases for struct type: @tn@ identifier i; type td; @@ -typedef struct i { ... } -td ; @@ type tn.td; identifier tn.i; @@ -td + struct i Signed-off-by:Sanjana Sanikommu <sanjana99reddy99@gmail.com> Signed-off-by:
-
Madhumitha Prabakaran authored
Get rid of custom macro, DBG_88E for printing message in kmalloc in order to maintain Linux kernel coding style based on which kernel does not print failure warning. Issue suggested by Coccinelle. Signed-off-by:
Madhumitha Prabakaran <madhumithabiw@gmail.com> Signed-off-by:
-
Jules Irenge authored
Lower case to fix CamelCase checkpatch.pl warning "CHECK: Avoid CamelCase: <ulActualMxClk>". Signed-off-by:
Jules Irenge <jbi.octave@gmail.com> Signed-off-by:
-
- 25 Mar, 2019 18 commits
-
-
Gao Xiang authored
Used to simulate disk IO read error for testing fatal error tolerance. Here are the details, 1) use bio->bi_private to indicate super_block for non-compressed bios since some (mainly meta) pages can be of the corresponding bdev inode; 2) get super_block dynamically for compressed bios, therefore it could not inject bios full of staging pages, yet it doesn't affect the normal usage. Signed-off-by:
Gao Xiang <gaoxiang25@huawei.com> Reviewed-by:
Chao Yu <yuchao0@huawei.com> Signed-off-by:
-
Gao Xiang authored
1) In order to clean up unnecessary page->mapping == MNGD_MAPPING(sbi) wrapped by #ifdefs; 2) Needed by "staging: erofs: support IO read error injection". Reviewed-by:
-
Gao Xiang authored
Complete read error handling paths for all three kinds of compressed pages: 1) For cache-managed pages, PG_uptodate will be checked since read_endio will unlock and SetPageUptodate for these pages; 2) For inplaced pages, read_endio cannot SetPageUptodate directly since it should be used to mark the final decompressed data, PG_error will be set with page locked for IO error instead; 3) For staging pages, PG_error is used, which is similar to what we do for inplaced pages. Fixes: 3883a79a ("staging: erofs: introduce VLE decompression support") Cc: <stable@vger.kernel.org> # 4.19+ Reviewed-by: -
Sanjana Sanikommu authored
Challenge suggested by coccinelle. Replace bit shifting on 1 with the BIT(x) macro. Coccinelle script: @@ constant c; @@ -(1 << c) +BIT(c) Signed-off-by:
-
Sammy Abed authored
Replaced spaces with tabs at the beginning of lines. Added spaces around a (+) operator. Signed-off-by:
Sammy Abed <abdlwahdsa@gmail.com> Signed-off-by:
-
Dominik Adamski authored
Fix checkpatch issue: line over 80 characters Signed-off-by:
Dominik Adamski <adamski.dominik@gmail.com> Signed-off-by:
-
Michael Straube authored
Align a comment to clear a line over 80 characters checkpatch warning. Signed-off-by:
Michael Straube <straube.linux@gmail.com> Signed-off-by:
-
Sidong Yang authored
Remove unnecessary rf69_set_mode() function call when rx is waiting for a telegram. There is waste to call rf69_set_mode() twice for becoming standby mode. Signed-off-by:
Sidong Yang <realwakka@gmail.com> Signed-off-by:
-
Bharath Vedartham authored
This fixes the checkpatch.pl check: "No space is necessary after the cast". Signed-off-by:
Bharath Vedartham <linux.bhar@gmail.com> Signed-off-by:
-
Bharath Vedartham authored
This fixes the checkpatch.pl warning: "Prefer unsigned to unsigned int" Signed-off-by:
-
Jules Irenge authored
Remove unnecessary boilerplate license identifier text. Signed-off-by:
-
Jules Irenge authored
Add the SPDX GPL-2.0+ license identifier to fix checkpatch.pl warning "WARNING: Missing or malformed SPDX-License-Identifier tag in line 1" Signed-off-by:
-
Madhumitha Prabakaran authored
Drop macros instead use functions set_bit() and clear_bit directly. Signed-off-by:
-
Madhumitha Prabakaran authored
Fix preferred form of passing a size of a struct to improve readability and eradicate an opportunity for a bug when the pointer variable type is changed but the corresponding sizeof that is passed to a memory allocator is not. Signed-off-by:
-
Vatsala Narang authored
Replace 'unsigned' with 'unsigned int' to get rid of checkpatch warning Signed-off-by:
Vatsala Narang <vatsalanarang@gmail.com> Signed-off-by:
-
Bhanusree Pola authored
The function devm_ioremap already prints error message when there is no enough memory. Remove print statements that give error messages Issue found using coccinelle The following semantic patch is used to solve this: <smpl> @@ expression x; constant char[] C; identifier f; @@ x = (\(kmalloc\|devm_kzalloc\|kmalloc_array\|devm_ioremap\| usb_alloc_urb\|alloc_netdev\|dev_alloc_skb\)(...)); if(x==NULL) { ... ( -f(C,...); | -f(...,C); ) ... } </smpl> Signed-off-by:Bhanusree Pola <bhanusreemahesh@gmail.com> Reviewed-by:
Fabio Estevam <festevam@gmail.com> Signed-off-by:
-
Vatsala Narang authored
Adjust code to fix the style issue-lines should not end with a parentheses Signed-off-by:
-
Ganesh Biradar authored
Fix the comment style of SPDX license identifier based on header file type Signed-off-by:
Ganesh Biradar <grbesd1@gmail.com> Signed-off-by:
-
- 24 Mar, 2019 8 commits
-
-
Payal Kshirsagar authored
Correct misspelled word. Signed-off-by:
Payal Kshirsagar <payal.s.kshirsagar.98@gmail.com> Signed-off-by:
-
Vatsala Narang authored
Corrected the identation of switch case to get rid of checkpatch error Signed-off-by:
-
Vatsala Narang authored
Replace 'foo * bar' with 'foo *bar' to fix a checkpatch warning Signed-off-by:
-
Vatsala Narang authored
Replace negoitation with negotiation to get rid of checkpatch warning. Signed-off-by:
-
Nishka Dasgupta authored
Remove function rtw_alloc_network() as all it does is call _rtw_alloc_network(). Rename _rtw_alloc_network() to rtw_alloc_network(). Change references to _rtw_alloc_network() to refer to rtw_alloc_network(). Issue first noticed while using Coccinelle and ret.cocci. Signed-off-by:
Nishka Dasgupta <nishka.dasgupta@yahoo.com> Signed-off-by:
-
Nishka Dasgupta authored
Remove unnecessary parentheses around variables. Issue found with Checkpatch. Signed-off-by:
-
Nishka Dasgupta authored
Change datatype of local variable from sint to int. Signed-off-by:
-
Nishka Dasgupta authored
Remove function rtw_init_mlme_priv() as all it does is call _rtw_init_mlme_priv(). Change the name of _rtw_init_mlme_priv() to rtw_init_mlme_priv() and its return type to int. Remove references to _rtw_init_mlme_priv() from the corresponding header file. Suggestion to delete return variable from rtw_init_mlme_priv() put forward by Coccinelle using ret.cocci. Signed-off-by:
-
- 22 Mar, 2019 8 commits
-
-
George Hilliard authored
The buffer descriptor setup loop is correct only if it is setting up at least one bd struct. Besides, there is an error if dma_map_sg() returns 0, which is possible and must be handled. Additionally, remove the BUG_ON() checking sglen, which is unnecessary because we configure DMA with that constraint during init. Signed-off-by:
George Hilliard <thirtythreeforty@gmail.com> Signed-off-by:
-
George Hilliard authored
The kernel complained: [ 510.277151] WARNING: CPU: 0 PID: 395 at fs/proc/generic.c:360 proc_register+0xf0/0x108 [ 510.292891] proc_dir_entry '/proc/msdc_debug' already registered when doing a modprobe/rmmod/modprobe of this module if debug messages are compiled in. Fix this by removing the proc entry when the module is unloaded. Signed-off-by: -
Bhanusree Pola authored
Test for NULL as !x instead of NULL comparisions. Issue found using coccinelle Semantic patch used to solve the problem is as follows // <smpl> @@ expression x; statement S; @@ x = (\(kmalloc\|devm_kzalloc\|kmalloc_array\|devm_ioremap\| usb_alloc_urb\|alloc_netdev\|dev_alloc_skb\)(...)); -if(x==NULL) +if(!x) S @@ expression e; @@ -e == NULL +!e // </smpl> Signed-off-by:
-
Michael Straube authored
Remove unnecessary parentheses in rtl8188eu_xmit.c. Reported by checkpatch. Signed-off-by:
-
Nishka Dasgupta authored
Remove unnecessary local return variables in rtw_mlme_ext.c. Issue found with Coccinelle using ret.cocci. Signed-off-by:
-
Nishka Dasgupta authored
Change NULL comparisons to Boolean negations. Issue found with Coccinelle using matchnull.cocci. Signed-off-by:
-
Nishka Dasgupta authored
Remove return variables from wilc_spi.c. Issue found with Coccinelle using ret.cocci. Signed-off-by:
-
Nishka Dasgupta authored
Remove return variable from host_interface.c. Issue found with Coccinelle using ret.cocci. Signed-off-by:
-
