• Guilhem Bichot's avatar
    Bug#45829 "CREATE TABLE TRANSACTIONAL PAGE_CHECKSUM ROW_FORMAT=PAGE accepted, does nothing": · a58b887c
    Guilhem Bichot authored
    those keywords do nothing in 5.1 (they are meant for future versions, for example featuring the Maria engine)
    so they are here removed from the syntax. Adding those keywords to future versions when needed is:
    - WL#5034 "Add TRANSACTIONA=0|1 and PAGE_CHECKSUM=0|1 clauses to CREATE TABLE"
    - WL#5037 "New ROW_FORMAT value for CREATE TABLE: PAGE"
    
    mysql-test/r/create.result:
      test that syntax is not accepted
    mysql-test/t/create.test:
      test that syntax is not accepted
    sql/handler.cc:
      remove ROW_FORMAT=PAGE
    sql/handler.h:
      Mark unused objects, but I don't remove them by fear of breaking any plugin which includes this file
      (see also table.h)
    sql/lex.h:
      removing syntax
    sql/sql_show.cc:
      removing output of noise keywords in SHOW CREATE TABLE and INFORMATION_SCHEMA.TABLES
    sql/sql_table.cc:
      removing TRANSACTIONAL
    sql/sql_yacc.yy:
      removing syntax
    sql/table.cc:
      removing TRANSACTIONAL, PAGE_CHECKSUM. Their place in the frm file is not reclaimed,
      for compatibility with older 5.1.
    sql/table.h:
      Mark unused objects, but I don't remove them by fear of breaking any plugin which includes this file
      (and there are several engines which use the content TABLE_SHARE and thus rely on a certain binary
      layout of this structure).
    a58b887c
table.h 58.4 KB