• unknown's avatar
    Reviewing new pushed code · 0ce12f70
    unknown authored
    - CHAR() now returns binary string as default
    - CHAR(X*65536+Y*256+Z) is now equal to CHAR(X,Y,Z) independent of the character set for CHAR()
    - Test for both ETIMEDOUT and ETIME from pthread_cond_timedwait()
      (Some old systems returns ETIME and it's safer to test for both values
       than to try to write a wrapper for each old system)
    - Fixed new introduced bug in NOT BETWEEN X and X
    - Ensure we call commit_by_xid or rollback_by_xid for all engines, even if one engine has failed
    - Use octet2hex() for all conversion of string to hex
    - Simplify and optimize code
    
    
    client/mysqldump.c:
      Simple optimizations of new code
      Indentation fixes
    client/mysqltest.c:
      Removed not needed variable
    include/mysql_com.h:
      Made octec2hex() more usable
    mysql-test/r/ctype_utf8.result:
      CHAR() now returns binary string as default
    mysql-test/r/func_str.result:
      CHAR() now returns binary string as default
    mysql-test/r/range.result:
      Added test to verify new introduced bug in NOT BETWEEN X and X
    mysql-test/r/user_var-binlog.result:
      CHAR() now returns binary string as default
    mysql-test/r/view.result:
      More tests of view rename
    mysql-test/t/ctype_utf8.test:
      CHAR() now returns binary string as default
    mysql-test/t/func_str.test:
      CHAR() now returns binary string as default
    mysql-test/t/range.test:
      Added test to verify new introduced bug in NOT BETWEEN X and X
    mysql-test/t/view.test:
      More tests of view rename
    mysys/mf_keycache.c:
      Indentation changes
      Test for both ETIMEDOUT and ETIME from pthread_cond_timedwait()
    mysys/my_os2cond.c:
      Fix to MySQL coding style
      Optimized functions
    mysys/thr_lock.c:
      Test for both ETIMEDOUT and ETIME from pthread_cond_timedwait()
    mysys/thr_mutex.c:
      Test for both ETIMEDOUT and ETIME from pthread_cond_timedwait()
    server-tools/instance-manager/instance.cc:
      Test for both ETIMEDOUT and ETIME from pthread_cond_timedwait()
    server-tools/instance-manager/thread_registry.cc:
      Test for both ETIMEDOUT and ETIME from pthread_cond_timedwait()
    sql/ha_federated.cc:
      Use octet2hex()
    sql/ha_ndbcluster.cc:
      Removed not used variable
    sql/handler.cc:
      Simplify code
      Use *NONE* instead of 'none' for not existing storage engine
      Ensure we call commit_by_xid or rollback_by_xid for all engines, even if one engine has failed
    sql/item.h:
      Remove not needed test for *ref.  (If ref is set, it should never point at 0)
    sql/item_func.cc:
      Test for both ETIMEDOUT and ETIME from pthread_cond_timedwait()
      Simplify code
      More comments
      Require that last argument to find_and_check_access() is given
      (Made code shorter and faster)
    sql/item_strfunc.cc:
      Changed CHAR() to return result in binary collation
      CHAR(X*65536+Y*256+Z) is now equal to CHAR(X,Y,Z) independent of the character set for CHAR()
      
      Bar will shortly add the following syntax:
      CHAR(.... USING character_set)
      and ensure that
      CONVERT(CHAR(....) USING utf8) cuts not legal utf8 strings
      Use ocet2hex()
    sql/item_strfunc.h:
      CHAR() now returns a binary string
    sql/log_event.cc:
      Use octet2hex()
      Simplify code
    sql/parse_file.cc:
      Indentation fixes
      Use for() instead of while()
    sql/password.c:
      Make octet2hex() more generally usable by returning pointer to end 0
    sql/slave.cc:
      Test for both ETIMEDOUT and ETIME from pthread_cond_timedwait()
    sql/sql_base.cc:
      Indentation fixes
    sql/sql_insert.cc:
      Test for both ETIMEDOUT and ETIME from pthread_cond_timedwait()
    sql/sql_manager.cc:
      Test for both ETIMEDOUT and ETIME from pthread_cond_timedwait()
    sql/sql_parse.cc:
      Don't check thd->db when checking for function privileges
    sql/sql_prepare.cc:
      Fixed wrong merge
    sql/sql_select.cc:
      Fixed new bug for NOT BETWEEN X and X
    sql/sql_show.cc:
      Removed not used variable
    sql/sql_table.cc:
      Indentation fixed
      Removed DBUG_PRINT that is obvious from context
    sql/sql_view.cc:
      Simplify code
    sql/unireg.cc:
      Use octet2hex()
    0ce12f70
sql_table.cc 124 KB