• Jon Olav Hauglid's avatar
    Backport of revno: 2617.68.18 · 1b5f2b90
    Jon Olav Hauglid authored
    Bug #42147 Concurrent DML and LOCK TABLE ... READ for InnoDB 
               table cause warnings in errlog
    
    Concurrent execution of LOCK TABLES ... READ statement and DML statements 
    affecting the same InnoDB table on debug builds of MySQL server might lead 
    to "Found lock of type 6 that is write and read locked" warnings appearing 
    in error log.
    
    The problem is that the table-level locking code allows a thread to acquire
    TL_READ_NO_INSERT lock on a table even if there is another thread which holds 
    TL_WRITE_ALLOW_WRITE lock on the same table. At the same time, the locking
    code assumes that that such locks are incompatible (for example, see check_locks()).
    
    This doesn't lead to any problems other than warnings in error log for
    debug builds of server since for InnoDB tables TL_READ_NO_INSERT type of
    lock is only used for LOCK TABLES and for this statement InnoDB also
    performs its own table-level locking.
    
    Unfortunately, the table lock compatibility matrix cannot be updated to disallow
    TL_READ_NO_INSERT when another thread holds TL_WRITE_ALLOW_WRITE without 
    causing starvation of LOCK TABLE READ in InnoDB under high write load. 
    This patch therefore contains no code changes.
    
    The issue will be fixed later when LOCK TABLE READ has been updated
    to not use table locks. This bug will therefore be marked as 
    "To be fixed later".
    
    Code comment in thr_lock.c expanded to clarify the issue and a 
    test case based on the bug description added to innodb_mysql_lock.test.
    Note that a global suppression rule has been added to both MTR v1 and v2
    for the "Found lock of type 6 that is write and read locked" warning.
    These suppression rules must be removed once this bug is properly fixed.
    1b5f2b90
innodb_mysql_lock.result 1.41 KB